From: Nicholas Krause <xerofoify@gmail.com>
To: dougthompson@xmission.com
Cc: bp@alien8.de, m.chehab@samsung.com, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] edac: Remove fixmes in e7xxx_edac.c
Date: Tue, 22 Jul 2014 00:53:09 -0400 [thread overview]
Message-ID: <1406004789-9918-1-git-send-email-xerofoify@gmail.com> (raw)
This removes two Page shift fixs me in this file and not checking
if row is -1 in process_ce as it cannot be this value or be must
exit this function by returning.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/edac/e7xxx_edac.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/edac/e7xxx_edac.c b/drivers/edac/e7xxx_edac.c
index 3cda79b..563983f 100644
--- a/drivers/edac/e7xxx_edac.c
+++ b/drivers/edac/e7xxx_edac.c
@@ -211,12 +211,13 @@ static void process_ce(struct mem_ctl_info *mci, struct e7xxx_error_info *info)
edac_dbg(3, "\n");
/* read the error address */
error_1b = info->dram_celog_add;
- /* FIXME - should use PAGE_SHIFT */
- page = error_1b >> 6; /* convert the address to 4k page */
+ page = error_1b >> PAGE_SHIFT; /* convert the address to 4k page */
/* read the syndrome */
syndrome = info->dram_celog_syndrome;
- /* FIXME - check for -1 */
row = edac_mc_find_csrow_by_page(mci, page);
+ if (row == -1)
+ return;
/* convert syndrome to channel */
channel = e7xxx_find_channel(syndrome);
edac_mc_handle_error(HW_EVENT_ERR_CORRECTED, mci, 1, page, 0, syndrome,
@@ -238,8 +239,7 @@ static void process_ue(struct mem_ctl_info *mci, struct e7xxx_error_info *info)
edac_dbg(3, "\n");
/* read the error address */
error_2b = info->dram_uelog_add;
- /* FIXME - should use PAGE_SHIFT */
- block_page = error_2b >> 6; /* convert to 4k address */
+ block_page = error_2b >> PAGE_SHIFT; /* convert to 4k address */
row = edac_mc_find_csrow_by_page(mci, block_page);
edac_mc_handle_error(HW_EVENT_ERR_UNCORRECTED, mci, 1, block_page, 0, 0,
--
1.9.1
next reply other threads:[~2014-07-22 4:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 4:53 Nicholas Krause [this message]
2014-07-22 14:04 ` [PATCH] edac: Remove fixmes in e7xxx_edac.c Bjørn Mork
2014-07-22 17:25 ` Tony Luck
2014-07-22 17:40 ` Nick Krause
2014-07-22 17:46 ` Borislav Petkov
2014-07-22 18:03 ` Nick Krause
2014-07-22 18:08 ` Borislav Petkov
2014-07-22 18:14 ` Levente Kurusa
2014-07-22 18:25 ` Nick Krause
2014-07-22 19:17 ` Randy Dunlap
2014-07-22 19:33 ` Steven Rostedt
2014-07-22 20:56 ` Nick Krause
2014-07-23 14:37 ` Steven Rostedt
2014-07-23 15:35 ` Nick Krause
2014-07-23 16:07 ` Steven Rostedt
2014-07-23 16:19 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406004789-9918-1-git-send-email-xerofoify@gmail.com \
--to=xerofoify@gmail.com \
--cc=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.