Re: [PATCH] edac: Remove fixmes in e7xxx_edac.c

From: Nick Krause <xerofoify@gmail.com>
To: Levente Kurusa <lkurusa@redhat.com>
Cc: "Tony Luck" <tony.luck@gmail.com>, "Bjørn Mork" <bjorn@mork.no>,
	"Doug Thompson" <dougthompson@xmission.com>,
	"Borislav Petkov" <bp@alien8.de>,
	"m.chehab@samsung.com" <m.chehab@samsung.com>,
	"Linux Edac Mailing List" <linux-edac@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] edac: Remove fixmes in e7xxx_edac.c
Date: Tue, 22 Jul 2014 14:25:24 -0400	[thread overview]
Message-ID: <CAPDOMVhj72TFKbtw_93juX19WVdfUzh3KM9tCEjbTdUZvUfcUQ@mail.gmail.com> (raw)
In-Reply-To: <CAAsK9AGtdJiz0xnmfqLBAqxmt=r+WANsmxwB_vQ3O5aKzMW1LQ@mail.gmail.com>

On Tue, Jul 22, 2014 at 2:14 PM, Levente Kurusa <lkurusa@redhat.com> wrote:
> 2014-07-22 19:40 GMT+02:00 Nick Krause <xerofoify@gmail.com>:
>> [...]
>>
>> Tony,
>>
>> What is the value of Page shift then ? If you can tell me it would be
>> much easier for
>> me to fix this.
>> Cheers Nick
>
> Nick,
>
> Help is always welcome. However, what you are doing is effectively a
> waste of time for you and for the maintainers as well, and hence cannot
> be called help. You are writing emails that make absolutely no sense at all.
> If you want to help us out, please consider learning three things:
>
> * The language that the kernel is written in: C
> * The language that most kernel developers understand: English
> * The environment the kernel is (in most cases) written in: UNIX
>
> If you had known these, then:
>
> * ... you would have already known that FIXMEs exist for a reason which is
>    not at all simple.
>
> * ... you would have understood that fixing FIXMEs without ANY reasoning and
>    asking about it is completely useless and wastes precious maintainer time.
>
> * ... you could have used grep for finding out PAGE_SHIFT and not need to ask
>    for it.
>
> Nick. Look, it is good that you are enthusiastic. However, this kind
> of 'work' gives
> you an undesirable reputation, which is {IF FROM:xerofoify@* THEN TRASH}...
>
> If you really want to help out, I suggest you to find yourself a piece
> of hardware from
> the store and try to write a driver for it. That way, you will learn
> how it all works, and if
> you are intelligent enough then you might get a "Kernel Job - Payed"
> like you asked us
> for them in November.
>
> Until then, please stop trying for FIXMEs. They will not get you a
> commit in the kernel
> 99% of the time.
>
> Hope you understand,
>
> Levente Kurusa

Levente,

I understand what your saying and I should have searched for Page shift.
In addition I am already got commits in the kernel for fix mes so I feel
that your comment on fix mes is incorrect.
Nick