From: Joe Perches <joe@perches.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH V2] SYSV: logging update
Date: Wed, 23 Jul 2014 08:07:11 -0700 [thread overview]
Message-ID: <1406128031.2755.21.camel@joe-AO725> (raw)
In-Reply-To: <1406127018-15953-1-git-send-email-fabf@skynet.be>
On Wed, 2014-07-23 at 16:50 +0200, Fabian Frederick wrote:
> -use current logging functions
> -replace no level printk by pr_err
> -add debug.c / sysv_err function to include sb->s_id
> -standardize prefix: "sysv (sb id): " and remove sb id from various logging at different places.
> -use __func__
> -coalesce formats
Seems fine but:
> diff --git a/fs/sysv/debug.c b/fs/sysv/debug.c
[]
> @@ -0,0 +1,15 @@
> +#define pr_fmt(fmt) KBUILD_MODNAME " " fmt
Please use KBUILD_MODNAME ": " fmt
> +
> +#include "sysv.h"
> +
> +void sysv_err(struct super_block *sb, const char *fmt, ...)
> +{
> + struct va_format vaf;
> + va_list args;
> +
> + va_start(args, fmt);
> + vaf.fmt = fmt;
> + vaf.va = &args;
> + pr_err("(%s): %pV\n", sb->s_id, &vaf);
This trailing \n is not necessary and causes
blank lines in the log.
All callers already use it.
next prev parent reply other threads:[~2014-07-23 15:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 14:50 [PATCH V2] SYSV: logging update Fabian Frederick
2014-07-23 15:07 ` Joe Perches [this message]
2014-07-23 15:30 ` Fabian Frederick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406128031.2755.21.camel@joe-AO725 \
--to=joe@perches.com \
--cc=fabf@skynet.be \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.