Re: [PATCH V2] SYSV: logging update

[Fabian Frederick <fabf@skynet.be>]

> On 23 July 2014 at 17:07 Joe Perches <joe@perches.com> wrote:
>
>
> On Wed, 2014-07-23 at 16:50 +0200, Fabian Frederick wrote:
> > -use current logging functions
> > -replace no level printk by pr_err
> > -add debug.c / sysv_err function to include sb->s_id
> > -standardize prefix: "sysv (sb id): " and remove sb id from various logging
> > at different places.
> > -use __func__
> > -coalesce formats
>
> Seems fine but:
>
> > diff --git a/fs/sysv/debug.c b/fs/sysv/debug.c
> []
> > @@ -0,0 +1,15 @@
> > +#define pr_fmt(fmt) KBUILD_MODNAME " " fmt
>
> Please use KBUILD_MODNAME ": " fmt

fs logging is generally like the following:

"sysv(sb->s_id): "

with KBUILD_MODNAME ": " :

"sysv: (sb->s_id)"


>
> > +
> > +#include "sysv.h"
> > +
> > +void sysv_err(struct super_block *sb, const char *fmt, ...)
> > +{
> > +   struct va_format vaf;
> > +   va_list args;
> > +
> > +   va_start(args, fmt);
> > +   vaf.fmt = fmt;
> > +   vaf.va = &args;
> > +   pr_err("(%s): %pV\n", sb->s_id, &vaf);
>
> This trailing \n is not necessary and causes
> blank lines in the log.
>
> All callers already use it.

I could remove it from all callers instead ?
Thanks,
Fabian
>
>