All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sched: Resolve some shadow warnings
@ 2014-07-25 16:27 Jeff Kirsher
  0 siblings, 0 replies; only message in thread
From: Jeff Kirsher @ 2014-07-25 16:27 UTC (permalink / raw)
  To: mingo, peterz; +Cc: Mark Rustad, linux-kernel, Jeff Kirsher

From: Mark Rustad <mark.d.rustad@intel.com>

Using names like down and up, which are well-known semaphore
functions, makes those functions unavailable. This can be a
trap for the future, should there be reason to call down or
up here. Mostly it is just noise, so make it go away by using
other names.

Signed-off-by: Mark Rustad <mark.d.rustad@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 kernel/sched/sched.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 579712f..a5f0f42 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -253,17 +253,17 @@ struct task_group {
 typedef int (*tg_visitor)(struct task_group *, void *);
 
 extern int walk_tg_tree_from(struct task_group *from,
-			     tg_visitor down, tg_visitor up, void *data);
+			     tg_visitor in, tg_visitor out, void *data);
 
 /*
- * Iterate the full tree, calling @down when first entering a node and @up when
+ * Iterate the full tree, calling @in when first entering a node and @out when
  * leaving it for the final time.
  *
  * Caller must hold rcu_lock or sufficient equivalent.
  */
-static inline int walk_tg_tree(tg_visitor down, tg_visitor up, void *data)
+static inline int walk_tg_tree(tg_visitor in, tg_visitor out, void *data)
 {
-	return walk_tg_tree_from(&root_task_group, down, up, data);
+	return walk_tg_tree_from(&root_task_group, in, out, data);
 }
 
 extern int tg_nop(struct task_group *tg, void *data);
-- 
1.9.3


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2014-07-25 16:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-25 16:27 [PATCH] sched: Resolve some shadow warnings Jeff Kirsher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.