* [PATCH] i915: initialize CADL in opregion
@ 2012-06-25 22:36 Lekensteyn
2012-06-26 21:04 ` Jesse Barnes
0 siblings, 1 reply; 13+ messages in thread
From: Lekensteyn @ 2012-06-25 22:36 UTC (permalink / raw)
To: Daniel Vetter; +Cc: dri-devel
This is rather a hack to fix brightness hotkeys on a Clevo laptop. CADL is not
used anywhere in the driver code at the moment, but it could be used in BIOS as
is the case with the Clevo laptop.
The Clevo B7130 requires the CADL field to contain at least the ID of
the LCD device. If this field is empty, the ACPI methods that are called
on pressing brightness / display switching hotkeys will not trigger a
notification. As a result, it appears as no hotkey has been pressed.
Reference: https://bugs.freedesktop.org/show_bug.cgi?id=45452
Tested-by: Peter Wu <lekensteyn@gmail.com>
Signed-off-by: Peter Wu <lekensteyn@gmail.com>
---
drivers/gpu/drm/i915/intel_opregion.c | 23 ++++++++++++++++++++++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
index 18bd0af..adf6c79 100644
--- a/drivers/gpu/drm/i915/intel_opregion.c
+++ b/drivers/gpu/drm/i915/intel_opregion.c
@@ -427,6 +427,25 @@ blind_set:
goto end;
}
+static void intel_setup_cadls(struct drm_device *dev)
+{
+ struct drm_i915_private *dev_priv = dev->dev_private;
+ struct intel_opregion *opregion = &dev_priv->opregion;
+ int i = 0;
+ u32 disp_id;
+
+ /* Initialize the CADL field by duplicating the DIDL values.
+ * Technically, this is not always correct as display outputs may exist,
+ * but not active. This initialization is necessary for some Clevo
+ * laptops that check this field before processing the brightness and
+ * display switching hotkeys. Just like DIDL, CADL is NULL-terminated if
+ * there are less than eight devices. */
+ do {
+ disp_id = ioread32(&opregion->acpi->didl[i]);
+ iowrite32(disp_id, &opregion->acpi->cadl[i]);
+ } while (++i < 8 && disp_id != 0);
+}
+
void intel_opregion_init(struct drm_device *dev)
{
struct drm_i915_private *dev_priv = dev->dev_private;
@@ -436,8 +455,10 @@ void intel_opregion_init(struct drm_device *dev)
return;
if (opregion->acpi) {
- if (drm_core_check_feature(dev, DRIVER_MODESET))
+ if (drm_core_check_feature(dev, DRIVER_MODESET)) {
intel_didl_outputs(dev);
+ intel_setup_cadls(dev);
+ }
/* Notify BIOS we are ready to handle ACPI video ext notifs.
* Right now, all the events are handled by the ACPI video module.
--
1.7.11
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] i915: initialize CADL in opregion
2012-06-25 22:36 [PATCH] i915: initialize CADL in opregion Lekensteyn
@ 2012-06-26 21:04 ` Jesse Barnes
2012-06-26 21:07 ` Daniel Vetter
2012-09-13 21:17 ` Daniel Vetter
0 siblings, 2 replies; 13+ messages in thread
From: Jesse Barnes @ 2012-06-26 21:04 UTC (permalink / raw)
To: Lekensteyn; +Cc: dri-devel
On Tue, 26 Jun 2012 00:36:24 +0200
Lekensteyn <lekensteyn@gmail.com> wrote:
> This is rather a hack to fix brightness hotkeys on a Clevo laptop. CADL is not
> used anywhere in the driver code at the moment, but it could be used in BIOS as
> is the case with the Clevo laptop.
>
> The Clevo B7130 requires the CADL field to contain at least the ID of
> the LCD device. If this field is empty, the ACPI methods that are called
> on pressing brightness / display switching hotkeys will not trigger a
> notification. As a result, it appears as no hotkey has been pressed.
Not ideal, but definitely better than nothing.
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] i915: initialize CADL in opregion
2012-06-26 21:04 ` Jesse Barnes
@ 2012-06-26 21:07 ` Daniel Vetter
2012-06-26 21:34 ` Paul Menzel
2012-06-27 15:03 ` Daniel Vetter
2012-09-13 21:17 ` Daniel Vetter
1 sibling, 2 replies; 13+ messages in thread
From: Daniel Vetter @ 2012-06-26 21:07 UTC (permalink / raw)
To: Jesse Barnes; +Cc: Lekensteyn, dri-devel
On Tue, Jun 26, 2012 at 02:04:00PM -0700, Jesse Barnes wrote:
> On Tue, 26 Jun 2012 00:36:24 +0200
> Lekensteyn <lekensteyn@gmail.com> wrote:
>
> > This is rather a hack to fix brightness hotkeys on a Clevo laptop. CADL is not
> > used anywhere in the driver code at the moment, but it could be used in BIOS as
> > is the case with the Clevo laptop.
> >
> > The Clevo B7130 requires the CADL field to contain at least the ID of
> > the LCD device. If this field is empty, the ACPI methods that are called
> > on pressing brightness / display switching hotkeys will not trigger a
> > notification. As a result, it appears as no hotkey has been pressed.
>
> Not ideal, but definitely better than nothing.
>
> Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] i915: initialize CADL in opregion
2012-06-26 21:07 ` Daniel Vetter
@ 2012-06-26 21:34 ` Paul Menzel
2012-06-27 15:03 ` Daniel Vetter
1 sibling, 0 replies; 13+ messages in thread
From: Paul Menzel @ 2012-06-26 21:34 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Lekensteyn, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1188 bytes --]
Am Dienstag, den 26.06.2012, 23:07 +0200 schrieb Daniel Vetter:
> On Tue, Jun 26, 2012 at 02:04:00PM -0700, Jesse Barnes wrote:
> > On Tue, 26 Jun 2012 00:36:24 +0200
> > Lekensteyn <lekensteyn@gmail.com> wrote:
> >
> > > This is rather a hack to fix brightness hotkeys on a Clevo laptop. CADL is not
> > > used anywhere in the driver code at the moment, but it could be used in BIOS as
> > > is the case with the Clevo laptop.
> > >
> > > The Clevo B7130 requires the CADL field to contain at least the ID of
> > > the LCD device. If this field is empty, the ACPI methods that are called
> > > on pressing brightness / display switching hotkeys will not trigger a
> > > notification. As a result, it appears as no hotkey has been pressed.
> >
> > Not ideal, but definitely better than nothing.
> >
> > Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> Queued for -next, thanks for the patch.
Peter, I guess the Author field does not contain your real name and does
not match the Signed-off-by line. To avoid that either set up the right
name in KMail or add
From: Peter Wu <lekensteyn@gmail.com>
as the first line of your message.
Thanks,
Paul
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] i915: initialize CADL in opregion
2012-06-26 21:07 ` Daniel Vetter
2012-06-26 21:34 ` Paul Menzel
@ 2012-06-27 15:03 ` Daniel Vetter
2012-06-27 15:09 ` Lekensteyn
1 sibling, 1 reply; 13+ messages in thread
From: Daniel Vetter @ 2012-06-27 15:03 UTC (permalink / raw)
To: Jesse Barnes; +Cc: Lekensteyn, dri-devel
On Tue, Jun 26, 2012 at 11:07:55PM +0200, Daniel Vetter wrote:
> On Tue, Jun 26, 2012 at 02:04:00PM -0700, Jesse Barnes wrote:
> > On Tue, 26 Jun 2012 00:36:24 +0200
> > Lekensteyn <lekensteyn@gmail.com> wrote:
> >
> > > This is rather a hack to fix brightness hotkeys on a Clevo laptop. CADL is not
> > > used anywhere in the driver code at the moment, but it could be used in BIOS as
> > > is the case with the Clevo laptop.
> > >
> > > The Clevo B7130 requires the CADL field to contain at least the ID of
> > > the LCD device. If this field is empty, the ACPI methods that are called
> > > on pressing brightness / display switching hotkeys will not trigger a
> > > notification. As a result, it appears as no hotkey has been pressed.
> >
> > Not ideal, but definitely better than nothing.
> >
> > Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> Queued for -next, thanks for the patch.
Unfortunately this results in a neat black screen on my ivb zenbook. Until
I've figured out what exactly's going on, I have to drop this from -next
again.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] i915: initialize CADL in opregion
2012-06-27 15:03 ` Daniel Vetter
@ 2012-06-27 15:09 ` Lekensteyn
[not found] ` <20120627162737.GF5326@phenom.ffwll.local>
0 siblings, 1 reply; 13+ messages in thread
From: Lekensteyn @ 2012-06-27 15:09 UTC (permalink / raw)
To: Daniel Vetter; +Cc: dri-devel
On Wednesday 27 June 2012 17:03:02 Daniel Vetter wrote:
> On Tue, Jun 26, 2012 at 11:07:55PM +0200, Daniel Vetter wrote:
> > On Tue, Jun 26, 2012 at 02:04:00PM -0700, Jesse Barnes wrote:
> > > On Tue, 26 Jun 2012 00:36:24 +0200
> > >
> > > Lekensteyn <lekensteyn@gmail.com> wrote:
> > > > This is rather a hack to fix brightness hotkeys on a Clevo laptop.
> > > > CADL is not used anywhere in the driver code at the moment, but it
> > > > could be used in BIOS as is the case with the Clevo laptop.
> > > >
> > > > The Clevo B7130 requires the CADL field to contain at least the ID of
> > > > the LCD device. If this field is empty, the ACPI methods that are
> > > > called
> > > > on pressing brightness / display switching hotkeys will not trigger a
> > > > notification. As a result, it appears as no hotkey has been pressed.
> > >
> > > Not ideal, but definitely better than nothing.
> > >
> > > Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> >
> > Queued for -next, thanks for the patch.
>
> Unfortunately this results in a neat black screen on my ivb zenbook. Until
> I've figured out what exactly's going on, I have to drop this from -next
> again.
> -Daniel
Can you share your acpidump on
https://bugs.freedesktop.org/show_bug.cgi?id=45452 ?
TIA
Peter
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] i915: initialize CADL in opregion
[not found] ` <20120627162737.GF5326@phenom.ffwll.local>
@ 2012-06-27 23:24 ` Lekensteyn
2012-06-28 11:05 ` Daniel Vetter
0 siblings, 1 reply; 13+ messages in thread
From: Lekensteyn @ 2012-06-27 23:24 UTC (permalink / raw)
To: Daniel Vetter; +Cc: dri-devel
On Wednesday 27 June 2012 18:27:37 Daniel Vetter wrote:
> On Wed, Jun 27, 2012 at 05:09:02PM +0200, Lekensteyn wrote:
> > On Wednesday 27 June 2012 17:03:02 Daniel Vetter wrote:
> > > On Tue, Jun 26, 2012 at 11:07:55PM +0200, Daniel Vetter wrote:
> > > > On Tue, Jun 26, 2012 at 02:04:00PM -0700, Jesse Barnes wrote:
> > > > > On Tue, 26 Jun 2012 00:36:24 +0200
> > > > >
> > > > > Lekensteyn <lekensteyn@gmail.com> wrote:
> > > > > > This is rather a hack to fix brightness hotkeys on a Clevo laptop.
> > > > > > CADL is not used anywhere in the driver code at the moment, but it
> > > > > > could be used in BIOS as is the case with the Clevo laptop.
> > > > > >
> > > > > > The Clevo B7130 requires the CADL field to contain at least the ID
> > > > > > of
> > > > > > the LCD device. If this field is empty, the ACPI methods that are
> > > > > > called
> > > > > > on pressing brightness / display switching hotkeys will not
> > > > > > trigger a
> > > > > > notification. As a result, it appears as no hotkey has been
> > > > > > pressed.
> > > > >
> > > > > Not ideal, but definitely better than nothing.
> > > > >
> > > > > Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > > >
> > > > Queued for -next, thanks for the patch.
> > >
> > > Unfortunately this results in a neat black screen on my ivb zenbook.
> > > Until
> > > I've figured out what exactly's going on, I have to drop this from -next
> > > again.
> > > -Daniel
> >
> > Can you share your acpidump on
> > https://bugs.freedesktop.org/show_bug.cgi?id=45452 ?
>
> Attached.
> -Daniel
Thank you, I've now written a partial analysis which is available at
https://github.com/Lekensteyn/acpi-
stuff/blob/HEAD/dsl/Asus_Zenbook_DanielVetter/analysis.txt (note: URL is cut in
two parts in this mail, concat them as needed).
Question: can you try disabling the asus-laptop module and try booting again
w/ and w/o the CADL patch applied?
- Does it boot in both cases?
- Do the brightness hotkeys work?
- Can you change brightness via /sys/class/backlight?
Can you SSH in it and check the logs? Any ACPI warnings/errors or messages
from the asus-laptop module? (or whatever asus module(s) is/are loaded)
Can you also generate dmidecode.txt? (peek in http://lekensteyn.nl/files/get-
acpi-info.sh, you do not have to run all of the commands since I already have
your acpidump)
Thanks,
Peter
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] i915: initialize CADL in opregion
2012-06-27 23:24 ` Lekensteyn
@ 2012-06-28 11:05 ` Daniel Vetter
2012-06-28 11:22 ` Daniel Vetter
2012-06-29 14:48 ` Daniel Vetter
0 siblings, 2 replies; 13+ messages in thread
From: Daniel Vetter @ 2012-06-28 11:05 UTC (permalink / raw)
To: Lekensteyn; +Cc: dri-devel
[-- Attachment #1: Type: text/plain, Size: 2575 bytes --]
On Thu, Jun 28, 2012 at 1:24 AM, Lekensteyn <lekensteyn@gmail.com> wrote:
> Thank you, I've now written a partial analysis which is available at
> https://github.com/Lekensteyn/acpi-
> stuff/blob/HEAD/dsl/Asus_Zenbook_DanielVetter/analysis.txt (note: URL is cut in
> two parts in this mail, concat them as needed).
>
> Question: can you try disabling the asus-laptop module and try booting again
> w/ and w/o the CADL patch applied?
> - Does it boot in both cases?
> - Do the brightness hotkeys work?
> - Can you change brightness via /sys/class/backlight?
> Can you SSH in it and check the logs? Any ACPI warnings/errors or messages
> from the asus-laptop module? (or whatever asus module(s) is/are loaded)
>
> Can you also generate dmidecode.txt? (peek in http://lekensteyn.nl/files/get-
> acpi-info.sh, you do not have to run all of the commands since I already have
> your acpidump)
Ok, because I have an ecrypted root fs I've tried to reload the
i915.ko with CADL after booting. Test-results:
- asus_wmi.ko doesn't seem to have any effect whatsoever on the endresult.
- asus_nb_wmi.ko doesn't load (ENODEV).
- brightness-keys (and also sound control) don't work, but controlling
the backlight with /sys/class/backlight/acpi_video0/brightness works
(if I can turn the panel on somehow, see below).
- When loading the i915.ko with the CADL patch the screen went black
(like at boot), but with some excessive vt-switching and X restarting
I've managed to light it up. Although it is flickery as hell,
especially the lower part of the screen. And if the screen is somewhat
stable, I just get the upper part of the screen duplicated in the
lower part.
- dmidecode is attached.
- no errors in the logs anywhere (if you ignore some ACPI resource
conflicts because ACPI reserves some pch stuff itself, which then
conflicts with the native gpio, sensors, whatever drivers).
So I think this might be simply a timing issue that with CADL enabled
we expose a pre-existing bug somewhere in our modeset sequence. I'm
already chasing two issues on this machine:
- edp refuses to light up crtc 1/2, only works after having switched
back to crtc 0.
- disabled pipes get stuck in the active state once having been used be edp.
I have a feeling that all these issues are related, so I guess until
I've tracked down the above the things we won't make much progress
with this CADL patch.
Still, if you have any insights or need more dumps/logs from my
machine, I'll happily help out.
Cheers, Daniel
--
Daniel Vetter
daniel.vetter@ffwll.ch - +41 (0) 79 364 57 48 - http://blog.ffwll.ch
[-- Attachment #2: dmidecode --]
[-- Type: application/octet-stream, Size: 9878 bytes --]
# dmidecode 2.11
SMBIOS 2.7 present.
23 structures occupying 1668 bytes.
Table at 0x000EBA60.
Handle 0x0000, DMI type 0, 24 bytes
BIOS Information
Vendor: American Megatrends Inc.
Version: UX31A.204
Release Date: 05/09/2012
Address: 0xF0000
Runtime Size: 64 kB
ROM Size: 6144 kB
Characteristics:
PCI is supported
BIOS is upgradeable
BIOS shadowing is allowed
Boot from CD is supported
Selectable boot is supported
BIOS ROM is socketed
EDD is supported
5.25"/1.2 MB floppy services are supported (int 13h)
3.5"/720 kB floppy services are supported (int 13h)
3.5"/2.88 MB floppy services are supported (int 13h)
Print screen service is supported (int 5h)
8042 keyboard services are supported (int 9h)
Serial services are supported (int 14h)
Printer services are supported (int 17h)
ACPI is supported
USB legacy is supported
Smart battery is supported
BIOS boot specification is supported
Targeted content distribution is supported
UEFI is supported
BIOS Revision: 4.6
Handle 0x0001, DMI type 1, 27 bytes
System Information
Manufacturer: ASUSTeK COMPUTER INC.
Product Name: UX31A
Version: 1.0
Serial Number: C6N0CJ06323323A
UUID: 69EDC567-75AC-E111-BA11-C4850810F3D8
Wake-up Type: Power Switch
SKU Number: ASUS-NotebookSKU
Family: UX
Handle 0x0002, DMI type 2, 15 bytes
Base Board Information
Manufacturer: ASUSTeK COMPUTER INC.
Product Name: UX31A
Version: 1.0
Serial Number: BSN12345678901234567
Asset Tag: ATN12345678901234567
Features:
Board is a hosting board
Board is replaceable
Location In Chassis: MIDDLE
Chassis Handle: 0x0003
Type: Motherboard
Contained Object Handles: 0
Handle 0x0003, DMI type 3, 22 bytes
Chassis Information
Manufacturer: ASUSTeK COMPUTER INC.
Type: Notebook
Lock: Not Present
Version: 1.0
Serial Number: CSN12345678901234567
Asset Tag: No Asset Tag
Boot-up State: Safe
Power Supply State: Safe
Thermal State: Safe
Security Status: None
OEM Information: 0x00000000
Height: Unspecified
Number Of Power Cords: 1
Contained Elements: 0
SKU Number: To be filled by O.E.M.
Handle 0x0004, DMI type 10, 26 bytes
On Board Device 1 Information
Type: Video
Status: Enabled
Description: VGA
On Board Device 2 Information
Type: Ethernet
Status: Enabled
Description: GLAN
On Board Device 3 Information
Type: Ethernet
Status: Enabled
Description: WLAN
On Board Device 4 Information
Type: Sound
Status: Enabled
Description: Audio CODEC
On Board Device 5 Information
Type: SATA Controller
Status: Enabled
Description: SATA Controller
On Board Device 6 Information
Type: Other
Status: Enabled
Description: USB 2.0 Controller
On Board Device 7 Information
Type: Other
Status: Enabled
Description: USB 3.0 Controller
On Board Device 8 Information
Type: Other
Status: Enabled
Description: SMBus Controller
On Board Device 9 Information
Type: Other
Status: Enabled
Description: Card Reader
On Board Device 10 Information
Type: Other
Status: Enabled
Description: Cmos Camera
On Board Device 11 Information
Type: Other
Status: Enabled
Description: Bluetooth
Handle 0x0005, DMI type 11, 5 bytes
OEM Strings
String 1: z5GgwceHSd6vE
String 2: izncoWc-j9I5k
String 3: gJ9GJtxvJxUwY
String 4: 90NIOA312E1122XL13EC
String 5:
String 6:
String 7:
String 8:
String 9:
String 10:
Handle 0x0006, DMI type 12, 5 bytes
System Configuration Options
Option 1: DSN:3200044560004033
Option 2: DSN:FFFFFFFFFFFF
Option 3: DSN:FFFFFFFFFFFF
Option 4: SMI:00B2CA
Handle 0x0007, DMI type 32, 20 bytes
System Boot Information
Status: No errors detected
Handle 0x0008, DMI type 7, 19 bytes
Cache Information
Socket Designation: CPU Internal L2
Configuration: Enabled, Not Socketed, Level 2
Operational Mode: Write Through
Location: Internal
Installed Size: 512 kB
Maximum Size: 512 kB
Supported SRAM Types:
Unknown
Installed SRAM Type: Unknown
Speed: Unknown
Error Correction Type: Multi-bit ECC
System Type: Unified
Associativity: 8-way Set-associative
Handle 0x0009, DMI type 7, 19 bytes
Cache Information
Socket Designation: CPU Internal L1
Configuration: Enabled, Not Socketed, Level 1
Operational Mode: Write Through
Location: Internal
Installed Size: 128 kB
Maximum Size: 128 kB
Supported SRAM Types:
Unknown
Installed SRAM Type: Unknown
Speed: Unknown
Error Correction Type: Parity
System Type: Data
Associativity: 8-way Set-associative
Handle 0x000A, DMI type 7, 19 bytes
Cache Information
Socket Designation: CPU Internal L3
Configuration: Enabled, Not Socketed, Level 3
Operational Mode: Write Back
Location: Internal
Installed Size: 4096 kB
Maximum Size: 4096 kB
Supported SRAM Types:
Unknown
Installed SRAM Type: Unknown
Speed: Unknown
Error Correction Type: Multi-bit ECC
System Type: Unified
Associativity: 16-way Set-associative
Handle 0x000B, DMI type 16, 23 bytes
Physical Memory Array
Location: System Board Or Motherboard
Use: System Memory
Error Correction Type: None
Maximum Capacity: 32 GB
Error Information Handle: Not Provided
Number Of Devices: 4
Handle 0x000C, DMI type 4, 42 bytes
Processor Information
Socket Designation: SOCKET 0
Type: Central Processor
Family: Core i7
Manufacturer: Intel(R) Corporation
ID: A9 06 03 00 FF FB EB BF
Signature: Type 0, Family 6, Model 58, Stepping 9
Flags:
FPU (Floating-point unit on-chip)
VME (Virtual mode extension)
DE (Debugging extension)
PSE (Page size extension)
TSC (Time stamp counter)
MSR (Model specific registers)
PAE (Physical address extension)
MCE (Machine check exception)
CX8 (CMPXCHG8 instruction supported)
APIC (On-chip APIC hardware supported)
SEP (Fast system call)
MTRR (Memory type range registers)
PGE (Page global enable)
MCA (Machine check architecture)
CMOV (Conditional move instruction supported)
PAT (Page attribute table)
PSE-36 (36-bit page size extension)
CLFSH (CLFLUSH instruction supported)
DS (Debug store)
ACPI (ACPI supported)
MMX (MMX technology supported)
FXSR (FXSAVE and FXSTOR instructions supported)
SSE (Streaming SIMD extensions)
SSE2 (Streaming SIMD extensions 2)
SS (Self-snoop)
HTT (Multi-threading)
TM (Thermal monitor supported)
PBE (Pending break enabled)
Version: Intel(R) Core(TM) i7-3517U CPU @ 1.90GHz
Voltage: 6.7 V
External Clock: 100 MHz
Max Speed: 3800 MHz
Current Speed: 2400 MHz
Status: Populated, Enabled
Upgrade: Socket rPGA988B
L1 Cache Handle: 0x0009
L2 Cache Handle: 0x0008
L3 Cache Handle: 0x000A
Serial Number: Not Specified
Asset Tag: Fill By OEM
Part Number: Fill By OEM
Core Count: 2
Core Enabled: 2
Thread Count: 4
Characteristics:
64-bit capable
Handle 0x000D, DMI type 17, 34 bytes
Memory Device
Array Handle: 0x000B
Error Information Handle: Not Provided
Total Width: 64 bits
Data Width: 64 bits
Size: 2048 MB
Form Factor: SODIMM
Set: None
Locator: ChannelA-DIMM0
Bank Locator: BANK 0
Type: DDR3
Type Detail: Synchronous
Speed: 1600 MHz
Manufacturer: Elpida
Serial Number: 00000000
Asset Tag: 9876543210
Part Number: [Empty]
Rank: 1
Configured Clock Speed: 1600 MHz
Handle 0x000E, DMI type 20, 35 bytes
Memory Device Mapped Address
Starting Address: 0x00000000000
Ending Address: 0x0007FFFFFFF
Range Size: 2 GB
Physical Device Handle: 0x000D
Memory Array Mapped Address Handle: 0x0013
Partition Row Position: Unknown
Interleave Position: 1
Interleaved Data Depth: 2
Handle 0x000F, DMI type 17, 34 bytes
Memory Device
Array Handle: 0x000B
Error Information Handle: Not Provided
Total Width: Unknown
Data Width: Unknown
Size: No Module Installed
Form Factor: DIMM
Set: None
Locator: ChannelA-DIMM1
Bank Locator: BANK 1
Type: Unknown
Type Detail: None
Speed: Unknown
Manufacturer: [Empty]
Serial Number: [Empty]
Asset Tag: 9876543210
Part Number: [Empty]
Rank: Unknown
Configured Clock Speed: Unknown
Handle 0x0010, DMI type 17, 34 bytes
Memory Device
Array Handle: 0x000B
Error Information Handle: Not Provided
Total Width: 64 bits
Data Width: 64 bits
Size: 2048 MB
Form Factor: SODIMM
Set: None
Locator: ChannelB-DIMM0
Bank Locator: BANK 2
Type: DDR3
Type Detail: Synchronous
Speed: 1600 MHz
Manufacturer: Elpida
Serial Number: 00000000
Asset Tag: 9876543210
Part Number: [Empty]
Rank: 1
Configured Clock Speed: 1600 MHz
Handle 0x0011, DMI type 20, 35 bytes
Memory Device Mapped Address
Starting Address: 0x00080000000
Ending Address: 0x000FFFFFFFF
Range Size: 2 GB
Physical Device Handle: 0x0010
Memory Array Mapped Address Handle: 0x0013
Partition Row Position: Unknown
Interleave Position: 2
Interleaved Data Depth: 2
Handle 0x0012, DMI type 17, 34 bytes
Memory Device
Array Handle: 0x000B
Error Information Handle: Not Provided
Total Width: Unknown
Data Width: Unknown
Size: No Module Installed
Form Factor: DIMM
Set: None
Locator: ChannelB-DIMM1
Bank Locator: BANK 3
Type: Unknown
Type Detail: None
Speed: Unknown
Manufacturer: [Empty]
Serial Number: [Empty]
Asset Tag: 9876543210
Part Number: [Empty]
Rank: Unknown
Configured Clock Speed: Unknown
Handle 0x0013, DMI type 19, 31 bytes
Memory Array Mapped Address
Starting Address: 0x00000000000
Ending Address: 0x000FFFFFFFF
Range Size: 4 GB
Physical Array Handle: 0x000B
Partition Width: 4
Handle 0x0017, DMI type 131, 64 bytes
OEM-specific Type
Header and Data:
83 40 17 00 31 00 00 00 00 00 00 00 00 00 00 00
F8 00 59 1E 00 00 00 00 01 20 00 00 00 00 08 00
B8 05 0A 00 00 00 00 00 C8 00 FF FF 00 00 00 00
00 00 00 00 66 00 00 00 76 50 72 6F 00 00 00 00
Handle 0x0018, DMI type 13, 22 bytes
BIOS Language Information
Language Description Format: Long
Installable Languages: 1
en|US|iso8859-1
Currently Installed Language: en|US|iso8859-1
Handle 0x0019, DMI type 127, 4 bytes
End Of Table
[-- Attachment #3: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] i915: initialize CADL in opregion
2012-06-28 11:05 ` Daniel Vetter
@ 2012-06-28 11:22 ` Daniel Vetter
2012-06-28 11:58 ` Lekensteyn
2012-06-29 14:48 ` Daniel Vetter
1 sibling, 1 reply; 13+ messages in thread
From: Daniel Vetter @ 2012-06-28 11:22 UTC (permalink / raw)
To: Lekensteyn; +Cc: dri-devel
On Thu, Jun 28, 2012 at 1:05 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
> - When loading the i915.ko with the CADL patch the screen went black
> (like at boot), but with some excessive vt-switching and X restarting
> I've managed to light it up. Although it is flickery as hell,
> especially the lower part of the screen. And if the screen is somewhat
> stable, I just get the upper part of the screen duplicated in the
> lower part.
Just a small note: Reloading i915.ko without the CADL patch fixes
things. No idea how that could happen ...
-Daniel
--
Daniel Vetter
daniel.vetter@ffwll.ch - +41 (0) 79 364 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] i915: initialize CADL in opregion
2012-06-28 11:22 ` Daniel Vetter
@ 2012-06-28 11:58 ` Lekensteyn
2012-06-28 12:38 ` Daniel Vetter
0 siblings, 1 reply; 13+ messages in thread
From: Lekensteyn @ 2012-06-28 11:58 UTC (permalink / raw)
To: Daniel Vetter; +Cc: dri-devel
On Thursday 28 June 2012 13:22:02 Daniel Vetter wrote:
> On Thu, Jun 28, 2012 at 1:05 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
> > - When loading the i915.ko with the CADL patch the screen went black
> > (like at boot), but with some excessive vt-switching and X restarting
> > I've managed to light it up. Although it is flickery as hell,
> > especially the lower part of the screen. And if the screen is somewhat
> > stable, I just get the upper part of the screen duplicated in the
> > lower part.
>
> Just a small note: Reloading i915.ko without the CADL patch fixes
> things. No idea how that could happen ...
> -Daniel
Does CADL gets reinitialised to zeroes on module load? (I think so, but could
you verify that by checking the contents of that field after loading the module
w/ and w/o the CADL patch?)
Peter
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] i915: initialize CADL in opregion
2012-06-28 11:58 ` Lekensteyn
@ 2012-06-28 12:38 ` Daniel Vetter
0 siblings, 0 replies; 13+ messages in thread
From: Daniel Vetter @ 2012-06-28 12:38 UTC (permalink / raw)
To: Lekensteyn; +Cc: dri-devel
On Thu, Jun 28, 2012 at 01:58:54PM +0200, Lekensteyn wrote:
> On Thursday 28 June 2012 13:22:02 Daniel Vetter wrote:
> > On Thu, Jun 28, 2012 at 1:05 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > - When loading the i915.ko with the CADL patch the screen went black
> > > (like at boot), but with some excessive vt-switching and X restarting
> > > I've managed to light it up. Although it is flickery as hell,
> > > especially the lower part of the screen. And if the screen is somewhat
> > > stable, I just get the upper part of the screen duplicated in the
> > > lower part.
> >
> > Just a small note: Reloading i915.ko without the CADL patch fixes
> > things. No idea how that could happen ...
> > -Daniel
>
> Does CADL gets reinitialised to zeroes on module load? (I think so, but could
> you verify that by checking the contents of that field after loading the module
> w/ and w/o the CADL patch?)
Yeah, the CADL is cleared out again.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] i915: initialize CADL in opregion
2012-06-28 11:05 ` Daniel Vetter
2012-06-28 11:22 ` Daniel Vetter
@ 2012-06-29 14:48 ` Daniel Vetter
1 sibling, 0 replies; 13+ messages in thread
From: Daniel Vetter @ 2012-06-29 14:48 UTC (permalink / raw)
To: Lekensteyn; +Cc: dri-devel
On Thu, Jun 28, 2012 at 01:05:58PM +0200, Daniel Vetter wrote:
> On Thu, Jun 28, 2012 at 1:24 AM, Lekensteyn <lekensteyn@gmail.com> wrote:
> > Thank you, I've now written a partial analysis which is available at
> > https://github.com/Lekensteyn/acpi-
> > stuff/blob/HEAD/dsl/Asus_Zenbook_DanielVetter/analysis.txt (note: URL is cut in
> > two parts in this mail, concat them as needed).
> >
> > Question: can you try disabling the asus-laptop module and try booting again
> > w/ and w/o the CADL patch applied?
> > - Does it boot in both cases?
> > - Do the brightness hotkeys work?
> > - Can you change brightness via /sys/class/backlight?
> > Can you SSH in it and check the logs? Any ACPI warnings/errors or messages
> > from the asus-laptop module? (or whatever asus module(s) is/are loaded)
> >
> > Can you also generate dmidecode.txt? (peek in http://lekensteyn.nl/files/get-
> > acpi-info.sh, you do not have to run all of the commands since I already have
> > your acpidump)
>
> Ok, because I have an ecrypted root fs I've tried to reload the
> i915.ko with CADL after booting. Test-results:
> - asus_wmi.ko doesn't seem to have any effect whatsoever on the endresult.
> - asus_nb_wmi.ko doesn't load (ENODEV).
> - brightness-keys (and also sound control) don't work, but controlling
> the backlight with /sys/class/backlight/acpi_video0/brightness works
> (if I can turn the panel on somehow, see below).
> - When loading the i915.ko with the CADL patch the screen went black
> (like at boot), but with some excessive vt-switching and X restarting
> I've managed to light it up. Although it is flickery as hell,
> especially the lower part of the screen. And if the screen is somewhat
> stable, I just get the upper part of the screen duplicated in the
> lower part.
> - dmidecode is attached.
> - no errors in the logs anywhere (if you ignore some ACPI resource
> conflicts because ACPI reserves some pch stuff itself, which then
> conflicts with the native gpio, sensors, whatever drivers).
>
> So I think this might be simply a timing issue that with CADL enabled
> we expose a pre-existing bug somewhere in our modeset sequence. I'm
> already chasing two issues on this machine:
> - edp refuses to light up crtc 1/2, only works after having switched
> back to crtc 0.
> - disabled pipes get stuck in the active state once having been used be edp.
>
> I have a feeling that all these issues are related, so I guess until
> I've tracked down the above the things we won't make much progress
> with this CADL patch.
Good news: I've fixed my edp issues (switching crtcs works reliable now
and nothing gets stuck in a half-disabled state) and now I don't get a
black/flashing screen any more when applying your patch.
Bad news: We need to refactor a big chunk of our driver to properly fix
this issue. Which means I can't merge your patch right away :(
Cheers, Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] i915: initialize CADL in opregion
2012-06-26 21:04 ` Jesse Barnes
2012-06-26 21:07 ` Daniel Vetter
@ 2012-09-13 21:17 ` Daniel Vetter
1 sibling, 0 replies; 13+ messages in thread
From: Daniel Vetter @ 2012-09-13 21:17 UTC (permalink / raw)
To: Jesse Barnes; +Cc: Lekensteyn, dri-devel
On Tue, Jun 26, 2012 at 02:04:00PM -0700, Jesse Barnes wrote:
> On Tue, 26 Jun 2012 00:36:24 +0200
> Lekensteyn <lekensteyn@gmail.com> wrote:
>
> > This is rather a hack to fix brightness hotkeys on a Clevo laptop. CADL is not
> > used anywhere in the driver code at the moment, but it could be used in BIOS as
> > is the case with the Clevo laptop.
> >
> > The Clevo B7130 requires the CADL field to contain at least the ID of
> > the LCD device. If this field is empty, the ACPI methods that are called
> > on pressing brightness / display switching hotkeys will not trigger a
> > notification. As a result, it appears as no hotkey has been pressed.
>
> Not ideal, but definitely better than nothing.
>
> Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Ok, 2nd try, I've merged this again to drm-intel-next. Let's hope it
doesn't blow up again, now that the cpu edp fixes are merged.
Thanks for the patch,
Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2012-09-13 21:17 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-25 22:36 [PATCH] i915: initialize CADL in opregion Lekensteyn
2012-06-26 21:04 ` Jesse Barnes
2012-06-26 21:07 ` Daniel Vetter
2012-06-26 21:34 ` Paul Menzel
2012-06-27 15:03 ` Daniel Vetter
2012-06-27 15:09 ` Lekensteyn
[not found] ` <20120627162737.GF5326@phenom.ffwll.local>
2012-06-27 23:24 ` Lekensteyn
2012-06-28 11:05 ` Daniel Vetter
2012-06-28 11:22 ` Daniel Vetter
2012-06-28 11:58 ` Lekensteyn
2012-06-28 12:38 ` Daniel Vetter
2012-06-29 14:48 ` Daniel Vetter
2012-09-13 21:17 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.