* [PATCH] ASoC: Intel: Don't issue ipc when processing response
@ 2014-08-01 15:09 Jie Yang
2014-08-01 18:12 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Jie Yang @ 2014-08-01 15:09 UTC (permalink / raw)
To: alsa-devel; +Cc: mengdong.lin, broonie, pawel.piskorski, liam.r.girdwood
From: Paweł Piskorski <pawel.piskorski@intel.com>
Make sure we dont issue IPC when we are processing a response.
Signed-off-by: Paweł Piskorski <pawel.piskorski@intel.com>
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Signed-off-by: Jie Yang <yang.jie@intel.com>
---
sound/soc/intel/sst-haswell-ipc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/sound/soc/intel/sst-haswell-ipc.c b/sound/soc/intel/sst-haswell-ipc.c
index 5a607ab..0fec686 100644
--- a/sound/soc/intel/sst-haswell-ipc.c
+++ b/sound/soc/intel/sst-haswell-ipc.c
@@ -457,9 +457,10 @@ static void ipc_tx_msgs(struct kthread_work *work)
return;
}
- /* if the DSP is busy we will TX messages after IRQ */
+ /* if the DSP is busy, we will TX messages after IRQ.
+ * also postpone if we are in the middle of procesing completion irq*/
ipcx = sst_dsp_shim_read_unlocked(hsw->dsp, SST_IPCX);
- if (ipcx & SST_IPCX_BUSY) {
+ if (ipcx & (SST_IPCX_BUSY | SST_IPCX_DONE)) {
spin_unlock_irqrestore(&hsw->dsp->spinlock, flags);
return;
}
--
1.8.3.2
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: Intel: Don't issue ipc when processing response
2014-08-01 15:09 [PATCH] ASoC: Intel: Don't issue ipc when processing response Jie Yang
@ 2014-08-01 18:12 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-08-01 18:12 UTC (permalink / raw)
To: Jie Yang; +Cc: mengdong.lin, alsa-devel, pawel.piskorski, liam.r.girdwood
[-- Attachment #1.1: Type: text/plain, Size: 203 bytes --]
On Fri, Aug 01, 2014 at 11:09:44PM +0800, Jie Yang wrote:
> From: Paweł Piskorski <pawel.piskorski@intel.com>
>
> Make sure we dont issue IPC when we are processing a response.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-01 18:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-01 15:09 [PATCH] ASoC: Intel: Don't issue ipc when processing response Jie Yang
2014-08-01 18:12 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.