All of lore.kernel.org
 help / color / mirror / Atom feed
* [Powertop] [PATCH 00/12] various build system and static analysis improvement
@ 2014-08-02 11:54 Sami Kerola
  0 siblings, 0 replies; 3+ messages in thread
From: Sami Kerola @ 2014-08-02 11:54 UTC (permalink / raw)
  To: powertop

[-- Attachment #1: Type: text/plain, Size: 5021 bytes --]

Hello,

Here is a set of various maintenance patches.  None very important, but I
am hopeful they are seen as usefull enought to be merged to the project. 

While working with the patch set I noticed my  Arch linux kernel 3.15.8-1
with powertop --auto-tune is printing

$ ./src/powertop --auto                                                          
Loaded 242 prior measurements
RAPL device for cpu 0
RAPL device for cpu 0
  unknown op '{'

An it seems the { is coming

/sys/kernel/debug/tracing/events/timer/hrtimer_expire_entry/format

Here's backtrace about about the message printout.

(gdb) bt
#0  0x00007fe46e9eed67 in raise () from /usr/lib/libc.so.6
#1  0x00007fe46e9f0118 in abort () from /usr/lib/libc.so.6
#2  0x0000000000461c1e in process_op (event=0x13eb750, arg=0x13ebd30, tok=0x7fff6efd8d08)
    at event-parse.c:1905
#3  0x000000000046328b in process_paren (event=0x13eb750, arg=0x13ebd30, tok=0x7fff6efd8d58)
    at event-parse.c:2574
#4  0x0000000000463af3 in process_arg_token (event=0x13eb750, arg=0x13ebd30, tok=0x7fff6efd8df8, 
    type=EVENT_DELIM) at event-parse.c:2833
#5  0x000000000046103e in process_arg (event=0x13eb750, arg=0x13ebd30, tok=0x7fff6efd8df8)
    at event-parse.c:1590
#6  0x0000000000463260 in process_paren (event=0x13eb750, arg=0x13ebd30, tok=0x7fff6efd8e48)
    at event-parse.c:2568
#7  0x0000000000463af3 in process_arg_token (event=0x13eb750, arg=0x13ebd30, tok=0x7fff6efd8ea8, 
    type=EVENT_DELIM) at event-parse.c:2833
#8  0x00000000004633af in process_paren (event=0x13eb750, arg=0x13ebcd0, tok=0x7fff6efd8ef8)
    at event-parse.c:2609
#9  0x0000000000463af3 in process_arg_token (event=0x13eb750, arg=0x13ebcd0, tok=0x7fff6efd8f88, 
    type=EVENT_DELIM) at event-parse.c:2833
#10 0x000000000046103e in process_arg (event=0x13eb750, arg=0x13ebcd0, tok=0x7fff6efd8f88)
    at event-parse.c:1590
#11 0x0000000000463c12 in event_read_print_args (event=0x13eb750, list=0x13ebc70) at event-parse.c:2879
#12 0x0000000000463e71 in event_read_print (event=0x13eb750) at event-parse.c:2963
#13 0x0000000000467fb3 in __pevent_parse_format (eventp=0x7fff6efd9080, pevent=0x1178930, 
    buf=0x13eb500 "name: hrtimer_expire_entry\nID: 128\nformat:\n\tfield:unsigned short common_type;\toffset:0;\tsize:2;\tsigned:0;\n\tfield:unsigned char common_flags;\toffset:2;\tsize:1;\tsigned:0;\n\tfield:unsigned char common_pre"..., size=578, sys=0x13eb130 "timer") at event-parse.c:5014
#14 0x00000000004681aa in pevent_parse_event (pevent=0x1178930, 
    buf=0x13eb500 "name: hrtimer_expire_entry\nID: 128\nformat:\n\tfield:unsigned short common_type;\toffset:0;\tsize:2;\tsigned:0;\n\tfield:unsigned char common_flags;\toffset:2;\tsize:1;\tsigned:0;\n\tfield:unsigned char common_pre"..., size=578, sys=0x13eb130 "timer") at event-parse.c:5099
#15 0x000000000043db0a in parse_event_format (event_name=0x46f0bd "timer:hrtimer_expire_entry")
    at perf/perf_bundle.cpp:147
#16 0x000000000043dc59 in perf_bundle::add_event (this=0x117a2e0, 
    event_name=0x46f0bd "timer:hrtimer_expire_entry") at perf/perf_bundle.cpp:173
#17 0x0000000000443b91 in start_process_measurement () at process/do_process.cpp:667
#18 0x0000000000411a18 in one_measurement (seconds=1, workload=0x0) at main.cpp:180
#19 0x0000000000412408 in main (argc=2, argv=0x7fff6efdb2c8) at main.cpp:466

I do not know how to fix that, so hopefully someone who knows the sysfs
file format in question notices this message and makes the code not to do
that.


Sami Kerola (12):
  configure: use vertical lists and AS_IF macro
  update .gitignore
  clean up Makefile.am files
  fix clang++ compilation errors
  remove unnecessary assignments
  remove unnecessary code reported by cppcheck
  move options structure to function scope
  do not use ncurses when --auto-tune is specified
  improve manual groff syntax
  fix couple typos
  wrap lines in README.traceevent
  clean up .gitignore file

 .gitignore                      | 110 ++++++++++-------------
 Makefile.am                     |  14 ++-
 README.traceevent               |  21 +++--
 configure.ac                    | 102 ++++++++++++++++-----
 doc/powertop.8                  | 141 ++++++++++++++---------------
 src/Makefile.am                 | 193 +++++++++++++++++++++++++++++++---------
 src/cpu/cpu.cpp                 |  18 ++--
 src/cpu/rapl/rapl_interface.cpp |   4 +-
 src/devices/ahci.cpp            |   3 +-
 src/devices/alsa.cpp            |   1 -
 src/devices/device.cpp          |   6 +-
 src/devlist.cpp                 |   3 +-
 src/display.cpp                 |   9 +-
 src/lib.cpp                     |   8 +-
 src/main.cpp                    |  50 ++++++-----
 src/process/do_process.cpp      |  11 ++-
 src/report/report.cpp           |   3 +-
 src/tuning/nl80211.h            |   4 +-
 src/tuning/runtime.cpp          |   4 -
 src/tuning/tuning.cpp           |  11 +--
 20 files changed, 445 insertions(+), 271 deletions(-)

-- 
2.0.3


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [Powertop] [PATCH 00/12] various build system and static analysis improvement
@ 2014-08-02 22:29 Sami Kerola
  0 siblings, 0 replies; 3+ messages in thread
From: Sami Kerola @ 2014-08-02 22:29 UTC (permalink / raw)
  To: powertop

[-- Attachment #1: Type: text/plain, Size: 2035 bytes --]

On 2 August 2014 14:58, Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com> wrote:
> On (08/02/14 12:54), Sami Kerola wrote:
>> Here is a set of various maintenance patches.  None very important, but I
>> am hopeful they are seen as usefull enought to be merged to the project.
>>
>> While working with the patch set I noticed my  Arch linux kernel 3.15.8-1
>> with powertop --auto-tune is printing
>>
>> $ ./src/powertop --auto
>> Loaded 242 prior measurements
>> RAPL device for cpu 0
>> RAPL device for cpu 0
>>   unknown op '{'
>>
>> An it seems the { is coming
>
> this is well a known warning, in short plugin support needs to be
> backported to traceevent.

Good to hear, and thank you Sergey and Magnus for first round of
review. As a result there are couple changes to few commits, biggest
being the split to the first commit. To avoid sending nearly the same
patches again to mail list I think it is better to fetch the latest
from my github branch.


The following changes since commit a5465a282107da5205b7928fe4ce4f642d1fd770:

  Bug-fix: for html & csv value for CPU Information (2014-06-18 14:23:18 -0700)

are available in the git repository at:

  https://github.com/kerolasa/powertop sami

for you to fetch changes up to 65b0eed332b515003dc1a38dbb51a43e563fb692:

  clean up .gitignore file (2014-08-02 22:50:26 +0100)

----------------------------------------------------------------
Sami Kerola (13):
      configure: use vertical lists
      configure: prefer AS_IF macro rather than shell if statement
      update .gitignore
      clean up Makefile.am files
      fix clang++ compilation errors
      remove unnecessary assignments
      remove unnecessary code reported by cppcheck
      move options structure to function scope
      do not use ncurses when --auto-tune is specified
      improve manual groff syntax
      fix couple typos
      wrap lines in README.traceevent
      clean up .gitignore file

-- 
Sami Kerola
http://www.iki.fi/kerolasa/

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [Powertop] [PATCH 00/12] various build system and static analysis improvement
@ 2014-08-02 13:58 Sergey Senozhatsky
  0 siblings, 0 replies; 3+ messages in thread
From: Sergey Senozhatsky @ 2014-08-02 13:58 UTC (permalink / raw)
  To: powertop

[-- Attachment #1: Type: text/plain, Size: 5529 bytes --]

Hello,

On (08/02/14 12:54), Sami Kerola wrote:
> Hello,
> 
> Here is a set of various maintenance patches.  None very important, but I
> am hopeful they are seen as usefull enought to be merged to the project. 
> 
> While working with the patch set I noticed my  Arch linux kernel 3.15.8-1
> with powertop --auto-tune is printing
> 
> $ ./src/powertop --auto                                                          
> Loaded 242 prior measurements
> RAPL device for cpu 0
> RAPL device for cpu 0
>   unknown op '{'
> 
> An it seems the { is coming

this is well a known warning, in short plugin support needs to be
backported to traceevent.

	-ss

> /sys/kernel/debug/tracing/events/timer/hrtimer_expire_entry/format
> 
> Here's backtrace about about the message printout.
> 
> (gdb) bt
> #0  0x00007fe46e9eed67 in raise () from /usr/lib/libc.so.6
> #1  0x00007fe46e9f0118 in abort () from /usr/lib/libc.so.6
> #2  0x0000000000461c1e in process_op (event=0x13eb750, arg=0x13ebd30, tok=0x7fff6efd8d08)
>     at event-parse.c:1905
> #3  0x000000000046328b in process_paren (event=0x13eb750, arg=0x13ebd30, tok=0x7fff6efd8d58)
>     at event-parse.c:2574
> #4  0x0000000000463af3 in process_arg_token (event=0x13eb750, arg=0x13ebd30, tok=0x7fff6efd8df8, 
>     type=EVENT_DELIM) at event-parse.c:2833
> #5  0x000000000046103e in process_arg (event=0x13eb750, arg=0x13ebd30, tok=0x7fff6efd8df8)
>     at event-parse.c:1590
> #6  0x0000000000463260 in process_paren (event=0x13eb750, arg=0x13ebd30, tok=0x7fff6efd8e48)
>     at event-parse.c:2568
> #7  0x0000000000463af3 in process_arg_token (event=0x13eb750, arg=0x13ebd30, tok=0x7fff6efd8ea8, 
>     type=EVENT_DELIM) at event-parse.c:2833
> #8  0x00000000004633af in process_paren (event=0x13eb750, arg=0x13ebcd0, tok=0x7fff6efd8ef8)
>     at event-parse.c:2609
> #9  0x0000000000463af3 in process_arg_token (event=0x13eb750, arg=0x13ebcd0, tok=0x7fff6efd8f88, 
>     type=EVENT_DELIM) at event-parse.c:2833
> #10 0x000000000046103e in process_arg (event=0x13eb750, arg=0x13ebcd0, tok=0x7fff6efd8f88)
>     at event-parse.c:1590
> #11 0x0000000000463c12 in event_read_print_args (event=0x13eb750, list=0x13ebc70) at event-parse.c:2879
> #12 0x0000000000463e71 in event_read_print (event=0x13eb750) at event-parse.c:2963
> #13 0x0000000000467fb3 in __pevent_parse_format (eventp=0x7fff6efd9080, pevent=0x1178930, 
>     buf=0x13eb500 "name: hrtimer_expire_entry\nID: 128\nformat:\n\tfield:unsigned short common_type;\toffset:0;\tsize:2;\tsigned:0;\n\tfield:unsigned char common_flags;\toffset:2;\tsize:1;\tsigned:0;\n\tfield:unsigned char common_pre"..., size=578, sys=0x13eb130 "timer") at event-parse.c:5014
> #14 0x00000000004681aa in pevent_parse_event (pevent=0x1178930, 
>     buf=0x13eb500 "name: hrtimer_expire_entry\nID: 128\nformat:\n\tfield:unsigned short common_type;\toffset:0;\tsize:2;\tsigned:0;\n\tfield:unsigned char common_flags;\toffset:2;\tsize:1;\tsigned:0;\n\tfield:unsigned char common_pre"..., size=578, sys=0x13eb130 "timer") at event-parse.c:5099
> #15 0x000000000043db0a in parse_event_format (event_name=0x46f0bd "timer:hrtimer_expire_entry")
>     at perf/perf_bundle.cpp:147
> #16 0x000000000043dc59 in perf_bundle::add_event (this=0x117a2e0, 
>     event_name=0x46f0bd "timer:hrtimer_expire_entry") at perf/perf_bundle.cpp:173
> #17 0x0000000000443b91 in start_process_measurement () at process/do_process.cpp:667
> #18 0x0000000000411a18 in one_measurement (seconds=1, workload=0x0) at main.cpp:180
> #19 0x0000000000412408 in main (argc=2, argv=0x7fff6efdb2c8) at main.cpp:466
> 
> I do not know how to fix that, so hopefully someone who knows the sysfs
> file format in question notices this message and makes the code not to do
> that.
> 
> 
> Sami Kerola (12):
>   configure: use vertical lists and AS_IF macro
>   update .gitignore
>   clean up Makefile.am files
>   fix clang++ compilation errors
>   remove unnecessary assignments
>   remove unnecessary code reported by cppcheck
>   move options structure to function scope
>   do not use ncurses when --auto-tune is specified
>   improve manual groff syntax
>   fix couple typos
>   wrap lines in README.traceevent
>   clean up .gitignore file
> 
>  .gitignore                      | 110 ++++++++++-------------
>  Makefile.am                     |  14 ++-
>  README.traceevent               |  21 +++--
>  configure.ac                    | 102 ++++++++++++++++-----
>  doc/powertop.8                  | 141 ++++++++++++++---------------
>  src/Makefile.am                 | 193 +++++++++++++++++++++++++++++++---------
>  src/cpu/cpu.cpp                 |  18 ++--
>  src/cpu/rapl/rapl_interface.cpp |   4 +-
>  src/devices/ahci.cpp            |   3 +-
>  src/devices/alsa.cpp            |   1 -
>  src/devices/device.cpp          |   6 +-
>  src/devlist.cpp                 |   3 +-
>  src/display.cpp                 |   9 +-
>  src/lib.cpp                     |   8 +-
>  src/main.cpp                    |  50 ++++++-----
>  src/process/do_process.cpp      |  11 ++-
>  src/report/report.cpp           |   3 +-
>  src/tuning/nl80211.h            |   4 +-
>  src/tuning/runtime.cpp          |   4 -
>  src/tuning/tuning.cpp           |  11 +--
>  20 files changed, 445 insertions(+), 271 deletions(-)
> 
> -- 
> 2.0.3
> 
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-02 22:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-02 11:54 [Powertop] [PATCH 00/12] various build system and static analysis improvement Sami Kerola
2014-08-02 13:58 Sergey Senozhatsky
2014-08-02 22:29 Sami Kerola

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.