* [PATCH] staging: comedi: fixing coding style problems
@ 2014-08-06 17:55 Niklas Svensson
2014-08-07 9:56 ` Ian Abbott
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Svensson @ 2014-08-06 17:55 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Ian Abbott, H Hartley Sweeten, Niklas Svensson,
Raghavendra Ganiga, devel, linux-kernel
This patch fixes warnings of checkpatch.pl script:
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around devpriv->timer
+ init_timer(&(devpriv->timer));
CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
+ dev_info(dev->class_dev,
+ "%s: %i microvolt, %li microsecond waveform attached\n",
Task of Eudyptula challenge.
Signed-off-by: Niklas Svensson <nks@flawful.org>
---
drivers/staging/comedi/drivers/comedi_test.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/comedi_test.c b/drivers/staging/comedi/drivers/comedi_test.c
index 845a679..7aa23db 100644
--- a/drivers/staging/comedi/drivers/comedi_test.c
+++ b/drivers/staging/comedi/drivers/comedi_test.c
@@ -415,14 +415,14 @@ static int waveform_attach(struct comedi_device *dev,
for (i = 0; i < s->n_chan; i++)
devpriv->ao_loopbacks[i] = s->maxdata / 2;
- init_timer(&(devpriv->timer));
+ init_timer(&devpriv->timer);
devpriv->timer.function = waveform_ai_interrupt;
devpriv->timer.data = (unsigned long)dev;
dev_info(dev->class_dev,
- "%s: %i microvolt, %li microsecond waveform attached\n",
- dev->board_name,
- devpriv->uvolt_amplitude, devpriv->usec_period);
+ "%s: %i microvolt, %li microsecond waveform attached\n",
+ dev->board_name,
+ devpriv->uvolt_amplitude, devpriv->usec_period);
return 0;
}
--
2.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: comedi: fixing coding style problems
2014-08-06 17:55 [PATCH] staging: comedi: fixing coding style problems Niklas Svensson
@ 2014-08-07 9:56 ` Ian Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Ian Abbott @ 2014-08-07 9:56 UTC (permalink / raw)
To: Niklas Svensson, Greg Kroah-Hartman
Cc: H Hartley Sweeten, Raghavendra Ganiga, devel, linux-kernel
On 2014/08/06 06:55 PM, Niklas Svensson wrote:
> This patch fixes warnings of checkpatch.pl script:
>
> CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around devpriv->timer
> + init_timer(&(devpriv->timer));
>
> CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
> + dev_info(dev->class_dev,
> + "%s: %i microvolt, %li microsecond waveform attached\n",
>
> Task of Eudyptula challenge.
>
> Signed-off-by: Niklas Svensson <nks@flawful.org>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-07 9:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-06 17:55 [PATCH] staging: comedi: fixing coding style problems Niklas Svensson
2014-08-07 9:56 ` Ian Abbott
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.