All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tests: make ipcs limit calculations work when numbers are large
@ 2014-08-06 22:04 Sami Kerola
  2014-08-11 12:58 ` Karel Zak
  0 siblings, 1 reply; 2+ messages in thread
From: Sami Kerola @ 2014-08-06 22:04 UTC (permalink / raw)
  To: util-linux; +Cc: kerolasa

Test suite  failed when I ran it with kernel 3.16.  Error is the
following.

tests/ts/ipcs/limits2: line 31: [: 18446744073692774399: integer expression expected

Reference: http://lkml.iu.edu/hypermail/linux/kernel/1406.0/01869.html
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---
 tests/ts/ipcs/limits2 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/ts/ipcs/limits2 b/tests/ts/ipcs/limits2
index 2333198..1a49c46 100755
--- a/tests/ts/ipcs/limits2
+++ b/tests/ts/ipcs/limits2
@@ -28,7 +28,8 @@ ts_check_prog "bc"
 . $TS_SELF/functions.sh
 
 # TODO https://github.com/karelzak/util-linux/issues/51
-if [ $(</proc/sys/kernel/shmall) -ge $(bc <<<"2^64 / $PAGE_SIZE") ]; then
+SHMALL=$(</proc/sys/kernel/shmall)
+if [ $(bc <<<"2^64 / $PAGE_SIZE < $SHMALL") -ne 1 ]; then
 	TS_KNOWN_FAIL="yes"
 fi
 
-- 
2.0.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] tests: make ipcs limit calculations work when numbers are large
  2014-08-06 22:04 [PATCH] tests: make ipcs limit calculations work when numbers are large Sami Kerola
@ 2014-08-11 12:58 ` Karel Zak
  0 siblings, 0 replies; 2+ messages in thread
From: Karel Zak @ 2014-08-11 12:58 UTC (permalink / raw)
  To: Sami Kerola; +Cc: util-linux

On Wed, Aug 06, 2014 at 11:04:31PM +0100, Sami Kerola wrote:
>  tests/ts/ipcs/limits2 | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

 Applied, thanks.

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-08-11 12:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-06 22:04 [PATCH] tests: make ipcs limit calculations work when numbers are large Sami Kerola
2014-08-11 12:58 ` Karel Zak

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.