All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: "Fujinaka, Todd" <todd.fujinaka@intel.com>
Cc: "hannes@stressinduktion.org" <hannes@stressinduktion.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"e1000-devel@lists.sourceforge.net" 
	<e1000-devel@lists.sourceforge.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"mathias.koehrer@etas.com" <mathias.koehrer@etas.com>
Subject: Re: [E1000-devel] PROBLEM: [x86] Running ptpd2 using an Intel 82572EI (e1000e) leads to a kernel oops (3.12.26)
Date: Wed, 6 Aug 2014 22:32:56 +0000	[thread overview]
Message-ID: <1407364376.29652.3.camel@jekeller-desk1.amr.corp.intel.com> (raw)
In-Reply-To: <9B4A1B1917080E46B64F07F2989DADD6533AC68E@ORSMSX114.amr.corp.intel.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 860 bytes --]

On Wed, 2014-08-06 at 15:38 +0000, Fujinaka, Todd wrote:
> Looking at your patches on netdev, it appears that there are flags set in the skb that should never be set for the 82572EI as that part doesn't have hardware timestamping. This points to a bug in the ptpd code.
> 
> Todd Fujinaka
> Software Application Engineer
> Networking Division (ND)
> Intel Corporation
> todd.fujinaka@intel.com
> (503) 712-4565


Surely we can bail here instead of generating a kernel oops? Even though
ptpd may be incorrect here, we still shouldn't do this. I think this may
be a bug in the set_ts_config possibly as well (since it shouldn't be
able to set the hardware timestamp flags for the 82572EI

Thanks,
Jake
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

WARNING: multiple messages have this Message-ID (diff)
From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: "Fujinaka, Todd" <todd.fujinaka@intel.com>
Cc: "hannes@stressinduktion.org" <hannes@stressinduktion.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"e1000-devel@lists.sourceforge.net"
	<e1000-devel@lists.sourceforge.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"mathias.koehrer@etas.com" <mathias.koehrer@etas.com>
Subject: Re: [E1000-devel] PROBLEM: [x86] Running ptpd2 using an Intel 82572EI (e1000e) leads to a kernel oops (3.12.26)
Date: Wed, 6 Aug 2014 22:32:56 +0000	[thread overview]
Message-ID: <1407364376.29652.3.camel@jekeller-desk1.amr.corp.intel.com> (raw)
In-Reply-To: <9B4A1B1917080E46B64F07F2989DADD6533AC68E@ORSMSX114.amr.corp.intel.com>

On Wed, 2014-08-06 at 15:38 +0000, Fujinaka, Todd wrote:
> Looking at your patches on netdev, it appears that there are flags set in the skb that should never be set for the 82572EI as that part doesn't have hardware timestamping. This points to a bug in the ptpd code.
> 
> Todd Fujinaka
> Software Application Engineer
> Networking Division (ND)
> Intel Corporation
> todd.fujinaka@intel.com
> (503) 712-4565


Surely we can bail here instead of generating a kernel oops? Even though
ptpd may be incorrect here, we still shouldn't do this. I think this may
be a bug in the set_ts_config possibly as well (since it shouldn't be
able to set the hardware timestamp flags for the 82572EI

Thanks,
Jake

  reply	other threads:[~2014-08-06 22:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-04 12:26 PROBLEM: [x86] Running ptpd2 using an Intel 82572EI (e1000e) leads to a kernel oops (3.12.26) Koehrer Mathias (ETAS/ESW5)
2014-08-06  0:35 ` Nick Krause
2014-08-06  8:33   ` Heinz Diehl
2014-08-06 10:52     ` Koehrer Mathias (ETAS/ESW5)
2014-08-06 10:15   ` Koehrer Mathias (ETAS/ESW5)
2014-08-06 10:15     ` Koehrer Mathias (ETAS/ESW5)
     [not found]     ` <CAPDOMVgFA-jTL=iDD2vLzPHrsO_=qsupAebTSUm0k0VmmHvX6A@mail.gmail.com>
2014-08-06 12:17       ` Koehrer Mathias (ETAS/ESW5)
2014-08-06 12:17         ` Koehrer Mathias (ETAS/ESW5)
     [not found]         ` <CAPDOMVjWO9rfZjnHOgK+yB-3MVkmVz_00piBgnDFdf6j=56+GA@mail.gmail.com>
2014-08-06 13:25           ` Koehrer Mathias (ETAS/ESW5)
2014-08-06  9:29 ` Hannes Frederic Sowa
2014-08-06 15:38   ` [E1000-devel] " Fujinaka, Todd
2014-08-06 15:38     ` Fujinaka, Todd
2014-08-06 22:32     ` Keller, Jacob E [this message]
2014-08-06 22:32       ` Keller, Jacob E

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407364376.29652.3.camel@jekeller-desk1.amr.corp.intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=hannes@stressinduktion.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathias.koehrer@etas.com \
    --cc=netdev@vger.kernel.org \
    --cc=todd.fujinaka@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.