* [PATCH 02/15] cpufreq: fix decimal printf format specifiers prefixed with 0x
@ 2014-08-06 4:41 Hans Wennborg
2014-08-06 20:35 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Hans Wennborg @ 2014-08-06 4:41 UTC (permalink / raw)
To: rjw, linux-pm, linux-kernel; +Cc: Hans Wennborg
The prefix suggests the number should be printed in hex, so use
the %x specifier to do that.
Found by using regex suggested by Joe Perches.
Signed-off-by: Hans Wennborg <hans@hanshq.net>
---
drivers/cpufreq/speedstep-smi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/cpufreq/speedstep-smi.c b/drivers/cpufreq/speedstep-smi.c
index 8635eec..fda9beb 100644
--- a/drivers/cpufreq/speedstep-smi.c
+++ b/drivers/cpufreq/speedstep-smi.c
@@ -324,8 +324,8 @@ static int __init speedstep_init(void)
return -ENODEV;
}
- pr_debug("signature:0x%.8ulx, command:0x%.8ulx, "
- "event:0x%.8ulx, perf_level:0x%.8ulx.\n",
+ pr_debug("signature:0x%.8lx, command:0x%.8lx, "
+ "event:0x%.8lx, perf_level:0x%.8lx.\n",
ist_info.signature, ist_info.command,
ist_info.event, ist_info.perf_level);
--
2.0.0.526.g5318336
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 02/15] cpufreq: fix decimal printf format specifiers prefixed with 0x
2014-08-06 4:41 [PATCH 02/15] cpufreq: fix decimal printf format specifiers prefixed with 0x Hans Wennborg
@ 2014-08-06 20:35 ` Rafael J. Wysocki
2014-08-07 5:52 ` [PATCH 1/1] cpufreq: fix decimal printf " Hans Wennborg
2014-08-07 5:53 ` [PATCH 02/15] cpufreq: fix decimal printf format " Hans Wennborg
0 siblings, 2 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2014-08-06 20:35 UTC (permalink / raw)
To: Hans Wennborg; +Cc: linux-pm, linux-kernel
On Tuesday, August 05, 2014 09:41:48 PM Hans Wennborg wrote:
> The prefix suggests the number should be printed in hex, so use
> the %x specifier to do that.
>
> Found by using regex suggested by Joe Perches.
>
> Signed-off-by: Hans Wennborg <hans@hanshq.net>
This triggers a build warning related to the formats. Care to fix up?
> ---
> drivers/cpufreq/speedstep-smi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/speedstep-smi.c b/drivers/cpufreq/speedstep-smi.c
> index 8635eec..fda9beb 100644
> --- a/drivers/cpufreq/speedstep-smi.c
> +++ b/drivers/cpufreq/speedstep-smi.c
> @@ -324,8 +324,8 @@ static int __init speedstep_init(void)
> return -ENODEV;
> }
>
> - pr_debug("signature:0x%.8ulx, command:0x%.8ulx, "
> - "event:0x%.8ulx, perf_level:0x%.8ulx.\n",
> + pr_debug("signature:0x%.8lx, command:0x%.8lx, "
> + "event:0x%.8lx, perf_level:0x%.8lx.\n",
> ist_info.signature, ist_info.command,
> ist_info.event, ist_info.perf_level);
>
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] cpufreq: fix decimal printf specifiers prefixed with 0x
2014-08-06 20:35 ` Rafael J. Wysocki
@ 2014-08-07 5:52 ` Hans Wennborg
2014-08-07 5:53 ` [PATCH 02/15] cpufreq: fix decimal printf format " Hans Wennborg
1 sibling, 0 replies; 4+ messages in thread
From: Hans Wennborg @ 2014-08-07 5:52 UTC (permalink / raw)
To: rjw, linux-pm, linux-kernel; +Cc: Hans Wennborg
The prefix suggests the number should be printed in hex, so use
the %x specifier to do that. Also, these are 32-bit values,
so drop the l characters.
Signed-off-by: Hans Wennborg <hans@hanshq.net>
---
drivers/cpufreq/speedstep-smi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/cpufreq/speedstep-smi.c b/drivers/cpufreq/speedstep-smi.c
index 8635eec..5fc96d5 100644
--- a/drivers/cpufreq/speedstep-smi.c
+++ b/drivers/cpufreq/speedstep-smi.c
@@ -324,8 +324,8 @@ static int __init speedstep_init(void)
return -ENODEV;
}
- pr_debug("signature:0x%.8ulx, command:0x%.8ulx, "
- "event:0x%.8ulx, perf_level:0x%.8ulx.\n",
+ pr_debug("signature:0x%.8x, command:0x%.8x, "
+ "event:0x%.8x, perf_level:0x%.8x.\n",
ist_info.signature, ist_info.command,
ist_info.event, ist_info.perf_level);
--
2.0.0.526.g5318336
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 02/15] cpufreq: fix decimal printf format specifiers prefixed with 0x
2014-08-06 20:35 ` Rafael J. Wysocki
2014-08-07 5:52 ` [PATCH 1/1] cpufreq: fix decimal printf " Hans Wennborg
@ 2014-08-07 5:53 ` Hans Wennborg
1 sibling, 0 replies; 4+ messages in thread
From: Hans Wennborg @ 2014-08-07 5:53 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: linux-pm, linux-kernel
On 08/06/2014 01:35 PM, Rafael J. Wysocki wrote:
> On Tuesday, August 05, 2014 09:41:48 PM Hans Wennborg wrote:
>> The prefix suggests the number should be printed in hex, so use
>> the %x specifier to do that.
>>
>> Found by using regex suggested by Joe Perches.
>>
>> Signed-off-by: Hans Wennborg <hans@hanshq.net>
>
> This triggers a build warning related to the formats. Care to fix up?
Sure. Sending a new patch, hopefully attached to the same thread (still
working on my git send-mail skills).
- Hans
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-07 5:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-06 4:41 [PATCH 02/15] cpufreq: fix decimal printf format specifiers prefixed with 0x Hans Wennborg
2014-08-06 20:35 ` Rafael J. Wysocki
2014-08-07 5:52 ` [PATCH 1/1] cpufreq: fix decimal printf " Hans Wennborg
2014-08-07 5:53 ` [PATCH 02/15] cpufreq: fix decimal printf format " Hans Wennborg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.