All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dmaengine: sun6i: depends on RESET_CONTROLLER
@ 2014-08-07 17:00 ` Maxime Ripard
  0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2014-08-07 17:00 UTC (permalink / raw)
  To: Dan Williams, Vinod Koul
  Cc: linux-kernel, linux-arm-kernel, dmaengine, Maxime Ripard

Fixes a compilation error when RESET_CONTROLLER is not enabled in the
configuration.

drivers/dma/sun6i-dma.c: In function 'sun6i_dma_probe':
drivers/dma/sun6i-dma.c:911:2: error: implicit declaration of function 'devm_reset_control_get' [-Werror=implicit-function-declaration]

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
---
 drivers/dma/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 4b439270fb11..a85e54af5eb1 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -378,6 +378,7 @@ config XILINX_VDMA
 config DMA_SUN6I
 	tristate "Allwinner A31 SoCs DMA support"
 	depends on MACH_SUN6I || COMPILE_TEST
+	depends on RESET_CONTROLLER
 	select DMA_ENGINE
 	select DMA_VIRTUAL_CHANNELS
 	help
-- 
2.0.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] dmaengine: sun6i: depends on RESET_CONTROLLER
@ 2014-08-07 17:00 ` Maxime Ripard
  0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2014-08-07 17:00 UTC (permalink / raw)
  To: linux-arm-kernel

Fixes a compilation error when RESET_CONTROLLER is not enabled in the
configuration.

drivers/dma/sun6i-dma.c: In function 'sun6i_dma_probe':
drivers/dma/sun6i-dma.c:911:2: error: implicit declaration of function 'devm_reset_control_get' [-Werror=implicit-function-declaration]

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
---
 drivers/dma/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 4b439270fb11..a85e54af5eb1 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -378,6 +378,7 @@ config XILINX_VDMA
 config DMA_SUN6I
 	tristate "Allwinner A31 SoCs DMA support"
 	depends on MACH_SUN6I || COMPILE_TEST
+	depends on RESET_CONTROLLER
 	select DMA_ENGINE
 	select DMA_VIRTUAL_CHANNELS
 	help
-- 
2.0.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dmaengine: sun6i: depends on RESET_CONTROLLER
  2014-08-07 17:00 ` Maxime Ripard
@ 2014-08-08 17:13   ` Vinod Koul
  -1 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2014-08-08 17:13 UTC (permalink / raw)
  To: Maxime Ripard; +Cc: Dan Williams, linux-kernel, linux-arm-kernel, dmaengine

On Thu, Aug 07, 2014 at 07:00:44PM +0200, Maxime Ripard wrote:
> Fixes a compilation error when RESET_CONTROLLER is not enabled in the
> configuration.
> 
> drivers/dma/sun6i-dma.c: In function 'sun6i_dma_probe':
> drivers/dma/sun6i-dma.c:911:2: error: implicit declaration of function 'devm_reset_control_get' [-Werror=implicit-function-declaration]

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] dmaengine: sun6i: depends on RESET_CONTROLLER
@ 2014-08-08 17:13   ` Vinod Koul
  0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2014-08-08 17:13 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Aug 07, 2014 at 07:00:44PM +0200, Maxime Ripard wrote:
> Fixes a compilation error when RESET_CONTROLLER is not enabled in the
> configuration.
> 
> drivers/dma/sun6i-dma.c: In function 'sun6i_dma_probe':
> drivers/dma/sun6i-dma.c:911:2: error: implicit declaration of function 'devm_reset_control_get' [-Werror=implicit-function-declaration]

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-08-08 17:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-07 17:00 [PATCH] dmaengine: sun6i: depends on RESET_CONTROLLER Maxime Ripard
2014-08-07 17:00 ` Maxime Ripard
2014-08-08 17:13 ` Vinod Koul
2014-08-08 17:13   ` Vinod Koul

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.