* [PATCH 1/4] [media] ov7670: Include media/v4l2-image-sizes.h
@ 2014-08-09 5:58 Axel Lin
2014-08-09 5:59 ` [PATCH 2/4] [media] vs6624: " Axel Lin
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Axel Lin @ 2014-08-09 5:58 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Jonathan Corbet, linux-media
So we can remove the same defines in the driver code.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/media/i2c/ov7670.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c
index cdd7c1b..dd3db24 100644
--- a/drivers/media/i2c/ov7670.c
+++ b/drivers/media/i2c/ov7670.c
@@ -19,6 +19,7 @@
#include <media/v4l2-device.h>
#include <media/v4l2-ctrls.h>
#include <media/v4l2-mediabus.h>
+#include <media/v4l2-image-sizes.h>
#include <media/ov7670.h>
MODULE_AUTHOR("Jonathan Corbet <corbet@lwn.net>");
@@ -30,19 +31,6 @@ module_param(debug, bool, 0644);
MODULE_PARM_DESC(debug, "Debug level (0-1)");
/*
- * Basic window sizes. These probably belong somewhere more globally
- * useful.
- */
-#define VGA_WIDTH 640
-#define VGA_HEIGHT 480
-#define QVGA_WIDTH 320
-#define QVGA_HEIGHT 240
-#define CIF_WIDTH 352
-#define CIF_HEIGHT 288
-#define QCIF_WIDTH 176
-#define QCIF_HEIGHT 144
-
-/*
* The 7670 sits on i2c with ID 0x42
*/
#define OV7670_I2C_ADDR 0x42
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/4] [media] vs6624: Include media/v4l2-image-sizes.h
2014-08-09 5:58 [PATCH 1/4] [media] ov7670: Include media/v4l2-image-sizes.h Axel Lin
@ 2014-08-09 5:59 ` Axel Lin
2014-08-09 6:00 ` [PATCH 3/4] [media] soc_camera: mt9t112: " Axel Lin
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Axel Lin @ 2014-08-09 5:59 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Scott Jiang, adi-buildroot-devel, linux-media
So we can remove the same defines in the driver code.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/media/i2c/vs6624.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/media/i2c/vs6624.c b/drivers/media/i2c/vs6624.c
index 23f4f65..373f2df 100644
--- a/drivers/media/i2c/vs6624.c
+++ b/drivers/media/i2c/vs6624.c
@@ -30,22 +30,10 @@
#include <media/v4l2-ctrls.h>
#include <media/v4l2-device.h>
#include <media/v4l2-mediabus.h>
+#include <media/v4l2-image-sizes.h>
#include "vs6624_regs.h"
-#define VGA_WIDTH 640
-#define VGA_HEIGHT 480
-#define QVGA_WIDTH 320
-#define QVGA_HEIGHT 240
-#define QQVGA_WIDTH 160
-#define QQVGA_HEIGHT 120
-#define CIF_WIDTH 352
-#define CIF_HEIGHT 288
-#define QCIF_WIDTH 176
-#define QCIF_HEIGHT 144
-#define QQCIF_WIDTH 88
-#define QQCIF_HEIGHT 72
-
#define MAX_FRAME_RATE 30
struct vs6624 {
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/4] [media] soc_camera: mt9t112: Include media/v4l2-image-sizes.h
2014-08-09 5:58 [PATCH 1/4] [media] ov7670: Include media/v4l2-image-sizes.h Axel Lin
2014-08-09 5:59 ` [PATCH 2/4] [media] vs6624: " Axel Lin
@ 2014-08-09 6:00 ` Axel Lin
2014-08-09 6:01 ` [PATCH 4/4] [media] soc_camera: ov772x: " Axel Lin
2014-08-11 12:58 ` [PATCH 1/4] [media] ov7670: " Jonathan Corbet
3 siblings, 0 replies; 5+ messages in thread
From: Axel Lin @ 2014-08-09 6:00 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Guennadi Liakhovetski, Kuninori Morimoto, linux-media
So we can remove the same defines in the driver code.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/media/i2c/soc_camera/mt9t112.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/i2c/soc_camera/mt9t112.c b/drivers/media/i2c/soc_camera/mt9t112.c
index 46f431a..996d7b4 100644
--- a/drivers/media/i2c/soc_camera/mt9t112.c
+++ b/drivers/media/i2c/soc_camera/mt9t112.c
@@ -29,6 +29,7 @@
#include <media/soc_camera.h>
#include <media/v4l2-clk.h>
#include <media/v4l2-common.h>
+#include <media/v4l2-image-sizes.h>
/* you can check PLL/clock info */
/* #define EXT_CLOCK 24000000 */
@@ -42,9 +43,6 @@
#define MAX_WIDTH 2048
#define MAX_HEIGHT 1536
-#define VGA_WIDTH 640
-#define VGA_HEIGHT 480
-
/*
* macro of read/write
*/
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 4/4] [media] soc_camera: ov772x: Include media/v4l2-image-sizes.h
2014-08-09 5:58 [PATCH 1/4] [media] ov7670: Include media/v4l2-image-sizes.h Axel Lin
2014-08-09 5:59 ` [PATCH 2/4] [media] vs6624: " Axel Lin
2014-08-09 6:00 ` [PATCH 3/4] [media] soc_camera: mt9t112: " Axel Lin
@ 2014-08-09 6:01 ` Axel Lin
2014-08-11 12:58 ` [PATCH 1/4] [media] ov7670: " Jonathan Corbet
3 siblings, 0 replies; 5+ messages in thread
From: Axel Lin @ 2014-08-09 6:01 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Guennadi Liakhovetski, Kuninori Morimoto, linux-media
So we can remove the same defines in the driver code.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/media/i2c/soc_camera/ov772x.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/media/i2c/soc_camera/ov772x.c b/drivers/media/i2c/soc_camera/ov772x.c
index 7f2b3c8..970a04e 100644
--- a/drivers/media/i2c/soc_camera/ov772x.c
+++ b/drivers/media/i2c/soc_camera/ov772x.c
@@ -29,6 +29,7 @@
#include <media/v4l2-clk.h>
#include <media/v4l2-ctrls.h>
#include <media/v4l2-subdev.h>
+#include <media/v4l2-image-sizes.h>
/*
* register offset
@@ -360,10 +361,6 @@
#define SCAL0_ACTRL 0x08 /* Auto scaling factor control */
#define SCAL1_2_ACTRL 0x04 /* Auto scaling factor control */
-#define VGA_WIDTH 640
-#define VGA_HEIGHT 480
-#define QVGA_WIDTH 320
-#define QVGA_HEIGHT 240
#define OV772X_MAX_WIDTH VGA_WIDTH
#define OV772X_MAX_HEIGHT VGA_HEIGHT
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/4] [media] ov7670: Include media/v4l2-image-sizes.h
2014-08-09 5:58 [PATCH 1/4] [media] ov7670: Include media/v4l2-image-sizes.h Axel Lin
` (2 preceding siblings ...)
2014-08-09 6:01 ` [PATCH 4/4] [media] soc_camera: ov772x: " Axel Lin
@ 2014-08-11 12:58 ` Jonathan Corbet
3 siblings, 0 replies; 5+ messages in thread
From: Jonathan Corbet @ 2014-08-11 12:58 UTC (permalink / raw)
To: Axel Lin; +Cc: Mauro Carvalho Chehab, linux-media
On Sat, 09 Aug 2014 13:58:40 +0800
Axel Lin <axel.lin@ingics.com> wrote:
> So we can remove the same defines in the driver code.
I always wanted a file like that (but, obviously, was too lazy to actually
create it).
Acked-by: Jonathan Corbet <corbet@lwn.net>
Thanks,
jon
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-08-11 13:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-09 5:58 [PATCH 1/4] [media] ov7670: Include media/v4l2-image-sizes.h Axel Lin
2014-08-09 5:59 ` [PATCH 2/4] [media] vs6624: " Axel Lin
2014-08-09 6:00 ` [PATCH 3/4] [media] soc_camera: mt9t112: " Axel Lin
2014-08-09 6:01 ` [PATCH 4/4] [media] soc_camera: ov772x: " Axel Lin
2014-08-11 12:58 ` [PATCH 1/4] [media] ov7670: " Jonathan Corbet
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.