All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: soc_camera: soc_camera_platform.c: Fixed a Missing blank line coding style issue
@ 2014-08-09 16:40 Suman Kumar
  0 siblings, 0 replies; 6+ messages in thread
From: Suman Kumar @ 2014-08-09 16:40 UTC (permalink / raw)
  To: g.liakhovetski; +Cc: m.chehab, linux-media, linux-kernel, suman

    Fixes a coding style issue reported by checkpatch.pl

Signed-off-by: Suman Kumar <suman@inforcecomputing.com>
---
 drivers/media/platform/soc_camera/soc_camera_platform.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/platform/soc_camera/soc_camera_platform.c b/drivers/media/platform/soc_camera/soc_camera_platform.c
index ceaddfb..fe15a80 100644
--- a/drivers/media/platform/soc_camera/soc_camera_platform.c
+++ b/drivers/media/platform/soc_camera/soc_camera_platform.c
@@ -27,12 +27,14 @@ struct soc_camera_platform_priv {
 static struct soc_camera_platform_priv *get_priv(struct platform_device *pdev)
 {
 	struct v4l2_subdev *subdev = platform_get_drvdata(pdev);
+
 	return container_of(subdev, struct soc_camera_platform_priv, subdev);
 }
 
 static int soc_camera_platform_s_stream(struct v4l2_subdev *sd, int enable)
 {
 	struct soc_camera_platform_info *p = v4l2_get_subdevdata(sd);
+
 	return p->set_capture(p, enable);
 }
 
-- 
1.8.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] staging: soc_camera: soc_camera_platform.c: Fixed a Missing blank line coding style issue
  2014-08-09 17:36 ` Guennadi Liakhovetski
@ 2014-08-09 17:47   ` Hans Verkuil
  0 siblings, 0 replies; 6+ messages in thread
From: Hans Verkuil @ 2014-08-09 17:47 UTC (permalink / raw)
  To: Guennadi Liakhovetski, Suman Kumar
  Cc: m.chehab, linux-media, linux-kernel, kernel-janitors

On 08/09/2014 07:36 PM, Guennadi Liakhovetski wrote:
> Hi Suman,
> 
> On Sat, 9 Aug 2014, Suman Kumar wrote:
> 
>>     Fixes a coding style issue reported by checkpatch.pl
> 
> Thanks for your patch. To my taste checkpatch.pl has unfortunately become 
> too noisy with meaningless / unimportant warnings like this one. Is this 
> in CodingStyle? If not, my intention is to drop this.

I don't see it being mentioned explicitly in the CodingStyle, but the coding
style follows K&R, and they put an empty line between local variables and the
start of the code. And I like it that way as well, it makes it easier to review.

If you don't want to be bothered by such patches, just delegate them to me in
patchwork, I don't mind.

Regards,

	Hans

> However, Mauro may 
> override by either taking this himself or asking me to apply this.
> 
> Thanks
> Guennadi
> 
>>
>> Signed-off-by: Suman Kumar <suman@inforcecomputing.com>
>> ---
>>  drivers/media/platform/soc_camera/soc_camera_platform.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/media/platform/soc_camera/soc_camera_platform.c b/drivers/media/platform/soc_camera/soc_camera_platform.c
>> index ceaddfb..fe15a80 100644
>> --- a/drivers/media/platform/soc_camera/soc_camera_platform.c
>> +++ b/drivers/media/platform/soc_camera/soc_camera_platform.c
>> @@ -27,12 +27,14 @@ struct soc_camera_platform_priv {
>>  static struct soc_camera_platform_priv *get_priv(struct platform_device *pdev)
>>  {
>>  	struct v4l2_subdev *subdev = platform_get_drvdata(pdev);
>> +
>>  	return container_of(subdev, struct soc_camera_platform_priv, subdev);
>>  }
>>  
>>  static int soc_camera_platform_s_stream(struct v4l2_subdev *sd, int enable)
>>  {
>>  	struct soc_camera_platform_info *p = v4l2_get_subdevdata(sd);
>> +
>>  	return p->set_capture(p, enable);
>>  }
>>  
>> -- 
>> 1.8.2
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] staging: soc_camera: soc_camera_platform.c: Fixed a Missing blank line coding style issue
  2014-08-09 17:22 ` Suman Kumar
  (?)
@ 2014-08-09 17:36 ` Guennadi Liakhovetski
  2014-08-09 17:47   ` Hans Verkuil
  -1 siblings, 1 reply; 6+ messages in thread
From: Guennadi Liakhovetski @ 2014-08-09 17:36 UTC (permalink / raw)
  To: Suman Kumar; +Cc: m.chehab, linux-media, linux-kernel, kernel-janitors

Hi Suman,

On Sat, 9 Aug 2014, Suman Kumar wrote:

>     Fixes a coding style issue reported by checkpatch.pl

Thanks for your patch. To my taste checkpatch.pl has unfortunately become 
too noisy with meaningless / unimportant warnings like this one. Is this 
in CodingStyle? If not, my intention is to drop this. However, Mauro may 
override by either taking this himself or asking me to apply this.

Thanks
Guennadi

> 
> Signed-off-by: Suman Kumar <suman@inforcecomputing.com>
> ---
>  drivers/media/platform/soc_camera/soc_camera_platform.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/media/platform/soc_camera/soc_camera_platform.c b/drivers/media/platform/soc_camera/soc_camera_platform.c
> index ceaddfb..fe15a80 100644
> --- a/drivers/media/platform/soc_camera/soc_camera_platform.c
> +++ b/drivers/media/platform/soc_camera/soc_camera_platform.c
> @@ -27,12 +27,14 @@ struct soc_camera_platform_priv {
>  static struct soc_camera_platform_priv *get_priv(struct platform_device *pdev)
>  {
>  	struct v4l2_subdev *subdev = platform_get_drvdata(pdev);
> +
>  	return container_of(subdev, struct soc_camera_platform_priv, subdev);
>  }
>  
>  static int soc_camera_platform_s_stream(struct v4l2_subdev *sd, int enable)
>  {
>  	struct soc_camera_platform_info *p = v4l2_get_subdevdata(sd);
> +
>  	return p->set_capture(p, enable);
>  }
>  
> -- 
> 1.8.2
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] staging: soc_camera: soc_camera_platform.c: Fixed a Missing blank line coding style issue
@ 2014-08-09 17:22 ` Suman Kumar
  0 siblings, 0 replies; 6+ messages in thread
From: Suman Kumar @ 2014-08-09 17:34 UTC (permalink / raw)
  To: g.liakhovetski
  Cc: m.chehab, linux-media, linux-kernel, suman, kernel-janitors

    Fixes a coding style issue reported by checkpatch.pl

Signed-off-by: Suman Kumar <suman@inforcecomputing.com>
---
 drivers/media/platform/soc_camera/soc_camera_platform.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/platform/soc_camera/soc_camera_platform.c b/drivers/media/platform/soc_camera/soc_camera_platform.c
index ceaddfb..fe15a80 100644
--- a/drivers/media/platform/soc_camera/soc_camera_platform.c
+++ b/drivers/media/platform/soc_camera/soc_camera_platform.c
@@ -27,12 +27,14 @@ struct soc_camera_platform_priv {
 static struct soc_camera_platform_priv *get_priv(struct platform_device *pdev)
 {
 	struct v4l2_subdev *subdev = platform_get_drvdata(pdev);
+
 	return container_of(subdev, struct soc_camera_platform_priv, subdev);
 }
 
 static int soc_camera_platform_s_stream(struct v4l2_subdev *sd, int enable)
 {
 	struct soc_camera_platform_info *p = v4l2_get_subdevdata(sd);
+
 	return p->set_capture(p, enable);
 }
 
-- 
1.8.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] staging: soc_camera: soc_camera_platform.c: Fixed a Missing blank line coding style issue
@ 2014-08-09 17:22 ` Suman Kumar
  0 siblings, 0 replies; 6+ messages in thread
From: Suman Kumar @ 2014-08-09 17:22 UTC (permalink / raw)
  To: g.liakhovetski
  Cc: m.chehab, linux-media, linux-kernel, suman, kernel-janitors

    Fixes a coding style issue reported by checkpatch.pl

Signed-off-by: Suman Kumar <suman@inforcecomputing.com>
---
 drivers/media/platform/soc_camera/soc_camera_platform.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/platform/soc_camera/soc_camera_platform.c b/drivers/media/platform/soc_camera/soc_camera_platform.c
index ceaddfb..fe15a80 100644
--- a/drivers/media/platform/soc_camera/soc_camera_platform.c
+++ b/drivers/media/platform/soc_camera/soc_camera_platform.c
@@ -27,12 +27,14 @@ struct soc_camera_platform_priv {
 static struct soc_camera_platform_priv *get_priv(struct platform_device *pdev)
 {
 	struct v4l2_subdev *subdev = platform_get_drvdata(pdev);
+
 	return container_of(subdev, struct soc_camera_platform_priv, subdev);
 }
 
 static int soc_camera_platform_s_stream(struct v4l2_subdev *sd, int enable)
 {
 	struct soc_camera_platform_info *p = v4l2_get_subdevdata(sd);
+
 	return p->set_capture(p, enable);
 }
 
-- 
1.8.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] staging: soc_camera: soc_camera_platform.c: Fixed a Missing blank line coding style issue
@ 2014-08-09 17:10 Suman Kumar
  0 siblings, 0 replies; 6+ messages in thread
From: Suman Kumar @ 2014-08-09 17:10 UTC (permalink / raw)
  To: g.liakhovetski; +Cc: m.chehab, linux-media, linux-kernel, suman

    Fixes a coding style issue reported by checkpatch.pl

Signed-off-by: Suman Kumar <suman@inforcecomputing.com>
---
 drivers/media/platform/soc_camera/soc_camera_platform.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/platform/soc_camera/soc_camera_platform.c b/drivers/media/platform/soc_camera/soc_camera_platform.c
index ceaddfb..fe15a80 100644
--- a/drivers/media/platform/soc_camera/soc_camera_platform.c
+++ b/drivers/media/platform/soc_camera/soc_camera_platform.c
@@ -27,12 +27,14 @@ struct soc_camera_platform_priv {
 static struct soc_camera_platform_priv *get_priv(struct platform_device *pdev)
 {
 	struct v4l2_subdev *subdev = platform_get_drvdata(pdev);
+
 	return container_of(subdev, struct soc_camera_platform_priv, subdev);
 }
 
 static int soc_camera_platform_s_stream(struct v4l2_subdev *sd, int enable)
 {
 	struct soc_camera_platform_info *p = v4l2_get_subdevdata(sd);
+
 	return p->set_capture(p, enable);
 }
 
-- 
1.8.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-08-09 17:55 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-09 16:40 [PATCH] staging: soc_camera: soc_camera_platform.c: Fixed a Missing blank line coding style issue Suman Kumar
2014-08-09 17:10 Suman Kumar
2014-08-09 17:34 Suman Kumar
2014-08-09 17:22 ` Suman Kumar
2014-08-09 17:36 ` Guennadi Liakhovetski
2014-08-09 17:47   ` Hans Verkuil

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.