All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] spi: Fix the spi task hangs waiting dma_rx
@ 2014-08-09 21:06 Jorge Ventura
       [not found] ` <1407618418-5427-1-git-send-email-jorge.araujo.ventura-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Jorge Ventura @ 2014-08-09 21:06 UTC (permalink / raw)
  To: Mark Brown, linux-spi-u79uwXL29TY76Z2rM5mHXA; +Cc: Jorge A. Ventura

From: "Jorge A. Ventura" <jorge.araujo.ventura-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

The spi hangs waiting the completion of omap2_mcspi_rx_callback.

Signed-off-by: Jorge A. Ventura <jorge.araujo.ventura-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 drivers/spi/spi-omap2-mcspi.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
index 68441fa..352eed7 100644
--- a/drivers/spi/spi-omap2-mcspi.c
+++ b/drivers/spi/spi-omap2-mcspi.c
@@ -329,7 +329,8 @@ static void omap2_mcspi_set_fifo(const struct spi_device *spi,
 disable_fifo:
 	if (t->rx_buf != NULL)
 		chconf &= ~OMAP2_MCSPI_CHCONF_FFER;
-	else
+
+	if (t->tx_buf != NULL)
 		chconf &= ~OMAP2_MCSPI_CHCONF_FFET;
 
 	mcspi_write_chconf0(spi, chconf);
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] spi: Fix the spi task hangs waiting dma_rx
       [not found] ` <1407618418-5427-1-git-send-email-jorge.araujo.ventura-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2014-08-11 18:56   ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-08-11 18:56 UTC (permalink / raw)
  To: Jorge Ventura; +Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

On Sat, Aug 09, 2014 at 04:06:58PM -0500, Jorge Ventura wrote:
> From: "Jorge A. Ventura" <jorge.araujo.ventura-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 
> The spi hangs waiting the completion of omap2_mcspi_rx_callback.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-08-11 18:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-09 21:06 [PATCH 1/1] spi: Fix the spi task hangs waiting dma_rx Jorge Ventura
     [not found] ` <1407618418-5427-1-git-send-email-jorge.araujo.ventura-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-11 18:56   ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.