[Buildroot] [PATCH 1/1] ipmitool: new package

[Buildroot] [PATCH 1/1] ipmitool: new package

[Floris Bos]

Adds ipmitool, a command-line interface to IPMI-enabled devices.

Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>
---
 package/Config.in            |  1 +
 package/ipmitool/Config.in   | 16 ++++++++++++++++
 package/ipmitool/ipmitool.mk | 25 +++++++++++++++++++++++++
 3 files changed, 42 insertions(+)
 create mode 100644 package/ipmitool/Config.in
 create mode 100644 package/ipmitool/ipmitool.mk

diff --git a/package/Config.in b/package/Config.in
index 7bb8fc0..4982396 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -984,6 +984,7 @@ endif
 	source "package/igmpproxy/Config.in"
 	source "package/inadyn/Config.in"
 	source "package/iperf/Config.in"
+	source "package/ipmitool/Config.in"
 	source "package/iproute2/Config.in"
 	source "package/ipsec-tools/Config.in"
 	source "package/ipset/Config.in"
diff --git a/package/ipmitool/Config.in b/package/ipmitool/Config.in
new file mode 100644
index 0000000..febe9f2
--- /dev/null
+++ b/package/ipmitool/Config.in
@@ -0,0 +1,16 @@
+config BR2_PACKAGE_IPMITOOL
+	bool "ipmitool"
+	select BR2_PACKAGE_OPENSSL
+	help
+	  IPMItool provides a simple command-line interface to IPMI-enabled devices.
+
+	  http://sourceforge.net/projects/ipmitool/
+
+if BR2_PACKAGE_IPMITOOL
+
+config BR2_PACKAGE_IPMITOOL_IPMIEVD
+	bool "ipmievd"
+	help
+	  IPMI event daemon for sending events to syslog
+
+endif
diff --git a/package/ipmitool/ipmitool.mk b/package/ipmitool/ipmitool.mk
new file mode 100644
index 0000000..2d96549
--- /dev/null
+++ b/package/ipmitool/ipmitool.mk
@@ -0,0 +1,25 @@
+################################################################################
+#
+# ipmitool
+#
+################################################################################
+
+IPMITOOL_VERSION = 1.8.14
+IPMITOOL_SOURCE = ipmitool-$(IPMITOOL_VERSION).tar.bz2
+IPMITOOL_SITE = http://downloads.sourceforge.net/project/ipmitool/ipmitool/$(IPMITOOL_VERSION)
+IPMITOOL_LICENSE = BSD-3c
+IPMITOOL_LICENSE_FILES = COPYING
+IPMITOOL_DEPENDENCIES = openssl
+
+ifeq ($(BR2_PACKAGE_READLINE),y)
+IPMITOOL_DEPENDENCIES += readline
+endif
+
+ifneq ($(BR2_PACKAGE_IPMITOOL_IPMIEVD),y)
+define IPMITOOL_REMOVE_IPMIEVD
+	$(RM) -f $(TARGET_DIR)/usr/sbin/ipmievd
+endef
+IPMITOOL_POST_INSTALL_TARGET_HOOKS += IPMITOOL_REMOVE_IPMIEVD
+endif
+
+$(eval $(autotools-package))
-- 
1.8.3.2

[Buildroot] [PATCH 1/1] ipmitool: new package

[David Bachelart]

Hi,

2014-09-11 13:53 GMT+02:00 Floris Bos <bos@je-eigen-domein.nl>:

> First of all note that I also submitted an ipmitool patch last month:
> http://patchwork.ozlabs.org/patch/378793/
> I don't care which one gets merged (anything is better than having to
> maintain local packages), but you might want to take a look at it.


Sorry for that, I usually look in pending patches, but this time, I forgot
to do it.

Your patch is more mature than mine, so I suggest to forget this one.

Thanks,

David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140911/cea33571/attachment.html>

[Buildroot] [PATCH 1/1] ipmitool: new package

[Floris Bos]

Hi,

First of all note that I also submitted an ipmitool patch last month: 
http://patchwork.ozlabs.org/patch/378793/
I don't care which one gets merged (anything is better than having to 
maintain local packages), but you might want to take a look at it.

On 09/11/2014 09:44 AM, David Bachelart wrote:
> Signed-off-by: David Bachelart <david.bachelart@bbright.com>
> ---
>   package/Config.in            |    1 +
>   package/ipmitool/Config.in   |    8 ++++++++
>   package/ipmitool/ipmiutil.mk |   16 ++++++++++++++++
>   3 files changed, 25 insertions(+)
>   create mode 100644 package/ipmitool/Config.in
>   create mode 100644 package/ipmitool/ipmiutil.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 883dd66..302a638 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -321,6 +321,7 @@ endif
>   	source "package/input-tools/Config.in"
>   	source "package/intel-microcode/Config.in"
>   	source "package/iostat/Config.in"
> +	source "package/ipmitool/Config.in"
>   	source "package/irda-utils/Config.in"
>   	source "package/iucode-tool/Config.in"
>   	source "package/kbd/Config.in"
> diff --git a/package/ipmitool/Config.in b/package/ipmitool/Config.in
> new file mode 100644
> index 0000000..c456a61
> --- /dev/null
> +++ b/package/ipmitool/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_IPMITOOL
> +  bool "ipmitool"
> +  help
> +    IPMItool provides a simple command-line interface to IPMI-enabled devices
> +    through an IPMIv1.5 or IPMIv2.0 LAN interface or Linux/Solaris kernel
> +    driver.
> +
> +    http://ipmitool.sourceforge.net/
> diff --git a/package/ipmitool/ipmiutil.mk b/package/ipmitool/ipmiutil.mk
> new file mode 100644
> index 0000000..2b179b0
> --- /dev/null
> +++ b/package/ipmitool/ipmiutil.mk
> @@ -0,0 +1,16 @@
> +################################################################################
> +#
> +# ipmitool
> +#
> +################################################################################
> +
> +IPMITOOL_VERSION = 1.8.14
> +IPMITOOL_SITE = http://sourceforge.net/projects/ipmitool/files/ipmitool/$(IPMITOOL_VERSION)
> +IPMITOOL_SOURCE = ipmitool-$(IPMITOOL_VERSION).tar.bz2
> +
> +IPMITOOL_LICENSE = GPL2+
> +IPMITOOL_LICENSE_FILES = COPYING
> +
> +IPMITOOL_CONF_OPTS = --enable-ipmishell

Note that ipmitool depends on openssl for crypto functions, and if you 
really want to have the interactive ipmishell functionality (instead of 
just calling ipmitool as command line utility) you also needs readline.

License is BSD-3c

Also note that ipmitool installs both ipmitool and ipmievd by default.
Most people only use ipmitool though, so have an option to remove 
ipmievd in my package.
Might be something you might also consider.


-- 
Yours sincerely,

Floris Bos

[Buildroot] [PATCH 1/1] ipmitool: new package

[Thomas Petazzoni]

Dear David Bachelart,

Please try to keep as quotation the text your are replying to, thanks.

On Thu, 11 Sep 2014 12:13:22 +0200, David Bachelart wrote:

> I submitted a new patch, setting the license field to MIT.

Great, thanks.

> The package builds fine with the last two configurations, but does not
> build using the first one. The link step breaks, looking for a _fork
> symbol. Since it seems related to the MMU, the second configuration did not
> make sense anymore.

Hum, I'm confused. Here is the list of configurations I provided:

 * http://autobuild.buildroot.org/toolchains/configs/br-arm-basic.config
 * http://autobuild.buildroot.org/toolchains/configs/bfin-linux-uclibc.config
 * http://autobuild.buildroot.org/toolchains/configs/bfin-uclinux.config 
 * http://autobuild.buildroot.org/toolchains/configs/br-arm-full-nothread.config

The first and fourth configurations are MMU-enabled configurations, so
clearly when you say the first configuration doesn't build due to
missing _fork, it's not possible.

Maybe you want to say that the first and fourth configurations built
fine, but not the second and third? If that's the case, then your new
patch that adds "depends on BR2_USE_MMU" looks good.

Thanks for the additional testing!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] ipmitool: new package

[David Bachelart]

Hi Thomas,

I submitted a new patch, setting the license field to MIT.

The package builds fine with the last two configurations, but does not
build using the first one. The link step breaks, looking for a _fork
symbol. Since it seems related to the MMU, the second configuration did not
make sense anymore.

David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140911/2010226b/attachment.html>

[Buildroot] [PATCH 1/1] ipmitool: new package

[Thomas Petazzoni]

Dear David Bachelart,

On Thu, 11 Sep 2014 09:44:25 +0200, David Bachelart wrote:

> diff --git a/package/ipmitool/Config.in b/package/ipmitool/Config.in
> new file mode 100644
> index 0000000..c456a61
> --- /dev/null
> +++ b/package/ipmitool/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_IPMITOOL
> +  bool "ipmitool"
> +  help

Indentation should be one tab here.

> +    IPMItool provides a simple command-line interface to IPMI-enabled devices
> +    through an IPMIv1.5 or IPMIv2.0 LAN interface or Linux/Solaris kernel 
> +    driver.
> +
> +    http://ipmitool.sourceforge.net/

And one tab + two spaces for the help text. See
http://buildroot.org/downloads/manual/manual.html#writing-rules-config-in.


> +IPMITOOL_VERSION = 1.8.14
> +IPMITOOL_SITE = http://sourceforge.net/projects/ipmitool/files/ipmitool/$(IPMITOOL_VERSION)
> +IPMITOOL_SOURCE = ipmitool-$(IPMITOOL_VERSION).tar.bz2
> +
> +IPMITOOL_LICENSE = GPL2+

Did you look into the COPYING file? It's clearly not a GPL license. It
looks more like a MIT license, but not sure.

> +IPMITOOL_LICENSE_FILES = COPYING
> +
> +IPMITOOL_CONF_OPTS = --enable-ipmishell
> +
> +$(eval $(autotools-package))

Also, could you quickly check if your package builds fine with the
following toolchain configurations:

 * http://autobuild.buildroot.org/toolchains/configs/br-arm-basic.config
 * http://autobuild.buildroot.org/toolchains/configs/bfin-linux-uclibc.config
 * http://autobuild.buildroot.org/toolchains/configs/bfin-uclinux.config 
 * http://autobuild.buildroot.org/toolchains/configs/br-arm-full-nothread.config

The first will check a basic uClibc configuration, to ensure your
package does not depend on features like wide-char, RPC, locales, etc.

The second will check if your package can build on noMMU platforms.

The third will check if your package can build on platforms that don't
support shared libraries.

The fourth will check if your package can build on platforms built
without thread support.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] ipmitool: new package

[David Bachelart]

Signed-off-by: David Bachelart <david.bachelart@bbright.com>
---
 package/Config.in            |    1 +
 package/ipmitool/Config.in   |    8 ++++++++
 package/ipmitool/ipmiutil.mk |   16 ++++++++++++++++
 3 files changed, 25 insertions(+)
 create mode 100644 package/ipmitool/Config.in
 create mode 100644 package/ipmitool/ipmiutil.mk

diff --git a/package/Config.in b/package/Config.in
index 883dd66..302a638 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -321,6 +321,7 @@ endif
 	source "package/input-tools/Config.in"
 	source "package/intel-microcode/Config.in"
 	source "package/iostat/Config.in"
+	source "package/ipmitool/Config.in"
 	source "package/irda-utils/Config.in"
 	source "package/iucode-tool/Config.in"
 	source "package/kbd/Config.in"
diff --git a/package/ipmitool/Config.in b/package/ipmitool/Config.in
new file mode 100644
index 0000000..c456a61
--- /dev/null
+++ b/package/ipmitool/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_IPMITOOL
+  bool "ipmitool"
+  help
+    IPMItool provides a simple command-line interface to IPMI-enabled devices
+    through an IPMIv1.5 or IPMIv2.0 LAN interface or Linux/Solaris kernel 
+    driver.
+
+    http://ipmitool.sourceforge.net/
diff --git a/package/ipmitool/ipmiutil.mk b/package/ipmitool/ipmiutil.mk
new file mode 100644
index 0000000..2b179b0
--- /dev/null
+++ b/package/ipmitool/ipmiutil.mk
@@ -0,0 +1,16 @@
+################################################################################
+#
+# ipmitool
+#
+################################################################################
+
+IPMITOOL_VERSION = 1.8.14
+IPMITOOL_SITE = http://sourceforge.net/projects/ipmitool/files/ipmitool/$(IPMITOOL_VERSION)
+IPMITOOL_SOURCE = ipmitool-$(IPMITOOL_VERSION).tar.bz2
+
+IPMITOOL_LICENSE = GPL2+
+IPMITOOL_LICENSE_FILES = COPYING
+
+IPMITOOL_CONF_OPTS = --enable-ipmishell
+
+$(eval $(autotools-package))
-- 
1.7.10.4