* [PATCH] crypto: qat - Use pci_enable_msix_exact() instead of pci_enable_msix()
@ 2014-08-19 7:32 Alexander Gordeev
2014-08-29 9:10 ` Alexander Gordeev
2014-08-29 13:48 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Gordeev @ 2014-08-19 7:32 UTC (permalink / raw)
To: linux-kernel
Cc: Alexander Gordeev, Tadeusz Struk, Herbert Xu, David S. Miller,
qat-linux, linux-crypto, linux-pci
As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range() or pci_enable_msi_exact()
and pci_enable_msix_range() or pci_enable_msix_exact()
interfaces.
Cc: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: qat-linux@intel.com
Cc: linux-crypto@vger.kernel.org
Cc: linux-pci@vger.kernel.org
Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
---
drivers/crypto/qat/qat_dh895xcc/adf_isr.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/qat/qat_dh895xcc/adf_isr.c b/drivers/crypto/qat/qat_dh895xcc/adf_isr.c
index d4172de..1082e3b 100644
--- a/drivers/crypto/qat/qat_dh895xcc/adf_isr.c
+++ b/drivers/crypto/qat/qat_dh895xcc/adf_isr.c
@@ -70,9 +70,9 @@ static int adf_enable_msix(struct adf_accel_dev *accel_dev)
for (i = 0; i < msix_num_entries; i++)
pci_dev_info->msix_entries.entries[i].entry = i;
- if (pci_enable_msix(pci_dev_info->pci_dev,
- pci_dev_info->msix_entries.entries,
- msix_num_entries)) {
+ if (pci_enable_msix_exact(pci_dev_info->pci_dev,
+ pci_dev_info->msix_entries.entries,
+ msix_num_entries)) {
pr_err("QAT: Failed to enable MSIX IRQ\n");
return -EFAULT;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: qat - Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-08-19 7:32 [PATCH] crypto: qat - Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
@ 2014-08-29 9:10 ` Alexander Gordeev
2014-08-29 13:48 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Gordeev @ 2014-08-29 9:10 UTC (permalink / raw)
To: linux-kernel
Cc: Tadeusz Struk, Herbert Xu, David S. Miller, qat-linux,
linux-crypto, linux-pci
On Tue, Aug 19, 2014 at 09:32:04AM +0200, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
Hello Gentleman,
This trivial patch blocks phasing out of deprecated
pci_enable_msix() function. Could someone review and
accept it, please?
Thanks!
> Cc: Tadeusz Struk <tadeusz.struk@intel.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: qat-linux@intel.com
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-pci@vger.kernel.org
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> ---
> drivers/crypto/qat/qat_dh895xcc/adf_isr.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/qat/qat_dh895xcc/adf_isr.c b/drivers/crypto/qat/qat_dh895xcc/adf_isr.c
> index d4172de..1082e3b 100644
> --- a/drivers/crypto/qat/qat_dh895xcc/adf_isr.c
> +++ b/drivers/crypto/qat/qat_dh895xcc/adf_isr.c
> @@ -70,9 +70,9 @@ static int adf_enable_msix(struct adf_accel_dev *accel_dev)
> for (i = 0; i < msix_num_entries; i++)
> pci_dev_info->msix_entries.entries[i].entry = i;
>
> - if (pci_enable_msix(pci_dev_info->pci_dev,
> - pci_dev_info->msix_entries.entries,
> - msix_num_entries)) {
> + if (pci_enable_msix_exact(pci_dev_info->pci_dev,
> + pci_dev_info->msix_entries.entries,
> + msix_num_entries)) {
> pr_err("QAT: Failed to enable MSIX IRQ\n");
> return -EFAULT;
> }
> --
> 1.9.3
>
--
Regards,
Alexander Gordeev
agordeev@redhat.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: qat - Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-08-19 7:32 [PATCH] crypto: qat - Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-08-29 9:10 ` Alexander Gordeev
@ 2014-08-29 13:48 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2014-08-29 13:48 UTC (permalink / raw)
To: Alexander Gordeev
Cc: linux-kernel, Tadeusz Struk, David S. Miller, qat-linux,
linux-crypto, linux-pci
On Tue, Aug 19, 2014 at 09:32:04AM +0200, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
>
> Cc: Tadeusz Struk <tadeusz.struk@intel.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: qat-linux@intel.com
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-pci@vger.kernel.org
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Applied.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-29 13:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-19 7:32 [PATCH] crypto: qat - Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-08-29 9:10 ` Alexander Gordeev
2014-08-29 13:48 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.