* [PATCH v1] Arm64: Remove unnecessary keyword 'extern' from proc-fns.h
@ 2014-08-19 8:58 Arun Chandran
2014-08-19 19:42 ` Geoff Levand
0 siblings, 1 reply; 3+ messages in thread
From: Arun Chandran @ 2014-08-19 8:58 UTC (permalink / raw)
To: linux-arm-kernel
As the functions have external linkage by default, the extern
keyword is irrelevant here.
Reported-by: Geoff Levand <geoff@infradead.org>
Signed-off-by: Arun Chandran <achandran@mvista.com>
---
arch/arm64/include/asm/proc-fns.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/include/asm/proc-fns.h b/arch/arm64/include/asm/proc-fns.h
index 9a8fd84..edfd79d 100644
--- a/arch/arm64/include/asm/proc-fns.h
+++ b/arch/arm64/include/asm/proc-fns.h
@@ -28,14 +28,14 @@
struct mm_struct;
struct cpu_suspend_ctx;
-extern void cpu_cache_off(void);
-extern void cpu_do_idle(void);
-extern void cpu_do_switch_mm(unsigned long pgd_phys, struct mm_struct *mm);
-extern void cpu_reset(unsigned long addr) __attribute__((noreturn));
+void cpu_cache_off(void);
+void cpu_do_idle(void);
+void cpu_do_switch_mm(unsigned long pgd_phys, struct mm_struct *mm);
+void cpu_reset(unsigned long addr) __attribute__((noreturn));
void cpu_soft_restart(phys_addr_t cpu_reset,
unsigned long addr) __attribute__((noreturn));
-extern void cpu_do_suspend(struct cpu_suspend_ctx *ptr);
-extern u64 cpu_do_resume(phys_addr_t ptr, u64 idmap_ttbr);
+void cpu_do_suspend(struct cpu_suspend_ctx *ptr);
+u64 cpu_do_resume(phys_addr_t ptr, u64 idmap_ttbr);
#include <asm/memory.h>
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v1] Arm64: Remove unnecessary keyword 'extern' from proc-fns.h
2014-08-19 8:58 [PATCH v1] Arm64: Remove unnecessary keyword 'extern' from proc-fns.h Arun Chandran
@ 2014-08-19 19:42 ` Geoff Levand
2014-08-19 20:29 ` Will Deacon
0 siblings, 1 reply; 3+ messages in thread
From: Geoff Levand @ 2014-08-19 19:42 UTC (permalink / raw)
To: linux-arm-kernel
Hi Arun,
On Tue, 2014-08-19 at 14:28 +0530, Arun Chandran wrote:
> As the functions have external linkage by default, the extern
> keyword is irrelevant here.
extern is used to say that the storage of a variable is done
somewhere else. It marks a statement as a declaration when
there is ambiguity about if the statement is a definition or
declaration. Since function prototypes are not definitions,
extern doesn't have any effect on them. It is not really
related to linkage or scope.
-Geoff
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v1] Arm64: Remove unnecessary keyword 'extern' from proc-fns.h
2014-08-19 19:42 ` Geoff Levand
@ 2014-08-19 20:29 ` Will Deacon
0 siblings, 0 replies; 3+ messages in thread
From: Will Deacon @ 2014-08-19 20:29 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Aug 19, 2014 at 08:42:51PM +0100, Geoff Levand wrote:
> On Tue, 2014-08-19 at 14:28 +0530, Arun Chandran wrote:
> > As the functions have external linkage by default, the extern
> > keyword is irrelevant here.
>
> extern is used to say that the storage of a variable is done
> somewhere else. It marks a statement as a declaration when
> there is ambiguity about if the statement is a definition or
> declaration. Since function prototypes are not definitions,
> extern doesn't have any effect on them. It is not really
> related to linkage or scope.
Regardless, this patch doesn't apply.
Will
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-19 20:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-19 8:58 [PATCH v1] Arm64: Remove unnecessary keyword 'extern' from proc-fns.h Arun Chandran
2014-08-19 19:42 ` Geoff Levand
2014-08-19 20:29 ` Will Deacon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.