From: Javier Martinez Canillas <javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> To: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Cc: "Wolfram Sang" <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>, "Dmitry Torokhov" <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "Doug Anderson" <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, "Simon Glass" <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, "Bill Richardson" <wfrichar-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, "Andrew Bresticker" <abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, "Derek Basehore" <dbasehore-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, "Todd Broch" <tbroch-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, "Olof Johansson" <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>, "Andreas Färber" <afaerber-l3A5Bk7waGM@public.gmane.org>, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Javier Martinez Canillas" <javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> Subject: [RESEND PATCH 2/7] i2c: i2c-cros-ec-tunnel: Set retries to 3 Date: Wed, 20 Aug 2014 14:13:27 +0200 [thread overview] Message-ID: <1408536812-7836-3-git-send-email-javier.martinez@collabora.co.uk> (raw) In-Reply-To: <1408536812-7836-1-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> From: Derek Basehore <dbasehore-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Since the i2c bus can get wedged on the EC sometimes, set the number of retries to 3. Since we un-wedge the bus immediately after the wedge happens, this is the correct fix since only one transfer will fail. Signed-off-by: Derek Basehore <dbasehore-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Reviewed-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Acked-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> Signed-off-by: Javier Martinez Canillas <javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> --- drivers/i2c/busses/i2c-cros-ec-tunnel.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/i2c/busses/i2c-cros-ec-tunnel.c b/drivers/i2c/busses/i2c-cros-ec-tunnel.c index 05e033c..a4411da 100644 --- a/drivers/i2c/busses/i2c-cros-ec-tunnel.c +++ b/drivers/i2c/busses/i2c-cros-ec-tunnel.c @@ -16,6 +16,8 @@ #include <linux/platform_device.h> #include <linux/slab.h> +#define I2C_MAX_RETRIES 3 + /** * struct ec_i2c_device - Driver data for I2C tunnel * @@ -290,6 +292,7 @@ static int ec_i2c_probe(struct platform_device *pdev) bus->adap.algo_data = bus; bus->adap.dev.parent = &pdev->dev; bus->adap.dev.of_node = np; + bus->adap.retries = I2C_MAX_RETRIES; err = i2c_add_adapter(&bus->adap); if (err) { -- 2.0.1
next prev parent reply other threads:[~2014-08-20 12:13 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-20 12:13 [RESEND PATCH 0/7] Second batch of cleanups for cros_ec Javier Martinez Canillas 2014-08-20 12:13 ` [RESEND PATCH 1/7] mfd: cros_ec: Delay for 50ms when we see EC_CMD_REBOOT_EC Javier Martinez Canillas 2014-08-21 13:37 ` Lee Jones 2014-08-21 13:49 ` Javier Martinez Canillas [not found] ` <1408536812-7836-1-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> 2014-08-20 12:13 ` Javier Martinez Canillas [this message] 2014-08-20 12:13 ` [RESEND PATCH 3/7] mfd: cros_ec: stop calling ->cmd_xfer() directly Javier Martinez Canillas 2014-08-20 22:33 ` Doug Anderson 2014-08-21 14:08 ` Lee Jones 2014-08-20 12:13 ` [RESEND PATCH 6/7] mfd: cros_ec: Instantiate sub-devices from device tree Javier Martinez Canillas [not found] ` <1408536812-7836-7-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> 2014-08-21 14:25 ` Lee Jones 2014-08-22 11:27 ` Javier Martinez Canillas 2014-08-20 12:13 ` [RESEND PATCH 7/7] Input: cros_ec_keyb: Optimize ghosting algorithm Javier Martinez Canillas 2014-08-20 12:13 ` [RESEND PATCH 4/7] mfd: cros_ec: move locking into cros_ec_cmd_xfer Javier Martinez Canillas 2014-08-20 22:36 ` Doug Anderson 2014-08-21 10:24 ` Javier Martinez Canillas 2014-08-21 14:09 ` Lee Jones 2014-08-20 12:13 ` [RESEND PATCH 5/7] mfd: cros_ec: wait for completion of commands that return IN_PROGRESS Javier Martinez Canillas [not found] ` <1408536812-7836-6-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> 2014-08-21 14:21 ` Lee Jones 2014-08-22 11:24 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1408536812-7836-3-git-send-email-javier.martinez@collabora.co.uk \ --to=javier.martinez-zgy8ohtn/8ppycu2f3hruq@public.gmane.org \ --cc=abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=afaerber-l3A5Bk7waGM@public.gmane.org \ --cc=dbasehore-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \ --cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=tbroch-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=wfrichar-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \ --subject='Re: [RESEND PATCH 2/7] i2c: i2c-cros-ec-tunnel: Set retries to 3' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.