* [PATCH] staging: android: fix style issue
@ 2014-08-20 14:13 Purnendu Kapadia
2014-08-20 15:04 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Purnendu Kapadia @ 2014-08-20 14:13 UTC (permalink / raw)
To: konkers; +Cc: gregkh, devel, linux-kernel, pro8linux
checkpatch fix. add a line before the switch statement
Signed-off-by: Purnendu Kapadia <pro8linux@gmail.com>
---
drivers/staging/android/sync.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
index e7b2e02..0d37495 100644
--- a/drivers/staging/android/sync.c
+++ b/drivers/staging/android/sync.c
@@ -705,6 +705,7 @@ static long sync_fence_ioctl(struct file *file, unsigned int cmd,
unsigned long arg)
{
struct sync_fence *fence = file->private_data;
+
switch (cmd) {
case SYNC_IOC_WAIT:
return sync_fence_ioctl_wait(fence, arg);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: android: fix style issue
2014-08-20 14:13 [PATCH] staging: android: fix style issue Purnendu Kapadia
@ 2014-08-20 15:04 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2014-08-20 15:04 UTC (permalink / raw)
To: Purnendu Kapadia; +Cc: konkers, gregkh, devel, linux-kernel
On Wed, 2014-08-20 at 15:13 +0100, Purnendu Kapadia wrote:
> checkpatch fix. add a line before the switch statement
Hello Purnendu.
This is a suboptimal patch description.
There is no generic style asking for a blank line
before a switch statement.
You are actually adding a blank line separating
declarations and code.
Specifying the change as a "checkpatch fix" is
also unnecessary.
A patch subject of
"[PATCH] staging: android: Add blank line after declaration"
with no patch description at all is probably good
enough.
> diff --git a/drivers/staging/android/sync.c b/drivers/staging/androchd/sync.c
[]
> @@ -705,6 +705,7 @@ static long sync_fence_ioctl(struct file *file, unsigned int cmd,
> unsigned long arg)
> {
> struct sync_fence *fence = file->private_data;
> +
> switch (cmd) {
> case SYNC_IOC_WAIT:
> return sync_fence_ioctl_wait(fence, arg);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-20 15:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-20 14:13 [PATCH] staging: android: fix style issue Purnendu Kapadia
2014-08-20 15:04 ` Joe Perches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.