[Qemu-devel] [PATCH v2] block/vvfat.c: remove debugging code to reinit stderr if NULL

[Qemu-devel] [PATCH v2] block/vvfat.c: remove debugging code to reinit stderr if NULL

[Michael Tokarev]

Just log to stderr unconditionally, like other similar code does.

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
 block/vvfat.c |    9 ---------
 1 file changed, 9 deletions(-)

v2: also remove stderr redefinition

diff --git a/block/vvfat.c b/block/vvfat.c
index 70176b1..1c270b2 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -52,10 +52,6 @@
 
 #define DLOG(a) a
 
-#undef stderr
-#define stderr STDERR
-FILE* stderr = NULL;
-
 static void checkpoint(void);
 
 #ifdef __MINGW32__
@@ -1082,11 +1078,6 @@ static int vvfat_open(BlockDriverState *bs, QDict *options, int flags,
     vvv = s;
 #endif
 
-DLOG(if (stderr == NULL) {
-    stderr = fopen("vvfat.log", "a");
-    setbuf(stderr, NULL);
-})
-
     opts = qemu_opts_create(&runtime_opts, NULL, 0, &error_abort);
     qemu_opts_absorb_qdict(opts, options, &local_err);
     if (local_err) {
-- 
1.7.10.4

Re: [Qemu-devel] [PATCH v2] block/vvfat.c: remove debugging code to reinit stderr if NULL

[Kevin Wolf]

Am 20.08.2014 um 17:02 hat Michael Tokarev geschrieben:
> Just log to stderr unconditionally, like other similar code does.
> 
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  block/vvfat.c |    9 ---------
>  1 file changed, 9 deletions(-)
> 
> v2: also remove stderr redefinition

Thanks, applied to the block branch.

Kevin