[PATCH] Add MODULE_ALIAS for Xen pciback. (v1)

[PATCH] Add MODULE_ALIAS for Xen pciback. (v1)

[Konrad Rzeszutek Wilk]

Most of the drivers had this in them except the Xen pciback.
This patch fixes that.

 drivers/xen/xen-pciback/pci_stub.c | 1 +
 1 file changed, 1 insertion(+)

Konrad Rzeszutek Wilk (1):
      xen-pciback: Add MODULE_ALIAS for pciback.

[PATCH] xen-pciback: Add MODULE_ALIAS for pciback.

[Konrad Rzeszutek Wilk]

The rest of the Xen device drivers use an module alias
to load devices when they shop up in XenBus.

This is done for the rest of them but hadn't been done
for Xen PCI back. This patch fixes it.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 drivers/xen/xen-pciback/pci_stub.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c
index d57a173..7da75f7 100644
--- a/drivers/xen/xen-pciback/pci_stub.c
+++ b/drivers/xen/xen-pciback/pci_stub.c
@@ -1538,3 +1538,4 @@ module_exit(xen_pcibk_cleanup);
 
 MODULE_LICENSE("Dual BSD/GPL");
 MODULE_ALIAS("xen-backend:pci");
+MODULE_ALIAS("xen:pci");
-- 
1.9.3

Re: [Xen-devel] [PATCH] xen-pciback: Add MODULE_ALIAS for pciback.

[Ian Campbell]

On Wed, 2014-08-20 at 12:40 -0400, Konrad Rzeszutek Wilk wrote:
> The rest of the Xen device drivers use an module alias
> to load devices when they shop up in XenBus.

"show".
>  
>  MODULE_LICENSE("Dual BSD/GPL");
>  MODULE_ALIAS("xen-backend:pci");
> +MODULE_ALIAS("xen:pci");

Isn't that xen-backend:pci already the right thing for a backend device?
xen: is for frontends, I thought.

Ian.

Re: [PATCH] xen-pciback: Add MODULE_ALIAS for pciback.

[Konrad Rzeszutek Wilk]

On Wed, Aug 20, 2014 at 06:18:52PM +0100, Ian Campbell wrote:
> On Wed, 2014-08-20 at 12:40 -0400, Konrad Rzeszutek Wilk wrote:
> > The rest of the Xen device drivers use an module alias
> > to load devices when they shop up in XenBus.
> 
> "show".
> >  
> >  MODULE_LICENSE("Dual BSD/GPL");
> >  MODULE_ALIAS("xen-backend:pci");
> > +MODULE_ALIAS("xen:pci");
> 
> Isn't that xen-backend:pci already the right thing for a backend device?
> xen: is for frontends, I thought.

Oh, you are right. Cool! Thanks!
> 
> Ian.
> 

Re: [Xen-devel] [PATCH] xen-pciback: Add MODULE_ALIAS for pciback.

[Konrad Rzeszutek Wilk]

On Wed, Aug 20, 2014 at 06:18:52PM +0100, Ian Campbell wrote:
> On Wed, 2014-08-20 at 12:40 -0400, Konrad Rzeszutek Wilk wrote:
> > The rest of the Xen device drivers use an module alias
> > to load devices when they shop up in XenBus.
> 
> "show".
> >  
> >  MODULE_LICENSE("Dual BSD/GPL");
> >  MODULE_ALIAS("xen-backend:pci");
> > +MODULE_ALIAS("xen:pci");
> 
> Isn't that xen-backend:pci already the right thing for a backend device?
> xen: is for frontends, I thought.

Oh, you are right. Cool! Thanks!
> 
> Ian.
> 

Re: [PATCH] xen-pciback: Add MODULE_ALIAS for pciback.

[Ian Campbell]

On Wed, 2014-08-20 at 13:20 -0400, Konrad Rzeszutek Wilk wrote:
> On Wed, Aug 20, 2014 at 06:18:52PM +0100, Ian Campbell wrote:
> > On Wed, 2014-08-20 at 12:40 -0400, Konrad Rzeszutek Wilk wrote:
> > > The rest of the Xen device drivers use an module alias
> > > to load devices when they shop up in XenBus.
> > 
> > "show".
> > >  
> > >  MODULE_LICENSE("Dual BSD/GPL");
> > >  MODULE_ALIAS("xen-backend:pci");
> > > +MODULE_ALIAS("xen:pci");
> > 
> > Isn't that xen-backend:pci already the right thing for a backend device?
> > xen: is for frontends, I thought.
> 
> Oh, you are right. Cool! Thanks!

The patch turned out to be even more trivial than expected ;-)

Ian.

Re: [Xen-devel] [PATCH] xen-pciback: Add MODULE_ALIAS for pciback.

[Ian Campbell]

On Wed, 2014-08-20 at 13:20 -0400, Konrad Rzeszutek Wilk wrote:
> On Wed, Aug 20, 2014 at 06:18:52PM +0100, Ian Campbell wrote:
> > On Wed, 2014-08-20 at 12:40 -0400, Konrad Rzeszutek Wilk wrote:
> > > The rest of the Xen device drivers use an module alias
> > > to load devices when they shop up in XenBus.
> > 
> > "show".
> > >  
> > >  MODULE_LICENSE("Dual BSD/GPL");
> > >  MODULE_ALIAS("xen-backend:pci");
> > > +MODULE_ALIAS("xen:pci");
> > 
> > Isn't that xen-backend:pci already the right thing for a backend device?
> > xen: is for frontends, I thought.
> 
> Oh, you are right. Cool! Thanks!

The patch turned out to be even more trivial than expected ;-)

Ian.

Re: [PATCH] xen-pciback: Add MODULE_ALIAS for pciback.

[Luis R. Rodriguez]

On Wed, Aug 20, 2014 at 1:26 PM, Ian Campbell <ian.campbell@citrix.com> wrote:
> On Wed, 2014-08-20 at 13:20 -0400, Konrad Rzeszutek Wilk wrote:
>> On Wed, Aug 20, 2014 at 06:18:52PM +0100, Ian Campbell wrote:
>> > On Wed, 2014-08-20 at 12:40 -0400, Konrad Rzeszutek Wilk wrote:
>> > > The rest of the Xen device drivers use an module alias
>> > > to load devices when they shop up in XenBus.
>> >
>> > "show".
>> > >
>> > >  MODULE_LICENSE("Dual BSD/GPL");
>> > >  MODULE_ALIAS("xen-backend:pci");
>> > > +MODULE_ALIAS("xen:pci");
>> >
>> > Isn't that xen-backend:pci already the right thing for a backend device?
>> > xen: is for frontends, I thought.
>>
>> Oh, you are right. Cool! Thanks!
>
> The patch turned out to be even more trivial than expected ;-)

Is this what we expected to be pending work for the item "device
hotplug (MODULE_ALIAS)" on the upstream TODO list?

http://wiki.xenproject.org/wiki/XenParavirtOps#Upstream_delta_details

This was simply to just auto load that driver when needed right?

Also as for actual PCI device hotplug support:

http://wiki.xen.org/wiki/Xen_PCI_Passthrough#Hotplug

I don't think we need a delta for that do we?

 Luis

Re: [Xen-devel] [PATCH] xen-pciback: Add MODULE_ALIAS for pciback.

[Luis R. Rodriguez]

On Wed, Aug 20, 2014 at 1:26 PM, Ian Campbell <ian.campbell@citrix.com> wrote:
> On Wed, 2014-08-20 at 13:20 -0400, Konrad Rzeszutek Wilk wrote:
>> On Wed, Aug 20, 2014 at 06:18:52PM +0100, Ian Campbell wrote:
>> > On Wed, 2014-08-20 at 12:40 -0400, Konrad Rzeszutek Wilk wrote:
>> > > The rest of the Xen device drivers use an module alias
>> > > to load devices when they shop up in XenBus.
>> >
>> > "show".
>> > >
>> > >  MODULE_LICENSE("Dual BSD/GPL");
>> > >  MODULE_ALIAS("xen-backend:pci");
>> > > +MODULE_ALIAS("xen:pci");
>> >
>> > Isn't that xen-backend:pci already the right thing for a backend device?
>> > xen: is for frontends, I thought.
>>
>> Oh, you are right. Cool! Thanks!
>
> The patch turned out to be even more trivial than expected ;-)

Is this what we expected to be pending work for the item "device
hotplug (MODULE_ALIAS)" on the upstream TODO list?

http://wiki.xenproject.org/wiki/XenParavirtOps#Upstream_delta_details

This was simply to just auto load that driver when needed right?

Also as for actual PCI device hotplug support:

http://wiki.xen.org/wiki/Xen_PCI_Passthrough#Hotplug

I don't think we need a delta for that do we?

 Luis

Re: [PATCH] xen-pciback: Add MODULE_ALIAS for pciback.

[Ian Campbell]

On Wed, 2014-08-20 at 12:40 -0400, Konrad Rzeszutek Wilk wrote:
> The rest of the Xen device drivers use an module alias
> to load devices when they shop up in XenBus.

"show".
>  
>  MODULE_LICENSE("Dual BSD/GPL");
>  MODULE_ALIAS("xen-backend:pci");
> +MODULE_ALIAS("xen:pci");

Isn't that xen-backend:pci already the right thing for a backend device?
xen: is for frontends, I thought.

Ian.

[PATCH] xen-pciback: Add MODULE_ALIAS for pciback.

[Konrad Rzeszutek Wilk]

The rest of the Xen device drivers use an module alias
to load devices when they shop up in XenBus.

This is done for the rest of them but hadn't been done
for Xen PCI back. This patch fixes it.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 drivers/xen/xen-pciback/pci_stub.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c
index d57a173..7da75f7 100644
--- a/drivers/xen/xen-pciback/pci_stub.c
+++ b/drivers/xen/xen-pciback/pci_stub.c
@@ -1538,3 +1538,4 @@ module_exit(xen_pcibk_cleanup);
 
 MODULE_LICENSE("Dual BSD/GPL");
 MODULE_ALIAS("xen-backend:pci");
+MODULE_ALIAS("xen:pci");
-- 
1.9.3

Re: [PATCH] xen-pciback: Add MODULE_ALIAS for pciback.

[Konrad Rzeszutek Wilk]

On Nov 26, 2014 11:39 AM, "Luis R. Rodriguez" <mcgrof@do-not-panic.com> wrote:
>
> On Wed, Aug 20, 2014 at 1:26 PM, Ian Campbell <ian.campbell@citrix.com> wrote: 
> > On Wed, 2014-08-20 at 13:20 -0400, Konrad Rzeszutek Wilk wrote: 
> >> On Wed, Aug 20, 2014 at 06:18:52PM +0100, Ian Campbell wrote: 
> >> > On Wed, 2014-08-20 at 12:40 -0400, Konrad Rzeszutek Wilk wrote: 
> >> > > The rest of the Xen device drivers use an module alias 
> >> > > to load devices when they shop up in XenBus. 
> >> > 
> >> > "show". 
> >> > > 
> >> > >  MODULE_LICENSE("Dual BSD/GPL"); 
> >> > >  MODULE_ALIAS("xen-backend:pci"); 
> >> > > +MODULE_ALIAS("xen:pci"); 
> >> > 
> >> > Isn't that xen-backend:pci already the right thing for a backend device? 
> >> > xen: is for frontends, I thought. 
> >> 
> >> Oh, you are right. Cool! Thanks! 
> > 
> > The patch turned out to be even more trivial than expected ;-) 
>
> Is this what we expected to be pending work for the item "device 
> hotplug (MODULE_ALIAS)" on the upstream TODO list? 
>
> http://wiki.xenproject.org/wiki/XenParavirtOps#Upstream_delta_details 
>
> This was simply to just auto load that driver when needed right? 
>

Right which it does now.

> Also as for actual PCI device hotplug support: 
>
> http://wiki.xen.org/wiki/Xen_PCI_Passthrough#Hotplug 
>
> I don't think we need a delta for that do we? 

Nope. This one is all done.
>
> Luis 
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel