From: Grygorii Strashko <grygorii.strashko@ti.com> To: Linus Walleij <linus.walleij@linaro.org>, santosh.shilimkar@ti.com, Alexander Shiyan <shc_work@mail.ru>, linux-gpio@vger.kernel.org Cc: Rob Herring <robh+dt@kernel.org>, Alexandre Courbot <gnurou@gmail.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Grygorii Strashko <grygorii.strashko@ti.com> Subject: [PATCH v2 1/3] gpio: syscon: add soc specific callback to assign output value Date: Thu, 21 Aug 2014 19:23:21 +0300 [thread overview] Message-ID: <1408638203-8246-2-git-send-email-grygorii.strashko@ti.com> (raw) In-Reply-To: <1408638203-8246-1-git-send-email-grygorii.strashko@ti.com> Some SoCs (like Keystone) may require to perform special sequence of operations to assign output GPIO value, so default implementation of .set() callback from gpio-syscon driver can't be used. Hence, add optional, SoC specific callback to assign output gpio value. Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> --- drivers/gpio/gpio-syscon.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c index 30884fb..03b4699 100644 --- a/drivers/gpio/gpio-syscon.c +++ b/drivers/gpio/gpio-syscon.c @@ -37,6 +37,8 @@ * dat_bit_offset: Offset (in bits) to the first GPIO bit. * dir_bit_offset: Optional offset (in bits) to the first bit to switch * GPIO direction (Used with GPIO_SYSCON_FEAT_DIR flag). + * set: HW specific callback to assigns output value + * for signal "offset" */ struct syscon_gpio_data { @@ -45,6 +47,8 @@ struct syscon_gpio_data { unsigned int bit_count; unsigned int dat_bit_offset; unsigned int dir_bit_offset; + void (*set)(struct gpio_chip *chip, + unsigned offset, int value); }; struct syscon_gpio_priv { @@ -77,6 +81,11 @@ static void syscon_gpio_set(struct gpio_chip *chip, unsigned offset, int val) struct syscon_gpio_priv *priv = to_syscon_gpio(chip); unsigned int offs = priv->data->dat_bit_offset + offset; + if (priv->data->set) { + priv->data->set(chip, offset, val); + return; + } + regmap_update_bits(priv->syscon, (offs / SYSCON_REG_BITS) * SYSCON_REG_SIZE, BIT(offs % SYSCON_REG_BITS), -- 1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: grygorii.strashko@ti.com (Grygorii Strashko) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 1/3] gpio: syscon: add soc specific callback to assign output value Date: Thu, 21 Aug 2014 19:23:21 +0300 [thread overview] Message-ID: <1408638203-8246-2-git-send-email-grygorii.strashko@ti.com> (raw) In-Reply-To: <1408638203-8246-1-git-send-email-grygorii.strashko@ti.com> Some SoCs (like Keystone) may require to perform special sequence of operations to assign output GPIO value, so default implementation of .set() callback from gpio-syscon driver can't be used. Hence, add optional, SoC specific callback to assign output gpio value. Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> --- drivers/gpio/gpio-syscon.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c index 30884fb..03b4699 100644 --- a/drivers/gpio/gpio-syscon.c +++ b/drivers/gpio/gpio-syscon.c @@ -37,6 +37,8 @@ * dat_bit_offset: Offset (in bits) to the first GPIO bit. * dir_bit_offset: Optional offset (in bits) to the first bit to switch * GPIO direction (Used with GPIO_SYSCON_FEAT_DIR flag). + * set: HW specific callback to assigns output value + * for signal "offset" */ struct syscon_gpio_data { @@ -45,6 +47,8 @@ struct syscon_gpio_data { unsigned int bit_count; unsigned int dat_bit_offset; unsigned int dir_bit_offset; + void (*set)(struct gpio_chip *chip, + unsigned offset, int value); }; struct syscon_gpio_priv { @@ -77,6 +81,11 @@ static void syscon_gpio_set(struct gpio_chip *chip, unsigned offset, int val) struct syscon_gpio_priv *priv = to_syscon_gpio(chip); unsigned int offs = priv->data->dat_bit_offset + offset; + if (priv->data->set) { + priv->data->set(chip, offset, val); + return; + } + regmap_update_bits(priv->syscon, (offs / SYSCON_REG_BITS) * SYSCON_REG_SIZE, BIT(offs % SYSCON_REG_BITS), -- 1.7.9.5
next prev parent reply other threads:[~2014-08-21 16:24 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-13 16:16 [PATCH 0/4] gpio: syscon: reuse for keystone 2 socs Grygorii Strashko 2014-08-13 16:16 ` Grygorii Strashko 2014-08-13 16:16 ` [PATCH 1/4] gpio: syscon: add soc specific callback to assign output value Grygorii Strashko 2014-08-13 16:16 ` Grygorii Strashko 2014-08-29 6:19 ` Linus Walleij 2014-08-29 6:19 ` Linus Walleij 2014-09-01 14:55 ` Grygorii Strashko 2014-09-01 14:55 ` Grygorii Strashko 2014-08-13 16:16 ` [PATCH 2/4] gpio: syscon: retrive syscon node and regs offsets from dt Grygorii Strashko 2014-08-13 16:16 ` Grygorii Strashko 2014-08-13 16:16 ` [PATCH 3/4] gpio: syscon: reuse for keystone 2 socs Grygorii Strashko 2014-08-13 16:16 ` Grygorii Strashko 2014-08-29 5:53 ` Linus Walleij 2014-08-29 5:53 ` Linus Walleij 2014-08-13 16:16 ` [PATCH 4/4] ARM: dts: keystone-k2hk: add dsp gpio controllers nodes Grygorii Strashko 2014-08-13 16:16 ` Grygorii Strashko 2014-08-13 16:06 ` Alexander Shiyan [not found] ` <1407946582-20927-5-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org> 2014-08-13 16:06 ` Alexander Shiyan 2014-08-13 16:06 ` Alexander Shiyan 2014-08-13 16:06 ` Alexander Shiyan 2014-08-14 12:13 ` Grygorii Strashko 2014-08-14 12:13 ` Grygorii Strashko 2014-08-14 12:12 ` Alexander Shiyan 2014-08-14 12:12 ` Alexander Shiyan 2014-08-14 15:57 ` Grygorii Strashko 2014-08-14 15:57 ` Grygorii Strashko 2014-08-14 15:26 ` Alexander Shiyan 2014-08-14 15:26 ` Alexander Shiyan 2014-08-14 16:54 ` Grygorii Strashko 2014-08-14 16:54 ` Grygorii Strashko 2014-08-21 16:23 ` [PATCH v2 0/3] gpio: syscon: reuse for keystone 2 socs Grygorii Strashko 2014-08-21 16:23 ` Grygorii Strashko 2014-08-21 16:23 ` Grygorii Strashko [this message] 2014-08-21 16:23 ` [PATCH v2 1/3] gpio: syscon: add soc specific callback to assign output value Grygorii Strashko 2014-08-21 16:23 ` [PATCH v2 2/3] gpio: syscon: reuse for keystone 2 socs Grygorii Strashko 2014-08-21 16:23 ` Grygorii Strashko 2014-08-21 16:23 ` [PATCH v2 3/3] ARM: dts: keystone-k2hk: add dsp gpio controllers nodes Grygorii Strashko 2014-08-21 16:23 ` Grygorii Strashko 2014-08-21 16:47 ` Alexander Shiyan 2014-08-21 16:47 ` Alexander Shiyan 2014-08-21 16:47 ` Alexander Shiyan [not found] ` <1408638203-8246-4-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org> 2014-08-21 16:47 ` Alexander Shiyan 2014-08-21 16:51 ` [PATCH v2 0/3] gpio: syscon: reuse for keystone 2 socs Alexander Shiyan 2014-08-21 16:51 ` Alexander Shiyan 2014-08-28 17:32 ` Grygorii Strashko 2014-08-28 17:32 ` Grygorii Strashko [not found] ` <1408638203-8246-1-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org> 2014-08-21 16:51 ` Alexander Shiyan 2014-08-21 16:51 ` Alexander Shiyan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1408638203-8246-2-git-send-email-grygorii.strashko@ti.com \ --to=grygorii.strashko@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=gnurou@gmail.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=santosh.shilimkar@ti.com \ --cc=shc_work@mail.ru \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.