* [Qemu-devel] [PULL 00/11] pci, pc fixes, features
@ 2014-08-24 22:18 Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 01/11] hostmem: set MPOL_MF_MOVE Michael S. Tsirkin
` (11 more replies)
0 siblings, 12 replies; 13+ messages in thread
From: Michael S. Tsirkin @ 2014-08-24 22:18 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Anthony Liguori
The following changes since commit 2656eb7c599e306b95bad82b1372fc49ba3088f6:
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20140819' into staging (2014-08-20 09:55:42 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
for you to fetch changes up to 187de915e8d06aaf82be206aebc551c82bf0670c:
pcie: fix trailing whitespace (2014-08-25 00:16:07 +0200)
----------------------------------------------------------------
pci, pc fixes, features
A bunch of bugfixes - these will make sense for 2.1.1
ACPI support for TPM and partial ARI support for PCIE.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
----------------------------------------------------------------
Gonglei (1):
pcihp: fix possible array out of bounds
Knut Omang (4):
pcie: Fix incorrect write to the ari capability next function field
pcie: Rename the pcie_cap_ari_* functions to pcie_cap_arifwd_*
ioh3420: Remove obsoleted, unused ioh3420_init function
ioh3420: Enable ARI forwarding
Michael S. Tsirkin (4):
hostmem: set MPOL_MF_MOVE
pc: reserve more memory for ACPI for new machine types
ssdt-tpm: add generated hex file to git
pcie: fix trailing whitespace
Paolo Bonzini (1):
pci_bridge: manually destroy memory regions within PCIBridgeWindows
Stefan Berger (1):
Add ACPI tables for TPM
hw/i386/acpi-defs.h | 11 +++++
hw/tpm/tpm_tis.h | 8 +---
include/hw/acpi/tpm.h | 29 ++++++++++++
include/hw/i386/pc.h | 2 +
include/hw/pci/pcie.h | 7 +--
include/sysemu/tpm.h | 7 +++
backends/hostmem.c | 2 +-
hw/acpi/pcihp.c | 2 +-
hw/i386/acpi-build.c | 45 ++++++++++++++++++
hw/i386/pc.c | 12 +++--
hw/i386/pc_piix.c | 1 +
hw/i386/pc_q35.c | 1 +
hw/pci-bridge/ioh3420.c | 27 ++---------
hw/pci-bridge/xio3130_downstream.c | 4 +-
hw/pci/pci_bridge.c | 6 +++
hw/pci/pcie.c | 13 +++---
hw/i386/Makefile.objs | 3 +-
hw/i386/ssdt-tpm.dsl | 43 +++++++++++++++++
hw/i386/ssdt-tpm.hex.generated | 95 ++++++++++++++++++++++++++++++++++++++
19 files changed, 270 insertions(+), 48 deletions(-)
create mode 100644 include/hw/acpi/tpm.h
create mode 100644 hw/i386/ssdt-tpm.dsl
create mode 100644 hw/i386/ssdt-tpm.hex.generated
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] [PULL 01/11] hostmem: set MPOL_MF_MOVE
2014-08-24 22:18 [Qemu-devel] [PULL 00/11] pci, pc fixes, features Michael S. Tsirkin
@ 2014-08-24 22:18 ` Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 02/11] pci_bridge: manually destroy memory regions within PCIBridgeWindows Michael S. Tsirkin
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Michael S. Tsirkin @ 2014-08-24 22:18 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Peter Crosthwaite, Hu Tao, qemu-stable,
Anthony Liguori, Igor Mammedov, Paolo Bonzini
When memory is allocated on a wrong node, MPOL_MF_STRICT
doesn't move it - it just fails the allocation.
A simple way to reproduce the failure is with mlock=on
realtime feature.
The code comment actually says: "ensure policy won't be ignored"
so setting MPOL_MF_MOVE seems like a better way to do this.
Cc: qemu-stable@nongnu.org
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
backends/hostmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/backends/hostmem.c b/backends/hostmem.c
index e7eec37..99e8f99 100644
--- a/backends/hostmem.c
+++ b/backends/hostmem.c
@@ -295,7 +295,7 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp)
/* ensure policy won't be ignored in case memory is preallocated
* before mbind(). note: MPOL_MF_STRICT is ignored on hugepages so
* this doesn't catch hugepage case. */
- unsigned flags = MPOL_MF_STRICT;
+ unsigned flags = MPOL_MF_STRICT | MPOL_MF_MOVE;
/* check for invalid host-nodes and policies and give more verbose
* error messages than mbind(). */
--
MST
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Qemu-devel] [PULL 02/11] pci_bridge: manually destroy memory regions within PCIBridgeWindows
2014-08-24 22:18 [Qemu-devel] [PULL 00/11] pci, pc fixes, features Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 01/11] hostmem: set MPOL_MF_MOVE Michael S. Tsirkin
@ 2014-08-24 22:18 ` Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 03/11] pcihp: fix possible array out of bounds Michael S. Tsirkin
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Michael S. Tsirkin @ 2014-08-24 22:18 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Gonglei, Knut Omang, Anthony Liguori, Paolo Bonzini
From: Paolo Bonzini <pbonzini@redhat.com>
The regions are destroyed and recreated on configuration space accesses.
We need to destroy them before the containing PCIBridgeWindows object
is freed.
Reported-by: Gonglei <arei.gonglei@huawei.com>
Reported-by: Knut Omang <knut.omang@oracle.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/pci/pci_bridge.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c
index 1307265..40c97b1 100644
--- a/hw/pci/pci_bridge.c
+++ b/hw/pci/pci_bridge.c
@@ -219,6 +219,12 @@ static void pci_bridge_region_del(PCIBridge *br, PCIBridgeWindows *w)
static void pci_bridge_region_cleanup(PCIBridge *br, PCIBridgeWindows *w)
{
+ object_unparent(OBJECT(&w->alias_io));
+ object_unparent(OBJECT(&w->alias_mem));
+ object_unparent(OBJECT(&w->alias_pref_mem));
+ object_unparent(OBJECT(&w->alias_vga[QEMU_PCI_VGA_IO_LO]));
+ object_unparent(OBJECT(&w->alias_vga[QEMU_PCI_VGA_IO_HI]));
+ object_unparent(OBJECT(&w->alias_vga[QEMU_PCI_VGA_MEM]));
g_free(w);
}
--
MST
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Qemu-devel] [PULL 03/11] pcihp: fix possible array out of bounds
2014-08-24 22:18 [Qemu-devel] [PULL 00/11] pci, pc fixes, features Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 01/11] hostmem: set MPOL_MF_MOVE Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 02/11] pci_bridge: manually destroy memory regions within PCIBridgeWindows Michael S. Tsirkin
@ 2014-08-24 22:18 ` Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 04/11] pc: reserve more memory for ACPI for new machine types Michael S. Tsirkin
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Michael S. Tsirkin @ 2014-08-24 22:18 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Peter Crosthwaite, qemu-stable, Gonglei,
Anthony Liguori, Marcel Apfelbaum
From: Gonglei <arei.gonglei@huawei.com>
Prevent out-of-bounds array access on
acpi_pcihp_pci_status.
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Cc: qemu-stable@nongnu.org
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
---
hw/acpi/pcihp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c
index fae663a..34dedf1 100644
--- a/hw/acpi/pcihp.c
+++ b/hw/acpi/pcihp.c
@@ -231,7 +231,7 @@ static uint64_t pci_read(void *opaque, hwaddr addr, unsigned int size)
uint32_t val = 0;
int bsel = s->hotplug_select;
- if (bsel < 0 || bsel > ACPI_PCIHP_MAX_HOTPLUG_BUS) {
+ if (bsel < 0 || bsel >= ACPI_PCIHP_MAX_HOTPLUG_BUS) {
return 0;
}
--
MST
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Qemu-devel] [PULL 04/11] pc: reserve more memory for ACPI for new machine types
2014-08-24 22:18 [Qemu-devel] [PULL 00/11] pci, pc fixes, features Michael S. Tsirkin
` (2 preceding siblings ...)
2014-08-24 22:18 ` [Qemu-devel] [PULL 03/11] pcihp: fix possible array out of bounds Michael S. Tsirkin
@ 2014-08-24 22:18 ` Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 05/11] Add ACPI tables for TPM Michael S. Tsirkin
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Michael S. Tsirkin @ 2014-08-24 22:18 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi, qemu-stable, Anthony Liguori
commit 868270f23d8db2cce83e4f082fe75e8625a5fbf9
acpi-build: tweak acpi migration limits
broke kernel loading with -kernel/-initrd: it doubled
the size of ACPI tables but did not reserve
enough memory.
As a result, issues on boot and halt are observed.
Fix this up by doubling reserved memory for new machine types.
Cc: qemu-stable@nongnu.org
Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hw/i386/pc.h | 2 ++
hw/i386/pc.c | 12 +++++++++---
hw/i386/pc_piix.c | 1 +
hw/i386/pc_q35.c | 1 +
4 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 0fca9e3..a39cb42 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -176,6 +176,8 @@ void pc_acpi_init(const char *default_dsdt);
PcGuestInfo *pc_guest_info_init(ram_addr_t below_4g_mem_size,
ram_addr_t above_4g_mem_size);
+void pc_set_legacy_acpi_data_size(void);
+
#define PCI_HOST_PROP_PCI_HOLE_START "pci-hole-start"
#define PCI_HOST_PROP_PCI_HOLE_END "pci-hole-end"
#define PCI_HOST_PROP_PCI_HOLE64_START "pci-hole64-start"
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 8fa8d2f..0ca4deb 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -73,7 +73,12 @@
#endif
/* Leave a chunk of memory at the top of RAM for the BIOS ACPI tables. */
-#define ACPI_DATA_SIZE 0x10000
+unsigned acpi_data_size = 0x20000;
+void pc_set_legacy_acpi_data_size(void)
+{
+ acpi_data_size = 0x10000;
+}
+
#define BIOS_CFG_IOPORT 0x510
#define FW_CFG_ACPI_TABLES (FW_CFG_ARCH_LOCAL + 0)
#define FW_CFG_SMBIOS_ENTRIES (FW_CFG_ARCH_LOCAL + 1)
@@ -811,8 +816,9 @@ static void load_linux(FWCfgState *fw_cfg,
initrd_max = 0x37ffffff;
}
- if (initrd_max >= max_ram_size-ACPI_DATA_SIZE)
- initrd_max = max_ram_size-ACPI_DATA_SIZE-1;
+ if (initrd_max >= max_ram_size - acpi_data_size) {
+ initrd_max = max_ram_size - acpi_data_size - 1;
+ }
fw_cfg_add_i32(fw_cfg, FW_CFG_CMDLINE_ADDR, cmdline_addr);
fw_cfg_add_i32(fw_cfg, FW_CFG_CMDLINE_SIZE, strlen(kernel_cmdline)+1);
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 47ac1b5..103d756 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -323,6 +323,7 @@ static void pc_compat_2_0(MachineState *machine)
legacy_acpi_table_size = 6652;
smbios_legacy_mode = true;
has_reserved_memory = false;
+ pc_set_legacy_acpi_data_size();
}
static void pc_compat_1_7(MachineState *machine)
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 4b5a274..d4a907c 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -280,6 +280,7 @@ static void pc_compat_2_0(MachineState *machine)
{
smbios_legacy_mode = true;
has_reserved_memory = false;
+ pc_set_legacy_acpi_data_size();
}
static void pc_compat_1_7(MachineState *machine)
--
MST
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Qemu-devel] [PULL 05/11] Add ACPI tables for TPM
2014-08-24 22:18 [Qemu-devel] [PULL 00/11] pci, pc fixes, features Michael S. Tsirkin
` (3 preceding siblings ...)
2014-08-24 22:18 ` [Qemu-devel] [PULL 04/11] pc: reserve more memory for ACPI for new machine types Michael S. Tsirkin
@ 2014-08-24 22:18 ` Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 06/11] ssdt-tpm: add generated hex file to git Michael S. Tsirkin
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Michael S. Tsirkin @ 2014-08-24 22:18 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Anthony Liguori, Stefan Berger
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
Add an SSDT ACPI table for the TPM device.
Add a TCPA table for BIOS logging area when a TPM is being used.
The latter follows this spec here:
http://www.trustedcomputinggroup.org/files/static_page_files/DCD4188E-1A4B-B294-D050A155FB6F7385/TCG_ACPIGeneralSpecification_PublicReview.pdf
This patch has Michael Tsirkin's patches folded in.
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/i386/acpi-defs.h | 11 +++++++++++
hw/tpm/tpm_tis.h | 8 +-------
include/hw/acpi/tpm.h | 29 +++++++++++++++++++++++++++++
include/sysemu/tpm.h | 7 +++++++
hw/i386/acpi-build.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
hw/i386/Makefile.objs | 3 ++-
hw/i386/ssdt-tpm.dsl | 43 +++++++++++++++++++++++++++++++++++++++++++
7 files changed, 138 insertions(+), 8 deletions(-)
create mode 100644 include/hw/acpi/tpm.h
create mode 100644 hw/i386/ssdt-tpm.dsl
diff --git a/hw/i386/acpi-defs.h b/hw/i386/acpi-defs.h
index e93babb..1bc974a 100644
--- a/hw/i386/acpi-defs.h
+++ b/hw/i386/acpi-defs.h
@@ -314,4 +314,15 @@ struct AcpiTableMcfg {
} QEMU_PACKED;
typedef struct AcpiTableMcfg AcpiTableMcfg;
+/*
+ * TCPA Description Table
+ */
+struct Acpi20Tcpa {
+ ACPI_TABLE_HEADER_DEF /* ACPI common table header */
+ uint16_t platform_class;
+ uint32_t log_area_minimum_length;
+ uint64_t log_area_start_address;
+} QEMU_PACKED;
+typedef struct Acpi20Tcpa Acpi20Tcpa;
+
#endif
diff --git a/hw/tpm/tpm_tis.h b/hw/tpm/tpm_tis.h
index 916152a..1a0db23 100644
--- a/hw/tpm/tpm_tis.h
+++ b/hw/tpm/tpm_tis.h
@@ -18,23 +18,17 @@
#define TPM_TPM_TIS_H
#include "hw/isa/isa.h"
+#include "hw/acpi/tpm.h"
#include "qemu-common.h"
-#define TPM_TIS_ADDR_BASE 0xFED40000
-
#define TPM_TIS_NUM_LOCALITIES 5 /* per spec */
#define TPM_TIS_LOCALITY_SHIFT 12
#define TPM_TIS_NO_LOCALITY 0xff
#define TPM_TIS_IS_VALID_LOCTY(x) ((x) < TPM_TIS_NUM_LOCALITIES)
-#define TPM_TIS_IRQ 5
-
#define TPM_TIS_BUFFER_MAX 4096
-#define TYPE_TPM_TIS "tpm-tis"
-
-
typedef enum {
TPM_TIS_STATE_IDLE = 0,
TPM_TIS_STATE_READY,
diff --git a/include/hw/acpi/tpm.h b/include/hw/acpi/tpm.h
new file mode 100644
index 0000000..792fcbf
--- /dev/null
+++ b/include/hw/acpi/tpm.h
@@ -0,0 +1,29 @@
+/*
+ * tpm.h - TPM ACPI definitions
+ *
+ * Copyright (C) 2014 IBM Corporation
+ *
+ * Authors:
+ * Stefan Berger <stefanb@us.ibm.com>
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ *
+ * Implementation of the TIS interface according to specs found at
+ * http://www.trustedcomputinggroup.org
+ *
+ */
+#ifndef HW_ACPI_TPM_H
+#define HW_ACPI_TPM_H
+
+#define TPM_TIS_ADDR_BASE 0xFED40000
+#define TPM_TIS_ADDR_SIZE 0x5000
+
+#define TPM_TIS_IRQ 5
+
+#define TPM_LOG_AREA_MINIMUM_SIZE (64 * 1024)
+
+#define TPM_TCPA_ACPI_CLASS_CLIENT 0
+#define TPM_TCPA_ACPI_CLASS_SERVER 1
+
+#endif /* HW_ACPI_TPM_H */
diff --git a/include/sysemu/tpm.h b/include/sysemu/tpm.h
index 13febdd..9b81ce9 100644
--- a/include/sysemu/tpm.h
+++ b/include/sysemu/tpm.h
@@ -20,4 +20,11 @@ int tpm_config_parse(QemuOptsList *opts_list, const char *optarg);
int tpm_init(void);
void tpm_cleanup(void);
+#define TYPE_TPM_TIS "tpm-tis"
+
+static inline bool tpm_find(void)
+{
+ return object_resolve_path_type("", TYPE_TPM_TIS, NULL);
+}
+
#endif /* QEMU_TPM_H */
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 10b84d0..85e5834 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -40,6 +40,8 @@
#include "hw/loader.h"
#include "hw/isa/isa.h"
#include "hw/acpi/memory_hotplug.h"
+#include "sysemu/tpm.h"
+#include "hw/acpi/tpm.h"
/* Supported chipsets: */
#include "hw/acpi/piix4.h"
@@ -88,6 +90,7 @@ typedef struct AcpiPmInfo {
typedef struct AcpiMiscInfo {
bool has_hpet;
+ bool has_tpm;
DECLARE_BITMAP(slot_hotplug_enable, PCI_SLOT_MAX);
const unsigned char *dsdt_code;
unsigned dsdt_size;
@@ -210,6 +213,7 @@ static void acpi_get_pm_info(AcpiPmInfo *pm)
static void acpi_get_misc_info(AcpiMiscInfo *info)
{
info->has_hpet = hpet_find();
+ info->has_tpm = tpm_find();
info->pvpanic_port = pvpanic_port();
}
@@ -698,6 +702,7 @@ static inline char acpi_get_hex(uint32_t val)
#include "hw/i386/ssdt-misc.hex"
#include "hw/i386/ssdt-pcihp.hex"
+#include "hw/i386/ssdt-tpm.hex"
static void
build_append_notify_method(GArray *device, const char *name,
@@ -1201,6 +1206,39 @@ build_hpet(GArray *table_data, GArray *linker)
(void *)hpet, "HPET", sizeof(*hpet), 1);
}
+static void
+build_tpm_tcpa(GArray *table_data, GArray *linker)
+{
+ Acpi20Tcpa *tcpa = acpi_data_push(table_data, sizeof *tcpa);
+ /* the log area will come right after the TCPA table */
+ uint64_t log_area_start_address = acpi_data_len(table_data);
+
+ tcpa->platform_class = cpu_to_le16(TPM_TCPA_ACPI_CLASS_CLIENT);
+ tcpa->log_area_minimum_length = cpu_to_le32(TPM_LOG_AREA_MINIMUM_SIZE);
+ tcpa->log_area_start_address = cpu_to_le64(log_area_start_address);
+
+ /* log area start address to be filled by Guest linker */
+ bios_linker_loader_add_pointer(linker, ACPI_BUILD_TABLE_FILE,
+ ACPI_BUILD_TABLE_FILE,
+ table_data, &tcpa->log_area_start_address,
+ sizeof(tcpa->log_area_start_address));
+
+ build_header(linker, table_data,
+ (void *)tcpa, "TCPA", sizeof(*tcpa), 2);
+
+ /* now only get the log area and with that modify table_data */
+ acpi_data_push(table_data, TPM_LOG_AREA_MINIMUM_SIZE);
+}
+
+static void
+build_tpm_ssdt(GArray *table_data, GArray *linker)
+{
+ void *tpm_ptr;
+
+ tpm_ptr = acpi_data_push(table_data, sizeof(ssdt_tpm_aml));
+ memcpy(tpm_ptr, ssdt_tpm_aml, sizeof(ssdt_tpm_aml));
+}
+
typedef enum {
MEM_AFFINITY_NOFLAGS = 0,
MEM_AFFINITY_ENABLED = (1 << 0),
@@ -1531,6 +1569,13 @@ void acpi_build(PcGuestInfo *guest_info, AcpiBuildTables *tables)
acpi_add_table(table_offsets, tables->table_data);
build_hpet(tables->table_data, tables->linker);
}
+ if (misc.has_tpm) {
+ acpi_add_table(table_offsets, tables->table_data);
+ build_tpm_tcpa(tables->table_data, tables->linker);
+
+ acpi_add_table(table_offsets, tables->table_data);
+ build_tpm_ssdt(tables->table_data, tables->linker);
+ }
if (guest_info->numa_nodes) {
acpi_add_table(table_offsets, tables->table_data);
build_srat(tables->table_data, tables->linker, &cpu, guest_info);
diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
index 48014ab..3688cf8 100644
--- a/hw/i386/Makefile.objs
+++ b/hw/i386/Makefile.objs
@@ -10,7 +10,8 @@ obj-y += bios-linker-loader.o
hw/i386/acpi-build.o: hw/i386/acpi-build.c hw/i386/acpi-dsdt.hex \
hw/i386/ssdt-proc.hex hw/i386/ssdt-pcihp.hex hw/i386/ssdt-misc.hex \
hw/i386/acpi-dsdt.hex hw/i386/q35-acpi-dsdt.hex \
- hw/i386/q35-acpi-dsdt.hex hw/i386/ssdt-mem.hex
+ hw/i386/q35-acpi-dsdt.hex hw/i386/ssdt-mem.hex \
+ hw/i386/ssdt-tpm.hex
iasl-option=$(shell if test -z "`$(1) $(2) 2>&1 > /dev/null`" \
; then echo "$(2)"; else echo "$(3)"; fi ;)
diff --git a/hw/i386/ssdt-tpm.dsl b/hw/i386/ssdt-tpm.dsl
new file mode 100644
index 0000000..75d9691
--- /dev/null
+++ b/hw/i386/ssdt-tpm.dsl
@@ -0,0 +1,43 @@
+/*
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, see <http://www.gnu.org/licenses/>.
+ */
+#include "hw/acpi/tpm.h"
+
+ACPI_EXTRACT_ALL_CODE ssdt_tpm_aml
+
+DefinitionBlock (
+ "ssdt-tpm.aml", // Output Filename
+ "SSDT", // Signature
+ 0x01, // SSDT Compliance Revision
+ "BXPC", // OEMID
+ "BXSSDT", // TABLE ID
+ 0x1 // OEM Revision
+ )
+{
+ Scope(\_SB) {
+ /* TPM with emulated TPM TIS interface */
+ Device (TPM) {
+ Name (_HID, EisaID ("PNP0C31"))
+ Name (_CRS, ResourceTemplate ()
+ {
+ Memory32Fixed (ReadWrite, TPM_TIS_ADDR_BASE, TPM_TIS_ADDR_SIZE)
+ // older Linux tpm_tis drivers do not work with IRQ
+ //IRQNoFlags () {TPM_TIS_IRQ}
+ })
+ Method (_STA, 0, NotSerialized) {
+ Return (0x0F)
+ }
+ }
+ }
+}
--
MST
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Qemu-devel] [PULL 06/11] ssdt-tpm: add generated hex file to git
2014-08-24 22:18 [Qemu-devel] [PULL 00/11] pci, pc fixes, features Michael S. Tsirkin
` (4 preceding siblings ...)
2014-08-24 22:18 ` [Qemu-devel] [PULL 05/11] Add ACPI tables for TPM Michael S. Tsirkin
@ 2014-08-24 22:18 ` Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 07/11] pcie: Fix incorrect write to the ari capability next function field Michael S. Tsirkin
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Michael S. Tsirkin @ 2014-08-24 22:18 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Anthony Liguori
Needed for systems without IASL.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/i386/ssdt-tpm.hex.generated | 95 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 95 insertions(+)
create mode 100644 hw/i386/ssdt-tpm.hex.generated
diff --git a/hw/i386/ssdt-tpm.hex.generated b/hw/i386/ssdt-tpm.hex.generated
new file mode 100644
index 0000000..4a916a8
--- /dev/null
+++ b/hw/i386/ssdt-tpm.hex.generated
@@ -0,0 +1,95 @@
+static unsigned char ssdt_tpm_aml[] = {
+0x53,
+0x53,
+0x44,
+0x54,
+0x5d,
+0x0,
+0x0,
+0x0,
+0x1,
+0xf,
+0x42,
+0x58,
+0x50,
+0x43,
+0x0,
+0x0,
+0x42,
+0x58,
+0x53,
+0x53,
+0x44,
+0x54,
+0x0,
+0x0,
+0x1,
+0x0,
+0x0,
+0x0,
+0x49,
+0x4e,
+0x54,
+0x4c,
+0x15,
+0x11,
+0x13,
+0x20,
+0x10,
+0x38,
+0x5c,
+0x5f,
+0x53,
+0x42,
+0x5f,
+0x5b,
+0x82,
+0x30,
+0x54,
+0x50,
+0x4d,
+0x5f,
+0x8,
+0x5f,
+0x48,
+0x49,
+0x44,
+0xc,
+0x41,
+0xd0,
+0xc,
+0x31,
+0x8,
+0x5f,
+0x43,
+0x52,
+0x53,
+0x11,
+0x11,
+0xa,
+0xe,
+0x86,
+0x9,
+0x0,
+0x1,
+0x0,
+0x0,
+0xd4,
+0xfe,
+0x0,
+0x50,
+0x0,
+0x0,
+0x79,
+0x0,
+0x14,
+0x9,
+0x5f,
+0x53,
+0x54,
+0x41,
+0x0,
+0xa4,
+0xa,
+0xf
+};
--
MST
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Qemu-devel] [PULL 07/11] pcie: Fix incorrect write to the ari capability next function field
2014-08-24 22:18 [Qemu-devel] [PULL 00/11] pci, pc fixes, features Michael S. Tsirkin
` (5 preceding siblings ...)
2014-08-24 22:18 ` [Qemu-devel] [PULL 06/11] ssdt-tpm: add generated hex file to git Michael S. Tsirkin
@ 2014-08-24 22:18 ` Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 08/11] pcie: Rename the pcie_cap_ari_* functions to pcie_cap_arifwd_* Michael S. Tsirkin
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Michael S. Tsirkin @ 2014-08-24 22:18 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Knut Omang, Anthony Liguori
From: Knut Omang <knut.omang@oracle.com>
PCI_ARI_CAP_NFN, a macro for reading next function was used instead of
the intended write.
Signed-off-by: Knut Omang <knut.omang@oracle.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/pci/pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index a123c01..de0e967 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -630,5 +630,5 @@ void pcie_ari_init(PCIDevice *dev, uint16_t offset, uint16_t nextfn)
{
pcie_add_capability(dev, PCI_EXT_CAP_ID_ARI, PCI_ARI_VER,
offset, PCI_ARI_SIZEOF);
- pci_set_long(dev->config + offset + PCI_ARI_CAP, PCI_ARI_CAP_NFN(nextfn));
+ pci_set_long(dev->config + offset + PCI_ARI_CAP, (nextfn & 0xff) << 8);
}
--
MST
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Qemu-devel] [PULL 08/11] pcie: Rename the pcie_cap_ari_* functions to pcie_cap_arifwd_*
2014-08-24 22:18 [Qemu-devel] [PULL 00/11] pci, pc fixes, features Michael S. Tsirkin
` (6 preceding siblings ...)
2014-08-24 22:18 ` [Qemu-devel] [PULL 07/11] pcie: Fix incorrect write to the ari capability next function field Michael S. Tsirkin
@ 2014-08-24 22:18 ` Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 09/11] ioh3420: Remove obsoleted, unused ioh3420_init function Michael S. Tsirkin
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Michael S. Tsirkin @ 2014-08-24 22:18 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Juan Quintela, Alexey Kardashevskiy,
Marcel Apfelbaum, Knut Omang, Anthony Liguori
From: Knut Omang <knut.omang@oracle.com>
Rename helper functions to make a clearer distinction between
the PCIe capability/control register feature ARI forwarding and a
device that supports the ARI feature via an ARI extended PCIe capability.
Signed-off-by: Knut Omang <knut.omang@oracle.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hw/pci/pcie.h | 7 ++++---
hw/pci-bridge/ioh3420.c | 1 +
hw/pci-bridge/xio3130_downstream.c | 4 ++--
hw/pci/pcie.c | 11 ++++++-----
4 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/include/hw/pci/pcie.h b/include/hw/pci/pcie.h
index 7fe81f3..d139d58 100644
--- a/include/hw/pci/pcie.h
+++ b/include/hw/pci/pcie.h
@@ -103,9 +103,10 @@ void pcie_cap_flr_init(PCIDevice *dev);
void pcie_cap_flr_write_config(PCIDevice *dev,
uint32_t addr, uint32_t val, int len);
-void pcie_cap_ari_init(PCIDevice *dev);
-void pcie_cap_ari_reset(PCIDevice *dev);
-bool pcie_cap_is_ari_enabled(const PCIDevice *dev);
+/* ARI forwarding capability and control */
+void pcie_cap_arifwd_init(PCIDevice *dev);
+void pcie_cap_arifwd_reset(PCIDevice *dev);
+bool pcie_cap_is_arifwd_enabled(const PCIDevice *dev);
/* PCI express extended capability helper functions */
uint16_t pcie_find_capability(PCIDevice *dev, uint16_t cap_id);
diff --git a/hw/pci-bridge/ioh3420.c b/hw/pci-bridge/ioh3420.c
index 7cd87fc..aed2bf1 100644
--- a/hw/pci-bridge/ioh3420.c
+++ b/hw/pci-bridge/ioh3420.c
@@ -118,6 +118,7 @@ static int ioh3420_initfn(PCIDevice *d)
if (rc < 0) {
goto err_msi;
}
+
pcie_cap_deverr_init(d);
pcie_cap_slot_init(d, s->slot);
pcie_chassis_create(s->chassis);
diff --git a/hw/pci-bridge/xio3130_downstream.c b/hw/pci-bridge/xio3130_downstream.c
index 51f20d7..b3a6479 100644
--- a/hw/pci-bridge/xio3130_downstream.c
+++ b/hw/pci-bridge/xio3130_downstream.c
@@ -50,7 +50,7 @@ static void xio3130_downstream_reset(DeviceState *qdev)
pcie_cap_deverr_reset(d);
pcie_cap_slot_reset(d);
- pcie_cap_ari_reset(d);
+ pcie_cap_arifwd_reset(d);
pci_bridge_reset(qdev);
}
@@ -91,7 +91,7 @@ static int xio3130_downstream_initfn(PCIDevice *d)
if (rc < 0) {
goto err_pcie_cap;
}
- pcie_cap_ari_init(d);
+ pcie_cap_arifwd_init(d);
rc = pcie_aer_init(d, XIO3130_AER_OFFSET);
if (rc < 0) {
goto err;
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index de0e967..6cb6e0c 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -497,9 +497,10 @@ void pcie_cap_flr_write_config(PCIDevice *dev,
}
}
-/* Alternative Routing-ID Interpretation (ARI) */
-/* ari forwarding support for down stream port */
-void pcie_cap_ari_init(PCIDevice *dev)
+/* Alternative Routing-ID Interpretation (ARI)
+ * forwarding support for root and downstream ports
+ */
+void pcie_cap_arifwd_init(PCIDevice *dev)
{
uint32_t pos = dev->exp.exp_cap;
pci_long_test_and_set_mask(dev->config + pos + PCI_EXP_DEVCAP2,
@@ -508,13 +509,13 @@ void pcie_cap_ari_init(PCIDevice *dev)
PCI_EXP_DEVCTL2_ARI);
}
-void pcie_cap_ari_reset(PCIDevice *dev)
+void pcie_cap_arifwd_reset(PCIDevice *dev)
{
uint8_t *devctl2 = dev->config + dev->exp.exp_cap + PCI_EXP_DEVCTL2;
pci_long_test_and_clear_mask(devctl2, PCI_EXP_DEVCTL2_ARI);
}
-bool pcie_cap_is_ari_enabled(const PCIDevice *dev)
+bool pcie_cap_is_arifwd_enabled(const PCIDevice *dev)
{
if (!pci_is_express(dev)) {
return false;
--
MST
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Qemu-devel] [PULL 09/11] ioh3420: Remove obsoleted, unused ioh3420_init function
2014-08-24 22:18 [Qemu-devel] [PULL 00/11] pci, pc fixes, features Michael S. Tsirkin
` (7 preceding siblings ...)
2014-08-24 22:18 ` [Qemu-devel] [PULL 08/11] pcie: Rename the pcie_cap_ari_* functions to pcie_cap_arifwd_* Michael S. Tsirkin
@ 2014-08-24 22:18 ` Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 10/11] ioh3420: Enable ARI forwarding Michael S. Tsirkin
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Michael S. Tsirkin @ 2014-08-24 22:18 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Juan Quintela, Alexey Kardashevskiy,
Marcel Apfelbaum, Knut Omang, Anthony Liguori
From: Knut Omang <knut.omang@oracle.com>
Signed-off-by: Knut Omang <knut.omang@oracle.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/pci-bridge/ioh3420.c | 24 ------------------------
1 file changed, 24 deletions(-)
diff --git a/hw/pci-bridge/ioh3420.c b/hw/pci-bridge/ioh3420.c
index aed2bf1..e6674a1 100644
--- a/hw/pci-bridge/ioh3420.c
+++ b/hw/pci-bridge/ioh3420.c
@@ -157,30 +157,6 @@ static void ioh3420_exitfn(PCIDevice *d)
pci_bridge_exitfn(d);
}
-PCIESlot *ioh3420_init(PCIBus *bus, int devfn, bool multifunction,
- const char *bus_name, pci_map_irq_fn map_irq,
- uint8_t port, uint8_t chassis, uint16_t slot)
-{
- PCIDevice *d;
- PCIBridge *br;
- DeviceState *qdev;
-
- d = pci_create_multifunction(bus, devfn, multifunction, "ioh3420");
- if (!d) {
- return NULL;
- }
- br = PCI_BRIDGE(d);
-
- qdev = DEVICE(d);
- pci_bridge_map_irq(br, bus_name, map_irq);
- qdev_prop_set_uint8(qdev, "port", port);
- qdev_prop_set_uint8(qdev, "chassis", chassis);
- qdev_prop_set_uint16(qdev, "slot", slot);
- qdev_init_nofail(qdev);
-
- return PCIE_SLOT(d);
-}
-
static Property ioh3420_props[] = {
DEFINE_PROP_BIT(COMPAT_PROP_PCP, PCIDevice, cap_present,
QEMU_PCIE_SLTCAP_PCP_BITNR, true),
--
MST
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Qemu-devel] [PULL 10/11] ioh3420: Enable ARI forwarding
2014-08-24 22:18 [Qemu-devel] [PULL 00/11] pci, pc fixes, features Michael S. Tsirkin
` (8 preceding siblings ...)
2014-08-24 22:18 ` [Qemu-devel] [PULL 09/11] ioh3420: Remove obsoleted, unused ioh3420_init function Michael S. Tsirkin
@ 2014-08-24 22:18 ` Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 11/11] pcie: fix trailing whitespace Michael S. Tsirkin
2014-08-25 18:42 ` [Qemu-devel] [PULL 00/11] pci, pc fixes, features Peter Maydell
11 siblings, 0 replies; 13+ messages in thread
From: Michael S. Tsirkin @ 2014-08-24 22:18 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Juan Quintela, Alexey Kardashevskiy,
Marcel Apfelbaum, Knut Omang, Anthony Liguori
From: Knut Omang <knut.omang@oracle.com>
Signed-off-by: Knut Omang <knut.omang@oracle.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/pci-bridge/ioh3420.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/pci-bridge/ioh3420.c b/hw/pci-bridge/ioh3420.c
index e6674a1..cce2fdd 100644
--- a/hw/pci-bridge/ioh3420.c
+++ b/hw/pci-bridge/ioh3420.c
@@ -85,6 +85,7 @@ static void ioh3420_reset(DeviceState *qdev)
pcie_cap_root_reset(d);
pcie_cap_deverr_reset(d);
pcie_cap_slot_reset(d);
+ pcie_cap_arifwd_reset(d);
pcie_aer_root_reset(d);
pci_bridge_reset(qdev);
pci_bridge_disable_base_limit(d);
@@ -119,6 +120,7 @@ static int ioh3420_initfn(PCIDevice *d)
goto err_msi;
}
+ pcie_cap_arifwd_init(d);
pcie_cap_deverr_init(d);
pcie_cap_slot_init(d, s->slot);
pcie_chassis_create(s->chassis);
--
MST
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Qemu-devel] [PULL 11/11] pcie: fix trailing whitespace
2014-08-24 22:18 [Qemu-devel] [PULL 00/11] pci, pc fixes, features Michael S. Tsirkin
` (9 preceding siblings ...)
2014-08-24 22:18 ` [Qemu-devel] [PULL 10/11] ioh3420: Enable ARI forwarding Michael S. Tsirkin
@ 2014-08-24 22:18 ` Michael S. Tsirkin
2014-08-25 18:42 ` [Qemu-devel] [PULL 00/11] pci, pc fixes, features Peter Maydell
11 siblings, 0 replies; 13+ messages in thread
From: Michael S. Tsirkin @ 2014-08-24 22:18 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Anthony Liguori
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/pci/pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 6cb6e0c..1babddf 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -498,7 +498,7 @@ void pcie_cap_flr_write_config(PCIDevice *dev,
}
/* Alternative Routing-ID Interpretation (ARI)
- * forwarding support for root and downstream ports
+ * forwarding support for root and downstream ports
*/
void pcie_cap_arifwd_init(PCIDevice *dev)
{
--
MST
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [PULL 00/11] pci, pc fixes, features
2014-08-24 22:18 [Qemu-devel] [PULL 00/11] pci, pc fixes, features Michael S. Tsirkin
` (10 preceding siblings ...)
2014-08-24 22:18 ` [Qemu-devel] [PULL 11/11] pcie: fix trailing whitespace Michael S. Tsirkin
@ 2014-08-25 18:42 ` Peter Maydell
11 siblings, 0 replies; 13+ messages in thread
From: Peter Maydell @ 2014-08-25 18:42 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: QEMU Developers, Anthony Liguori
On 24 August 2014 23:18, Michael S. Tsirkin <mst@redhat.com> wrote:
> The following changes since commit 2656eb7c599e306b95bad82b1372fc49ba3088f6:
>
> Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20140819' into staging (2014-08-20 09:55:42 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
>
> for you to fetch changes up to 187de915e8d06aaf82be206aebc551c82bf0670c:
>
> pcie: fix trailing whitespace (2014-08-25 00:16:07 +0200)
>
> ----------------------------------------------------------------
> pci, pc fixes, features
>
> A bunch of bugfixes - these will make sense for 2.1.1
>
> ACPI support for TPM and partial ARI support for PCIE.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> ----------------------------------------------------------------
Applied, thanks.
-- PMM
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2014-08-25 18:43 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-24 22:18 [Qemu-devel] [PULL 00/11] pci, pc fixes, features Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 01/11] hostmem: set MPOL_MF_MOVE Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 02/11] pci_bridge: manually destroy memory regions within PCIBridgeWindows Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 03/11] pcihp: fix possible array out of bounds Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 04/11] pc: reserve more memory for ACPI for new machine types Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 05/11] Add ACPI tables for TPM Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 06/11] ssdt-tpm: add generated hex file to git Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 07/11] pcie: Fix incorrect write to the ari capability next function field Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 08/11] pcie: Rename the pcie_cap_ari_* functions to pcie_cap_arifwd_* Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 09/11] ioh3420: Remove obsoleted, unused ioh3420_init function Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 10/11] ioh3420: Enable ARI forwarding Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 11/11] pcie: fix trailing whitespace Michael S. Tsirkin
2014-08-25 18:42 ` [Qemu-devel] [PULL 00/11] pci, pc fixes, features Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.