All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] emulator/btdev: Fix not disabling le advertising on connection
@ 2014-08-25 11:08 Jakub Tyszkowski
  2014-08-28  9:03 ` Tyszkowski Jakub
  2014-09-01 12:18 ` Johan Hedberg
  0 siblings, 2 replies; 3+ messages in thread
From: Jakub Tyszkowski @ 2014-08-25 11:08 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Jakub Tyszkowski

Le Advertising should be disabled after the le connection is
established (Core Spec. 4.1 - Part E, Sec. 7.8.9). Not doing so
results in errors while switching advertisement multiple times during
different connection states.
---
 emulator/btdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/emulator/btdev.c b/emulator/btdev.c
index b09f8cb..86fd3d9 100644
--- a/emulator/btdev.c
+++ b/emulator/btdev.c
@@ -1023,6 +1023,7 @@ static void le_conn_complete(struct btdev *btdev,
 
 		btdev->conn = remote;
 		remote->conn = btdev;
+		remote->le_adv_enable = 0;
 
 		cc->status = status;
 		cc->peer_addr_type = btdev->le_scan_own_addr_type;
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] emulator/btdev: Fix not disabling le advertising on connection
  2014-08-25 11:08 [PATCH] emulator/btdev: Fix not disabling le advertising on connection Jakub Tyszkowski
@ 2014-08-28  9:03 ` Tyszkowski Jakub
  2014-09-01 12:18 ` Johan Hedberg
  1 sibling, 0 replies; 3+ messages in thread
From: Tyszkowski Jakub @ 2014-08-28  9:03 UTC (permalink / raw)
  To: linux-bluetooth

On 08/25/2014 01:08 PM, Jakub Tyszkowski wrote:
> Le Advertising should be disabled after the le connection is
> established (Core Spec. 4.1 - Part E, Sec. 7.8.9). Not doing so
> results in errors while switching advertisement multiple times during
> different connection states.
> ---
>   emulator/btdev.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/emulator/btdev.c b/emulator/btdev.c
> index b09f8cb..86fd3d9 100644
> --- a/emulator/btdev.c
> +++ b/emulator/btdev.c
> @@ -1023,6 +1023,7 @@ static void le_conn_complete(struct btdev *btdev,
>
>   		btdev->conn = remote;
>   		remote->conn = btdev;
> +		remote->le_adv_enable = 0;
>
>   		cc->status = status;
>   		cc->peer_addr_type = btdev->le_scan_own_addr_type;
>
  ping

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] emulator/btdev: Fix not disabling le advertising on connection
  2014-08-25 11:08 [PATCH] emulator/btdev: Fix not disabling le advertising on connection Jakub Tyszkowski
  2014-08-28  9:03 ` Tyszkowski Jakub
@ 2014-09-01 12:18 ` Johan Hedberg
  1 sibling, 0 replies; 3+ messages in thread
From: Johan Hedberg @ 2014-09-01 12:18 UTC (permalink / raw)
  To: Jakub Tyszkowski; +Cc: linux-bluetooth

Hi Jakub,

On Mon, Aug 25, 2014, Jakub Tyszkowski wrote:
> Le Advertising should be disabled after the le connection is
> established (Core Spec. 4.1 - Part E, Sec. 7.8.9). Not doing so
> results in errors while switching advertisement multiple times during
> different connection states.
> ---
>  emulator/btdev.c | 1 +
>  1 file changed, 1 insertion(+)

Applied. Thanks.

Johan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-09-01 12:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-25 11:08 [PATCH] emulator/btdev: Fix not disabling le advertising on connection Jakub Tyszkowski
2014-08-28  9:03 ` Tyszkowski Jakub
2014-09-01 12:18 ` Johan Hedberg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.