All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Lübbe" <jlu@pengutronix.de>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: "Joe.C" <srv_yingjoe.chen@mediatek.com>,
	Mark Rutland <Mark.Rutland@arm.com>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"yingjoe.chen@gmail.com" <yingjoe.chen@gmail.com>,
	Russell King <linux@arm.linux.org.uk>,
	Arnd Bergmann <arnd@arndb.de>,
	"yh.chen@mediatek.com" <yh.chen@mediatek.com>,
	"nathan.chung@mediatek.com" <nathan.chung@mediatek.com>,
	"Joe.C" <yingjoe.chen@mediatek.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Jason Cooper <jason@lakedaemon.net>,
	Pawel Moll <Pawel.Moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"eddie.huang@mediatek.com" <eddie.huang@mediatek.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"srv_heupstream@mediatek.com" <srv_heupstream@mediatek.com>,
	"hc.yen@mediatek.com" <hc.yen@mediatek.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jonas Jensen <jonas.jensen@gmail.com>,
	Kumar Gala <galak@codeaurora.org>,
	Olof Johansson <olof@lixom.net>
Subject: Re: [RESEND PATCH v2 1/4] irqchip: gic: Change irq type check when extension is present
Date: Wed, 27 Aug 2014 11:55:44 +0200	[thread overview]
Message-ID: <1409133344.25382.37.camel@coredoba.hi.pengutronix.de> (raw)
In-Reply-To: <53F724F5.3040004@arm.com>

Marc,

On Fri, 2014-08-22 at 12:09 +0100, Marc Zyngier wrote:
> Here, you're using it to program something that sits between the
> device and the GIC. This is a separate block, with its own hardware
> configuration, that modifies the interrupt signal. This should be
> reflected in the device-tree and the code paths.
> 
> You can probably model this as a separate irqchip for the few
> interrupts that require this, or have it configured at boot time
> (assuming the configuration never changes).

It seems to me that using a separate irqchip for a simple inverter would
add the run-time overhead of passing through wrapper functions on every
IRQ. Do you have an idea how this could be avoided without using the
gic_arch_extn feature?

As in the DT the actual IRQ polarity should be used, simply configuring
the HW IRQ polarity in the bootloader is not enough without telling the
GIC driver which polarity is supported on which IRQ, right?

Regards,
Jan
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |


WARNING: multiple messages have this Message-ID (diff)
From: "Jan Lübbe" <jlu@pengutronix.de>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: "Joe.C" <srv_yingjoe.chen@mediatek.com>,
	Mark Rutland <Mark.Rutland@arm.com>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"yingjoe.chen@gmail.com" <yingjoe.chen@gmail.com>,
	Russell King <linux@arm.linux.org.uk>,
	Arnd Bergmann <arnd@arndb.de>,
	"yh.chen@mediatek.com" <yh.chen@mediatek.com>,
	"nathan.chung@mediatek.com" <nathan.chung@mediatek.com>"Joe.C"
	<yingjoe.chen@mediatek.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Jason Cooper <jason@lakedaemon.net>,
	Pawel Moll <Pawel.Moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"eddie.huang@mediatek.com" <eddie.huang@mediatek.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"srv_heupstream@mediatek.com" <srv_heupstream@mediatek.>
Subject: Re: [RESEND PATCH v2 1/4] irqchip: gic: Change irq type check when extension is present
Date: Wed, 27 Aug 2014 11:55:44 +0200	[thread overview]
Message-ID: <1409133344.25382.37.camel@coredoba.hi.pengutronix.de> (raw)
In-Reply-To: <53F724F5.3040004@arm.com>

Marc,

On Fri, 2014-08-22 at 12:09 +0100, Marc Zyngier wrote:
> Here, you're using it to program something that sits between the
> device and the GIC. This is a separate block, with its own hardware
> configuration, that modifies the interrupt signal. This should be
> reflected in the device-tree and the code paths.
> 
> You can probably model this as a separate irqchip for the few
> interrupts that require this, or have it configured at boot time
> (assuming the configuration never changes).

It seems to me that using a separate irqchip for a simple inverter would
add the run-time overhead of passing through wrapper functions on every
IRQ. Do you have an idea how this could be avoided without using the
gic_arch_extn feature?

As in the DT the actual IRQ polarity should be used, simply configuring
the HW IRQ polarity in the bootloader is not enough without telling the
GIC driver which polarity is supported on which IRQ, right?

Regards,
Jan
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |


WARNING: multiple messages have this Message-ID (diff)
From: jlu@pengutronix.de (Jan Lübbe)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v2 1/4] irqchip: gic: Change irq type check when extension is present
Date: Wed, 27 Aug 2014 11:55:44 +0200	[thread overview]
Message-ID: <1409133344.25382.37.camel@coredoba.hi.pengutronix.de> (raw)
In-Reply-To: <53F724F5.3040004@arm.com>

Marc,

On Fri, 2014-08-22 at 12:09 +0100, Marc Zyngier wrote:
> Here, you're using it to program something that sits between the
> device and the GIC. This is a separate block, with its own hardware
> configuration, that modifies the interrupt signal. This should be
> reflected in the device-tree and the code paths.
> 
> You can probably model this as a separate irqchip for the few
> interrupts that require this, or have it configured at boot time
> (assuming the configuration never changes).

It seems to me that using a separate irqchip for a simple inverter would
add the run-time overhead of passing through wrapper functions on every
IRQ. Do you have an idea how this could be avoided without using the
gic_arch_extn feature?

As in the DT the actual IRQ polarity should be used, simply configuring
the HW IRQ polarity in the bootloader is not enough without telling the
GIC driver which polarity is supported on which IRQ, right?

Regards,
Jan
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  parent reply	other threads:[~2014-08-27  9:57 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-13  2:11 [RESEND PATCH v2 0/4] arm: mediatek: Add support for GIC interrupt polarity extension Joe.C
2014-08-13  2:11 ` Joe.C
2014-08-13  2:11 ` [RESEND PATCH v2 1/4] irqchip: gic: Change irq type check when extension is present Joe.C
2014-08-13  2:11   ` Joe.C
2014-08-22 11:09   ` Marc Zyngier
2014-08-22 11:09     ` Marc Zyngier
2014-08-22 11:09     ` Marc Zyngier
2014-08-23  5:28     ` Joe.C
2014-08-23  5:28       ` Joe.C
2014-08-27  9:55     ` Jan Lübbe [this message]
2014-08-27  9:55       ` Jan Lübbe
2014-08-27  9:55       ` Jan Lübbe
2014-08-27 10:36       ` Marc Zyngier
2014-08-27 10:36         ` Marc Zyngier
2014-08-27 10:36         ` Marc Zyngier
2014-08-27 12:23         ` Thomas Gleixner
2014-08-27 12:23           ` Thomas Gleixner
2014-08-27 12:23           ` Thomas Gleixner
2014-08-27 13:37           ` Marc Zyngier
2014-08-27 13:37             ` Marc Zyngier
2014-08-27 14:03             ` Thomas Gleixner
2014-08-27 14:03               ` Thomas Gleixner
2014-08-27 14:03               ` Thomas Gleixner
2014-08-27 14:29             ` Mark Rutland
2014-08-27 14:29               ` Mark Rutland
2014-08-27 14:29               ` Mark Rutland
2014-08-27 15:22               ` Thomas Gleixner
2014-08-27 15:22                 ` Thomas Gleixner
2014-08-27 15:22                 ` Thomas Gleixner
2014-08-13  2:11 ` [RESEND PATCH v2 2/4] arm: mediatek: Add support for GIC interrupt polarity extension Joe.C
2014-08-13  2:11   ` Joe.C
2014-08-13  2:11 ` [RESEND PATCH v2 3/4] arm: mediatek: Add intpol in mt6589.dtsi Joe.C
2014-08-13  2:11   ` Joe.C
2014-08-13  2:11 ` [RESEND PATCH v2 4/4] dt-bindings: add bindings for mediatek intpol Joe.C
2014-08-13  2:11   ` Joe.C
2014-08-21 15:02   ` Matthias Brugger
2014-08-21 15:02     ` Matthias Brugger
2014-08-21 15:02     ` Matthias Brugger
2014-08-22  8:39     ` Joe.C
2014-08-22  8:39       ` Joe.C
2014-08-22  9:23 ` [RESEND PATCH v2 0/4] arm: mediatek: Add support for GIC interrupt polarity extension Joe.C
2014-08-22  9:23   ` Joe.C

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409133344.25382.37.camel@coredoba.hi.pengutronix.de \
    --to=jlu@pengutronix.de \
    --cc=Mark.Rutland@arm.com \
    --cc=Pawel.Moll@arm.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=eddie.huang@mediatek.com \
    --cc=galak@codeaurora.org \
    --cc=hc.yen@mediatek.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jason@lakedaemon.net \
    --cc=jonas.jensen@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=marc.zyngier@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=nathan.chung@mediatek.com \
    --cc=olof@lixom.net \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    --cc=srv_yingjoe.chen@mediatek.com \
    --cc=tglx@linutronix.de \
    --cc=yh.chen@mediatek.com \
    --cc=yingjoe.chen@gmail.com \
    --cc=yingjoe.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.