All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/11] [WIP] ARM: shmobile: armadillo800eva legacy: Add missing A3SP pm domain devices
Date: Fri, 29 Aug 2014 13:50:09 +0000	[thread overview]
Message-ID: <1409320217-13278-4-git-send-email-geert+renesas@glider.be> (raw)
In-Reply-To: <1409320217-13278-1-git-send-email-geert+renesas@glider.be>

Commit 802a5639aa7041b2 ("ARM: shmobile: r8a7740: add A3SP pm domain
support") added the A3SP power domain, but forgot to hook up the TPU,
SDHI0/1, and MMCIF hardware blocks.

FIXME: As the default PM QoS latency constraint for SDHI is only 100 µs
       (cfr. commit c419e611c3c59c0e ("tmio_mmc / PM: Use PM QoS latency
       constraint"), while DEFAULT_DEV_LATENCY_NS is 250000, suspend
       fails with -EBUSY, unless the constraint is increased first to
       more than 500 µs using e.g.

	echo 501 > /sys/devices/platform/sh_mobile_sdhi.0/power/pm_qos_resume_latency_us

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/mach-shmobile/board-armadillo800eva.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c b/arch/arm/mach-shmobile/board-armadillo800eva.c
index f19459a8c3ed..64a68450c28a 100644
--- a/arch/arm/mach-shmobile/board-armadillo800eva.c
+++ b/arch/arm/mach-shmobile/board-armadillo800eva.c
@@ -1234,8 +1234,11 @@ static void __init eva_init(void)
 	static struct pm_domain_device domain_devices[] __initdata = {
 		{ "A4LC", &lcdc0_device },
 		{ "A4LC", &hdmi_lcdc_device },
+		{ "A3SP", &pwm_device },
+		{ "A3SP", &sdhi0_device },
+		{ "A3SP", &sh_mmcif_device },
 	};
-	struct platform_device *usb = NULL;
+	struct platform_device *usb = NULL, *sdhi1 = NULL;
 
 	regulator_register_always_on(0, "fixed-3.3V", fixed3v3_power_consumers,
 				     ARRAY_SIZE(fixed3v3_power_consumers), 3300000);
@@ -1304,6 +1307,7 @@ static void __init eva_init(void)
 
 		platform_device_register(&vcc_sdhi1);
 		platform_device_register(&sdhi1_device);
+		sdhi1 = &sdhi1_device;
 	}
 
 
@@ -1324,6 +1328,8 @@ static void __init eva_init(void)
 				       ARRAY_SIZE(domain_devices));
 	if (usb)
 		rmobile_add_device_to_domain("A3SP", usb);
+	if (sdhi1)
+		rmobile_add_device_to_domain("A3SP", sdhi1);
 
 	r8a7740_pm_init();
 }
-- 
1.7.9.5


WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Simon Horman <horms@verge.net.au>, Magnus Damm <magnus.damm@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-sh@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH 03/11] [WIP] ARM: shmobile: armadillo800eva legacy: Add missing A3SP pm domain devices
Date: Fri, 29 Aug 2014 15:50:09 +0200	[thread overview]
Message-ID: <1409320217-13278-4-git-send-email-geert+renesas@glider.be> (raw)
In-Reply-To: <1409320217-13278-1-git-send-email-geert+renesas@glider.be>

Commit 802a5639aa7041b2 ("ARM: shmobile: r8a7740: add A3SP pm domain
support") added the A3SP power domain, but forgot to hook up the TPU,
SDHI0/1, and MMCIF hardware blocks.

FIXME: As the default PM QoS latency constraint for SDHI is only 100 µs
       (cfr. commit c419e611c3c59c0e ("tmio_mmc / PM: Use PM QoS latency
       constraint"), while DEFAULT_DEV_LATENCY_NS is 250000, suspend
       fails with -EBUSY, unless the constraint is increased first to
       more than 500 µs using e.g.

	echo 501 > /sys/devices/platform/sh_mobile_sdhi.0/power/pm_qos_resume_latency_us

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/mach-shmobile/board-armadillo800eva.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c b/arch/arm/mach-shmobile/board-armadillo800eva.c
index f19459a8c3ed..64a68450c28a 100644
--- a/arch/arm/mach-shmobile/board-armadillo800eva.c
+++ b/arch/arm/mach-shmobile/board-armadillo800eva.c
@@ -1234,8 +1234,11 @@ static void __init eva_init(void)
 	static struct pm_domain_device domain_devices[] __initdata = {
 		{ "A4LC", &lcdc0_device },
 		{ "A4LC", &hdmi_lcdc_device },
+		{ "A3SP", &pwm_device },
+		{ "A3SP", &sdhi0_device },
+		{ "A3SP", &sh_mmcif_device },
 	};
-	struct platform_device *usb = NULL;
+	struct platform_device *usb = NULL, *sdhi1 = NULL;
 
 	regulator_register_always_on(0, "fixed-3.3V", fixed3v3_power_consumers,
 				     ARRAY_SIZE(fixed3v3_power_consumers), 3300000);
@@ -1304,6 +1307,7 @@ static void __init eva_init(void)
 
 		platform_device_register(&vcc_sdhi1);
 		platform_device_register(&sdhi1_device);
+		sdhi1 = &sdhi1_device;
 	}
 
 
@@ -1324,6 +1328,8 @@ static void __init eva_init(void)
 				       ARRAY_SIZE(domain_devices));
 	if (usb)
 		rmobile_add_device_to_domain("A3SP", usb);
+	if (sdhi1)
+		rmobile_add_device_to_domain("A3SP", sdhi1);
 
 	r8a7740_pm_init();
 }
-- 
1.7.9.5


WARNING: multiple messages have this Message-ID (diff)
From: geert+renesas@glider.be (Geert Uytterhoeven)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/11] [WIP] ARM: shmobile: armadillo800eva legacy: Add missing A3SP pm domain devices
Date: Fri, 29 Aug 2014 15:50:09 +0200	[thread overview]
Message-ID: <1409320217-13278-4-git-send-email-geert+renesas@glider.be> (raw)
In-Reply-To: <1409320217-13278-1-git-send-email-geert+renesas@glider.be>

Commit 802a5639aa7041b2 ("ARM: shmobile: r8a7740: add A3SP pm domain
support") added the A3SP power domain, but forgot to hook up the TPU,
SDHI0/1, and MMCIF hardware blocks.

FIXME: As the default PM QoS latency constraint for SDHI is only 100 ?s
       (cfr. commit c419e611c3c59c0e ("tmio_mmc / PM: Use PM QoS latency
       constraint"), while DEFAULT_DEV_LATENCY_NS is 250000, suspend
       fails with -EBUSY, unless the constraint is increased first to
       more than 500 ?s using e.g.

	echo 501 > /sys/devices/platform/sh_mobile_sdhi.0/power/pm_qos_resume_latency_us

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/mach-shmobile/board-armadillo800eva.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c b/arch/arm/mach-shmobile/board-armadillo800eva.c
index f19459a8c3ed..64a68450c28a 100644
--- a/arch/arm/mach-shmobile/board-armadillo800eva.c
+++ b/arch/arm/mach-shmobile/board-armadillo800eva.c
@@ -1234,8 +1234,11 @@ static void __init eva_init(void)
 	static struct pm_domain_device domain_devices[] __initdata = {
 		{ "A4LC", &lcdc0_device },
 		{ "A4LC", &hdmi_lcdc_device },
+		{ "A3SP", &pwm_device },
+		{ "A3SP", &sdhi0_device },
+		{ "A3SP", &sh_mmcif_device },
 	};
-	struct platform_device *usb = NULL;
+	struct platform_device *usb = NULL, *sdhi1 = NULL;
 
 	regulator_register_always_on(0, "fixed-3.3V", fixed3v3_power_consumers,
 				     ARRAY_SIZE(fixed3v3_power_consumers), 3300000);
@@ -1304,6 +1307,7 @@ static void __init eva_init(void)
 
 		platform_device_register(&vcc_sdhi1);
 		platform_device_register(&sdhi1_device);
+		sdhi1 = &sdhi1_device;
 	}
 
 
@@ -1324,6 +1328,8 @@ static void __init eva_init(void)
 				       ARRAY_SIZE(domain_devices));
 	if (usb)
 		rmobile_add_device_to_domain("A3SP", usb);
+	if (sdhi1)
+		rmobile_add_device_to_domain("A3SP", sdhi1);
 
 	r8a7740_pm_init();
 }
-- 
1.7.9.5

  parent reply	other threads:[~2014-08-29 13:50 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-29 13:50 [PATCH 00/11] ARM: shmobile: r8a7740/armadillo legacy prototype pm domain support Geert Uytterhoeven
2014-08-29 13:50 ` Geert Uytterhoeven
2014-08-29 13:50 ` Geert Uytterhoeven
2014-08-29 13:50 ` [PATCH 01/11] ARM: shmobile: r8a7740: Add missing A3SP pm domain devices Geert Uytterhoeven
2014-08-29 13:50   ` Geert Uytterhoeven
2014-08-29 13:50   ` Geert Uytterhoeven
2014-08-29 13:50 ` [PATCH 02/11] ARM: shmobile: r8a7740: Add missing A4S " Geert Uytterhoeven
2014-08-29 13:50   ` Geert Uytterhoeven
2014-08-29 13:50   ` Geert Uytterhoeven
2014-08-29 13:50 ` Geert Uytterhoeven [this message]
2014-08-29 13:50   ` [PATCH 03/11] [WIP] ARM: shmobile: armadillo800eva legacy: Add missing A3SP " Geert Uytterhoeven
2014-08-29 13:50   ` Geert Uytterhoeven
2014-08-29 13:50 ` [PATCH 04/11] ARM: shmobile: armadillo800eva legacy: Add missing A4S " Geert Uytterhoeven
2014-08-29 13:50   ` Geert Uytterhoeven
2014-08-29 13:50   ` Geert Uytterhoeven
2014-08-29 13:50 ` [PATCH 05/11] ARM: shmobile: r8a7740: Add A3RV pm domain support Geert Uytterhoeven
2014-08-29 13:50   ` Geert Uytterhoeven
2014-08-29 13:50   ` Geert Uytterhoeven
2014-08-29 13:50 ` [PATCH 06/11] ARM: shmobile: r8a7740: Add A3SG " Geert Uytterhoeven
2014-08-29 13:50   ` Geert Uytterhoeven
2014-08-29 13:50   ` Geert Uytterhoeven
2014-08-29 13:50 ` [PATCH 07/11] [WIP] ARM: shmobile: r8a7740/armadillo legacy: Add A4MP " Geert Uytterhoeven
2014-08-29 13:50   ` Geert Uytterhoeven
2014-08-29 13:50   ` Geert Uytterhoeven
2014-08-29 13:50 ` [PATCH 08/11] [WIP] ARM: shmobile: r8a7740: Add D4 " Geert Uytterhoeven
2014-08-29 13:50   ` Geert Uytterhoeven
2014-08-29 13:50   ` Geert Uytterhoeven
2014-08-29 13:50 ` [PATCH 09/11] ARM: shmobile: r8a7740/armadillo legacy: Add A4R " Geert Uytterhoeven
2014-08-29 13:50   ` Geert Uytterhoeven
2014-08-29 13:50   ` Geert Uytterhoeven
2014-08-29 13:50 ` [PATCH 10/11] [WIP] ARM: shmobile: r8a7740: Add A4SU " Geert Uytterhoeven
2014-08-29 13:50   ` Geert Uytterhoeven
2014-08-29 13:50   ` Geert Uytterhoeven
2014-08-29 13:50 ` [PATCH 11/11] [WIP] ARM: shmobile: r8a7740: Add A3SM " Geert Uytterhoeven
2014-08-29 13:50   ` Geert Uytterhoeven
2014-08-29 13:50   ` Geert Uytterhoeven
2014-09-09  2:26 ` [PATCH 00/11] ARM: shmobile: r8a7740/armadillo legacy prototype " Simon Horman
2014-09-09  2:26   ` Simon Horman
2014-09-09  2:26   ` Simon Horman
2014-09-09  9:48   ` Geert Uytterhoeven
2014-09-09  9:48     ` Geert Uytterhoeven
2014-09-09  9:48     ` Geert Uytterhoeven
2014-09-11  0:22     ` Simon Horman
2014-09-11  0:22       ` Simon Horman
2014-09-11  0:22       ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409320217-13278-4-git-send-email-geert+renesas@glider.be \
    --to=geert+renesas@glider.be \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.