* [PATCH] xfstests: remove check_scratch_fs in btrfs/012
@ 2014-09-03 3:25 ` Liu Bo
0 siblings, 0 replies; 6+ messages in thread
From: Liu Bo @ 2014-09-03 3:25 UTC (permalink / raw)
To: xfs; +Cc: linux-btrfs
From: Liu Bo <liub.liubo@gmail.com>
btrfs/012 is a case to verify btrfs-convert feature, it converts an ext4 to
btrfs firstly and do something, then rolls back to ext4.
So at last we have a ext4 on the scratch device, but setting _require_scratch
will force a btrfsck on a ext4 fs because $FSTYP here is btrfs, and it ends up
with a failure report of _check_btrfs_filesystem.
Now that we have deliberately check the final ext4 fs in btrfs/012, just do not
set _require_scratch in this case.
Signed-off-by: Liu Bo <liub.liubo@gmail.com>
---
tests/btrfs/012 | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/btrfs/012 b/tests/btrfs/012
index f7e5da5..12f6462 100755
--- a/tests/btrfs/012
+++ b/tests/btrfs/012
@@ -52,7 +52,6 @@ _cleanup()
# Modify as appropriate.
_supported_fs btrfs
_supported_os Linux
-_require_scratch
BTRFS_CONVERT_PROG="`set_prog_path btrfs-convert`"
MKFS_EXT4_PROG="`set_prog_path mkfs.ext4`"
--
1.8.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] xfstests: remove check_scratch_fs in btrfs/012
@ 2014-09-03 3:25 ` Liu Bo
0 siblings, 0 replies; 6+ messages in thread
From: Liu Bo @ 2014-09-03 3:25 UTC (permalink / raw)
To: xfs; +Cc: linux-btrfs
From: Liu Bo <liub.liubo@gmail.com>
btrfs/012 is a case to verify btrfs-convert feature, it converts an ext4 to
btrfs firstly and do something, then rolls back to ext4.
So at last we have a ext4 on the scratch device, but setting _require_scratch
will force a btrfsck on a ext4 fs because $FSTYP here is btrfs, and it ends up
with a failure report of _check_btrfs_filesystem.
Now that we have deliberately check the final ext4 fs in btrfs/012, just do not
set _require_scratch in this case.
Signed-off-by: Liu Bo <liub.liubo@gmail.com>
---
tests/btrfs/012 | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/btrfs/012 b/tests/btrfs/012
index f7e5da5..12f6462 100755
--- a/tests/btrfs/012
+++ b/tests/btrfs/012
@@ -52,7 +52,6 @@ _cleanup()
# Modify as appropriate.
_supported_fs btrfs
_supported_os Linux
-_require_scratch
BTRFS_CONVERT_PROG="`set_prog_path btrfs-convert`"
MKFS_EXT4_PROG="`set_prog_path mkfs.ext4`"
--
1.8.1.4
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] xfstests: remove check_scratch_fs in btrfs/012
2014-09-03 3:25 ` Liu Bo
@ 2014-09-19 6:37 ` Eryu Guan
-1 siblings, 0 replies; 6+ messages in thread
From: Eryu Guan @ 2014-09-19 6:37 UTC (permalink / raw)
To: Liu Bo; +Cc: xfs, linux-btrfs
On Wed, Sep 03, 2014 at 11:25:59AM +0800, Liu Bo wrote:
> From: Liu Bo <liub.liubo@gmail.com>
>
> btrfs/012 is a case to verify btrfs-convert feature, it converts an ext4 to
> btrfs firstly and do something, then rolls back to ext4.
>
> So at last we have a ext4 on the scratch device, but setting _require_scratch
> will force a btrfsck on a ext4 fs because $FSTYP here is btrfs, and it ends up
> with a failure report of _check_btrfs_filesystem.
>
> Now that we have deliberately check the final ext4 fs in btrfs/012, just do not
> set _require_scratch in this case.
>
> Signed-off-by: Liu Bo <liub.liubo@gmail.com>
> ---
> tests/btrfs/012 | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/btrfs/012 b/tests/btrfs/012
> index f7e5da5..12f6462 100755
> --- a/tests/btrfs/012
> +++ b/tests/btrfs/012
> @@ -52,7 +52,6 @@ _cleanup()
> # Modify as appropriate.
> _supported_fs btrfs
> _supported_os Linux
> -_require_scratch
The test still requires a scratch device, so we cannot simply remove
this line. Now we can use _require_scratch_nocheck helper, and it
works fine based on my test.
Thanks,
Eryu
>
> BTRFS_CONVERT_PROG="`set_prog_path btrfs-convert`"
> MKFS_EXT4_PROG="`set_prog_path mkfs.ext4`"
> --
> 1.8.1.4
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfstests: remove check_scratch_fs in btrfs/012
@ 2014-09-19 6:37 ` Eryu Guan
0 siblings, 0 replies; 6+ messages in thread
From: Eryu Guan @ 2014-09-19 6:37 UTC (permalink / raw)
To: Liu Bo; +Cc: linux-btrfs, xfs
On Wed, Sep 03, 2014 at 11:25:59AM +0800, Liu Bo wrote:
> From: Liu Bo <liub.liubo@gmail.com>
>
> btrfs/012 is a case to verify btrfs-convert feature, it converts an ext4 to
> btrfs firstly and do something, then rolls back to ext4.
>
> So at last we have a ext4 on the scratch device, but setting _require_scratch
> will force a btrfsck on a ext4 fs because $FSTYP here is btrfs, and it ends up
> with a failure report of _check_btrfs_filesystem.
>
> Now that we have deliberately check the final ext4 fs in btrfs/012, just do not
> set _require_scratch in this case.
>
> Signed-off-by: Liu Bo <liub.liubo@gmail.com>
> ---
> tests/btrfs/012 | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/btrfs/012 b/tests/btrfs/012
> index f7e5da5..12f6462 100755
> --- a/tests/btrfs/012
> +++ b/tests/btrfs/012
> @@ -52,7 +52,6 @@ _cleanup()
> # Modify as appropriate.
> _supported_fs btrfs
> _supported_os Linux
> -_require_scratch
The test still requires a scratch device, so we cannot simply remove
this line. Now we can use _require_scratch_nocheck helper, and it
works fine based on my test.
Thanks,
Eryu
>
> BTRFS_CONVERT_PROG="`set_prog_path btrfs-convert`"
> MKFS_EXT4_PROG="`set_prog_path mkfs.ext4`"
> --
> 1.8.1.4
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfstests: remove check_scratch_fs in btrfs/012
2014-09-03 3:25 ` Liu Bo
@ 2014-09-19 15:02 ` Josef Bacik
-1 siblings, 0 replies; 6+ messages in thread
From: Josef Bacik @ 2014-09-19 15:02 UTC (permalink / raw)
To: Liu Bo, xfs; +Cc: linux-btrfs
On 09/02/2014 11:25 PM, Liu Bo wrote:
> From: Liu Bo <liub.liubo@gmail.com>
>
> btrfs/012 is a case to verify btrfs-convert feature, it converts an ext4 to
> btrfs firstly and do something, then rolls back to ext4.
>
> So at last we have a ext4 on the scratch device, but setting _require_scratch
> will force a btrfsck on a ext4 fs because $FSTYP here is btrfs, and it ends up
> with a failure report of _check_btrfs_filesystem.
>
> Now that we have deliberately check the final ext4 fs in btrfs/012, just do not
> set _require_scratch in this case.
>
> Signed-off-by: Liu Bo <liub.liubo@gmail.com>
I sent a patch for this already, it's on the fs-tests list. Thanks,
Josef
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfstests: remove check_scratch_fs in btrfs/012
@ 2014-09-19 15:02 ` Josef Bacik
0 siblings, 0 replies; 6+ messages in thread
From: Josef Bacik @ 2014-09-19 15:02 UTC (permalink / raw)
To: Liu Bo, xfs; +Cc: linux-btrfs
On 09/02/2014 11:25 PM, Liu Bo wrote:
> From: Liu Bo <liub.liubo@gmail.com>
>
> btrfs/012 is a case to verify btrfs-convert feature, it converts an ext4 to
> btrfs firstly and do something, then rolls back to ext4.
>
> So at last we have a ext4 on the scratch device, but setting _require_scratch
> will force a btrfsck on a ext4 fs because $FSTYP here is btrfs, and it ends up
> with a failure report of _check_btrfs_filesystem.
>
> Now that we have deliberately check the final ext4 fs in btrfs/012, just do not
> set _require_scratch in this case.
>
> Signed-off-by: Liu Bo <liub.liubo@gmail.com>
I sent a patch for this already, it's on the fs-tests list. Thanks,
Josef
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-09-19 15:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-03 3:25 [PATCH] xfstests: remove check_scratch_fs in btrfs/012 Liu Bo
2014-09-03 3:25 ` Liu Bo
2014-09-19 6:37 ` Eryu Guan
2014-09-19 6:37 ` Eryu Guan
2014-09-19 15:02 ` Josef Bacik
2014-09-19 15:02 ` Josef Bacik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.