All of lore.kernel.org
 help / color / mirror / Atom feed
* [tisdk-build-scripts][PATCH 1/2] run-opentest: only pass u-boot and spl/uart when enabled in config
@ 2014-09-08 19:48 Denys Dmytriyenko
  2014-09-08 19:48 ` [tisdk-build-scripts][PATCH 2/2] test-files: disable Qt4 specific test cases, may add Qt5 in the future Denys Dmytriyenko
  2014-09-08 21:39 ` [tisdk-build-scripts][PATCH 1/2] run-opentest: only pass u-boot and spl/uart when enabled in config Cooper Jr., Franklin
  0 siblings, 2 replies; 11+ messages in thread
From: Denys Dmytriyenko @ 2014-09-08 19:48 UTC (permalink / raw)
  To: meta-arago

From: Denys Dmytriyenko <denys@ti.com>

Introduce new variable OPENTEST_BOOTLOADERS to control it, but defaults to false.
This never worked as expected, since SPL/UART is only supported by am335x and
on other platforms it causes OpenTest to miss the escape window and it can't stop
boot sequence to configure the necessary parameters.

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
 configs/arago-core-tisdk-daisy-puget.txt |  4 ++++
 lib/run-opentest                         | 17 ++++++++++-------
 2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/configs/arago-core-tisdk-daisy-puget.txt b/configs/arago-core-tisdk-daisy-puget.txt
index c132baf..f8bfb7a 100644
--- a/configs/arago-core-tisdk-daisy-puget.txt
+++ b/configs/arago-core-tisdk-daisy-puget.txt
@@ -177,6 +177,10 @@ OPENTEST_TEE_IP="none"
 # Limit the board selection to official TI GT farm, avoiding personal boards
 OPENTEST_HW_CAP="linux_tigt_farm"
 
+# Determine whether SPL/UART and U-boot binaries are passed to OpenTest for
+# testing. Otherwise uses existing bootloaders on the board (SD, NAND, etc)
+OPENTEST_BOOTLOADERS="false"
+
 # This variable will allow control over whether to perform build testing or
 # skip it.  This should usually be set to true but may be changed for
 # prototyping.
diff --git a/lib/run-opentest b/lib/run-opentest
index a64e4cc..1a71ae8 100644
--- a/lib/run-opentest
+++ b/lib/run-opentest
@@ -206,15 +206,18 @@ run_target_side_test() {
     fi
 
     uboot=""
-    if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-$m.* ]
-    then
-        uboot="~secondary_bootloader=$(ls $test_dir/temp/board-support/prebuilt-images/u-boot-$m.*)"
-    fi
-
     spluart=""
-    if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-spl.bin-$m ]
+    if [ "$OPENTEST_BOOTLOADERS" == "true" ]
     then
-        spluart="~primary_bootloader=$(ls $test_dir/temp/board-support/prebuilt-images/u-boot-spl.bin-$m)"
+        if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-$m.* ]
+        then
+            uboot="~secondary_bootloader=$(ls $test_dir/temp/board-support/prebuilt-images/u-boot-$m.*)"
+        fi
+
+        if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-spl.bin-$m ]
+        then
+            spluart="~primary_bootloader=$(ls $test_dir/temp/board-support/prebuilt-images/u-boot-spl.bin-$m)"
+        fi
     fi
 
     # Start the STAF process if not already started
-- 
2.0.4



^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [tisdk-build-scripts][PATCH 2/2] test-files: disable Qt4 specific test cases, may add Qt5 in the future
  2014-09-08 19:48 [tisdk-build-scripts][PATCH 1/2] run-opentest: only pass u-boot and spl/uart when enabled in config Denys Dmytriyenko
@ 2014-09-08 19:48 ` Denys Dmytriyenko
  2014-09-08 21:37   ` Cooper Jr., Franklin
  2014-09-08 21:39 ` [tisdk-build-scripts][PATCH 1/2] run-opentest: only pass u-boot and spl/uart when enabled in config Cooper Jr., Franklin
  1 sibling, 1 reply; 11+ messages in thread
From: Denys Dmytriyenko @ 2014-09-08 19:48 UTC (permalink / raw)
  To: meta-arago

From: Denys Dmytriyenko <denys@ti.com>

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
 test-scripts/test-files/mandatory-oesdk-armv7a.txt | 2 +-
 test-scripts/test-files/mandatory-oesdk.txt        | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/test-scripts/test-files/mandatory-oesdk-armv7a.txt b/test-scripts/test-files/mandatory-oesdk-armv7a.txt
index 4931d1f..51832d3 100644
--- a/test-scripts/test-files/mandatory-oesdk-armv7a.txt
+++ b/test-scripts/test-files/mandatory-oesdk-armv7a.txt
@@ -1 +1 @@
-check_app.sh -a /usr/bin/qtopia/examples/animation/moveblocks/moveblocks -x
+#check_app.sh -a /usr/bin/qtopia/examples/animation/moveblocks/moveblocks -x
diff --git a/test-scripts/test-files/mandatory-oesdk.txt b/test-scripts/test-files/mandatory-oesdk.txt
index 91aece1..ac85a72 100644
--- a/test-scripts/test-files/mandatory-oesdk.txt
+++ b/test-scripts/test-files/mandatory-oesdk.txt
@@ -1,7 +1,7 @@
 check_app.sh -a runDhrystone
 check_app.sh -a runLinpack
 check_app.sh -a runWhetstone
-check_app.sh -a /usr/bin/qtopia/examples/widgets/calculator/calculator -x
-check_app.sh -a /usr/bin/qtopia/demos/deform/deform -x
-check_app.sh -a /usr/bin/qtopia/examples/animation/animatedtiles/animatedtiles -x
-check_app.sh -a /usr/bin/qtopia/examples/graphicsview/elasticnodes/elasticnodes -x
+#check_app.sh -a /usr/bin/qtopia/examples/widgets/calculator/calculator -x
+#check_app.sh -a /usr/bin/qtopia/demos/deform/deform -x
+#check_app.sh -a /usr/bin/qtopia/examples/animation/animatedtiles/animatedtiles -x
+#check_app.sh -a /usr/bin/qtopia/examples/graphicsview/elasticnodes/elasticnodes -x
-- 
2.0.4



^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [tisdk-build-scripts][PATCH 2/2] test-files: disable Qt4 specific test cases, may add Qt5 in the future
  2014-09-08 19:48 ` [tisdk-build-scripts][PATCH 2/2] test-files: disable Qt4 specific test cases, may add Qt5 in the future Denys Dmytriyenko
@ 2014-09-08 21:37   ` Cooper Jr., Franklin
  2014-09-08 21:44     ` Denys Dmytriyenko
  0 siblings, 1 reply; 11+ messages in thread
From: Cooper Jr., Franklin @ 2014-09-08 21:37 UTC (permalink / raw)
  To: Denys Dmytriyenko, meta-arago

Acked-by: Franklin Cooper Jr. <fcooper@ti.com>

Although I don't think these test make much sense. Maybe we should just use a simple boot "testplan" and don't even worry about these scripts unless we plan on doing a bit more testing.

> -----Original Message-----
> From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
> Sent: Monday, September 08, 2014 2:49 PM
> To: meta-arago@arago-project.org
> Subject: [meta-arago] [tisdk-build-scripts][PATCH 2/2] test-files: disable Qt4
> specific test cases, may add Qt5 in the future
> 
> From: Denys Dmytriyenko <denys@ti.com>
> 
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
>  test-scripts/test-files/mandatory-oesdk-armv7a.txt | 2 +-
>  test-scripts/test-files/mandatory-oesdk.txt        | 8 ++++----
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/test-scripts/test-files/mandatory-oesdk-armv7a.txt b/test-
> scripts/test-files/mandatory-oesdk-armv7a.txt
> index 4931d1f..51832d3 100644
> --- a/test-scripts/test-files/mandatory-oesdk-armv7a.txt
> +++ b/test-scripts/test-files/mandatory-oesdk-armv7a.txt
> @@ -1 +1 @@
> -check_app.sh -a
> /usr/bin/qtopia/examples/animation/moveblocks/moveblocks -x
> +#check_app.sh -a
> +/usr/bin/qtopia/examples/animation/moveblocks/moveblocks -x
> diff --git a/test-scripts/test-files/mandatory-oesdk.txt b/test-scripts/test-
> files/mandatory-oesdk.txt
> index 91aece1..ac85a72 100644
> --- a/test-scripts/test-files/mandatory-oesdk.txt
> +++ b/test-scripts/test-files/mandatory-oesdk.txt
> @@ -1,7 +1,7 @@
>  check_app.sh -a runDhrystone
>  check_app.sh -a runLinpack
>  check_app.sh -a runWhetstone
> -check_app.sh -a /usr/bin/qtopia/examples/widgets/calculator/calculator -x
> -check_app.sh -a /usr/bin/qtopia/demos/deform/deform -x -check_app.sh -
> a /usr/bin/qtopia/examples/animation/animatedtiles/animatedtiles -x -
> check_app.sh -a
> /usr/bin/qtopia/examples/graphicsview/elasticnodes/elasticnodes -x
> +#check_app.sh -a /usr/bin/qtopia/examples/widgets/calculator/calculator
> +-x #check_app.sh -a /usr/bin/qtopia/demos/deform/deform -x
> +#check_app.sh -a
> +/usr/bin/qtopia/examples/animation/animatedtiles/animatedtiles -x
> +#check_app.sh -a
> +/usr/bin/qtopia/examples/graphicsview/elasticnodes/elasticnodes -x
> --
> 2.0.4
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [tisdk-build-scripts][PATCH 1/2] run-opentest: only pass u-boot and spl/uart when enabled in config
  2014-09-08 19:48 [tisdk-build-scripts][PATCH 1/2] run-opentest: only pass u-boot and spl/uart when enabled in config Denys Dmytriyenko
  2014-09-08 19:48 ` [tisdk-build-scripts][PATCH 2/2] test-files: disable Qt4 specific test cases, may add Qt5 in the future Denys Dmytriyenko
@ 2014-09-08 21:39 ` Cooper Jr., Franklin
  2014-09-08 21:42   ` Denys Dmytriyenko
  1 sibling, 1 reply; 11+ messages in thread
From: Cooper Jr., Franklin @ 2014-09-08 21:39 UTC (permalink / raw)
  To: Denys Dmytriyenko, meta-arago

Should we make this variable specific to am335x some how then?

> -----Original Message-----
> From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
> Sent: Monday, September 08, 2014 2:49 PM
> To: meta-arago@arago-project.org
> Subject: [meta-arago] [tisdk-build-scripts][PATCH 1/2] run-opentest: only
> pass u-boot and spl/uart when enabled in config
> 
> From: Denys Dmytriyenko <denys@ti.com>
> 
> Introduce new variable OPENTEST_BOOTLOADERS to control it, but defaults
> to false.
> This never worked as expected, since SPL/UART is only supported by am335x
> and on other platforms it causes OpenTest to miss the escape window and it
> can't stop boot sequence to configure the necessary parameters.
> 
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
>  configs/arago-core-tisdk-daisy-puget.txt |  4 ++++
>  lib/run-opentest                         | 17 ++++++++++-------
>  2 files changed, 14 insertions(+), 7 deletions(-)
> 
> diff --git a/configs/arago-core-tisdk-daisy-puget.txt b/configs/arago-core-
> tisdk-daisy-puget.txt
> index c132baf..f8bfb7a 100644
> --- a/configs/arago-core-tisdk-daisy-puget.txt
> +++ b/configs/arago-core-tisdk-daisy-puget.txt
> @@ -177,6 +177,10 @@ OPENTEST_TEE_IP="none"
>  # Limit the board selection to official TI GT farm, avoiding personal boards
> OPENTEST_HW_CAP="linux_tigt_farm"
> 
> +# Determine whether SPL/UART and U-boot binaries are passed to
> OpenTest
> +for # testing. Otherwise uses existing bootloaders on the board (SD,
> +NAND, etc) OPENTEST_BOOTLOADERS="false"
> +
>  # This variable will allow control over whether to perform build testing or  #
> skip it.  This should usually be set to true but may be changed for  #
> prototyping.
> diff --git a/lib/run-opentest b/lib/run-opentest index a64e4cc..1a71ae8
> 100644
> --- a/lib/run-opentest
> +++ b/lib/run-opentest
> @@ -206,15 +206,18 @@ run_target_side_test() {
>      fi
> 
>      uboot=""
> -    if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-$m.* ]
> -    then
> -        uboot="~secondary_bootloader=$(ls $test_dir/temp/board-
> support/prebuilt-images/u-boot-$m.*)"
> -    fi
> -
>      spluart=""
> -    if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-spl.bin-$m ]
> +    if [ "$OPENTEST_BOOTLOADERS" == "true" ]
>      then
> -        spluart="~primary_bootloader=$(ls $test_dir/temp/board-
> support/prebuilt-images/u-boot-spl.bin-$m)"
> +        if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-$m.* ]
> +        then
> +            uboot="~secondary_bootloader=$(ls $test_dir/temp/board-
> support/prebuilt-images/u-boot-$m.*)"
> +        fi
> +
> +        if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-spl.bin-$m
> ]
> +        then
> +            spluart="~primary_bootloader=$(ls $test_dir/temp/board-
> support/prebuilt-images/u-boot-spl.bin-$m)"
> +        fi
>      fi
> 
>      # Start the STAF process if not already started
> --
> 2.0.4
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [tisdk-build-scripts][PATCH 1/2] run-opentest: only pass u-boot and spl/uart when enabled in config
  2014-09-08 21:39 ` [tisdk-build-scripts][PATCH 1/2] run-opentest: only pass u-boot and spl/uart when enabled in config Cooper Jr., Franklin
@ 2014-09-08 21:42   ` Denys Dmytriyenko
  2014-09-08 22:05     ` Cooper Jr., Franklin
  0 siblings, 1 reply; 11+ messages in thread
From: Denys Dmytriyenko @ 2014-09-08 21:42 UTC (permalink / raw)
  To: Cooper Jr., Franklin; +Cc: meta-arago

On Mon, Sep 08, 2014 at 09:39:29PM +0000, Cooper Jr., Franklin wrote:
> Should we make this variable specific to am335x some how then?

I don't think there's easy way to control a config variable based on 
machine...


> > -----Original Message-----
> > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
> > Sent: Monday, September 08, 2014 2:49 PM
> > To: meta-arago@arago-project.org
> > Subject: [meta-arago] [tisdk-build-scripts][PATCH 1/2] run-opentest: only
> > pass u-boot and spl/uart when enabled in config
> > 
> > From: Denys Dmytriyenko <denys@ti.com>
> > 
> > Introduce new variable OPENTEST_BOOTLOADERS to control it, but defaults
> > to false.
> > This never worked as expected, since SPL/UART is only supported by am335x
> > and on other platforms it causes OpenTest to miss the escape window and it
> > can't stop boot sequence to configure the necessary parameters.
> > 
> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > ---
> >  configs/arago-core-tisdk-daisy-puget.txt |  4 ++++
> >  lib/run-opentest                         | 17 ++++++++++-------
> >  2 files changed, 14 insertions(+), 7 deletions(-)
> > 
> > diff --git a/configs/arago-core-tisdk-daisy-puget.txt b/configs/arago-core-
> > tisdk-daisy-puget.txt
> > index c132baf..f8bfb7a 100644
> > --- a/configs/arago-core-tisdk-daisy-puget.txt
> > +++ b/configs/arago-core-tisdk-daisy-puget.txt
> > @@ -177,6 +177,10 @@ OPENTEST_TEE_IP="none"
> >  # Limit the board selection to official TI GT farm, avoiding personal boards
> > OPENTEST_HW_CAP="linux_tigt_farm"
> > 
> > +# Determine whether SPL/UART and U-boot binaries are passed to
> > OpenTest
> > +for # testing. Otherwise uses existing bootloaders on the board (SD,
> > +NAND, etc) OPENTEST_BOOTLOADERS="false"
> > +
> >  # This variable will allow control over whether to perform build testing or  #
> > skip it.  This should usually be set to true but may be changed for  #
> > prototyping.
> > diff --git a/lib/run-opentest b/lib/run-opentest index a64e4cc..1a71ae8
> > 100644
> > --- a/lib/run-opentest
> > +++ b/lib/run-opentest
> > @@ -206,15 +206,18 @@ run_target_side_test() {
> >      fi
> > 
> >      uboot=""
> > -    if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-$m.* ]
> > -    then
> > -        uboot="~secondary_bootloader=$(ls $test_dir/temp/board-
> > support/prebuilt-images/u-boot-$m.*)"
> > -    fi
> > -
> >      spluart=""
> > -    if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-spl.bin-$m ]
> > +    if [ "$OPENTEST_BOOTLOADERS" == "true" ]
> >      then
> > -        spluart="~primary_bootloader=$(ls $test_dir/temp/board-
> > support/prebuilt-images/u-boot-spl.bin-$m)"
> > +        if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-$m.* ]
> > +        then
> > +            uboot="~secondary_bootloader=$(ls $test_dir/temp/board-
> > support/prebuilt-images/u-boot-$m.*)"
> > +        fi
> > +
> > +        if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-spl.bin-$m
> > ]
> > +        then
> > +            spluart="~primary_bootloader=$(ls $test_dir/temp/board-
> > support/prebuilt-images/u-boot-spl.bin-$m)"
> > +        fi
> >      fi
> > 
> >      # Start the STAF process if not already started
> > --
> > 2.0.4
> > 
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [tisdk-build-scripts][PATCH 2/2] test-files: disable Qt4 specific test cases, may add Qt5 in the future
  2014-09-08 21:37   ` Cooper Jr., Franklin
@ 2014-09-08 21:44     ` Denys Dmytriyenko
  2014-09-08 21:59       ` Cooper Jr., Franklin
  0 siblings, 1 reply; 11+ messages in thread
From: Denys Dmytriyenko @ 2014-09-08 21:44 UTC (permalink / raw)
  To: Cooper Jr., Franklin; +Cc: meta-arago

On Mon, Sep 08, 2014 at 09:37:23PM +0000, Cooper Jr., Franklin wrote:
> Acked-by: Franklin Cooper Jr. <fcooper@ti.com>
> 
> Although I don't think these test make much sense. Maybe we should just use 
> a simple boot "testplan" and don't even worry about these scripts unless we 
> plan on doing a bit more testing.

I wouldn't mind switching to standard OpenTest test plans, but I don't yet 
have enough experience for that, maybe after the release...


> > -----Original Message-----
> > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
> > Sent: Monday, September 08, 2014 2:49 PM
> > To: meta-arago@arago-project.org
> > Subject: [meta-arago] [tisdk-build-scripts][PATCH 2/2] test-files: disable Qt4
> > specific test cases, may add Qt5 in the future
> > 
> > From: Denys Dmytriyenko <denys@ti.com>
> > 
> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > ---
> >  test-scripts/test-files/mandatory-oesdk-armv7a.txt | 2 +-
> >  test-scripts/test-files/mandatory-oesdk.txt        | 8 ++++----
> >  2 files changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/test-scripts/test-files/mandatory-oesdk-armv7a.txt b/test-
> > scripts/test-files/mandatory-oesdk-armv7a.txt
> > index 4931d1f..51832d3 100644
> > --- a/test-scripts/test-files/mandatory-oesdk-armv7a.txt
> > +++ b/test-scripts/test-files/mandatory-oesdk-armv7a.txt
> > @@ -1 +1 @@
> > -check_app.sh -a
> > /usr/bin/qtopia/examples/animation/moveblocks/moveblocks -x
> > +#check_app.sh -a
> > +/usr/bin/qtopia/examples/animation/moveblocks/moveblocks -x
> > diff --git a/test-scripts/test-files/mandatory-oesdk.txt b/test-scripts/test-
> > files/mandatory-oesdk.txt
> > index 91aece1..ac85a72 100644
> > --- a/test-scripts/test-files/mandatory-oesdk.txt
> > +++ b/test-scripts/test-files/mandatory-oesdk.txt
> > @@ -1,7 +1,7 @@
> >  check_app.sh -a runDhrystone
> >  check_app.sh -a runLinpack
> >  check_app.sh -a runWhetstone
> > -check_app.sh -a /usr/bin/qtopia/examples/widgets/calculator/calculator -x
> > -check_app.sh -a /usr/bin/qtopia/demos/deform/deform -x -check_app.sh -
> > a /usr/bin/qtopia/examples/animation/animatedtiles/animatedtiles -x -
> > check_app.sh -a
> > /usr/bin/qtopia/examples/graphicsview/elasticnodes/elasticnodes -x
> > +#check_app.sh -a /usr/bin/qtopia/examples/widgets/calculator/calculator
> > +-x #check_app.sh -a /usr/bin/qtopia/demos/deform/deform -x
> > +#check_app.sh -a
> > +/usr/bin/qtopia/examples/animation/animatedtiles/animatedtiles -x
> > +#check_app.sh -a
> > +/usr/bin/qtopia/examples/graphicsview/elasticnodes/elasticnodes -x
> > --
> > 2.0.4
> > 
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [tisdk-build-scripts][PATCH 2/2] test-files: disable Qt4 specific test cases, may add Qt5 in the future
  2014-09-08 21:44     ` Denys Dmytriyenko
@ 2014-09-08 21:59       ` Cooper Jr., Franklin
  0 siblings, 0 replies; 11+ messages in thread
From: Cooper Jr., Franklin @ 2014-09-08 21:59 UTC (permalink / raw)
  To: Dmytriyenko, Denys; +Cc: meta-arago


> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Monday, September 08, 2014 4:44 PM
> To: Cooper Jr., Franklin
> Cc: Denys Dmytriyenko; meta-arago@arago-project.org
> Subject: Re: [meta-arago] [tisdk-build-scripts][PATCH 2/2] test-files: disable
> Qt4 specific test cases, may add Qt5 in the future
> 
> On Mon, Sep 08, 2014 at 09:37:23PM +0000, Cooper Jr., Franklin wrote:
> > Acked-by: Franklin Cooper Jr. <fcooper@ti.com>
> >
> > Although I don't think these test make much sense. Maybe we should
> > just use a simple boot "testplan" and don't even worry about these
> > scripts unless we plan on doing a bit more testing.
> 
> I wouldn't mind switching to standard OpenTest test plans, but I don't yet
> have enough experience for that, maybe after the release...
[Franklin] I'm currently trying to get using a testplan via opentest_cli to work for another reason so I can look into a simple boot testplan.
> 
> 
> > > -----Original Message-----
> > > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > > bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
> > > Sent: Monday, September 08, 2014 2:49 PM
> > > To: meta-arago@arago-project.org
> > > Subject: [meta-arago] [tisdk-build-scripts][PATCH 2/2] test-files: disable
> Qt4
> > > specific test cases, may add Qt5 in the future
> > >
> > > From: Denys Dmytriyenko <denys@ti.com>
> > >
> > > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > > ---
> > >  test-scripts/test-files/mandatory-oesdk-armv7a.txt | 2 +-
> > >  test-scripts/test-files/mandatory-oesdk.txt        | 8 ++++----
> > >  2 files changed, 5 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/test-scripts/test-files/mandatory-oesdk-armv7a.txt b/test-
> > > scripts/test-files/mandatory-oesdk-armv7a.txt
> > > index 4931d1f..51832d3 100644
> > > --- a/test-scripts/test-files/mandatory-oesdk-armv7a.txt
> > > +++ b/test-scripts/test-files/mandatory-oesdk-armv7a.txt
> > > @@ -1 +1 @@
> > > -check_app.sh -a
> > > /usr/bin/qtopia/examples/animation/moveblocks/moveblocks -x
> > > +#check_app.sh -a
> > > +/usr/bin/qtopia/examples/animation/moveblocks/moveblocks -x
> > > diff --git a/test-scripts/test-files/mandatory-oesdk.txt b/test-scripts/test-
> > > files/mandatory-oesdk.txt
> > > index 91aece1..ac85a72 100644
> > > --- a/test-scripts/test-files/mandatory-oesdk.txt
> > > +++ b/test-scripts/test-files/mandatory-oesdk.txt
> > > @@ -1,7 +1,7 @@
> > >  check_app.sh -a runDhrystone
> > >  check_app.sh -a runLinpack
> > >  check_app.sh -a runWhetstone
> > > -check_app.sh -a
> /usr/bin/qtopia/examples/widgets/calculator/calculator -x
> > > -check_app.sh -a /usr/bin/qtopia/demos/deform/deform -x -
> check_app.sh -
> > > a /usr/bin/qtopia/examples/animation/animatedtiles/animatedtiles -x -
> > > check_app.sh -a
> > > /usr/bin/qtopia/examples/graphicsview/elasticnodes/elasticnodes -x
> > > +#check_app.sh -a
> /usr/bin/qtopia/examples/widgets/calculator/calculator
> > > +-x #check_app.sh -a /usr/bin/qtopia/demos/deform/deform -x
> > > +#check_app.sh -a
> > > +/usr/bin/qtopia/examples/animation/animatedtiles/animatedtiles -x
> > > +#check_app.sh -a
> > > +/usr/bin/qtopia/examples/graphicsview/elasticnodes/elasticnodes -x
> > > --
> > > 2.0.4
> > >
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [tisdk-build-scripts][PATCH 1/2] run-opentest: only pass u-boot and spl/uart when enabled in config
  2014-09-08 21:42   ` Denys Dmytriyenko
@ 2014-09-08 22:05     ` Cooper Jr., Franklin
  2014-09-08 22:08       ` Denys Dmytriyenko
  0 siblings, 1 reply; 11+ messages in thread
From: Cooper Jr., Franklin @ 2014-09-08 22:05 UTC (permalink / raw)
  To: Dmytriyenko, Denys; +Cc: meta-arago



> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Monday, September 08, 2014 4:43 PM
> To: Cooper Jr., Franklin
> Cc: Denys Dmytriyenko; meta-arago@arago-project.org
> Subject: Re: [meta-arago] [tisdk-build-scripts][PATCH 1/2] run-opentest: only
> pass u-boot and spl/uart when enabled in config
> 
> On Mon, Sep 08, 2014 at 09:39:29PM +0000, Cooper Jr., Franklin wrote:
> > Should we make this variable specific to am335x some how then?
> 
> I don't think there's easy way to control a config variable based on
> machine...
[Franklin] Maybe for now just check against the "machine" or some regexp am335x*?

Also can we update all the configs to use true for now? This way it doesn't change the current behavior. With my above suggestion we can set things to true and take advantage of it when it makes sense.

> 
> 
> > > -----Original Message-----
> > > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > > bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
> > > Sent: Monday, September 08, 2014 2:49 PM
> > > To: meta-arago@arago-project.org
> > > Subject: [meta-arago] [tisdk-build-scripts][PATCH 1/2] run-opentest: only
> > > pass u-boot and spl/uart when enabled in config
> > >
> > > From: Denys Dmytriyenko <denys@ti.com>
> > >
> > > Introduce new variable OPENTEST_BOOTLOADERS to control it, but
> defaults
> > > to false.
> > > This never worked as expected, since SPL/UART is only supported by
> am335x
> > > and on other platforms it causes OpenTest to miss the escape window
> and it
> > > can't stop boot sequence to configure the necessary parameters.
> > >
> > > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > > ---
> > >  configs/arago-core-tisdk-daisy-puget.txt |  4 ++++
> > >  lib/run-opentest                         | 17 ++++++++++-------
> > >  2 files changed, 14 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/configs/arago-core-tisdk-daisy-puget.txt b/configs/arago-
> core-
> > > tisdk-daisy-puget.txt
> > > index c132baf..f8bfb7a 100644
> > > --- a/configs/arago-core-tisdk-daisy-puget.txt
> > > +++ b/configs/arago-core-tisdk-daisy-puget.txt
> > > @@ -177,6 +177,10 @@ OPENTEST_TEE_IP="none"
> > >  # Limit the board selection to official TI GT farm, avoiding personal
> boards
> > > OPENTEST_HW_CAP="linux_tigt_farm"
> > >
> > > +# Determine whether SPL/UART and U-boot binaries are passed to
> > > OpenTest
> > > +for # testing. Otherwise uses existing bootloaders on the board (SD,
> > > +NAND, etc) OPENTEST_BOOTLOADERS="false"
> > > +
> > >  # This variable will allow control over whether to perform build testing or
> #
> > > skip it.  This should usually be set to true but may be changed for  #
> > > prototyping.
> > > diff --git a/lib/run-opentest b/lib/run-opentest index a64e4cc..1a71ae8
> > > 100644
> > > --- a/lib/run-opentest
> > > +++ b/lib/run-opentest
> > > @@ -206,15 +206,18 @@ run_target_side_test() {
> > >      fi
> > >
> > >      uboot=""
> > > -    if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-$m.* ]
> > > -    then
> > > -        uboot="~secondary_bootloader=$(ls $test_dir/temp/board-
> > > support/prebuilt-images/u-boot-$m.*)"
> > > -    fi
> > > -
> > >      spluart=""
> > > -    if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-spl.bin-
> $m ]
> > > +    if [ "$OPENTEST_BOOTLOADERS" == "true" ]
> > >      then
> > > -        spluart="~primary_bootloader=$(ls $test_dir/temp/board-
> > > support/prebuilt-images/u-boot-spl.bin-$m)"
> > > +        if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-$m.* ]
> > > +        then
> > > +            uboot="~secondary_bootloader=$(ls $test_dir/temp/board-
> > > support/prebuilt-images/u-boot-$m.*)"
> > > +        fi
> > > +
> > > +        if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-
> spl.bin-$m
> > > ]
> > > +        then
> > > +            spluart="~primary_bootloader=$(ls $test_dir/temp/board-
> > > support/prebuilt-images/u-boot-spl.bin-$m)"
> > > +        fi
> > >      fi
> > >
> > >      # Start the STAF process if not already started
> > > --
> > > 2.0.4
> > >
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [tisdk-build-scripts][PATCH 1/2] run-opentest: only pass u-boot and spl/uart when enabled in config
  2014-09-08 22:05     ` Cooper Jr., Franklin
@ 2014-09-08 22:08       ` Denys Dmytriyenko
  2014-09-11 22:20         ` Denys Dmytriyenko
  0 siblings, 1 reply; 11+ messages in thread
From: Denys Dmytriyenko @ 2014-09-08 22:08 UTC (permalink / raw)
  To: Cooper Jr., Franklin; +Cc: meta-arago

On Mon, Sep 08, 2014 at 06:05:02PM -0400, Cooper Jr., Franklin wrote:
> 
> 
> > -----Original Message-----
> > From: Dmytriyenko, Denys
> > Sent: Monday, September 08, 2014 4:43 PM
> > To: Cooper Jr., Franklin
> > Cc: Denys Dmytriyenko; meta-arago@arago-project.org
> > Subject: Re: [meta-arago] [tisdk-build-scripts][PATCH 1/2] run-opentest: only
> > pass u-boot and spl/uart when enabled in config
> > 
> > On Mon, Sep 08, 2014 at 09:39:29PM +0000, Cooper Jr., Franklin wrote:
> > > Should we make this variable specific to am335x some how then?
> > 
> > I don't think there's easy way to control a config variable based on
> > machine...
> [Franklin] Maybe for now just check against the "machine" or some regexp am335x*?
> 
> Also can we update all the configs to use true for now? This way it doesn't 
> change the current behavior. With my above suggestion we can set things to 
> true and take advantage of it when it makes sense.

Actually, I was going to disable it for all my configs, as it makes things 
worse if enabled - don't know why, but systest is not yet explaining this 
behaviour. You can keep it enabled, if you want, in your configs, though.


> > > > -----Original Message-----
> > > > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > > > bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
> > > > Sent: Monday, September 08, 2014 2:49 PM
> > > > To: meta-arago@arago-project.org
> > > > Subject: [meta-arago] [tisdk-build-scripts][PATCH 1/2] run-opentest: only
> > > > pass u-boot and spl/uart when enabled in config
> > > >
> > > > From: Denys Dmytriyenko <denys@ti.com>
> > > >
> > > > Introduce new variable OPENTEST_BOOTLOADERS to control it, but
> > defaults
> > > > to false.
> > > > This never worked as expected, since SPL/UART is only supported by
> > am335x
> > > > and on other platforms it causes OpenTest to miss the escape window
> > and it
> > > > can't stop boot sequence to configure the necessary parameters.
> > > >
> > > > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > > > ---
> > > >  configs/arago-core-tisdk-daisy-puget.txt |  4 ++++
> > > >  lib/run-opentest                         | 17 ++++++++++-------
> > > >  2 files changed, 14 insertions(+), 7 deletions(-)
> > > >
> > > > diff --git a/configs/arago-core-tisdk-daisy-puget.txt b/configs/arago-
> > core-
> > > > tisdk-daisy-puget.txt
> > > > index c132baf..f8bfb7a 100644
> > > > --- a/configs/arago-core-tisdk-daisy-puget.txt
> > > > +++ b/configs/arago-core-tisdk-daisy-puget.txt
> > > > @@ -177,6 +177,10 @@ OPENTEST_TEE_IP="none"
> > > >  # Limit the board selection to official TI GT farm, avoiding personal
> > boards
> > > > OPENTEST_HW_CAP="linux_tigt_farm"
> > > >
> > > > +# Determine whether SPL/UART and U-boot binaries are passed to
> > > > OpenTest
> > > > +for # testing. Otherwise uses existing bootloaders on the board (SD,
> > > > +NAND, etc) OPENTEST_BOOTLOADERS="false"
> > > > +
> > > >  # This variable will allow control over whether to perform build testing or
> > #
> > > > skip it.  This should usually be set to true but may be changed for  #
> > > > prototyping.
> > > > diff --git a/lib/run-opentest b/lib/run-opentest index a64e4cc..1a71ae8
> > > > 100644
> > > > --- a/lib/run-opentest
> > > > +++ b/lib/run-opentest
> > > > @@ -206,15 +206,18 @@ run_target_side_test() {
> > > >      fi
> > > >
> > > >      uboot=""
> > > > -    if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-$m.* ]
> > > > -    then
> > > > -        uboot="~secondary_bootloader=$(ls $test_dir/temp/board-
> > > > support/prebuilt-images/u-boot-$m.*)"
> > > > -    fi
> > > > -
> > > >      spluart=""
> > > > -    if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-spl.bin-
> > $m ]
> > > > +    if [ "$OPENTEST_BOOTLOADERS" == "true" ]
> > > >      then
> > > > -        spluart="~primary_bootloader=$(ls $test_dir/temp/board-
> > > > support/prebuilt-images/u-boot-spl.bin-$m)"
> > > > +        if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-$m.* ]
> > > > +        then
> > > > +            uboot="~secondary_bootloader=$(ls $test_dir/temp/board-
> > > > support/prebuilt-images/u-boot-$m.*)"
> > > > +        fi
> > > > +
> > > > +        if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-
> > spl.bin-$m
> > > > ]
> > > > +        then
> > > > +            spluart="~primary_bootloader=$(ls $test_dir/temp/board-
> > > > support/prebuilt-images/u-boot-spl.bin-$m)"
> > > > +        fi
> > > >      fi
> > > >
> > > >      # Start the STAF process if not already started
> > > > --
> > > > 2.0.4
> > > >
> > > > _______________________________________________
> > > > meta-arago mailing list
> > > > meta-arago@arago-project.org
> > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [tisdk-build-scripts][PATCH 1/2] run-opentest: only pass u-boot and spl/uart when enabled in config
  2014-09-08 22:08       ` Denys Dmytriyenko
@ 2014-09-11 22:20         ` Denys Dmytriyenko
  2014-09-11 22:55           ` Cooper Jr., Franklin
  0 siblings, 1 reply; 11+ messages in thread
From: Denys Dmytriyenko @ 2014-09-11 22:20 UTC (permalink / raw)
  To: Cooper Jr., Franklin; +Cc: meta-arago

On Mon, Sep 08, 2014 at 06:08:01PM -0400, Denys Dmytriyenko wrote:
> On Mon, Sep 08, 2014 at 06:05:02PM -0400, Cooper Jr., Franklin wrote:
> > 
> > 
> > > -----Original Message-----
> > > From: Dmytriyenko, Denys
> > > Sent: Monday, September 08, 2014 4:43 PM
> > > To: Cooper Jr., Franklin
> > > Cc: Denys Dmytriyenko; meta-arago@arago-project.org
> > > Subject: Re: [meta-arago] [tisdk-build-scripts][PATCH 1/2] run-opentest: only
> > > pass u-boot and spl/uart when enabled in config
> > > 
> > > On Mon, Sep 08, 2014 at 09:39:29PM +0000, Cooper Jr., Franklin wrote:
> > > > Should we make this variable specific to am335x some how then?
> > > 
> > > I don't think there's easy way to control a config variable based on
> > > machine...
> > [Franklin] Maybe for now just check against the "machine" or some regexp am335x*?
> > 
> > Also can we update all the configs to use true for now? This way it doesn't 
> > change the current behavior. With my above suggestion we can set things to 
> > true and take advantage of it when it makes sense.
> 
> Actually, I was going to disable it for all my configs, as it makes things 
> worse if enabled - don't know why, but systest is not yet explaining this 
> behaviour. You can keep it enabled, if you want, in your configs, though.

Ping on this one. Carlos said that passing this to a platform not supporting 
SPL/UART boot will interfere with normal boot and cause issues we are seeing 
now. So, it's best to have it disabled by default and only enable it for 335.


> > > > > -----Original Message-----
> > > > > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > > > > bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
> > > > > Sent: Monday, September 08, 2014 2:49 PM
> > > > > To: meta-arago@arago-project.org
> > > > > Subject: [meta-arago] [tisdk-build-scripts][PATCH 1/2] run-opentest: only
> > > > > pass u-boot and spl/uart when enabled in config
> > > > >
> > > > > From: Denys Dmytriyenko <denys@ti.com>
> > > > >
> > > > > Introduce new variable OPENTEST_BOOTLOADERS to control it, but
> > > defaults
> > > > > to false.
> > > > > This never worked as expected, since SPL/UART is only supported by
> > > am335x
> > > > > and on other platforms it causes OpenTest to miss the escape window
> > > and it
> > > > > can't stop boot sequence to configure the necessary parameters.
> > > > >
> > > > > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > > > > ---
> > > > >  configs/arago-core-tisdk-daisy-puget.txt |  4 ++++
> > > > >  lib/run-opentest                         | 17 ++++++++++-------
> > > > >  2 files changed, 14 insertions(+), 7 deletions(-)
> > > > >
> > > > > diff --git a/configs/arago-core-tisdk-daisy-puget.txt b/configs/arago-
> > > core-
> > > > > tisdk-daisy-puget.txt
> > > > > index c132baf..f8bfb7a 100644
> > > > > --- a/configs/arago-core-tisdk-daisy-puget.txt
> > > > > +++ b/configs/arago-core-tisdk-daisy-puget.txt
> > > > > @@ -177,6 +177,10 @@ OPENTEST_TEE_IP="none"
> > > > >  # Limit the board selection to official TI GT farm, avoiding personal
> > > boards
> > > > > OPENTEST_HW_CAP="linux_tigt_farm"
> > > > >
> > > > > +# Determine whether SPL/UART and U-boot binaries are passed to
> > > > > OpenTest
> > > > > +for # testing. Otherwise uses existing bootloaders on the board (SD,
> > > > > +NAND, etc) OPENTEST_BOOTLOADERS="false"
> > > > > +
> > > > >  # This variable will allow control over whether to perform build testing or
> > > #
> > > > > skip it.  This should usually be set to true but may be changed for  #
> > > > > prototyping.
> > > > > diff --git a/lib/run-opentest b/lib/run-opentest index a64e4cc..1a71ae8
> > > > > 100644
> > > > > --- a/lib/run-opentest
> > > > > +++ b/lib/run-opentest
> > > > > @@ -206,15 +206,18 @@ run_target_side_test() {
> > > > >      fi
> > > > >
> > > > >      uboot=""
> > > > > -    if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-$m.* ]
> > > > > -    then
> > > > > -        uboot="~secondary_bootloader=$(ls $test_dir/temp/board-
> > > > > support/prebuilt-images/u-boot-$m.*)"
> > > > > -    fi
> > > > > -
> > > > >      spluart=""
> > > > > -    if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-spl.bin-
> > > $m ]
> > > > > +    if [ "$OPENTEST_BOOTLOADERS" == "true" ]
> > > > >      then
> > > > > -        spluart="~primary_bootloader=$(ls $test_dir/temp/board-
> > > > > support/prebuilt-images/u-boot-spl.bin-$m)"
> > > > > +        if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-$m.* ]
> > > > > +        then
> > > > > +            uboot="~secondary_bootloader=$(ls $test_dir/temp/board-
> > > > > support/prebuilt-images/u-boot-$m.*)"
> > > > > +        fi
> > > > > +
> > > > > +        if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-
> > > spl.bin-$m
> > > > > ]
> > > > > +        then
> > > > > +            spluart="~primary_bootloader=$(ls $test_dir/temp/board-
> > > > > support/prebuilt-images/u-boot-spl.bin-$m)"
> > > > > +        fi
> > > > >      fi
> > > > >
> > > > >      # Start the STAF process if not already started
> > > > > --
> > > > > 2.0.4
> > > > >
> > > > > _______________________________________________
> > > > > meta-arago mailing list
> > > > > meta-arago@arago-project.org
> > > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > > > _______________________________________________
> > > > meta-arago mailing list
> > > > meta-arago@arago-project.org
> > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [tisdk-build-scripts][PATCH 1/2] run-opentest: only pass u-boot and spl/uart when enabled in config
  2014-09-11 22:20         ` Denys Dmytriyenko
@ 2014-09-11 22:55           ` Cooper Jr., Franklin
  0 siblings, 0 replies; 11+ messages in thread
From: Cooper Jr., Franklin @ 2014-09-11 22:55 UTC (permalink / raw)
  To: Dmytriyenko, Denys; +Cc: meta-arago



> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Thursday, September 11, 2014 5:21 PM
> To: Cooper Jr., Franklin
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [tisdk-build-scripts][PATCH 1/2] run-opentest: only
> pass u-boot and spl/uart when enabled in config
> 
> On Mon, Sep 08, 2014 at 06:08:01PM -0400, Denys Dmytriyenko wrote:
> > On Mon, Sep 08, 2014 at 06:05:02PM -0400, Cooper Jr., Franklin wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: Dmytriyenko, Denys
> > > > Sent: Monday, September 08, 2014 4:43 PM
> > > > To: Cooper Jr., Franklin
> > > > Cc: Denys Dmytriyenko; meta-arago@arago-project.org
> > > > Subject: Re: [meta-arago] [tisdk-build-scripts][PATCH 1/2]
> > > > run-opentest: only pass u-boot and spl/uart when enabled in config
> > > >
> > > > On Mon, Sep 08, 2014 at 09:39:29PM +0000, Cooper Jr., Franklin wrote:
> > > > > Should we make this variable specific to am335x some how then?
> > > >
> > > > I don't think there's easy way to control a config variable based
> > > > on machine...
> > > [Franklin] Maybe for now just check against the "machine" or some
> regexp am335x*?
> > >
> > > Also can we update all the configs to use true for now? This way it
> > > doesn't change the current behavior. With my above suggestion we can
> > > set things to true and take advantage of it when it makes sense.
> >
> > Actually, I was going to disable it for all my configs, as it makes
> > things worse if enabled - don't know why, but systest is not yet
> > explaining this behaviour. You can keep it enabled, if you want, in your
> configs, though.
> 
> Ping on this one. Carlos said that passing this to a platform not supporting
> SPL/UART boot will interfere with normal boot and cause issues we are
> seeing now. So, it's best to have it disabled by default and only enable it for
> 335.
[Franklin] Any thoughts to my suggestion above since I think it addresses the issue although it's a band-aid instead of a longer term fix? Since the alternative is to disable it which means 335x can utilize this useful functionality or enable it which of course means test will fail on non am335x platforms.

If you don't like the suggestion then feel free and disable it by default in the configs but can you also do that too all configs?
> 
> 
> > > > > > -----Original Message-----
> > > > > > From: meta-arago-bounces@arago-project.org [mailto:meta-
> arago-
> > > > > > bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
> > > > > > Sent: Monday, September 08, 2014 2:49 PM
> > > > > > To: meta-arago@arago-project.org
> > > > > > Subject: [meta-arago] [tisdk-build-scripts][PATCH 1/2]
> > > > > > run-opentest: only pass u-boot and spl/uart when enabled in
> > > > > > config
> > > > > >
> > > > > > From: Denys Dmytriyenko <denys@ti.com>
> > > > > >
> > > > > > Introduce new variable OPENTEST_BOOTLOADERS to control it, but
> > > > defaults
> > > > > > to false.
> > > > > > This never worked as expected, since SPL/UART is only
> > > > > > supported by
> > > > am335x
> > > > > > and on other platforms it causes OpenTest to miss the escape
> > > > > > window
> > > > and it
> > > > > > can't stop boot sequence to configure the necessary parameters.
> > > > > >
> > > > > > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > > > > > ---
> > > > > >  configs/arago-core-tisdk-daisy-puget.txt |  4 ++++
> > > > > >  lib/run-opentest                         | 17 ++++++++++-------
> > > > > >  2 files changed, 14 insertions(+), 7 deletions(-)
> > > > > >
> > > > > > diff --git a/configs/arago-core-tisdk-daisy-puget.txt
> > > > > > b/configs/arago-
> > > > core-
> > > > > > tisdk-daisy-puget.txt
> > > > > > index c132baf..f8bfb7a 100644
> > > > > > --- a/configs/arago-core-tisdk-daisy-puget.txt
> > > > > > +++ b/configs/arago-core-tisdk-daisy-puget.txt
> > > > > > @@ -177,6 +177,10 @@ OPENTEST_TEE_IP="none"
> > > > > >  # Limit the board selection to official TI GT farm, avoiding
> > > > > > personal
> > > > boards
> > > > > > OPENTEST_HW_CAP="linux_tigt_farm"
> > > > > >
> > > > > > +# Determine whether SPL/UART and U-boot binaries are passed
> > > > > > +to
> > > > > > OpenTest
> > > > > > +for # testing. Otherwise uses existing bootloaders on the
> > > > > > +board (SD, NAND, etc) OPENTEST_BOOTLOADERS="false"
> > > > > > +
> > > > > >  # This variable will allow control over whether to perform
> > > > > > build testing or
> > > > #
> > > > > > skip it.  This should usually be set to true but may be
> > > > > > changed for  # prototyping.
> > > > > > diff --git a/lib/run-opentest b/lib/run-opentest index
> > > > > > a64e4cc..1a71ae8
> > > > > > 100644
> > > > > > --- a/lib/run-opentest
> > > > > > +++ b/lib/run-opentest
> > > > > > @@ -206,15 +206,18 @@ run_target_side_test() {
> > > > > >      fi
> > > > > >
> > > > > >      uboot=""
> > > > > > -    if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-
> $m.* ]
> > > > > > -    then
> > > > > > -        uboot="~secondary_bootloader=$(ls $test_dir/temp/board-
> > > > > > support/prebuilt-images/u-boot-$m.*)"
> > > > > > -    fi
> > > > > > -
> > > > > >      spluart=""
> > > > > > -    if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-
> spl.bin-
> > > > $m ]
> > > > > > +    if [ "$OPENTEST_BOOTLOADERS" == "true" ]
> > > > > >      then
> > > > > > -        spluart="~primary_bootloader=$(ls $test_dir/temp/board-
> > > > > > support/prebuilt-images/u-boot-spl.bin-$m)"
> > > > > > +        if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-
> $m.* ]
> > > > > > +        then
> > > > > > +            uboot="~secondary_bootloader=$(ls
> > > > > > + $test_dir/temp/board-
> > > > > > support/prebuilt-images/u-boot-$m.*)"
> > > > > > +        fi
> > > > > > +
> > > > > > +        if [ -f
> > > > > > + $test_dir/temp/board-support/prebuilt-images/u-boot-
> > > > spl.bin-$m
> > > > > > ]
> > > > > > +        then
> > > > > > +            spluart="~primary_bootloader=$(ls
> > > > > > + $test_dir/temp/board-
> > > > > > support/prebuilt-images/u-boot-spl.bin-$m)"
> > > > > > +        fi
> > > > > >      fi
> > > > > >
> > > > > >      # Start the STAF process if not already started
> > > > > > --
> > > > > > 2.0.4
> > > > > >
> > > > > > _______________________________________________
> > > > > > meta-arago mailing list
> > > > > > meta-arago@arago-project.org
> > > > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > > > > _______________________________________________
> > > > > meta-arago mailing list
> > > > > meta-arago@arago-project.org
> > > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2014-09-11 22:55 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-08 19:48 [tisdk-build-scripts][PATCH 1/2] run-opentest: only pass u-boot and spl/uart when enabled in config Denys Dmytriyenko
2014-09-08 19:48 ` [tisdk-build-scripts][PATCH 2/2] test-files: disable Qt4 specific test cases, may add Qt5 in the future Denys Dmytriyenko
2014-09-08 21:37   ` Cooper Jr., Franklin
2014-09-08 21:44     ` Denys Dmytriyenko
2014-09-08 21:59       ` Cooper Jr., Franklin
2014-09-08 21:39 ` [tisdk-build-scripts][PATCH 1/2] run-opentest: only pass u-boot and spl/uart when enabled in config Cooper Jr., Franklin
2014-09-08 21:42   ` Denys Dmytriyenko
2014-09-08 22:05     ` Cooper Jr., Franklin
2014-09-08 22:08       ` Denys Dmytriyenko
2014-09-11 22:20         ` Denys Dmytriyenko
2014-09-11 22:55           ` Cooper Jr., Franklin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.