From: Ulf Hansson <ulf.hansson@linaro.org> To: "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-pm@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, Geert Uytterhoeven <geert+renesas@glider.be>, Kevin Hilman <khilman@linaro.org>, Alan Stern <stern@rowland.harvard.edu>, Daniel Lezcano <daniel.lezcano@linaro.org>, Tomasz Figa <tomasz.figa@gmail.com>, devicetree@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>, Simon Horman <horms@verge.net.au>, Magnus Damm <magnus.damm@gmail.com>, Ben Dooks <ben-linux@fluff.org>, Kukjin Kim <kgene.kim@samsung.com>, Stephen Boyd <sboyd@codeaurora.org>, Philipp Zabel <philipp.zabel@gmail.com>, Mark Brown <broonie@kernel.org>, Wolfram Sang <wsa@the-dreams.de>, Chris Ball <chris@printf.net>, Russell King <linux@arm.linux.org.uk>, Ulf Hansson <ulf.hansson@linaro.org> Subject: [PATCH v4 8/9] amba: Add support for attach/detach of PM domains Date: Tue, 9 Sep 2014 13:36:09 +0200 [thread overview] Message-ID: <1410262570-22785-9-git-send-email-ulf.hansson@linaro.org> (raw) In-Reply-To: <1410262570-22785-1-git-send-email-ulf.hansson@linaro.org> AMBA devices may on some SoCs resides in PM domains. To be able to manage these devices from there, let's try to attach devices to their corresponding PM domain during the probe phase. To reverse these actions at the remove phase, we try to detach the device from its PM domain. Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Reviewed-by: Kevin Hilman <khilman@linaro.org> --- drivers/amba/bus.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c index 3cf61a1..8f52393 100644 --- a/drivers/amba/bus.c +++ b/drivers/amba/bus.c @@ -182,9 +182,15 @@ static int amba_probe(struct device *dev) int ret; do { + ret = dev_pm_domain_attach(dev, true); + if (ret == -EPROBE_DEFER) + break; + ret = amba_get_enable_pclk(pcdev); - if (ret) + if (ret) { + dev_pm_domain_detach(dev, true); break; + } pm_runtime_get_noresume(dev); pm_runtime_set_active(dev); @@ -199,6 +205,7 @@ static int amba_probe(struct device *dev) pm_runtime_put_noidle(dev); amba_put_disable_pclk(pcdev); + dev_pm_domain_detach(dev, true); } while (0); return ret; @@ -220,6 +227,7 @@ static int amba_remove(struct device *dev) pm_runtime_put_noidle(dev); amba_put_disable_pclk(pcdev); + dev_pm_domain_detach(dev, true); return ret; } -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: ulf.hansson@linaro.org (Ulf Hansson) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 8/9] amba: Add support for attach/detach of PM domains Date: Tue, 9 Sep 2014 13:36:09 +0200 [thread overview] Message-ID: <1410262570-22785-9-git-send-email-ulf.hansson@linaro.org> (raw) In-Reply-To: <1410262570-22785-1-git-send-email-ulf.hansson@linaro.org> AMBA devices may on some SoCs resides in PM domains. To be able to manage these devices from there, let's try to attach devices to their corresponding PM domain during the probe phase. To reverse these actions at the remove phase, we try to detach the device from its PM domain. Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Reviewed-by: Kevin Hilman <khilman@linaro.org> --- drivers/amba/bus.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c index 3cf61a1..8f52393 100644 --- a/drivers/amba/bus.c +++ b/drivers/amba/bus.c @@ -182,9 +182,15 @@ static int amba_probe(struct device *dev) int ret; do { + ret = dev_pm_domain_attach(dev, true); + if (ret == -EPROBE_DEFER) + break; + ret = amba_get_enable_pclk(pcdev); - if (ret) + if (ret) { + dev_pm_domain_detach(dev, true); break; + } pm_runtime_get_noresume(dev); pm_runtime_set_active(dev); @@ -199,6 +205,7 @@ static int amba_probe(struct device *dev) pm_runtime_put_noidle(dev); amba_put_disable_pclk(pcdev); + dev_pm_domain_detach(dev, true); } while (0); return ret; @@ -220,6 +227,7 @@ static int amba_remove(struct device *dev) pm_runtime_put_noidle(dev); amba_put_disable_pclk(pcdev); + dev_pm_domain_detach(dev, true); return ret; } -- 1.9.1
next prev parent reply other threads:[~2014-09-09 11:37 UTC|newest] Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-04 13:52 [PATCH v3 0/9] PM / Domains: Generic OF-based support Ulf Hansson 2014-09-04 13:52 ` Ulf Hansson 2014-09-04 13:52 ` [PATCH v3 1/9] ACPI / PM: Let acpi_dev_pm_detach() return an error code Ulf Hansson 2014-09-04 13:52 ` Ulf Hansson 2014-08-23 22:45 ` Pavel Machek 2014-08-23 22:45 ` Pavel Machek 2014-09-07 22:12 ` Rafael J. Wysocki 2014-09-07 22:12 ` Rafael J. Wysocki 2014-09-04 13:52 ` [PATCH v3 2/9] PM / Domains: Add generic OF-based PM domain look-up Ulf Hansson 2014-09-04 13:52 ` Ulf Hansson 2014-09-07 22:13 ` Rafael J. Wysocki 2014-09-07 22:13 ` Rafael J. Wysocki 2014-09-08 7:26 ` Ulf Hansson 2014-09-08 7:26 ` Ulf Hansson 2014-09-08 21:04 ` Rafael J. Wysocki 2014-09-08 21:04 ` Rafael J. Wysocki 2014-09-08 21:08 ` Rafael J. Wysocki 2014-09-08 21:08 ` Rafael J. Wysocki 2014-09-08 20:53 ` Geert Uytterhoeven 2014-09-08 20:53 ` Geert Uytterhoeven [not found] ` <CAMuHMdURbp8a0Ps2sZUZn7UHcWXZvRgS-4ubk1r=wGgXZ1PHmA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2014-09-08 21:26 ` Rafael J. Wysocki 2014-09-08 21:26 ` Rafael J. Wysocki 2014-09-09 11:40 ` Mark Brown 2014-09-09 11:40 ` Mark Brown 2014-09-09 13:45 ` Rafael J. Wysocki 2014-09-09 13:45 ` Rafael J. Wysocki 2014-09-08 20:53 ` Tomasz Figa 2014-09-08 20:53 ` Tomasz Figa 2014-09-09 7:04 ` Ulf Hansson 2014-09-09 7:04 ` Ulf Hansson 2014-09-04 13:52 ` [PATCH v3 3/9] PM / Domains: Add APIs to attach/detach a PM domain for a device Ulf Hansson 2014-09-04 13:52 ` Ulf Hansson 2014-09-08 22:11 ` Rafael J. Wysocki 2014-09-08 22:11 ` Rafael J. Wysocki 2014-09-04 13:52 ` [PATCH v3 4/9] drivercore / platform: Convert to dev_pm_domain_attach|detach() Ulf Hansson 2014-09-04 13:52 ` Ulf Hansson 2014-09-04 13:52 ` [PATCH v3 5/9] i2c: core: " Ulf Hansson 2014-09-04 13:52 ` Ulf Hansson 2014-09-04 13:52 ` [PATCH v3 6/9] mmc: sdio: " Ulf Hansson 2014-09-04 13:52 ` Ulf Hansson 2014-09-04 13:52 ` [PATCH v3 7/9] spi: core: " Ulf Hansson 2014-09-04 13:52 ` Ulf Hansson 2014-09-04 13:52 ` [PATCH v3 8/9] amba: Add support for attach/detach of PM domains Ulf Hansson 2014-09-04 13:52 ` Ulf Hansson 2014-09-04 13:52 ` [PATCH v3 9/9] ARM: exynos: Move to generic PM domain DT bindings Ulf Hansson 2014-09-04 13:52 ` Ulf Hansson 2014-09-05 15:39 ` [PATCH v3 0/9] PM / Domains: Generic OF-based support Kevin Hilman 2014-09-05 15:39 ` Kevin Hilman 2014-09-09 11:36 ` [PATCH v4 " Ulf Hansson 2014-09-09 11:36 ` Ulf Hansson 2014-09-09 11:36 ` [PATCH v4 1/9] ACPI / PM: Let acpi_dev_pm_detach() return an error code Ulf Hansson 2014-09-09 11:36 ` Ulf Hansson 2014-09-12 21:05 ` [v4,1/9] " Dmitry Torokhov 2014-09-12 21:05 ` [v4, 1/9] " Dmitry Torokhov 2014-09-14 16:38 ` [v4,1/9] " Rafael J. Wysocki 2014-09-14 16:38 ` [v4, 1/9] " Rafael J. Wysocki 2014-09-15 16:53 ` [v4,1/9] " Dmitry Torokhov 2014-09-15 16:53 ` [v4, 1/9] " Dmitry Torokhov 2014-09-15 23:36 ` [v4,1/9] " Rafael J. Wysocki 2014-09-15 23:36 ` [v4, 1/9] " Rafael J. Wysocki 2014-09-17 18:25 ` [v4,1/9] " Ulf Hansson 2014-09-17 18:25 ` [v4, 1/9] " Ulf Hansson 2014-09-17 20:10 ` [v4,1/9] " Dmitry Torokhov 2014-09-17 20:10 ` [v4, 1/9] " Dmitry Torokhov 2014-09-17 23:20 ` [v4,1/9] " Ulf Hansson 2014-09-17 23:20 ` [v4, 1/9] " Ulf Hansson 2014-09-17 23:43 ` [v4,1/9] " Dmitry Torokhov 2014-09-17 23:43 ` [v4, 1/9] " Dmitry Torokhov [not found] ` <20140917234331.GA28771-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org> 2014-09-18 0:35 ` [v4,1/9] " Ulf Hansson 2014-09-18 0:35 ` [v4, 1/9] " Ulf Hansson 2014-09-18 23:13 ` [v4,1/9] " Rafael J. Wysocki 2014-09-18 23:13 ` [v4, 1/9] " Rafael J. Wysocki 2014-09-09 11:36 ` [PATCH v4 2/9] PM / Domains: Add generic OF-based PM domain look-up Ulf Hansson 2014-09-09 11:36 ` Ulf Hansson 2014-09-09 11:36 ` [PATCH v4 3/9] PM / Domains: Add APIs to attach/detach a PM domain for a device Ulf Hansson 2014-09-09 11:36 ` Ulf Hansson 2014-09-09 11:36 ` [PATCH v4 4/9] drivercore / platform: Convert to dev_pm_domain_attach|detach() Ulf Hansson 2014-09-09 11:36 ` Ulf Hansson 2014-09-09 13:46 ` Rafael J. Wysocki 2014-09-09 13:46 ` Rafael J. Wysocki 2014-09-09 11:36 ` [PATCH v4 5/9] i2c: core: " Ulf Hansson 2014-09-09 11:36 ` Ulf Hansson 2014-09-09 11:36 ` [PATCH v4 6/9] mmc: sdio: " Ulf Hansson 2014-09-09 11:36 ` Ulf Hansson 2014-09-09 11:36 ` [PATCH v4 7/9] spi: core: " Ulf Hansson 2014-09-09 11:36 ` Ulf Hansson 2014-09-09 11:36 ` Ulf Hansson [this message] 2014-09-09 11:36 ` [PATCH v4 8/9] amba: Add support for attach/detach of PM domains Ulf Hansson 2014-09-09 11:36 ` [PATCH v4 9/9] ARM: exynos: Move to generic PM domain DT bindings Ulf Hansson 2014-09-09 11:36 ` Ulf Hansson 2014-09-09 11:43 ` [PATCH v4 0/9] PM / Domains: Generic OF-based support Tomasz Figa 2014-09-09 11:43 ` Tomasz Figa 2014-09-09 11:54 ` Mark Brown 2014-09-09 11:54 ` Mark Brown 2014-09-09 12:45 ` Ulf Hansson 2014-09-09 12:45 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1410262570-22785-9-git-send-email-ulf.hansson@linaro.org \ --to=ulf.hansson@linaro.org \ --cc=ben-linux@fluff.org \ --cc=broonie@kernel.org \ --cc=chris@printf.net \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=geert+renesas@glider.be \ --cc=gregkh@linuxfoundation.org \ --cc=horms@verge.net.au \ --cc=kgene.kim@samsung.com \ --cc=khilman@linaro.org \ --cc=len.brown@intel.com \ --cc=linus.walleij@linaro.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=magnus.damm@gmail.com \ --cc=pavel@ucw.cz \ --cc=philipp.zabel@gmail.com \ --cc=rjw@rjwysocki.net \ --cc=sboyd@codeaurora.org \ --cc=stern@rowland.harvard.edu \ --cc=tomasz.figa@gmail.com \ --cc=wsa@the-dreams.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.