* [PATCH iproute2 1/2] ip/vxlan: add a help for ageing and maxaddress options
@ 2014-09-09 14:55 Nicolas Dichtel
2014-09-09 14:55 ` [PATCH iproute2 2/2] ip/vxlan: fix display of maxaddress option Nicolas Dichtel
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Dichtel @ 2014-09-09 14:55 UTC (permalink / raw)
To: shemminger; +Cc: netdev, Nicolas Dichtel
These options were missing in usage and man pages.
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
ip/iplink_vxlan.c | 1 +
man/man8/ip-link.8.in | 12 ++++++++++++
2 files changed, 13 insertions(+)
diff --git a/ip/iplink_vxlan.c b/ip/iplink_vxlan.c
index 53c50accde89..8aa25cd5fe52 100644
--- a/ip/iplink_vxlan.c
+++ b/ip/iplink_vxlan.c
@@ -28,6 +28,7 @@ static void explain(void)
fprintf(stderr, " [ dstport PORT ] [ srcport MIN MAX ]\n");
fprintf(stderr, " [ [no]learning ] [ [no]proxy ] [ [no]rsc ]\n");
fprintf(stderr, " [ [no]l2miss ] [ [no]l3miss ]\n");
+ fprintf(stderr, " [ ageing SECONDS ] [ maxaddress NUMBER ]\n");
fprintf(stderr, "\n");
fprintf(stderr, "Where: VNI := 0-16777215\n");
fprintf(stderr, " ADDR := { IP_ADDRESS | any }\n");
diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
index 29d12fb2c773..383917a63669 100644
--- a/man/man8/ip-link.8.in
+++ b/man/man8/ip-link.8.in
@@ -262,6 +262,10 @@ the following additional arguments are supported:
.I "[no]l2miss "
.R " ] [ "
.I "[no]l3miss "
+.R " ] [ "
+.BI ageing " SECONDS "
+.R " ] [ "
+.BI maxaddress " NUMBER "
.R " ]"
.in +8
@@ -326,6 +330,14 @@ are entered into the VXLAN device forwarding database.
.I [no]l3miss
- specifies if netlink IP ADDR miss notifications are generated.
+.sp
+.BI ageing " SECONDS"
+- specifies the lifetime in seconds of FDB entries learnt by the kernel.
+
+.sp
+.BI maxaddress " NUMBER"
+- specifies the maximum number of FDB entries.
+
.in -8
.TP
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH iproute2 2/2] ip/vxlan: fix display of maxaddress option
2014-09-09 14:55 [PATCH iproute2 1/2] ip/vxlan: add a help for ageing and maxaddress options Nicolas Dichtel
@ 2014-09-09 14:55 ` Nicolas Dichtel
2014-09-28 23:21 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Dichtel @ 2014-09-09 14:55 UTC (permalink / raw)
To: shemminger; +Cc: netdev, Nicolas Dichtel
Parenthesis are required else maxaddr value is a bool and thus output is always
1 when the option is set.
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
ip/iplink_vxlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/iplink_vxlan.c b/ip/iplink_vxlan.c
index 8aa25cd5fe52..d92cfe8156e4 100644
--- a/ip/iplink_vxlan.c
+++ b/ip/iplink_vxlan.c
@@ -361,7 +361,7 @@ static void vxlan_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
}
if (tb[IFLA_VXLAN_LIMIT] &&
- (maxaddr = rta_getattr_u32(tb[IFLA_VXLAN_LIMIT]) != 0))
+ ((maxaddr = rta_getattr_u32(tb[IFLA_VXLAN_LIMIT])) != 0))
fprintf(f, "maxaddr %u ", maxaddr);
}
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH iproute2 2/2] ip/vxlan: fix display of maxaddress option
2014-09-09 14:55 ` [PATCH iproute2 2/2] ip/vxlan: fix display of maxaddress option Nicolas Dichtel
@ 2014-09-28 23:21 ` Stephen Hemminger
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2014-09-28 23:21 UTC (permalink / raw)
To: Nicolas Dichtel; +Cc: shemminger, netdev
On Tue, 9 Sep 2014 16:55:11 +0200
Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote:
> Parenthesis are required else maxaddr value is a bool and thus output is always
> 1 when the option is set.
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> ---
> ip/iplink_vxlan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Both patches applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-28 23:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-09 14:55 [PATCH iproute2 1/2] ip/vxlan: add a help for ageing and maxaddress options Nicolas Dichtel
2014-09-09 14:55 ` [PATCH iproute2 2/2] ip/vxlan: fix display of maxaddress option Nicolas Dichtel
2014-09-28 23:21 ` Stephen Hemminger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.