From: Dan Streetman <ddstreet@ieee.org> To: Minchan Kim <minchan@kernel.org> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>, Nitin Gupta <ngupta@vflare.org>, Seth Jennings <sjennings@variantweb.net>, Andrew Morton <akpm@linux-foundation.org>, Dan Streetman <ddstreet@ieee.org> Subject: [PATCH 02/10] zsmalloc: add fullness group list for ZS_FULL zspages Date: Thu, 11 Sep 2014 16:53:53 -0400 [thread overview] Message-ID: <1410468841-320-3-git-send-email-ddstreet@ieee.org> (raw) In-Reply-To: <1410468841-320-1-git-send-email-ddstreet@ieee.org> Move ZS_FULL into section of fullness_group entries that are tracked in the class fullness_lists. Without this change, full zspages are untracked by zsmalloc; they are only moved back onto one of the tracked lists (ZS_ALMOST_FULL or ZS_ALMOST_EMPTY) when a zsmalloc user frees one or more of its contained objects. This is required for zsmalloc shrinking, which needs to be able to search all zspages in a zsmalloc pool, to find one to shrink. Signed-off-by: Dan Streetman <ddstreet@ieee.org> Cc: Minchan Kim <minchan@kernel.org> --- mm/zsmalloc.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 03aa72f..fedb70f 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -159,16 +159,19 @@ ZS_SIZE_CLASS_DELTA + 1) /* - * We do not maintain any list for completely empty or full pages + * We do not maintain any list for completely empty zspages, + * since a zspage is freed when it becomes empty. */ enum fullness_group { ZS_ALMOST_FULL, ZS_ALMOST_EMPTY, + ZS_FULL, + _ZS_NR_FULLNESS_GROUPS, ZS_EMPTY, - ZS_FULL }; +#define _ZS_NR_AVAILABLE_FULLNESS_GROUPS ZS_FULL /* * We assign a page to ZS_ALMOST_EMPTY fullness group when: @@ -722,12 +725,12 @@ cleanup: return first_page; } -static struct page *find_get_zspage(struct size_class *class) +static struct page *find_available_zspage(struct size_class *class) { int i; struct page *page; - for (i = 0; i < _ZS_NR_FULLNESS_GROUPS; i++) { + for (i = 0; i < _ZS_NR_AVAILABLE_FULLNESS_GROUPS; i++) { page = class->fullness_list[i]; if (page) break; @@ -1013,7 +1016,7 @@ unsigned long zs_malloc(struct zs_pool *pool, size_t size) BUG_ON(class_idx != class->index); spin_lock(&class->lock); - first_page = find_get_zspage(class); + first_page = find_available_zspage(class); if (!first_page) { spin_unlock(&class->lock); -- 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Dan Streetman <ddstreet@ieee.org> To: Minchan Kim <minchan@kernel.org> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>, Nitin Gupta <ngupta@vflare.org>, Seth Jennings <sjennings@variantweb.net>, Andrew Morton <akpm@linux-foundation.org>, Dan Streetman <ddstreet@ieee.org> Subject: [PATCH 02/10] zsmalloc: add fullness group list for ZS_FULL zspages Date: Thu, 11 Sep 2014 16:53:53 -0400 [thread overview] Message-ID: <1410468841-320-3-git-send-email-ddstreet@ieee.org> (raw) In-Reply-To: <1410468841-320-1-git-send-email-ddstreet@ieee.org> Move ZS_FULL into section of fullness_group entries that are tracked in the class fullness_lists. Without this change, full zspages are untracked by zsmalloc; they are only moved back onto one of the tracked lists (ZS_ALMOST_FULL or ZS_ALMOST_EMPTY) when a zsmalloc user frees one or more of its contained objects. This is required for zsmalloc shrinking, which needs to be able to search all zspages in a zsmalloc pool, to find one to shrink. Signed-off-by: Dan Streetman <ddstreet@ieee.org> Cc: Minchan Kim <minchan@kernel.org> --- mm/zsmalloc.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 03aa72f..fedb70f 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -159,16 +159,19 @@ ZS_SIZE_CLASS_DELTA + 1) /* - * We do not maintain any list for completely empty or full pages + * We do not maintain any list for completely empty zspages, + * since a zspage is freed when it becomes empty. */ enum fullness_group { ZS_ALMOST_FULL, ZS_ALMOST_EMPTY, + ZS_FULL, + _ZS_NR_FULLNESS_GROUPS, ZS_EMPTY, - ZS_FULL }; +#define _ZS_NR_AVAILABLE_FULLNESS_GROUPS ZS_FULL /* * We assign a page to ZS_ALMOST_EMPTY fullness group when: @@ -722,12 +725,12 @@ cleanup: return first_page; } -static struct page *find_get_zspage(struct size_class *class) +static struct page *find_available_zspage(struct size_class *class) { int i; struct page *page; - for (i = 0; i < _ZS_NR_FULLNESS_GROUPS; i++) { + for (i = 0; i < _ZS_NR_AVAILABLE_FULLNESS_GROUPS; i++) { page = class->fullness_list[i]; if (page) break; @@ -1013,7 +1016,7 @@ unsigned long zs_malloc(struct zs_pool *pool, size_t size) BUG_ON(class_idx != class->index); spin_lock(&class->lock); - first_page = find_get_zspage(class); + first_page = find_available_zspage(class); if (!first_page) { spin_unlock(&class->lock); -- 1.8.3.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-09-11 20:54 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-11 20:53 [PATCH 00/10] implement zsmalloc shrinking Dan Streetman 2014-09-11 20:53 ` Dan Streetman 2014-09-11 20:53 ` [PATCH 01/10] zsmalloc: fix init_zspage free obj linking Dan Streetman 2014-09-11 20:53 ` Dan Streetman 2014-09-12 3:16 ` Seth Jennings 2014-09-12 4:59 ` Minchan Kim 2014-09-12 4:59 ` Minchan Kim 2014-09-12 16:43 ` Dan Streetman 2014-09-12 16:43 ` Dan Streetman 2014-09-14 23:24 ` Minchan Kim 2014-09-14 23:24 ` Minchan Kim 2014-09-15 20:58 ` [PATCH] zsmalloc: simplify " Dan Streetman 2014-09-15 20:58 ` Dan Streetman 2014-09-16 2:41 ` Minchan Kim 2014-09-16 2:41 ` Minchan Kim 2014-09-11 20:53 ` Dan Streetman [this message] 2014-09-11 20:53 ` [PATCH 02/10] zsmalloc: add fullness group list for ZS_FULL zspages Dan Streetman 2014-09-11 20:53 ` [PATCH 03/10] zsmalloc: always update lru ordering of each zspage Dan Streetman 2014-09-11 20:53 ` Dan Streetman 2014-09-12 3:20 ` Seth Jennings 2014-09-11 20:53 ` [PATCH 04/10] zsmalloc: move zspage obj freeing to separate function Dan Streetman 2014-09-11 20:53 ` Dan Streetman 2014-09-11 20:53 ` [PATCH 05/10] zsmalloc: add atomic index to find zspage to reclaim Dan Streetman 2014-09-11 20:53 ` Dan Streetman 2014-09-11 20:53 ` [PATCH 06/10] zsmalloc: add zs_ops to zs_pool Dan Streetman 2014-09-11 20:53 ` Dan Streetman 2014-09-11 20:53 ` [PATCH 07/10] zsmalloc: add obj_handle_is_free() Dan Streetman 2014-09-11 20:53 ` Dan Streetman 2014-09-11 20:53 ` [PATCH 08/10] zsmalloc: add reclaim_zspage() Dan Streetman 2014-09-11 20:53 ` Dan Streetman 2014-09-11 20:54 ` [PATCH 09/10] zsmalloc: add zs_shrink() Dan Streetman 2014-09-11 20:54 ` Dan Streetman 2014-09-11 20:54 ` [PATCH 10/10] zsmalloc: implement zs_zpool_shrink() with zs_shrink() Dan Streetman 2014-09-11 20:54 ` Dan Streetman 2014-09-12 3:14 ` [PATCH 00/10] implement zsmalloc shrinking Seth Jennings 2014-09-12 5:46 ` Minchan Kim 2014-09-12 5:46 ` Minchan Kim 2014-09-12 17:05 ` Dan Streetman 2014-09-12 17:05 ` Dan Streetman 2014-09-15 0:00 ` Minchan Kim 2014-09-15 0:00 ` Minchan Kim 2014-09-15 14:29 ` Dan Streetman 2014-09-15 14:29 ` Dan Streetman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1410468841-320-3-git-send-email-ddstreet@ieee.org \ --to=ddstreet@ieee.org \ --cc=akpm@linux-foundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=minchan@kernel.org \ --cc=ngupta@vflare.org \ --cc=sergey.senozhatsky@gmail.com \ --cc=sjennings@variantweb.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.