* [Buildroot] [PATCH 1/2] libqrencode: link with pthread to avoid build failure
@ 2014-09-14 14:14 Danomi Manchego
2014-09-14 14:14 ` [Buildroot] [PATCH 2/2] libqrencode: needs thread support Danomi Manchego
2014-09-14 21:14 ` [Buildroot] [PATCH 1/2] libqrencode: link with pthread to avoid build failure Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Danomi Manchego @ 2014-09-14 14:14 UTC (permalink / raw)
To: buildroot
Fixes: http://autobuild.buildroot.net/results/1ca0719dd1fe0bbc528ec99b5bc2b42e985bfdca/
Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
---
package/libqrencode/libqrencode.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/libqrencode/libqrencode.mk b/package/libqrencode/libqrencode.mk
index d445763..085d0ae 100644
--- a/package/libqrencode/libqrencode.mk
+++ b/package/libqrencode/libqrencode.mk
@@ -11,6 +11,8 @@ LIBQRENCODE_INSTALL_STAGING = YES
LIBQRENCODE_LICENSE = LGPLv2.1+
LIBQRENCODE_LICENSE_FILES = COPYING
+LIBQRENCODE_CONF_OPT = LIBS='-pthread'
+
ifeq ($(BR2_PACKAGE_LIBQRENCODE_TOOLS),y)
LIBQRENCODE_CONF_OPT += --with-tools=yes
LIBQRENCODE_DEPENDENCIES += libpng
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 2/2] libqrencode: needs thread support
2014-09-14 14:14 [Buildroot] [PATCH 1/2] libqrencode: link with pthread to avoid build failure Danomi Manchego
@ 2014-09-14 14:14 ` Danomi Manchego
2014-09-14 21:14 ` [Buildroot] [PATCH 1/2] libqrencode: link with pthread to avoid build failure Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Danomi Manchego @ 2014-09-14 14:14 UTC (permalink / raw)
To: buildroot
Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
---
package/libqrencode/Config.in | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/libqrencode/Config.in b/package/libqrencode/Config.in
index b866626..2888113 100644
--- a/package/libqrencode/Config.in
+++ b/package/libqrencode/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_LIBQRENCODE
bool "libqrencode"
+ depends on BR2_TOOLCHAIN_HAS_THREADS
help
libqrencode is a C library for encoding data in a QR Code
symbol, a kind of 2D symbology that can be scanned by handy
@@ -18,3 +19,6 @@ config BR2_PACKAGE_LIBQRENCODE_TOOLS
Build command-line tools
endif #BR2_PACKAGE_LIBQRENCODE
+
+comment "libqrencode needs a toolchain w/ threads"
+ depends on !BR2_TOOLCHAIN_HAS_THREADS
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/2] libqrencode: link with pthread to avoid build failure
2014-09-14 14:14 [Buildroot] [PATCH 1/2] libqrencode: link with pthread to avoid build failure Danomi Manchego
2014-09-14 14:14 ` [Buildroot] [PATCH 2/2] libqrencode: needs thread support Danomi Manchego
@ 2014-09-14 21:14 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2014-09-14 21:14 UTC (permalink / raw)
To: buildroot
>>>>> "Danomi" == Danomi Manchego <danomimanchego123@gmail.com> writes:
> Fixes: http://autobuild.buildroot.net/results/1ca0719dd1fe0bbc528ec99b5bc2b42e985bfdca/
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
> ---
> package/libqrencode/libqrencode.mk | 2 ++
> 1 file changed, 2 insertions(+)
> diff --git a/package/libqrencode/libqrencode.mk b/package/libqrencode/libqrencode.mk
> index d445763..085d0ae 100644
> --- a/package/libqrencode/libqrencode.mk
> +++ b/package/libqrencode/libqrencode.mk
> @@ -11,6 +11,8 @@ LIBQRENCODE_INSTALL_STAGING = YES
> LIBQRENCODE_LICENSE = LGPLv2.1+
> LIBQRENCODE_LICENSE_FILES = COPYING
> +LIBQRENCODE_CONF_OPT = LIBS='-pthread'
> +
Looking at configure.ac I see that pthread support is optional, so this
should only be done if BR2_TOOLCHAIN_HAS_THREADS, otherwise we need to
pass --disable-thread-safety.
Committed with that fixed, thanks. The 2nd patch then doesn't make any
sense, so I've dropped that one.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-14 21:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-14 14:14 [Buildroot] [PATCH 1/2] libqrencode: link with pthread to avoid build failure Danomi Manchego
2014-09-14 14:14 ` [Buildroot] [PATCH 2/2] libqrencode: needs thread support Danomi Manchego
2014-09-14 21:14 ` [Buildroot] [PATCH 1/2] libqrencode: link with pthread to avoid build failure Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.