* [PATCH net 0/2] Fix randconfig errros in bnx2i/bnx2fc caused by IPV6
@ 2014-09-15 20:45 Anish Bhatt
2014-09-15 20:45 ` [PATCH net 1/2] scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET Anish Bhatt
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Anish Bhatt @ 2014-09-15 20:45 UTC (permalink / raw)
To: netdev
Cc: linux-scsi, davem, JBottomley, mchan, eddie.wai, rdunlap,
jim.epost, Anish Bhatt
Just like CNIC bnx2i/bnx2fc also have their tristate dependent on IPV6, however
using the same solution as CNIC can cause recursive dependecies during make.
Based on suggestions by Randy Dunlap, SCSI_NETLINK now depends on NET instead
of selecting NET. Second patch fixes the actual randconfig error.
Entire thread can be followed here : https://lkml.org/lkml/2014/9/9/500
-Anish
Fixes: c99d667e8527 ("cnic : Cleanup CONFIG_IPV6 & VLAN check")
Anish Bhatt (2):
scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting
NET
bnx2i/bnx2fc : fix randconfig error
drivers/scsi/Kconfig | 2 +-
drivers/scsi/bnx2fc/Kconfig | 1 +
drivers/scsi/bnx2i/Kconfig | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
--
2.1.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH net 1/2] scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET
2014-09-15 20:45 [PATCH net 0/2] Fix randconfig errros in bnx2i/bnx2fc caused by IPV6 Anish Bhatt
@ 2014-09-15 20:45 ` Anish Bhatt
2014-09-16 0:20 ` [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI && NET Randy Dunlap
2014-09-15 20:45 ` [PATCH net 2/2] bnx2i/bnx2fc : fix randconfig error in next-20140909 Anish Bhatt
2014-09-15 21:45 ` [PATCH net 0/2] Fix randconfig errros in bnx2i/bnx2fc caused by IPV6 David Miller
2 siblings, 1 reply; 9+ messages in thread
From: Anish Bhatt @ 2014-09-15 20:45 UTC (permalink / raw)
To: netdev
Cc: linux-scsi, davem, JBottomley, mchan, eddie.wai, rdunlap,
jim.epost, Anish Bhatt
Required for avoiding recursive dependencies in the Kconfig, brought out
by fixing randconfig error for bnx2i/bnx2fc in the patch that follows.
As suggested by Randy Dunlap
Signed-off-by: Anish Bhatt <anish@chelsio.com>
---
drivers/scsi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 18a3358..756cdda 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -43,7 +43,7 @@ config SCSI_DMA
config SCSI_NETLINK
bool
default n
- select NET
+ depends on NET
config SCSI_PROC_FS
bool "legacy /proc/scsi/ support"
--
2.1.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH net 2/2] bnx2i/bnx2fc : fix randconfig error in next-20140909
2014-09-15 20:45 [PATCH net 0/2] Fix randconfig errros in bnx2i/bnx2fc caused by IPV6 Anish Bhatt
2014-09-15 20:45 ` [PATCH net 1/2] scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET Anish Bhatt
@ 2014-09-15 20:45 ` Anish Bhatt
2014-09-15 21:45 ` [PATCH net 0/2] Fix randconfig errros in bnx2i/bnx2fc caused by IPV6 David Miller
2 siblings, 0 replies; 9+ messages in thread
From: Anish Bhatt @ 2014-09-15 20:45 UTC (permalink / raw)
To: netdev
Cc: linux-scsi, davem, JBottomley, mchan, eddie.wai, rdunlap,
jim.epost, Anish Bhatt
Just like CNIC, tristate of these two modules is also dependent on IPV6.
These need to be handled separately as they select CNIC, which can override
tristate for CNIC from 'm' to 'y', which can cause build failures when ipv6 is
compiled as a module even if CNIC's Kconfig will only 'm' or 'n' when ipv6 is
compiled as a module.
Fixes: c99d667e8527 ("cnic : Cleanup CONFIG_IPV6 & VLAN check")
Signed-off-by: Anish Bhatt <anish@chelsio.com>
---
drivers/scsi/bnx2fc/Kconfig | 1 +
drivers/scsi/bnx2i/Kconfig | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/scsi/bnx2fc/Kconfig b/drivers/scsi/bnx2fc/Kconfig
index f245d54..02b0ba8 100644
--- a/drivers/scsi/bnx2fc/Kconfig
+++ b/drivers/scsi/bnx2fc/Kconfig
@@ -1,6 +1,7 @@
config SCSI_BNX2X_FCOE
tristate "QLogic NetXtreme II FCoE support"
depends on PCI
+ depends on (IPV6 || IPV6=n)
select NETDEVICES
select ETHERNET
select NET_VENDOR_BROADCOM
diff --git a/drivers/scsi/bnx2i/Kconfig b/drivers/scsi/bnx2i/Kconfig
index 44ce54e..ba30ff8 100644
--- a/drivers/scsi/bnx2i/Kconfig
+++ b/drivers/scsi/bnx2i/Kconfig
@@ -2,6 +2,7 @@ config SCSI_BNX2_ISCSI
tristate "QLogic NetXtreme II iSCSI support"
depends on NET
depends on PCI
+ depends on (IPV6 || IPV6=n)
select SCSI_ISCSI_ATTRS
select NETDEVICES
select ETHERNET
--
2.1.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH net 0/2] Fix randconfig errros in bnx2i/bnx2fc caused by IPV6
2014-09-15 20:45 [PATCH net 0/2] Fix randconfig errros in bnx2i/bnx2fc caused by IPV6 Anish Bhatt
2014-09-15 20:45 ` [PATCH net 1/2] scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET Anish Bhatt
2014-09-15 20:45 ` [PATCH net 2/2] bnx2i/bnx2fc : fix randconfig error in next-20140909 Anish Bhatt
@ 2014-09-15 21:45 ` David Miller
2 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2014-09-15 21:45 UTC (permalink / raw)
To: anish
Cc: netdev, linux-scsi, JBottomley, mchan, eddie.wai, rdunlap, jim.epost
From: Anish Bhatt <anish@chelsio.com>
Date: Mon, 15 Sep 2014 13:45:19 -0700
> Just like CNIC bnx2i/bnx2fc also have their tristate dependent on IPV6, however
> using the same solution as CNIC can cause recursive dependecies during make.
>
> Based on suggestions by Randy Dunlap, SCSI_NETLINK now depends on NET instead
> of selecting NET. Second patch fixes the actual randconfig error.
>
> Entire thread can be followed here : https://lkml.org/lkml/2014/9/9/500
> -Anish
>
> Fixes: c99d667e8527 ("cnic : Cleanup CONFIG_IPV6 & VLAN check")
Series applied, thank you.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI && NET
2014-09-15 20:45 ` [PATCH net 1/2] scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET Anish Bhatt
@ 2014-09-16 0:20 ` Randy Dunlap
2014-09-16 3:00 ` Anish Bhatt
2014-09-16 4:07 ` David Miller
0 siblings, 2 replies; 9+ messages in thread
From: Randy Dunlap @ 2014-09-16 0:20 UTC (permalink / raw)
To: Anish Bhatt, netdev, JBottomley, David Miller
Cc: linux-scsi, mchan, eddie.wai, jim.epost
From: Randy Dunlap <rdunlap@infradead.org>
Fix build errors when CONFIG_SCSI_NETLINK is enabled but
CONFIG_NET is not enabled:
drivers/built-in.o: In function `scsi_nl_rcv_msg':
scsi_netlink.c:(.text+0x1850fa): undefined reference to `netlink_ack'
scsi_netlink.c:(.text+0x185105): undefined reference to `skb_pull'
scsi_netlink.c:(.text+0x18515d): undefined reference to `netlink_capable'
drivers/built-in.o: In function `scsi_netlink_init':
(.text+0x185244): undefined reference to `init_net'
drivers/built-in.o: In function `scsi_netlink_init':
(.text+0x185258): undefined reference to `__netlink_kernel_create'
drivers/built-in.o: In function `scsi_netlink_exit':
(.text+0x185291): undefined reference to `netlink_kernel_release'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
drivers/scsi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Based on Anish's previous SCSI_NETLINK patch.
Sorry about missing this one.
--- lnx-317-rc5.orig/drivers/scsi/Kconfig
+++ lnx-317-rc5/drivers/scsi/Kconfig
@@ -257,7 +257,7 @@ config SCSI_SPI_ATTRS
config SCSI_FC_ATTRS
tristate "FiberChannel Transport Attributes"
- depends on SCSI
+ depends on SCSI && NET
select SCSI_NETLINK
help
If you wish to export transport-specific information about
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI && NET
2014-09-16 0:20 ` [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI && NET Randy Dunlap
@ 2014-09-16 3:00 ` Anish Bhatt
2014-09-16 3:17 ` Randy Dunlap
2014-09-16 4:07 ` David Miller
1 sibling, 1 reply; 9+ messages in thread
From: Anish Bhatt @ 2014-09-16 3:00 UTC (permalink / raw)
To: Randy Dunlap, netdev, JBottomley, David Miller
Cc: linux-scsi, mchan, eddie.wai, jim.epost
> From : Randy Dunlap [rdunlap@infradead.org]
> Sent: Monday, September 15, 2014 5:20 PM
> To: Anish Bhatt; netdev@vger.kernel.org; JBottomley@parallels.com; David Miller
> Cc: linux-scsi@vger.kernel.org; mchan@broadcom.com; eddie.wai@broadcom.com; jim.epost@gmail.com
> Subject: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI && NET
>
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors when CONFIG_SCSI_NETLINK is enabled but
> CONFIG_NET is not enabled:
>
> drivers/built-in.o: In function `scsi_nl_rcv_msg':
> scsi_netlink.c:(.text+0x1850fa): undefined reference to `netlink_ack'
> scsi_netlink.c:(.text+0x185105): undefined reference to `skb_pull'
> scsi_netlink.c:(.text+0x18515d): undefined reference to `netlink_capable'
> drivers/built-in.o: In function `scsi_netlink_init':
> (.text+0x185244): undefined reference to `init_net'
> drivers/built-in.o: In function `scsi_netlink_init':
> (.text+0x185258): undefined reference to `__netlink_kernel_create'
> drivers/built-in.o: In function `scsi_netlink_exit':
> (.text+0x185291): undefined reference to `netlink_kernel_release'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Doesn't fix make warnings, but SCSI_FC_ATTRS can no longer be selected without
NET. Though both ia64 and powerpc emit a lot of unmet dependency warnings as is
on defconfig
Tested-by: Anish Bhatt <anish@chelsio.com>
> ---
> drivers/scsi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Based on Anish's previous SCSI_NETLINK patch.
> Sorry about missing this one.
>
> --- lnx-317-rc5.orig/drivers/scsi/Kconfig
> +++ lnx-317-rc5/drivers/scsi/Kconfig
> @@ -257,7 +257,7 @@ config SCSI_SPI_ATTRS
>
> config SCSI_FC_ATTRS
> tristate "FiberChannel Transport Attributes"
> - depends on SCSI
> + depends on SCSI && NET
> select SCSI_NETLINK
> help
> If you wish to export transport-specific information about
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI && NET
2014-09-16 3:00 ` Anish Bhatt
@ 2014-09-16 3:17 ` Randy Dunlap
2014-09-16 4:11 ` Anish Bhatt
0 siblings, 1 reply; 9+ messages in thread
From: Randy Dunlap @ 2014-09-16 3:17 UTC (permalink / raw)
To: Anish Bhatt, netdev, JBottomley, David Miller
Cc: linux-scsi, mchan, eddie.wai, jim.epost
On 09/15/14 20:00, Anish Bhatt wrote:
>
> Doesn't fix make warnings, but SCSI_FC_ATTRS can no longer be selected without
> NET. Though both ia64 and powerpc emit a lot of unmet dependency warnings as is
> on defconfig
You mean these kconfig warnings?
<quote>
After merging the net tree, today's linux-next build
(powerpc ppc64_defconfig) failed like this:
warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
</quote>
I'll look into those.
--
~Randy
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI && NET
2014-09-16 0:20 ` [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI && NET Randy Dunlap
2014-09-16 3:00 ` Anish Bhatt
@ 2014-09-16 4:07 ` David Miller
1 sibling, 0 replies; 9+ messages in thread
From: David Miller @ 2014-09-16 4:07 UTC (permalink / raw)
To: rdunlap
Cc: anish, netdev, JBottomley, linux-scsi, mchan, eddie.wai, jim.epost
From: Randy Dunlap <rdunlap@infradead.org>
Date: Mon, 15 Sep 2014 17:20:42 -0700
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors when CONFIG_SCSI_NETLINK is enabled but
> CONFIG_NET is not enabled:
...
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Applied, thanks a lot Randy.
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI && NET
2014-09-16 3:17 ` Randy Dunlap
@ 2014-09-16 4:11 ` Anish Bhatt
0 siblings, 0 replies; 9+ messages in thread
From: Anish Bhatt @ 2014-09-16 4:11 UTC (permalink / raw)
To: Randy Dunlap, netdev, JBottomley, David Miller
Cc: linux-scsi, mchan, eddie.wai, jim.epost
________________________________________
From: Randy Dunlap [rdunlap@infradead.org]
Sent: Monday, September 15, 2014 8:17 PM
To: Anish Bhatt; netdev@vger.kernel.org; JBottomley@parallels.com; David Miller
Cc: linux-scsi@vger.kernel.org; mchan@broadcom.com; eddie.wai@broadcom.com; jim.epost@gmail.com
Subject: Re: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI && NET
On 09/15/14 20:00, Anish Bhatt wrote:
>>
>> Doesn't fix make warnings, but SCSI_FC_ATTRS can no longer be selected without
>> NET. Though both ia64 and powerpc emit a lot of unmet dependency warnings as is
>> on defconfig
> You mean these kconfig warnings?
[....]
> I'll look into those.
>--
>~Randy
Yes, thanks
-Anish
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-09-16 4:11 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-15 20:45 [PATCH net 0/2] Fix randconfig errros in bnx2i/bnx2fc caused by IPV6 Anish Bhatt
2014-09-15 20:45 ` [PATCH net 1/2] scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET Anish Bhatt
2014-09-16 0:20 ` [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI && NET Randy Dunlap
2014-09-16 3:00 ` Anish Bhatt
2014-09-16 3:17 ` Randy Dunlap
2014-09-16 4:11 ` Anish Bhatt
2014-09-16 4:07 ` David Miller
2014-09-15 20:45 ` [PATCH net 2/2] bnx2i/bnx2fc : fix randconfig error in next-20140909 Anish Bhatt
2014-09-15 21:45 ` [PATCH net 0/2] Fix randconfig errros in bnx2i/bnx2fc caused by IPV6 David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.