All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] mesa3d: Add missing dependencies
@ 2014-09-16 15:58 Vicente Olivert Riera
  2014-09-16 20:07 ` Peter Korsgaard
  0 siblings, 1 reply; 4+ messages in thread
From: Vicente Olivert Riera @ 2014-09-16 15:58 UTC (permalink / raw)
  To: buildroot

Add xcb-dri3, xcb-present and xshmfence to mesa3d's dependencies.
Otherwise it will fail during the configure phase.

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/mesa3d/Config.in | 3 +++
 package/mesa3d/mesa3d.mk | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
index 74ebbed..c362467 100644
--- a/package/mesa3d/Config.in
+++ b/package/mesa3d/Config.in
@@ -3,11 +3,14 @@ menuconfig BR2_PACKAGE_MESA3D
 	select BR2_PACKAGE_LIBDRM
 	select BR2_PACKAGE_EXPAT
 	select BR2_PACKAGE_XPROTO_DRI2PROTO if BR2_PACKAGE_XORG7
+	select BR2_PACKAGE_XPROTO_DRI3PROTO if BR2_PACKAGE_XORG7
+	select BR2_PACKAGE_XPROTO_PRESENTPROTO if BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_XPROTO_XF86DRIPROTO if BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_XLIB_LIBX11 if BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_XLIB_LIBXEXT if BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_XLIB_LIBXDAMAGE if BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_XLIB_LIBXFIXES if BR2_PACKAGE_XORG7
+	select BR2_PACKAGE_XLIB_LIBXSHMFENCE if BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_LIBXCB if BR2_PACKAGE_XORG7
 	depends on BR2_PACKAGE_HAS_UDEV
 	depends on BR2_INSTALL_LIBSTDCPP
diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
index f986d0e..f5a274a 100644
--- a/package/mesa3d/mesa3d.mk
+++ b/package/mesa3d/mesa3d.mk
@@ -28,11 +28,14 @@ ifeq ($(BR2_PACKAGE_XORG7),y)
 MESA3D_DEPENDENCIES += \
 	xproto_xf86driproto \
 	xproto_dri2proto \
+	xproto_dri3proto \
+	xproto_presentproto \
 	xproto_glproto \
 	xlib_libX11 \
 	xlib_libXext \
 	xlib_libXdamage \
 	xlib_libXfixes \
+	xlib_libxshmfence \
 	libxcb
 MESA3D_CONF_OPT += --enable-glx
 # quote from mesa3d configure "Building xa requires at least one non swrast gallium driver."
-- 
1.9.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] mesa3d: Add missing dependencies
  2014-09-16 15:58 [Buildroot] [PATCH] mesa3d: Add missing dependencies Vicente Olivert Riera
@ 2014-09-16 20:07 ` Peter Korsgaard
  2014-09-17 13:12   ` Vicente Olivert Riera
  2014-09-20 12:39   ` Bernd Kuhls
  0 siblings, 2 replies; 4+ messages in thread
From: Peter Korsgaard @ 2014-09-16 20:07 UTC (permalink / raw)
  To: buildroot

>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:

 > Add xcb-dri3, xcb-present and xshmfence to mesa3d's dependencies.
 > Otherwise it will fail during the configure phase.

 > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

hmm, but we also have optional dri3 support since:

commit 1fcc621f0344c11ebaf7903545cd99d2f5b8ec9b
Author: Bernd Kuhls <bernd.kuhls@t-online.de>
Date:   Thu Jul 17 07:42:54 2014 +0200

    package/mesa3d: Fix optional DRI3 support

Looking at configure.ac, I think we should just disable dri support if
no dri drivers are enabled, E.G.:

diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
index f986d0e..31bbacf 100644
--- a/package/mesa3d/mesa3d.mk
+++ b/package/mesa3d/mesa3d.mk
@@ -75,7 +75,7 @@ endif
 
 ifeq ($(MESA3D_DRI_DRIVERS-y),)
 MESA3D_CONF_OPT += \
-       --without-dri-drivers
+       --without-dri-drivers --disable-dri
 else
 ifeq ($(BR2_PACKAGE_XPROTO_DRI3PROTO),y)
 MESA3D_DEPENDENCIES += xlib_libxshmfence xproto_dri3proto xproto_presentproto

What do the mesa3d experts say?

-- 
Bye, Peter Korsgaard

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] mesa3d: Add missing dependencies
  2014-09-16 20:07 ` Peter Korsgaard
@ 2014-09-17 13:12   ` Vicente Olivert Riera
  2014-09-20 12:39   ` Bernd Kuhls
  1 sibling, 0 replies; 4+ messages in thread
From: Vicente Olivert Riera @ 2014-09-17 13:12 UTC (permalink / raw)
  To: buildroot

On 09/16/2014 09:07 PM, Peter Korsgaard wrote:
>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
>
>   > Add xcb-dri3, xcb-present and xshmfence to mesa3d's dependencies.
>   > Otherwise it will fail during the configure phase.
>
>   > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>
> hmm, but we also have optional dri3 support since:
>
> commit 1fcc621f0344c11ebaf7903545cd99d2f5b8ec9b
> Author: Bernd Kuhls <bernd.kuhls@t-online.de>
> Date:   Thu Jul 17 07:42:54 2014 +0200
>
>      package/mesa3d: Fix optional DRI3 support
>
> Looking at configure.ac, I think we should just disable dri support if
> no dri drivers are enabled, E.G.:
>
> diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
> index f986d0e..31bbacf 100644
> --- a/package/mesa3d/mesa3d.mk
> +++ b/package/mesa3d/mesa3d.mk
> @@ -75,7 +75,7 @@ endif
>
>   ifeq ($(MESA3D_DRI_DRIVERS-y),)
>   MESA3D_CONF_OPT += \
> -       --without-dri-drivers
> +       --without-dri-drivers --disable-dri
>   else
>   ifeq ($(BR2_PACKAGE_XPROTO_DRI3PROTO),y)
>   MESA3D_DEPENDENCIES += xlib_libxshmfence xproto_dri3proto xproto_presentproto
>
> What do the mesa3d experts say?
>

Please use this defconfig if you want to reproduce the failure:

-----------------------------------------
BR2_x86_64=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
BR2_PACKAGE_MESA3D=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_NOUVEAU=y
BR2_PACKAGE_MESA3D_OPENGL_ES=y
BR2_PACKAGE_QT5=y
BR2_PACKAGE_QT5BASE_LICENSE_APPROVED=y
BR2_PACKAGE_QT5BASE_EXAMPLES=y
BR2_PACKAGE_QT5BASE_SQL=y
BR2_PACKAGE_QT5BASE_MYSQL=y
BR2_PACKAGE_QT5BASE_PSQL=y
BR2_PACKAGE_QT5BASE_TEST=y
BR2_PACKAGE_QT5BASE_OPENGL_LIB=y
BR2_PACKAGE_QT5BASE_LINUXFB=y
BR2_PACKAGE_QT5BASE_DIRECTFB=y
BR2_PACKAGE_QT5BASE_XCB=y
BR2_PACKAGE_QT5BASE_PRINTSUPPORT=y
BR2_PACKAGE_QT5BASE_FONTCONFIG=y
BR2_PACKAGE_QT5BASE_GIF=y
BR2_PACKAGE_QT5BASE_JPEG=y
BR2_PACKAGE_QT5BASE_PNG=y
BR2_PACKAGE_QT5BASE_TSLIB=y
BR2_PACKAGE_QT5CONNECTIVITY=y
BR2_PACKAGE_QT5ENGINIO=y
BR2_PACKAGE_QT5GRAPHICALEFFECTS=y
BR2_PACKAGE_QT5IMAGEFORMATS=y
BR2_PACKAGE_QT5MULTIMEDIA=y
BR2_PACKAGE_QT5QUICK1=y
BR2_PACKAGE_QT5QUICKCONTROLS=y
BR2_PACKAGE_QT5SENSORS=y
BR2_PACKAGE_QT5SERIALPORT=y
BR2_PACKAGE_QT5SVG=y
BR2_PACKAGE_QT5WEBKIT=y
BR2_PACKAGE_QT5WEBKIT_EXAMPLES=y
BR2_PACKAGE_QT5WEBSOCKETS=y
BR2_PACKAGE_QT5X11EXTRAS=y
BR2_PACKAGE_XORG7=y
BR2_PACKAGE_XSERVER_XORG_SERVER=y
BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR=y
-----------------------------------------

By the way, if you fix mesa3d and keep building the rest of the stuff, 
you will find a failure of qt5webkit like this one:

platform/graphics/opengl/Extensions3DOpenGLES.cpp:33:21: fatal error: 
EGL/egl.h: No such file or directory

It tries to include that file when the 3D_GRAPHICS macro is enabled, and 
that macro is enabled if Qt has opengl support. I don't know if there 
are more packages providing that file, but the only one I know is this one:

BR2_PACKAGE_MESA3D_OPENGL_EGL

-- 
Vincent

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] mesa3d: Add missing dependencies
  2014-09-16 20:07 ` Peter Korsgaard
  2014-09-17 13:12   ` Vicente Olivert Riera
@ 2014-09-20 12:39   ` Bernd Kuhls
  1 sibling, 0 replies; 4+ messages in thread
From: Bernd Kuhls @ 2014-09-20 12:39 UTC (permalink / raw)
  To: buildroot

Peter Korsgaard <jacmet@uclibc.org> wrote in 
news:87sijr8h2t.fsf at dell.be.48ers.dk:

>  MESA3D_CONF_OPT += \
> -       --without-dri-drivers
> +       --without-dri-drivers --disable-dri

Hi,

Acked-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Please note that enabling dri3 support in mesa3d is currently broken when 
used together with xdriver_xf86-video-intel:
https://github.com/OpenELEC/OpenELEC.tv/commit/b574ad91fe9c7b9fcf627df0d5e3c7
7e262a1f85#diff-87b6f34fde55cda38c8e119be89a63d4

Regards, Bernd

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-20 12:39 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-16 15:58 [Buildroot] [PATCH] mesa3d: Add missing dependencies Vicente Olivert Riera
2014-09-16 20:07 ` Peter Korsgaard
2014-09-17 13:12   ` Vicente Olivert Riera
2014-09-20 12:39   ` Bernd Kuhls

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.