All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris J Arges <chris.j.arges@canonical.com>
To: hch@infradead.org
Cc: bruce.lucas@mongodb.com,
	Chris J Arges <chris.j.arges@canonical.com>,
	Nagalakshmi Nandigama <nagalakshmi.nandigama@avagotech.com>,
	Praveen Krishnamoorthy <praveen.krishnamoorthy@avagotech.com>,
	Sreekanth Reddy <sreekanth.reddy@avagotech.com>,
	Abhijit Mahajan <abhijit.mahajan@avagotech.com>,
	MPT-FusionLinux.pdl@avagotech.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2] mptfusion: enable no_write_same for vmware scsi disks
Date: Mon, 22 Sep 2014 15:44:52 -0500	[thread overview]
Message-ID: <1411418701-25025-1-git-send-email-chris.j.arges@canonical.com> (raw)
In-Reply-To: <20140922181929.GA11319@infradead.org>

When using a virtual SCSI disk in a VMWare VM if blkdev_issue_zeroout is used
data can be improperly zeroed out using the mptfusion driver. This patch
disables write_same for this driver and the vmware subsystem_vendor which
ensures that manual zeroing out is used instead.

BugLink: http://bugs.launchpad.net/bugs/1371591
Reported-by: Bruce Lucas <bruce.lucas@mongodb.com>
Tested-by: Chris J Arges <chris.j.arges@canonical.com>
Signed-off-by: Chris J Arges <chris.j.arges@canonical.com>
---
 drivers/message/fusion/mptspi.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/message/fusion/mptspi.c b/drivers/message/fusion/mptspi.c
index 787933d..fca1594 100644
--- a/drivers/message/fusion/mptspi.c
+++ b/drivers/message/fusion/mptspi.c
@@ -1409,6 +1409,12 @@ mptspi_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 		return 0;
 	}
 
+	/* Fix for vmware guests that do not implement write_same
+         */
+	if (pdev->subsystem_vendor == 0x15AD) {
+		mptspi_driver_template.no_write_same = 1;
+	}
+
 	sh = scsi_host_alloc(&mptspi_driver_template, sizeof(MPT_SCSI_HOST));
 
 	if (!sh) {
-- 
1.9.1


  parent reply	other threads:[~2014-09-22 20:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-22 17:56 [PATCH] mptfusion: enable no_write_same in scsi_host_template Chris J Arges
2014-09-22 18:02 ` Christoph Hellwig
2014-09-22 18:17   ` Chris J Arges
2014-09-22 18:19     ` Christoph Hellwig
2014-09-22 18:50       ` Chris J Arges
2014-09-22 20:44       ` Chris J Arges [this message]
2014-09-22 20:54         ` [PATCH v2] mptfusion: enable no_write_same for vmware scsi disks Chris J Arges
2014-09-23  7:11         ` Christoph Hellwig
2014-09-23 14:22           ` [PATCH v3] " Chris J Arges
2014-09-23 15:29             ` Chris J Arges
2014-09-23 22:11             ` Chris J Arges
2014-09-23 23:28               ` Martin K. Petersen
2014-09-24  8:18                 ` Christoph Hellwig
2014-09-24 15:11                   ` Martin K. Petersen
2014-09-25 17:01             ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411418701-25025-1-git-send-email-chris.j.arges@canonical.com \
    --to=chris.j.arges@canonical.com \
    --cc=MPT-FusionLinux.pdl@avagotech.com \
    --cc=abhijit.mahajan@avagotech.com \
    --cc=bruce.lucas@mongodb.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nagalakshmi.nandigama@avagotech.com \
    --cc=praveen.krishnamoorthy@avagotech.com \
    --cc=sreekanth.reddy@avagotech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.