All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Chris J Arges <chris.j.arges@canonical.com>
Cc: hch@infradead.org, bruce.lucas@mongodb.com,
	Nagalakshmi Nandigama <nagalakshmi.nandigama@avagotech.com>,
	Praveen Krishnamoorthy <praveen.krishnamoorthy@avagotech.com>,
	Sreekanth Reddy <sreekanth.reddy@avagotech.com>,
	Abhijit Mahajan <abhijit.mahajan@avagotech.com>,
	MPT-FusionLinux.pdl@avagotech.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mptfusion: enable no_write_same for vmware scsi disks
Date: Tue, 23 Sep 2014 00:11:54 -0700	[thread overview]
Message-ID: <20140923071154.GB3867@infradead.org> (raw)
In-Reply-To: <1411418701-25025-1-git-send-email-chris.j.arges@canonical.com>

Hi Chris,

thanks for updating it, althugh it would need a few more updates.

> +	/* Fix for vmware guests that do not implement write_same
> +         */
> +	if (pdev->subsystem_vendor == 0x15AD) {
> +		mptspi_driver_template.no_write_same = 1;
> +	}
> +

We should set it only on th host that matches, not the whole template
for this case.  The host is allocated just below your statement in
the same function, so this should be easy.

Also no need for braces here, and try to follow the Linux comment style:

	/* The VMWare emulation doesn't properly impement WRITE SAME */
	if (pdev->subsystem_vendor == 0x15AD)
		sh->no_write_same = 1;
		

(and yes, it would be good to have PCI_VENDOR_ID_VMWARE in pci_ids.h,
 but that shouldn't be done in this bug fix patch)

  parent reply	other threads:[~2014-09-23  7:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-22 17:56 [PATCH] mptfusion: enable no_write_same in scsi_host_template Chris J Arges
2014-09-22 18:02 ` Christoph Hellwig
2014-09-22 18:17   ` Chris J Arges
2014-09-22 18:19     ` Christoph Hellwig
2014-09-22 18:50       ` Chris J Arges
2014-09-22 20:44       ` [PATCH v2] mptfusion: enable no_write_same for vmware scsi disks Chris J Arges
2014-09-22 20:54         ` Chris J Arges
2014-09-23  7:11         ` Christoph Hellwig [this message]
2014-09-23 14:22           ` [PATCH v3] " Chris J Arges
2014-09-23 15:29             ` Chris J Arges
2014-09-23 22:11             ` Chris J Arges
2014-09-23 23:28               ` Martin K. Petersen
2014-09-24  8:18                 ` Christoph Hellwig
2014-09-24 15:11                   ` Martin K. Petersen
2014-09-25 17:01             ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140923071154.GB3867@infradead.org \
    --to=hch@infradead.org \
    --cc=MPT-FusionLinux.pdl@avagotech.com \
    --cc=abhijit.mahajan@avagotech.com \
    --cc=bruce.lucas@mongodb.com \
    --cc=chris.j.arges@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nagalakshmi.nandigama@avagotech.com \
    --cc=praveen.krishnamoorthy@avagotech.com \
    --cc=sreekanth.reddy@avagotech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.