* [PATCH] libxl: Remove a duplicate calculation of be_path
[not found] <5411357975a60_122d108b334573c1@209.249.196.67.mail>
@ 2014-09-23 16:46 ` Ian Jackson
2014-09-23 20:21 ` Slutz, Donald Christopher
0 siblings, 1 reply; 3+ messages in thread
From: Ian Jackson @ 2014-09-23 16:46 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Ian.Campell, Ian Jackson
Coverity-ID: 1238177
CC: Wei Liu <wei.liu2@citrix.com>
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
tools/libxl/libxl_device.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/libxl/libxl_device.c b/tools/libxl/libxl_device.c
index 045212f..3425446 100644
--- a/tools/libxl/libxl_device.c
+++ b/tools/libxl/libxl_device.c
@@ -48,7 +48,6 @@ int libxl__device_exists(libxl__gc *gc, xs_transaction_t t,
char *be_path = libxl__device_backend_path(gc, device);
const char *dir;
- be_path = libxl__device_backend_path(gc, device);
rc = libxl__xs_read_checked(gc, t, be_path, &dir);
if (rc)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libxl: Remove a duplicate calculation of be_path
2014-09-23 16:46 ` [PATCH] libxl: Remove a duplicate calculation of be_path Ian Jackson
@ 2014-09-23 20:21 ` Slutz, Donald Christopher
2014-09-24 8:59 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Slutz, Donald Christopher @ 2014-09-23 20:21 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel, Wei Liu, Ian.Campell
On 09/23/14 12:46, Ian Jackson wrote:
> Coverity-ID: 1238177
> CC: Wei Liu <wei.liu2@citrix.com>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> ---
> tools/libxl/libxl_device.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/libxl/libxl_device.c b/tools/libxl/libxl_device.c
> index 045212f..3425446 100644
> --- a/tools/libxl/libxl_device.c
> +++ b/tools/libxl/libxl_device.c
> @@ -48,7 +48,6 @@ int libxl__device_exists(libxl__gc *gc, xs_transaction_t t,
> char *be_path = libxl__device_backend_path(gc, device);
> const char *dir;
>
> - be_path = libxl__device_backend_path(gc, device);
> rc = libxl__xs_read_checked(gc, t, be_path, &dir);
>
> if (rc)
Looks good.
Reviewed-by: Don Slutz <dslutz@verizon.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libxl: Remove a duplicate calculation of be_path
2014-09-23 20:21 ` Slutz, Donald Christopher
@ 2014-09-24 8:59 ` Ian Campbell
0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2014-09-24 8:59 UTC (permalink / raw)
To: Slutz, Donald Christopher; +Cc: Wei Liu, xen-devel, Ian Jackson, Ian.Campell
On Tue, 2014-09-23 at 20:21 +0000, Slutz, Donald Christopher wrote:
> On 09/23/14 12:46, Ian Jackson wrote:
> > Coverity-ID: 1238177
> > CC: Wei Liu <wei.liu2@citrix.com>
> > Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> > ---
> > tools/libxl/libxl_device.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/tools/libxl/libxl_device.c b/tools/libxl/libxl_device.c
> > index 045212f..3425446 100644
> > --- a/tools/libxl/libxl_device.c
> > +++ b/tools/libxl/libxl_device.c
> > @@ -48,7 +48,6 @@ int libxl__device_exists(libxl__gc *gc, xs_transaction_t t,
> > char *be_path = libxl__device_backend_path(gc, device);
> > const char *dir;
> >
> > - be_path = libxl__device_backend_path(gc, device);
> > rc = libxl__xs_read_checked(gc, t, be_path, &dir);
> >
> > if (rc)
>
> Looks good.
>
> Reviewed-by: Don Slutz <dslutz@verizon.com>
Acked + applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-24 8:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <5411357975a60_122d108b334573c1@209.249.196.67.mail>
2014-09-23 16:46 ` [PATCH] libxl: Remove a duplicate calculation of be_path Ian Jackson
2014-09-23 20:21 ` Slutz, Donald Christopher
2014-09-24 8:59 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.