[PATCH on mfd-regulator-power-v3.17] charger: max14577: Fix build breakage when compiled as module

[PATCH on mfd-regulator-power-v3.17] charger: max14577: Fix build breakage when compiled as module

[Krzysztof Kozlowski]

The charger's module device table used the same name as regulator driver
causing a build break when charger was compiled as a module:

drivers/power/max14577_charger.c:598:1: error: ‘__mod_platform__max14577_regulator_id_device_table’ aliased to undefined symbol ‘max14577_regulator_id’
make[2]: *** [drivers/power/max14577_charger.o] Error 1

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
---
 drivers/power/max14577_charger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/max14577_charger.c b/drivers/power/max14577_charger.c
index c2e87c41d853..0a2bc7277026 100644
--- a/drivers/power/max14577_charger.c
+++ b/drivers/power/max14577_charger.c
@@ -595,7 +595,7 @@ static const struct platform_device_id max14577_charger_id[] = {
 	{ "max77836-charger", MAXIM_DEVICE_TYPE_MAX77836, },
 	{ }
 };
-MODULE_DEVICE_TABLE(platform, max14577_regulator_id);
+MODULE_DEVICE_TABLE(platform, max14577_charger_id);
 
 static struct platform_driver max14577_charger_driver = {
 	.driver = {
-- 
1.9.1

Re: [PATCH on mfd-regulator-power-v3.17] charger: max14577: Fix build breakage when compiled as module

[Lee Jones]

On Wed, 24 Sep 2014, Krzysztof Kozlowski wrote:

> The charger's module device table used the same name as regulator driver
> causing a build break when charger was compiled as a module:
> 
> drivers/power/max14577_charger.c:598:1: error: ‘__mod_platform__max14577_regulator_id_device_table’ aliased to undefined symbol ‘max14577_regulator_id’
> make[2]: *** [drivers/power/max14577_charger.o] Error 1
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> ---
>  drivers/power/max14577_charger.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I have fixed this up into the original set and re-sent the
pull-request.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH on mfd-regulator-power-v3.17] charger: max14577: Fix build breakage when compiled as module

[Krzysztof Kozlowski]

On śro, 2014-09-24 at 15:35 +0100, Lee Jones wrote:
> On Wed, 24 Sep 2014, Krzysztof Kozlowski wrote:
> 
> > The charger's module device table used the same name as regulator driver
> > causing a build break when charger was compiled as a module:
> > 
> > drivers/power/max14577_charger.c:598:1: error: ‘__mod_platform__max14577_regulator_id_device_table’ aliased to undefined symbol ‘max14577_regulator_id’
> > make[2]: *** [drivers/power/max14577_charger.o] Error 1
> > 
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Reported-by: kbuild test robot <fengguang.wu@intel.com>
> > ---
> >  drivers/power/max14577_charger.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> I have fixed this up into the original set and re-sent the
> pull-request.

Great, thanks!

Best regards,
Krzysztof