* [PATCH 0/2] qcom: add CM-QS600 board @ 2014-09-26 8:07 ` Mike Rapoport 0 siblings, 0 replies; 10+ messages in thread From: Mike Rapoport @ 2014-09-26 8:07 UTC (permalink / raw) To: Kumar Gala Cc: Srinivas Kandagatla, linux-arm-msm, linux-arm-kernel, Mike Rapoport These two patches add DT for CompuLab CM-QS600 board which is similar to ifc6410 Mike Rapoport (2): ARM: DT: apq8064: create qcom-apq8064-board-common.dtsi ARM: DT: apq8064: add CM-QS600 board arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/qcom-apq8064-board-common.dtsi | 57 ++++++++++++++++++++++++ arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 7 +++ arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 54 +--------------------- 4 files changed, 66 insertions(+), 53 deletions(-) create mode 100644 arch/arm/boot/dts/qcom-apq8064-board-common.dtsi create mode 100644 arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts -- 1.9.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 0/2] qcom: add CM-QS600 board @ 2014-09-26 8:07 ` Mike Rapoport 0 siblings, 0 replies; 10+ messages in thread From: Mike Rapoport @ 2014-09-26 8:07 UTC (permalink / raw) To: linux-arm-kernel These two patches add DT for CompuLab CM-QS600 board which is similar to ifc6410 Mike Rapoport (2): ARM: DT: apq8064: create qcom-apq8064-board-common.dtsi ARM: DT: apq8064: add CM-QS600 board arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/qcom-apq8064-board-common.dtsi | 57 ++++++++++++++++++++++++ arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 7 +++ arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 54 +--------------------- 4 files changed, 66 insertions(+), 53 deletions(-) create mode 100644 arch/arm/boot/dts/qcom-apq8064-board-common.dtsi create mode 100644 arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts -- 1.9.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] ARM: DT: apq8064: create qcom-apq8064-board-common.dtsi 2014-09-26 8:07 ` Mike Rapoport @ 2014-09-26 8:07 ` Mike Rapoport -1 siblings, 0 replies; 10+ messages in thread From: Mike Rapoport @ 2014-09-26 8:07 UTC (permalink / raw) To: Kumar Gala Cc: Srinivas Kandagatla, linux-arm-msm, linux-arm-kernel, Mike Rapoport This way similar boards will be able to share common definitions. Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com> --- arch/arm/boot/dts/qcom-apq8064-board-common.dtsi | 57 ++++++++++++++++++++++++ arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 54 +--------------------- 2 files changed, 58 insertions(+), 53 deletions(-) create mode 100644 arch/arm/boot/dts/qcom-apq8064-board-common.dtsi diff --git a/arch/arm/boot/dts/qcom-apq8064-board-common.dtsi b/arch/arm/boot/dts/qcom-apq8064-board-common.dtsi new file mode 100644 index 0000000..c92d3e9 --- /dev/null +++ b/arch/arm/boot/dts/qcom-apq8064-board-common.dtsi @@ -0,0 +1,57 @@ +#include "qcom-apq8064-v2.0.dtsi" + +/ { + + soc { + pinctrl@800000 { + i2c1_pins: i2c1 { + mux { + pins = "gpio20", "gpio21"; + function = "gsbi1"; + }; + }; + }; + + gsbi@12440000 { + status = "okay"; + qcom,mode = <GSBI_PROT_I2C>; + + i2c@12460000 { + status = "okay"; + clock-frequency = <200000>; + pinctrl-0 = <&i2c1_pins>; + pinctrl-names = "default"; + + eeprom: eeprom@52 { + compatible = "atmel,24c128"; + reg = <0x52>; + pagesize = <32>; + }; + }; + }; + + gsbi@16600000 { + status = "ok"; + qcom,mode = <GSBI_PROT_I2C_UART>; + serial@16640000 { + status = "ok"; + }; + }; + + amba { + /* eMMC */ + sdcc1: sdcc@12400000 { + status = "okay"; + }; + + /* External micro SD card */ + sdcc3: sdcc@12180000 { + status = "okay"; + }; + /* WLAN */ + sdcc4: sdcc@121c0000 { + status = "okay"; + }; + }; + }; +}; diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts index b396c83..61784d7 100644 --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts @@ -1,59 +1,7 @@ -#include "qcom-apq8064-v2.0.dtsi" +#include "qcom-apq8064-board-common.dtsi" / { model = "Qualcomm APQ8064/IFC6410"; compatible = "qcom,apq8064-ifc6410", "qcom,apq8064"; - soc { - pinctrl@800000 { - i2c1_pins: i2c1 { - mux { - pins = "gpio20", "gpio21"; - function = "gsbi1"; - }; - }; - }; - - gsbi@12440000 { - status = "okay"; - qcom,mode = <GSBI_PROT_I2C>; - - i2c@12460000 { - status = "okay"; - clock-frequency = <200000>; - pinctrl-0 = <&i2c1_pins>; - pinctrl-names = "default"; - - eeprom: eeprom@52 { - compatible = "atmel,24c128"; - reg = <0x52>; - pagesize = <32>; - }; - }; - }; - - gsbi@16600000 { - status = "ok"; - qcom,mode = <GSBI_PROT_I2C_UART>; - serial@16640000 { - status = "ok"; - }; - }; - - amba { - /* eMMC */ - sdcc1: sdcc@12400000 { - status = "okay"; - }; - - /* External micro SD card */ - sdcc3: sdcc@12180000 { - status = "okay"; - }; - /* WLAN */ - sdcc4: sdcc@121c0000 { - status = "okay"; - }; - }; - }; }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 1/2] ARM: DT: apq8064: create qcom-apq8064-board-common.dtsi @ 2014-09-26 8:07 ` Mike Rapoport 0 siblings, 0 replies; 10+ messages in thread From: Mike Rapoport @ 2014-09-26 8:07 UTC (permalink / raw) To: linux-arm-kernel This way similar boards will be able to share common definitions. Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com> --- arch/arm/boot/dts/qcom-apq8064-board-common.dtsi | 57 ++++++++++++++++++++++++ arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 54 +--------------------- 2 files changed, 58 insertions(+), 53 deletions(-) create mode 100644 arch/arm/boot/dts/qcom-apq8064-board-common.dtsi diff --git a/arch/arm/boot/dts/qcom-apq8064-board-common.dtsi b/arch/arm/boot/dts/qcom-apq8064-board-common.dtsi new file mode 100644 index 0000000..c92d3e9 --- /dev/null +++ b/arch/arm/boot/dts/qcom-apq8064-board-common.dtsi @@ -0,0 +1,57 @@ +#include "qcom-apq8064-v2.0.dtsi" + +/ { + + soc { + pinctrl at 800000 { + i2c1_pins: i2c1 { + mux { + pins = "gpio20", "gpio21"; + function = "gsbi1"; + }; + }; + }; + + gsbi at 12440000 { + status = "okay"; + qcom,mode = <GSBI_PROT_I2C>; + + i2c at 12460000 { + status = "okay"; + clock-frequency = <200000>; + pinctrl-0 = <&i2c1_pins>; + pinctrl-names = "default"; + + eeprom: eeprom at 52 { + compatible = "atmel,24c128"; + reg = <0x52>; + pagesize = <32>; + }; + }; + }; + + gsbi at 16600000 { + status = "ok"; + qcom,mode = <GSBI_PROT_I2C_UART>; + serial at 16640000 { + status = "ok"; + }; + }; + + amba { + /* eMMC */ + sdcc1: sdcc at 12400000 { + status = "okay"; + }; + + /* External micro SD card */ + sdcc3: sdcc at 12180000 { + status = "okay"; + }; + /* WLAN */ + sdcc4: sdcc at 121c0000 { + status = "okay"; + }; + }; + }; +}; diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts index b396c83..61784d7 100644 --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts @@ -1,59 +1,7 @@ -#include "qcom-apq8064-v2.0.dtsi" +#include "qcom-apq8064-board-common.dtsi" / { model = "Qualcomm APQ8064/IFC6410"; compatible = "qcom,apq8064-ifc6410", "qcom,apq8064"; - soc { - pinctrl at 800000 { - i2c1_pins: i2c1 { - mux { - pins = "gpio20", "gpio21"; - function = "gsbi1"; - }; - }; - }; - - gsbi at 12440000 { - status = "okay"; - qcom,mode = <GSBI_PROT_I2C>; - - i2c at 12460000 { - status = "okay"; - clock-frequency = <200000>; - pinctrl-0 = <&i2c1_pins>; - pinctrl-names = "default"; - - eeprom: eeprom at 52 { - compatible = "atmel,24c128"; - reg = <0x52>; - pagesize = <32>; - }; - }; - }; - - gsbi at 16600000 { - status = "ok"; - qcom,mode = <GSBI_PROT_I2C_UART>; - serial at 16640000 { - status = "ok"; - }; - }; - - amba { - /* eMMC */ - sdcc1: sdcc at 12400000 { - status = "okay"; - }; - - /* External micro SD card */ - sdcc3: sdcc at 12180000 { - status = "okay"; - }; - /* WLAN */ - sdcc4: sdcc at 121c0000 { - status = "okay"; - }; - }; - }; }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] ARM: DT: apq8064: create qcom-apq8064-board-common.dtsi 2014-09-26 8:07 ` Mike Rapoport @ 2014-09-26 13:41 ` Bjorn Andersson -1 siblings, 0 replies; 10+ messages in thread From: Bjorn Andersson @ 2014-09-26 13:41 UTC (permalink / raw) To: Mike Rapoport Cc: Kumar Gala, linux-arm-msm, Srinivas Kandagatla, linux-arm-kernel On Fri, Sep 26, 2014 at 1:07 AM, Mike Rapoport <mike.rapoport@gmail.com> wrote: Cool to see the addition of dt for additional devices. I do however not think it is correct to put all these things in common... > diff --git a/arch/arm/boot/dts/qcom-apq8064-board-common.dtsi b/arch/arm/boot/dts/qcom-apq8064-board-common.dtsi > new file mode 100644 > index 0000000..c92d3e9 > --- /dev/null > +++ b/arch/arm/boot/dts/qcom-apq8064-board-common.dtsi > @@ -0,0 +1,57 @@ > +#include "qcom-apq8064-v2.0.dtsi" > + > +/ { > + > + soc { > + pinctrl@800000 { > + i2c1_pins: i2c1 { > + mux { > + pins = "gpio20", "gpio21"; > + function = "gsbi1"; > + }; The muxing is common, but you probably want to be able to set drive strength and bias as well and handle active vs sleep mode and then I'm not sure if it is common anymore... > + }; > + }; > + > + gsbi@12440000 { > + status = "okay"; > + qcom,mode = <GSBI_PROT_I2C>; > + > + i2c@12460000 { > + status = "okay"; > + clock-frequency = <200000>; > + pinctrl-0 = <&i2c1_pins>; > + pinctrl-names = "default"; > + > + eeprom: eeprom@52 { > + compatible = "atmel,24c128"; > + reg = <0x52>; > + pagesize = <32>; > + }; Not all apq8064 boards have this eeprom. > + }; > + }; > + > + gsbi@16600000 { > + status = "ok"; > + qcom,mode = <GSBI_PROT_I2C_UART>; > + serial@16640000 { > + status = "ok"; > + }; > + }; > + > + amba { > + /* eMMC */ > + sdcc1: sdcc@12400000 { > + status = "okay"; > + }; > + > + /* External micro SD card */ > + sdcc3: sdcc@12180000 { > + status = "okay"; > + }; > + /* WLAN */ > + sdcc4: sdcc@121c0000 { > + status = "okay"; > + }; I'm not sure if all boards are using sdcc4 for WiFi. Regards, Bjorn ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] ARM: DT: apq8064: create qcom-apq8064-board-common.dtsi @ 2014-09-26 13:41 ` Bjorn Andersson 0 siblings, 0 replies; 10+ messages in thread From: Bjorn Andersson @ 2014-09-26 13:41 UTC (permalink / raw) To: linux-arm-kernel On Fri, Sep 26, 2014 at 1:07 AM, Mike Rapoport <mike.rapoport@gmail.com> wrote: Cool to see the addition of dt for additional devices. I do however not think it is correct to put all these things in common... > diff --git a/arch/arm/boot/dts/qcom-apq8064-board-common.dtsi b/arch/arm/boot/dts/qcom-apq8064-board-common.dtsi > new file mode 100644 > index 0000000..c92d3e9 > --- /dev/null > +++ b/arch/arm/boot/dts/qcom-apq8064-board-common.dtsi > @@ -0,0 +1,57 @@ > +#include "qcom-apq8064-v2.0.dtsi" > + > +/ { > + > + soc { > + pinctrl at 800000 { > + i2c1_pins: i2c1 { > + mux { > + pins = "gpio20", "gpio21"; > + function = "gsbi1"; > + }; The muxing is common, but you probably want to be able to set drive strength and bias as well and handle active vs sleep mode and then I'm not sure if it is common anymore... > + }; > + }; > + > + gsbi at 12440000 { > + status = "okay"; > + qcom,mode = <GSBI_PROT_I2C>; > + > + i2c at 12460000 { > + status = "okay"; > + clock-frequency = <200000>; > + pinctrl-0 = <&i2c1_pins>; > + pinctrl-names = "default"; > + > + eeprom: eeprom at 52 { > + compatible = "atmel,24c128"; > + reg = <0x52>; > + pagesize = <32>; > + }; Not all apq8064 boards have this eeprom. > + }; > + }; > + > + gsbi at 16600000 { > + status = "ok"; > + qcom,mode = <GSBI_PROT_I2C_UART>; > + serial at 16640000 { > + status = "ok"; > + }; > + }; > + > + amba { > + /* eMMC */ > + sdcc1: sdcc at 12400000 { > + status = "okay"; > + }; > + > + /* External micro SD card */ > + sdcc3: sdcc at 12180000 { > + status = "okay"; > + }; > + /* WLAN */ > + sdcc4: sdcc at 121c0000 { > + status = "okay"; > + }; I'm not sure if all boards are using sdcc4 for WiFi. Regards, Bjorn ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] ARM: DT: apq8064: create qcom-apq8064-board-common.dtsi 2014-09-26 13:41 ` Bjorn Andersson @ 2014-09-26 13:53 ` Kumar Gala -1 siblings, 0 replies; 10+ messages in thread From: Kumar Gala @ 2014-09-26 13:53 UTC (permalink / raw) To: Bjorn Andersson Cc: Mike Rapoport, linux-arm-msm, Srinivas Kandagatla, linux-arm-kernel On Sep 26, 2014, at 8:41 AM, Bjorn Andersson <bjorn@kryo.se> wrote: > On Fri, Sep 26, 2014 at 1:07 AM, Mike Rapoport <mike.rapoport@gmail.com> wrote: > > Cool to see the addition of dt for additional devices. I do however > not think it is correct to put all these things in common… I’m with Bjorn, just duplicate the settings for the cm-qs600 board in its .dts file. - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] ARM: DT: apq8064: create qcom-apq8064-board-common.dtsi @ 2014-09-26 13:53 ` Kumar Gala 0 siblings, 0 replies; 10+ messages in thread From: Kumar Gala @ 2014-09-26 13:53 UTC (permalink / raw) To: linux-arm-kernel On Sep 26, 2014, at 8:41 AM, Bjorn Andersson <bjorn@kryo.se> wrote: > On Fri, Sep 26, 2014 at 1:07 AM, Mike Rapoport <mike.rapoport@gmail.com> wrote: > > Cool to see the addition of dt for additional devices. I do however > not think it is correct to put all these things in common? I?m with Bjorn, just duplicate the settings for the cm-qs600 board in its .dts file. - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] ARM: DT: apq8064: add CM-QS600 board 2014-09-26 8:07 ` Mike Rapoport @ 2014-09-26 8:07 ` Mike Rapoport -1 siblings, 0 replies; 10+ messages in thread From: Mike Rapoport @ 2014-09-26 8:07 UTC (permalink / raw) To: Kumar Gala Cc: Srinivas Kandagatla, linux-arm-msm, linux-arm-kernel, Mike Rapoport Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com> --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 7 +++++++ 2 files changed, 8 insertions(+) create mode 100644 arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index aaa1a68..71d2ade 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -340,6 +340,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += orion5x-lacie-d2-network.dtb \ dtb-$(CONFIG_ARCH_PRIMA2) += prima2-evb.dtb dtb-$(CONFIG_ARCH_QCOM) += \ qcom-apq8064-ifc6410.dtb \ + qcom-apq8064-cm-qs600.dtb \ qcom-apq8074-dragonboard.dtb \ qcom-apq8084-ifc6540.dtb \ qcom-apq8084-mtp.dtb \ diff --git a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts new file mode 100644 index 0000000..ec577e1 --- /dev/null +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts @@ -0,0 +1,7 @@ +#include "qcom-apq8064-board-common.dtsi" + +/ { + model = "CompuLab CM-QS600"; + compatible = "qcom,apq8064-cm-qs600", "qcom,apq8064"; + +}; -- 1.9.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/2] ARM: DT: apq8064: add CM-QS600 board @ 2014-09-26 8:07 ` Mike Rapoport 0 siblings, 0 replies; 10+ messages in thread From: Mike Rapoport @ 2014-09-26 8:07 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com> --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 7 +++++++ 2 files changed, 8 insertions(+) create mode 100644 arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index aaa1a68..71d2ade 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -340,6 +340,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += orion5x-lacie-d2-network.dtb \ dtb-$(CONFIG_ARCH_PRIMA2) += prima2-evb.dtb dtb-$(CONFIG_ARCH_QCOM) += \ qcom-apq8064-ifc6410.dtb \ + qcom-apq8064-cm-qs600.dtb \ qcom-apq8074-dragonboard.dtb \ qcom-apq8084-ifc6540.dtb \ qcom-apq8084-mtp.dtb \ diff --git a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts new file mode 100644 index 0000000..ec577e1 --- /dev/null +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts @@ -0,0 +1,7 @@ +#include "qcom-apq8064-board-common.dtsi" + +/ { + model = "CompuLab CM-QS600"; + compatible = "qcom,apq8064-cm-qs600", "qcom,apq8064"; + +}; -- 1.9.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-09-26 13:53 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2014-09-26 8:07 [PATCH 0/2] qcom: add CM-QS600 board Mike Rapoport 2014-09-26 8:07 ` Mike Rapoport 2014-09-26 8:07 ` [PATCH 1/2] ARM: DT: apq8064: create qcom-apq8064-board-common.dtsi Mike Rapoport 2014-09-26 8:07 ` Mike Rapoport 2014-09-26 13:41 ` Bjorn Andersson 2014-09-26 13:41 ` Bjorn Andersson 2014-09-26 13:53 ` Kumar Gala 2014-09-26 13:53 ` Kumar Gala 2014-09-26 8:07 ` [PATCH 2/2] ARM: DT: apq8064: add CM-QS600 board Mike Rapoport 2014-09-26 8:07 ` Mike Rapoport
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.