From: Eric Dumazet <eric.dumazet@gmail.com>
To: Alexei Starovoitov <ast@plumgrid.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Eric Dumazet <edumazet@google.com>,
John Fastabend <john.r.fastabend@intel.com>,
netdev@vger.kernel.org, Amir Vadai <amirv@mellanox.com>,
Or Gerlitz <or.gerlitz@gmail.com>
Subject: Re: [RFC PATCH net-next] net: pktgen: packet bursting via skb->xmit_more
Date: Sat, 27 Sep 2014 13:43:10 -0700 [thread overview]
Message-ID: <1411850590.15768.6.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <1411717322.16953.99.camel@edumazet-glaptop2.roam.corp.google.com>
On Fri, 2014-09-26 at 00:42 -0700, Eric Dumazet wrote:
> By the way with this patch, I now reach 10 Mpps on mlx4
>
> base line : 5 Mpps
>
> + skb->xmit_more and quick hack in pjtgen (spinlock/unlock per packet)
> -> 7 Mpps
>
> + burst of 16 packets, no spinlock per packet -> 10 Mpps
With careful study of mlx4 driver to remove false sharing, I now get 14
Mpps.
(Note they have a special feature to 'inline' small packets in tx
descriptors : If this is used, max rate is lower, because cpu spend more
cycles to perform the copies)
I find worrying driver authors do not know how to properly use a ring
buffer, and do not place the producer and consumer indexes in separate
cache lines.
next prev parent reply other threads:[~2014-09-27 20:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 0:46 [RFC PATCH net-next] net: pktgen: packet bursting via skb->xmit_more Alexei Starovoitov
2014-09-26 1:20 ` Eric Dumazet
2014-09-26 7:42 ` Eric Dumazet
2014-09-26 15:44 ` Eric Dumazet
2014-09-26 15:59 ` Alexei Starovoitov
2014-09-26 16:06 ` Eric Dumazet
2014-09-27 20:43 ` Eric Dumazet [this message]
2014-09-27 20:55 ` Or Gerlitz
2014-09-27 21:30 ` Eric Dumazet
2014-09-27 22:56 ` [PATCH net-next] mlx4: optimize xmit path Eric Dumazet
2014-09-27 23:44 ` Hannes Frederic Sowa
2014-09-28 0:05 ` Eric Dumazet
2014-09-28 0:22 ` Hannes Frederic Sowa
2014-09-28 12:42 ` Eric Dumazet
2014-09-28 14:35 ` Or Gerlitz
2014-09-28 16:03 ` Eric Dumazet
2014-09-29 4:19 ` [PATCH v2 " Eric Dumazet
2014-09-30 12:01 ` Amir Vadai
2014-09-30 12:11 ` Eric Dumazet
2014-10-02 4:35 ` Eric Dumazet
2014-10-02 8:03 ` Amir Vadai
2014-10-02 8:29 ` Jesper Dangaard Brouer
2014-10-02 8:57 ` Amir Vadai
2014-10-02 11:45 ` Eric Dumazet
2014-10-02 11:56 ` Amir Vadai
2014-10-02 12:07 ` Eric Dumazet
2014-10-02 12:45 ` Amir Vadai
2014-09-26 8:05 ` [RFC PATCH net-next] net: pktgen: packet bursting via skb->xmit_more Jesper Dangaard Brouer
2014-09-27 20:59 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411850590.15768.6.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=amirv@mellanox.com \
--cc=ast@plumgrid.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.