From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Eric Dumazet <eric.dumazet@gmail.com>, Or Gerlitz <gerlitz.or@gmail.com>
Cc: Alexei Starovoitov <ast@plumgrid.com>,
"David S. Miller" <davem@davemloft.net>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Eric Dumazet <edumazet@google.com>,
John Fastabend <john.r.fastabend@intel.com>,
Linux Netdev List <netdev@vger.kernel.org>,
Amir Vadai <amirv@mellanox.com>,
Or Gerlitz <or.gerlitz@gmail.com>
Subject: Re: [PATCH net-next] mlx4: optimize xmit path
Date: Sun, 28 Sep 2014 01:44:27 +0200 [thread overview]
Message-ID: <1411861467.374982.172498061.37EB43B1@webmail.messagingengine.com> (raw)
In-Reply-To: <1411858593.15768.51.camel@edumazet-glaptop2.roam.corp.google.com>
Hi Eric,
On Sun, Sep 28, 2014, at 00:56, Eric Dumazet wrote:
> - ring->cons += txbbs_skipped;
> +
> + /* we want to dirty this cache line once */
> + ACCESS_ONCE(ring->last_nr_txbb) = last_nr_txbb;
> + ACCESS_ONCE(ring->cons) = ring_cons + txbbs_skipped;
> +
Impressive work!
I wonder if another macro might be useful for those kind of
dereferences, because ACCESS_ONCE is associated with correctness in my
mind and those usages only try to optimize access patterns.
Does OPTIMIZER_HIDE_VAR generate the same code?
Bye,
Hannes
next prev parent reply other threads:[~2014-09-27 23:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 0:46 [RFC PATCH net-next] net: pktgen: packet bursting via skb->xmit_more Alexei Starovoitov
2014-09-26 1:20 ` Eric Dumazet
2014-09-26 7:42 ` Eric Dumazet
2014-09-26 15:44 ` Eric Dumazet
2014-09-26 15:59 ` Alexei Starovoitov
2014-09-26 16:06 ` Eric Dumazet
2014-09-27 20:43 ` Eric Dumazet
2014-09-27 20:55 ` Or Gerlitz
2014-09-27 21:30 ` Eric Dumazet
2014-09-27 22:56 ` [PATCH net-next] mlx4: optimize xmit path Eric Dumazet
2014-09-27 23:44 ` Hannes Frederic Sowa [this message]
2014-09-28 0:05 ` Eric Dumazet
2014-09-28 0:22 ` Hannes Frederic Sowa
2014-09-28 12:42 ` Eric Dumazet
2014-09-28 14:35 ` Or Gerlitz
2014-09-28 16:03 ` Eric Dumazet
2014-09-29 4:19 ` [PATCH v2 " Eric Dumazet
2014-09-30 12:01 ` Amir Vadai
2014-09-30 12:11 ` Eric Dumazet
2014-10-02 4:35 ` Eric Dumazet
2014-10-02 8:03 ` Amir Vadai
2014-10-02 8:29 ` Jesper Dangaard Brouer
2014-10-02 8:57 ` Amir Vadai
2014-10-02 11:45 ` Eric Dumazet
2014-10-02 11:56 ` Amir Vadai
2014-10-02 12:07 ` Eric Dumazet
2014-10-02 12:45 ` Amir Vadai
2014-09-26 8:05 ` [RFC PATCH net-next] net: pktgen: packet bursting via skb->xmit_more Jesper Dangaard Brouer
2014-09-27 20:59 ` Or Gerlitz
2014-09-28 18:07 [PATCH net-next] mlx4: optimize xmit path Alexei Starovoitov
2014-09-28 18:52 ` Eric Dumazet
2014-09-28 20:49 ` Alexei Starovoitov
2014-09-29 2:22 ` Eric Dumazet
2014-09-29 5:08 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411861467.374982.172498061.37EB43B1@webmail.messagingengine.com \
--to=hannes@stressinduktion.org \
--cc=amirv@mellanox.com \
--cc=ast@plumgrid.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=gerlitz.or@gmail.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.