All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: julien.grall@linaro.org,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH 3/4] xen/arm: Add PSCI system_off and system_reset support
Date: Wed, 1 Oct 2014 15:04:07 +0100	[thread overview]
Message-ID: <1412172247.4861.36.camel@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1410011101570.17038@kaball.uk.xensource.com>

On Wed, 2014-10-01 at 11:07 +0100, Stefano Stabellini wrote:
> > diff --git a/xen/arch/arm/shutdown.c b/xen/arch/arm/shutdown.c
> > index adc0529..2f63674 100644
> > --- a/xen/arch/arm/shutdown.c
> > +++ b/xen/arch/arm/shutdown.c
> > @@ -6,11 +6,6 @@
> >  #include <xen/smp.h>
> >  #include <asm/platform.h>
> >  
> > -static void raw_machine_reset(void)
> > -{
> > -    platform_reset();
> > -}
> 
> Please mention this change in the commit message.

Actually, since this is going to need a freeze exception I think it
would be good to split into individual commits which separately:
        Refactor raw_machine_reset
        (Re)Implement machine_halt
        Introduce whatever PSCI stuff is needed.

That'll make it easier to reason about and make an argument for.

BTW I'm in favour of trying to get this stuff in for 4.5.

Ian.

  parent reply	other threads:[~2014-10-01 14:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-01  8:07 [PATCH 0/4] Introduce AMD Seattle platform support suravee.suthikulpanit
2014-10-01  8:07 ` [PATCH 1/4] gicv2: Add compatibility id for gic-400 suravee.suthikulpanit
2014-10-01  9:54   ` Stefano Stabellini
2014-10-01 14:41   ` Julien Grall
2014-10-01  8:07 ` [PATCH 2/4] amd/seattle: Add early printk message for the platform suravee.suthikulpanit
2014-10-01  9:55   ` Stefano Stabellini
2014-10-01 14:43   ` Julien Grall
2014-10-01  8:07 ` [PATCH 3/4] xen/arm: Add PSCI system_off and system_reset support suravee.suthikulpanit
2014-10-01 10:07   ` Stefano Stabellini
2014-10-01 10:26     ` Ian Campbell
2014-10-01 14:15       ` Suravee Suthikulpanit
2014-10-01 14:46         ` Ian Campbell
2014-10-01 17:58           ` Suravee Suthikulanit
2014-10-02  8:28             ` Ian Campbell
2014-10-01 14:04     ` Ian Campbell [this message]
2014-10-01  8:07 ` [PATCH 4/4] amd/seattle: Initial revision of AMD Seattle support suravee.suthikulpanit
2014-10-01 10:10   ` Stefano Stabellini
2014-10-01 19:21     ` Suravee Suthikulanit
2014-10-02  9:10       ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412172247.4861.36.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=julien.grall@linaro.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.