All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: rt286: Add depends on I2C
@ 2014-10-03  1:55 Bard Liao
  2014-10-03 10:19 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Bard Liao @ 2014-10-03  1:55 UTC (permalink / raw)
  To: broonie, lgirdwood; +Cc: oder_chiou, Bard Liao, alsa-devel, lars, flove

rt286 use I2C as its I/O. So the driver can only available when
I2C is selected.

Signed-off-by: Bard Liao <bardliao@realtek.com>
---
 sound/soc/codecs/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 351bf48..a68d173 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -484,6 +484,7 @@ config SND_SOC_RL6231
 
 config SND_SOC_RT286
 	tristate
+	depends on I2C
 
 config SND_SOC_RT5631
 	tristate
-- 
1.8.1.1.439.g50a6b54

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: rt286: Add depends on I2C
  2014-10-03  1:55 [PATCH] ASoC: rt286: Add depends on I2C Bard Liao
@ 2014-10-03 10:19 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-10-03 10:19 UTC (permalink / raw)
  To: Bard Liao; +Cc: oder_chiou, alsa-devel, lars, lgirdwood, flove


[-- Attachment #1.1: Type: text/plain, Size: 380 bytes --]

On Fri, Oct 03, 2014 at 09:55:07AM +0800, Bard Liao wrote:
> rt286 use I2C as its I/O. So the driver can only available when
> I2C is selected.

>  config SND_SOC_RT286
>  	tristate
> +	depends on I2C

This won't actually do anything - since the symbol SND_SOC_RT286 is
selected rather than enabled directly Kconfig will just ignore any
dependencies it has.  I've applied anyway.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-10-03 10:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-03  1:55 [PATCH] ASoC: rt286: Add depends on I2C Bard Liao
2014-10-03 10:19 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.