* [PATCH] [next-20141003] USB: host: st: fix typo 'CONFIG_USB_EHCI_HCD_ST'
@ 2014-10-03 8:21 Paul Bolle
2014-10-04 11:33 ` Arnd Bergmann
2014-10-06 10:10 ` Peter Griffin
0 siblings, 2 replies; 4+ messages in thread
From: Paul Bolle @ 2014-10-03 8:21 UTC (permalink / raw)
To: Arnd Bergmann, Alan Stern, Greg Kroah-Hartman
Cc: Valentin Rothberg, Peter Griffin, linux-usb, linux-kernel
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Fixes: 905e300e1043 ("USB: host: st: fix ehci/ohci driver selection")
---
drivers/usb/host/ehci-st.o actually builds (on x86_64. that is) so
there's no _obvious_ reason not to fix this typo.
drivers/usb/host/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile
index 0336bb2c0e6f..3beda2655232 100644
--- a/drivers/usb/host/Makefile
+++ b/drivers/usb/host/Makefile
@@ -38,7 +38,7 @@ obj-$(CONFIG_USB_EHCI_MXC) += ehci-mxc.o
obj-$(CONFIG_USB_EHCI_HCD_OMAP) += ehci-omap.o
obj-$(CONFIG_USB_EHCI_HCD_ORION) += ehci-orion.o
obj-$(CONFIG_USB_EHCI_HCD_SPEAR) += ehci-spear.o
-obj-$(CONFIG_USB_EHCI_HCD_ST) += ehci-st.o
+obj-$(CONFIG_USB_EHCI_HCD_STI) += ehci-st.o
obj-$(CONFIG_USB_EHCI_EXYNOS) += ehci-exynos.o
obj-$(CONFIG_USB_EHCI_HCD_AT91) += ehci-atmel.o
obj-$(CONFIG_USB_EHCI_MSM) += ehci-msm.o
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] [next-20141003] USB: host: st: fix typo 'CONFIG_USB_EHCI_HCD_ST'
2014-10-03 8:21 [PATCH] [next-20141003] USB: host: st: fix typo 'CONFIG_USB_EHCI_HCD_ST' Paul Bolle
@ 2014-10-04 11:33 ` Arnd Bergmann
2014-10-04 13:23 ` Paul Bolle
2014-10-06 10:10 ` Peter Griffin
1 sibling, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2014-10-04 11:33 UTC (permalink / raw)
To: Paul Bolle
Cc: Alan Stern, Greg Kroah-Hartman, Valentin Rothberg, Peter Griffin,
linux-usb, linux-kernel
On Friday 03 October 2014 10:21:44 Paul Bolle wrote:
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> Fixes: 905e300e1043 ("USB: host: st: fix ehci/ohci driver selection")
> ---
> drivers/usb/host/ehci-st.o actually builds (on x86_64. that is) so
> there's no _obvious_ reason not to fix this typo.
>
I was about to post the same fix, thanks a lot for addressing this.
Sorry for my stupid mistake.
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [next-20141003] USB: host: st: fix typo 'CONFIG_USB_EHCI_HCD_ST'
2014-10-04 11:33 ` Arnd Bergmann
@ 2014-10-04 13:23 ` Paul Bolle
0 siblings, 0 replies; 4+ messages in thread
From: Paul Bolle @ 2014-10-04 13:23 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Alan Stern, Greg Kroah-Hartman, Valentin Rothberg, Peter Griffin,
linux-usb, linux-kernel
On Sat, 2014-10-04 at 13:33 +0200, Arnd Bergmann wrote:
> I was about to post the same fix, thanks a lot for addressing this.
You're welcome. I just figured that sending a (second) message regarding
this typo would have been about as much trouble as sending a one line
patch, so I sent that patch.
> Sorry for my stupid mistake.
That typo was rather easy to make and hard to notice (make won't shout
at you for using an unknown macro, etc). See the thread starting at
https://lkml.kernel.org/r/1411730854.7866.10.camel@x220 for what I've
been doing lately to try to catch these type of things early (ie, in
linux-next) and for how Valentin hopes to automate that properly.
Paul Bolle
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [next-20141003] USB: host: st: fix typo 'CONFIG_USB_EHCI_HCD_ST'
2014-10-03 8:21 [PATCH] [next-20141003] USB: host: st: fix typo 'CONFIG_USB_EHCI_HCD_ST' Paul Bolle
2014-10-04 11:33 ` Arnd Bergmann
@ 2014-10-06 10:10 ` Peter Griffin
1 sibling, 0 replies; 4+ messages in thread
From: Peter Griffin @ 2014-10-06 10:10 UTC (permalink / raw)
To: Paul Bolle
Cc: Arnd Bergmann, Alan Stern, Greg Kroah-Hartman, Valentin Rothberg,
linux-usb, linux-kernel
On Fri, 03 Oct 2014, Paul Bolle wrote:
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> Fixes: 905e300e1043 ("USB: host: st: fix ehci/ohci driver selection")
Acked-by: Peter Griffin <peter.griffin@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-06 10:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-03 8:21 [PATCH] [next-20141003] USB: host: st: fix typo 'CONFIG_USB_EHCI_HCD_ST' Paul Bolle
2014-10-04 11:33 ` Arnd Bergmann
2014-10-04 13:23 ` Paul Bolle
2014-10-06 10:10 ` Peter Griffin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.