* [PATCH] android/gatt: Fix unneeded increment
@ 2014-10-06 7:49 Andrei Emeltchenko
2014-10-06 8:13 ` [RFC] android/gatt: Fix sign_cnt increment Andrei Emeltchenko
2014-10-06 11:06 ` [PATCH] android/gatt: Fix unneeded increment Lukasz Rymanowski
0 siblings, 2 replies; 5+ messages in thread
From: Andrei Emeltchenko @ 2014-10-06 7:49 UTC (permalink / raw)
To: linux-bluetooth
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
---
android/gatt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/android/gatt.c b/android/gatt.c
index dbe067f..ecd1813 100644
--- a/android/gatt.c
+++ b/android/gatt.c
@@ -3169,7 +3169,7 @@ static guint signed_write_cmd(struct gatt_device *dev, uint16_t handle,
return 0;
}
- bt_update_sign_counter(&dev->bdaddr, LOCAL_CSRK, sign_cnt++);
+ bt_update_sign_counter(&dev->bdaddr, LOCAL_CSRK, sign_cnt);
return res;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [RFC] android/gatt: Fix sign_cnt increment
2014-10-06 7:49 [PATCH] android/gatt: Fix unneeded increment Andrei Emeltchenko
@ 2014-10-06 8:13 ` Andrei Emeltchenko
2014-10-06 13:50 ` Szymon Janc
2014-10-06 11:06 ` [PATCH] android/gatt: Fix unneeded increment Lukasz Rymanowski
1 sibling, 1 reply; 5+ messages in thread
From: Andrei Emeltchenko @ 2014-10-06 8:13 UTC (permalink / raw)
To: linux-bluetooth
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
---
android/gatt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/android/gatt.c b/android/gatt.c
index dbe067f..718b137 100644
--- a/android/gatt.c
+++ b/android/gatt.c
@@ -3169,7 +3169,7 @@ static guint signed_write_cmd(struct gatt_device *dev, uint16_t handle,
return 0;
}
- bt_update_sign_counter(&dev->bdaddr, LOCAL_CSRK, sign_cnt++);
+ bt_update_sign_counter(&dev->bdaddr, LOCAL_CSRK, ++sign_cnt);
return res;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] android/gatt: Fix unneeded increment
2014-10-06 7:49 [PATCH] android/gatt: Fix unneeded increment Andrei Emeltchenko
2014-10-06 8:13 ` [RFC] android/gatt: Fix sign_cnt increment Andrei Emeltchenko
@ 2014-10-06 11:06 ` Lukasz Rymanowski
2014-10-06 11:14 ` Andrei Emeltchenko
1 sibling, 1 reply; 5+ messages in thread
From: Lukasz Rymanowski @ 2014-10-06 11:06 UTC (permalink / raw)
To: Andrei Emeltchenko; +Cc: linux-bluetooth, Szymon Janc
Hi Andrei,
On Mon, Oct 6, 2014 at 9:49 AM, Andrei Emeltchenko
<Andrei.Emeltchenko.news@gmail.com> wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> ---
> android/gatt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index dbe067f..ecd1813 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -3169,7 +3169,7 @@ static guint signed_write_cmd(struct gatt_device *dev, uint16_t handle,
> return 0;
> }
>
> - bt_update_sign_counter(&dev->bdaddr, LOCAL_CSRK, sign_cnt++);
> + bt_update_sign_counter(&dev->bdaddr, LOCAL_CSRK, sign_cnt);
Your rfc: "[RFC] android/gatt: Fix sign_cnt increment" shall be used
instead of this patch.
Thanks
\Lukasz
>
> return res;
> }
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] android/gatt: Fix unneeded increment
2014-10-06 11:06 ` [PATCH] android/gatt: Fix unneeded increment Lukasz Rymanowski
@ 2014-10-06 11:14 ` Andrei Emeltchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andrei Emeltchenko @ 2014-10-06 11:14 UTC (permalink / raw)
To: Lukasz Rymanowski; +Cc: linux-bluetooth, Szymon Janc
Hi Lukasz,
On Mon, Oct 06, 2014 at 01:06:49PM +0200, Lukasz Rymanowski wrote:
> Hi Andrei,
>
> On Mon, Oct 6, 2014 at 9:49 AM, Andrei Emeltchenko
> <Andrei.Emeltchenko.news@gmail.com> wrote:
> > From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> >
> > ---
> > android/gatt.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/android/gatt.c b/android/gatt.c
> > index dbe067f..ecd1813 100644
> > --- a/android/gatt.c
> > +++ b/android/gatt.c
> > @@ -3169,7 +3169,7 @@ static guint signed_write_cmd(struct gatt_device *dev, uint16_t handle,
> > return 0;
> > }
> >
> > - bt_update_sign_counter(&dev->bdaddr, LOCAL_CSRK, sign_cnt++);
> > + bt_update_sign_counter(&dev->bdaddr, LOCAL_CSRK, sign_cnt);
>
> Your rfc: "[RFC] android/gatt: Fix sign_cnt increment" shall be used
> instead of this patch.
Yes, it was sent later. I called it RFC since wanted double check from the
code authors.
Best regards
Andrei Emeltchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC] android/gatt: Fix sign_cnt increment
2014-10-06 8:13 ` [RFC] android/gatt: Fix sign_cnt increment Andrei Emeltchenko
@ 2014-10-06 13:50 ` Szymon Janc
0 siblings, 0 replies; 5+ messages in thread
From: Szymon Janc @ 2014-10-06 13:50 UTC (permalink / raw)
To: Andrei Emeltchenko; +Cc: linux-bluetooth
Hi Andrei,
On Monday 06 of October 2014 11:13:58 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> ---
> android/gatt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index dbe067f..718b137 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -3169,7 +3169,7 @@ static guint signed_write_cmd(struct gatt_device *dev, uint16_t handle,
> return 0;
> }
>
> - bt_update_sign_counter(&dev->bdaddr, LOCAL_CSRK, sign_cnt++);
> + bt_update_sign_counter(&dev->bdaddr, LOCAL_CSRK, ++sign_cnt);
>
> return res;
> }
Applied. Thanks.
--
Best regards,
Szymon Janc
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-10-06 13:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-06 7:49 [PATCH] android/gatt: Fix unneeded increment Andrei Emeltchenko
2014-10-06 8:13 ` [RFC] android/gatt: Fix sign_cnt increment Andrei Emeltchenko
2014-10-06 13:50 ` Szymon Janc
2014-10-06 11:06 ` [PATCH] android/gatt: Fix unneeded increment Lukasz Rymanowski
2014-10-06 11:14 ` Andrei Emeltchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.