[PATCH] ASoC: soc-pcm: fix sig_bits determination in soc_pcm_apply_msb()

[PATCH] ASoC: soc-pcm: fix sig_bits determination in soc_pcm_apply_msb()

[Daniel Mack]

In the SNDRV_PCM_STREAM_CAPTURE branch in soc_pcm_apply_msb(), look at
sig_bits of the capture stream, not the playback one.

Spotted by coverity.

Signed-off-by: Daniel Mack <daniel@zonque.org>
---
 sound/soc/soc-pcm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index 642c862..002311a 100644
--- a/sound/soc/soc-pcm.c
+++ b/sound/soc/soc-pcm.c
@@ -352,7 +352,7 @@ static void soc_pcm_apply_msb(struct snd_pcm_substream *substream)
 	} else {
 		for (i = 0; i < rtd->num_codecs; i++) {
 			codec_dai = rtd->codec_dais[i];
-			if (codec_dai->driver->playback.sig_bits == 0) {
+			if (codec_dai->driver->capture.sig_bits == 0) {
 				bits = 0;
 				break;
 			}
-- 
2.1.0

Re: [PATCH] ASoC: soc-pcm: fix sig_bits determination in soc_pcm_apply_msb()

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 208 bytes --]

On Tue, Oct 07, 2014 at 02:33:46PM +0200, Daniel Mack wrote:
> In the SNDRV_PCM_STREAM_CAPTURE branch in soc_pcm_apply_msb(), look at
> sig_bits of the capture stream, not the playback one.

Applied, thanks.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]