* [PATCH v2 0/3] Add Reset Controller for MediaTek SoC
@ 2014-11-03 9:02 ` Flora Fu
0 siblings, 0 replies; 18+ messages in thread
From: Flora Fu @ 2014-11-03 9:02 UTC (permalink / raw)
To: Philipp Zabel, Rob Herring, Matthias Brugger, arm
Cc: Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
Grant Likely, devicetree, linux-kernel, linux-arm-kernel,
srv_heupstream, Sascha Hauer, Olof Johansson, Arnd Bergmann,
Flora Fu
Hi,
The patch modification is base on https://lkml.org/lkml/2014/5/27/422
Changes since v1
================
(1) Patch 1/3: Update reset controller driver's implementation.
- rename mt_ prefixes to the prefix mtk_
- use module_platform_driver() macro for driver init.
- clean up includes of header files.
- reset controll is a child of syscon. Get regamp through its parent node.
- rename data->size to data->num_regs. It is number of registers in syscon for reset usage.
(2) Patch 2/3: update bindings document according to new dts layout of reset-controller.
(3) Patch 3/3: change reset-controller device node as child of syscon.
This driver is based on 3.18-rc1.
Flora Fu (3):
ARM: mediatek: Add Reset Controller for MediaTek SoC
dt-bindings: Add Reset Controller for MediaTek SoC
ARM: dts: mt8135: Add Reset Controller for MediaTek SoC
.../devicetree/bindings/reset/mediatek,reset.txt | 45 +++++++
arch/arm/boot/dts/mt8135.dtsi | 26 ++++
drivers/reset/Makefile | 1 +
drivers/reset/reset-mtk.c | 131 +++++++++++++++++++++
4 files changed, 203 insertions(+)
create mode 100644 Documentation/devicetree/bindings/reset/mediatek,reset.txt
create mode 100644 drivers/reset/reset-mtk.c
--
1.8.1.1.dirty
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2 0/3] Add Reset Controller for MediaTek SoC
@ 2014-11-03 9:02 ` Flora Fu
0 siblings, 0 replies; 18+ messages in thread
From: Flora Fu @ 2014-11-03 9:02 UTC (permalink / raw)
To: Philipp Zabel, Rob Herring, Matthias Brugger, arm-DgEjT+Ai2ygdnm+yROfE0A
Cc: Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
Grant Likely, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
srv_heupstream-NuS5LvNUpcJWk0Htik3J/w, Sascha Hauer,
Olof Johansson, Arnd Bergmann, Flora Fu
Hi,
The patch modification is base on https://lkml.org/lkml/2014/5/27/422
Changes since v1
================
(1) Patch 1/3: Update reset controller driver's implementation.
- rename mt_ prefixes to the prefix mtk_
- use module_platform_driver() macro for driver init.
- clean up includes of header files.
- reset controll is a child of syscon. Get regamp through its parent node.
- rename data->size to data->num_regs. It is number of registers in syscon for reset usage.
(2) Patch 2/3: update bindings document according to new dts layout of reset-controller.
(3) Patch 3/3: change reset-controller device node as child of syscon.
This driver is based on 3.18-rc1.
Flora Fu (3):
ARM: mediatek: Add Reset Controller for MediaTek SoC
dt-bindings: Add Reset Controller for MediaTek SoC
ARM: dts: mt8135: Add Reset Controller for MediaTek SoC
.../devicetree/bindings/reset/mediatek,reset.txt | 45 +++++++
arch/arm/boot/dts/mt8135.dtsi | 26 ++++
drivers/reset/Makefile | 1 +
drivers/reset/reset-mtk.c | 131 +++++++++++++++++++++
4 files changed, 203 insertions(+)
create mode 100644 Documentation/devicetree/bindings/reset/mediatek,reset.txt
create mode 100644 drivers/reset/reset-mtk.c
--
1.8.1.1.dirty
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2 0/3] Add Reset Controller for MediaTek SoC
@ 2014-11-03 9:02 ` Flora Fu
0 siblings, 0 replies; 18+ messages in thread
From: Flora Fu @ 2014-11-03 9:02 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
The patch modification is base on https://lkml.org/lkml/2014/5/27/422
Changes since v1
================
(1) Patch 1/3: Update reset controller driver's implementation.
- rename mt_ prefixes to the prefix mtk_
- use module_platform_driver() macro for driver init.
- clean up includes of header files.
- reset controll is a child of syscon. Get regamp through its parent node.
- rename data->size to data->num_regs. It is number of registers in syscon for reset usage.
(2) Patch 2/3: update bindings document according to new dts layout of reset-controller.
(3) Patch 3/3: change reset-controller device node as child of syscon.
This driver is based on 3.18-rc1.
Flora Fu (3):
ARM: mediatek: Add Reset Controller for MediaTek SoC
dt-bindings: Add Reset Controller for MediaTek SoC
ARM: dts: mt8135: Add Reset Controller for MediaTek SoC
.../devicetree/bindings/reset/mediatek,reset.txt | 45 +++++++
arch/arm/boot/dts/mt8135.dtsi | 26 ++++
drivers/reset/Makefile | 1 +
drivers/reset/reset-mtk.c | 131 +++++++++++++++++++++
4 files changed, 203 insertions(+)
create mode 100644 Documentation/devicetree/bindings/reset/mediatek,reset.txt
create mode 100644 drivers/reset/reset-mtk.c
--
1.8.1.1.dirty
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2 1/3] ARM: mediatek: Add Reset Controller for MediaTek SoC
2014-11-03 9:02 ` Flora Fu
(?)
@ 2014-11-03 9:02 ` Flora Fu
-1 siblings, 0 replies; 18+ messages in thread
From: Flora Fu @ 2014-11-03 9:02 UTC (permalink / raw)
To: Philipp Zabel, Rob Herring, Matthias Brugger, arm
Cc: Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
Grant Likely, devicetree, linux-kernel, linux-arm-kernel,
srv_heupstream, Sascha Hauer, Olof Johansson, Arnd Bergmann,
Flora Fu
Add a driver in reset controller.
Signed-off-by: Flora Fu <flora.fu@mediatek.com>
---
drivers/reset/Makefile | 1 +
drivers/reset/reset-mtk.c | 131 ++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 132 insertions(+)
create mode 100644 drivers/reset/reset-mtk.c
diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
index 60fed3d..adcebdf 100644
--- a/drivers/reset/Makefile
+++ b/drivers/reset/Makefile
@@ -2,3 +2,4 @@ obj-$(CONFIG_RESET_CONTROLLER) += core.o
obj-$(CONFIG_ARCH_SOCFPGA) += reset-socfpga.o
obj-$(CONFIG_ARCH_SUNXI) += reset-sunxi.o
obj-$(CONFIG_ARCH_STI) += sti/
+obj-$(CONFIG_ARCH_MEDIATEK) += reset-mtk.o
diff --git a/drivers/reset/reset-mtk.c b/drivers/reset/reset-mtk.c
new file mode 100644
index 0000000..7d792ec
--- /dev/null
+++ b/drivers/reset/reset-mtk.c
@@ -0,0 +1,131 @@
+/*
+ * Copyright (c) 2014 MediaTek Inc.
+ * Author: Flora.Fu <flora.fu@mediatek.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include <linux/mfd/syscon.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
+#include <linux/regmap.h>
+#include <linux/reset-controller.h>
+
+struct mtk_reset_data {
+ struct regmap *regmap;
+ u32 resetbase;
+ u32 num_regs;
+ struct reset_controller_dev rcdev;
+};
+
+static int mtk_reset_assert(struct reset_controller_dev *rcdev,
+ unsigned long id)
+{
+ struct regmap *regmap;
+ u32 addr;
+ u32 mask;
+ struct mtk_reset_data *data = container_of(rcdev,
+ struct mtk_reset_data,
+ rcdev);
+ regmap = data->regmap;
+ addr = data->resetbase + ((id / 32) << 2);
+ mask = BIT(id % 32);
+
+ return regmap_update_bits(regmap, addr, mask, mask);
+}
+
+static int mtk_reset_deassert(struct reset_controller_dev *rcdev,
+ unsigned long id)
+{
+ struct regmap *regmap;
+ u32 addr;
+ u32 mask;
+ struct mtk_reset_data *data = container_of(rcdev,
+ struct mtk_reset_data,
+ rcdev);
+
+ regmap = data->regmap;
+ addr = data->resetbase + ((id / 32) << 2);
+ mask = BIT(id % 32);
+
+ return regmap_update_bits(regmap, addr, mask, ~mask);
+}
+
+static struct reset_control_ops mtk_reset_ops = {
+ .assert = mtk_reset_assert,
+ .deassert = mtk_reset_deassert,
+};
+
+static int mtk_reset_probe(struct platform_device *pdev)
+{
+ struct mtk_reset_data *data;
+ struct device_node *np = pdev->dev.of_node;
+ struct device_node *syscon_np;
+ u32 reg[2];
+ int ret;
+
+ data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
+ if (!data)
+ return -ENOMEM;
+
+ syscon_np = of_get_parent(np);
+ data->regmap = syscon_node_to_regmap(syscon_np);
+ of_node_put(syscon_np);
+ if (IS_ERR(data->regmap)) {
+ dev_err(&pdev->dev, "couldn't get syscon-reset regmap\n");
+ return PTR_ERR(data->regmap);
+ }
+ ret = of_property_read_u32_array(np, "reg", reg, 2);
+ if (ret) {
+ dev_err(&pdev->dev, "couldn't read reset base from syscon!\n");
+ return -EINVAL;
+ }
+
+ data->resetbase = reg[0];
+ data->num_regs = reg[1] >> 2;
+ data->rcdev.owner = THIS_MODULE;
+ data->rcdev.nr_resets = data->num_regs * 32;
+ data->rcdev.ops = &mtk_reset_ops;
+ data->rcdev.of_node = pdev->dev.of_node;
+
+ return reset_controller_register(&data->rcdev);
+}
+
+static int mtk_reset_remove(struct platform_device *pdev)
+{
+ struct mtk_reset_data *data = platform_get_drvdata(pdev);
+
+ reset_controller_unregister(&data->rcdev);
+
+ return 0;
+}
+
+static const struct of_device_id mtk_reset_dt_ids[] = {
+ { .compatible = "mediatek,reset", },
+ {},
+};
+MODULE_DEVICE_TABLE(of, mtk_reset_dt_ids);
+
+static struct platform_driver mtk_reset_driver = {
+ .probe = mtk_reset_probe,
+ .remove = mtk_reset_remove,
+ .driver = {
+ .name = "mtk-reset",
+ .owner = THIS_MODULE,
+ .of_match_table = mtk_reset_dt_ids,
+ },
+};
+
+module_platform_driver(mtk_reset_driver);
+
+MODULE_AUTHOR("Flora Fu <flora.fu@mediatek.com>");
+MODULE_DESCRIPTION("MediaTek SoC Generic Reset Controller");
+MODULE_LICENSE("GPL");
--
1.8.1.1.dirty
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 1/3] ARM: mediatek: Add Reset Controller for MediaTek SoC
@ 2014-11-03 9:02 ` Flora Fu
0 siblings, 0 replies; 18+ messages in thread
From: Flora Fu @ 2014-11-03 9:02 UTC (permalink / raw)
To: Philipp Zabel, Rob Herring, Matthias Brugger, arm
Cc: Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
Grant Likely, devicetree, linux-kernel, linux-arm-kernel,
srv_heupstream, Sascha Hauer, Olof Johansson, Arnd Bergmann,
Flora Fu
Add a driver in reset controller.
Signed-off-by: Flora Fu <flora.fu@mediatek.com>
---
drivers/reset/Makefile | 1 +
drivers/reset/reset-mtk.c | 131 ++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 132 insertions(+)
create mode 100644 drivers/reset/reset-mtk.c
diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
index 60fed3d..adcebdf 100644
--- a/drivers/reset/Makefile
+++ b/drivers/reset/Makefile
@@ -2,3 +2,4 @@ obj-$(CONFIG_RESET_CONTROLLER) += core.o
obj-$(CONFIG_ARCH_SOCFPGA) += reset-socfpga.o
obj-$(CONFIG_ARCH_SUNXI) += reset-sunxi.o
obj-$(CONFIG_ARCH_STI) += sti/
+obj-$(CONFIG_ARCH_MEDIATEK) += reset-mtk.o
diff --git a/drivers/reset/reset-mtk.c b/drivers/reset/reset-mtk.c
new file mode 100644
index 0000000..7d792ec
--- /dev/null
+++ b/drivers/reset/reset-mtk.c
@@ -0,0 +1,131 @@
+/*
+ * Copyright (c) 2014 MediaTek Inc.
+ * Author: Flora.Fu <flora.fu@mediatek.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include <linux/mfd/syscon.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
+#include <linux/regmap.h>
+#include <linux/reset-controller.h>
+
+struct mtk_reset_data {
+ struct regmap *regmap;
+ u32 resetbase;
+ u32 num_regs;
+ struct reset_controller_dev rcdev;
+};
+
+static int mtk_reset_assert(struct reset_controller_dev *rcdev,
+ unsigned long id)
+{
+ struct regmap *regmap;
+ u32 addr;
+ u32 mask;
+ struct mtk_reset_data *data = container_of(rcdev,
+ struct mtk_reset_data,
+ rcdev);
+ regmap = data->regmap;
+ addr = data->resetbase + ((id / 32) << 2);
+ mask = BIT(id % 32);
+
+ return regmap_update_bits(regmap, addr, mask, mask);
+}
+
+static int mtk_reset_deassert(struct reset_controller_dev *rcdev,
+ unsigned long id)
+{
+ struct regmap *regmap;
+ u32 addr;
+ u32 mask;
+ struct mtk_reset_data *data = container_of(rcdev,
+ struct mtk_reset_data,
+ rcdev);
+
+ regmap = data->regmap;
+ addr = data->resetbase + ((id / 32) << 2);
+ mask = BIT(id % 32);
+
+ return regmap_update_bits(regmap, addr, mask, ~mask);
+}
+
+static struct reset_control_ops mtk_reset_ops = {
+ .assert = mtk_reset_assert,
+ .deassert = mtk_reset_deassert,
+};
+
+static int mtk_reset_probe(struct platform_device *pdev)
+{
+ struct mtk_reset_data *data;
+ struct device_node *np = pdev->dev.of_node;
+ struct device_node *syscon_np;
+ u32 reg[2];
+ int ret;
+
+ data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
+ if (!data)
+ return -ENOMEM;
+
+ syscon_np = of_get_parent(np);
+ data->regmap = syscon_node_to_regmap(syscon_np);
+ of_node_put(syscon_np);
+ if (IS_ERR(data->regmap)) {
+ dev_err(&pdev->dev, "couldn't get syscon-reset regmap\n");
+ return PTR_ERR(data->regmap);
+ }
+ ret = of_property_read_u32_array(np, "reg", reg, 2);
+ if (ret) {
+ dev_err(&pdev->dev, "couldn't read reset base from syscon!\n");
+ return -EINVAL;
+ }
+
+ data->resetbase = reg[0];
+ data->num_regs = reg[1] >> 2;
+ data->rcdev.owner = THIS_MODULE;
+ data->rcdev.nr_resets = data->num_regs * 32;
+ data->rcdev.ops = &mtk_reset_ops;
+ data->rcdev.of_node = pdev->dev.of_node;
+
+ return reset_controller_register(&data->rcdev);
+}
+
+static int mtk_reset_remove(struct platform_device *pdev)
+{
+ struct mtk_reset_data *data = platform_get_drvdata(pdev);
+
+ reset_controller_unregister(&data->rcdev);
+
+ return 0;
+}
+
+static const struct of_device_id mtk_reset_dt_ids[] = {
+ { .compatible = "mediatek,reset", },
+ {},
+};
+MODULE_DEVICE_TABLE(of, mtk_reset_dt_ids);
+
+static struct platform_driver mtk_reset_driver = {
+ .probe = mtk_reset_probe,
+ .remove = mtk_reset_remove,
+ .driver = {
+ .name = "mtk-reset",
+ .owner = THIS_MODULE,
+ .of_match_table = mtk_reset_dt_ids,
+ },
+};
+
+module_platform_driver(mtk_reset_driver);
+
+MODULE_AUTHOR("Flora Fu <flora.fu@mediatek.com>");
+MODULE_DESCRIPTION("MediaTek SoC Generic Reset Controller");
+MODULE_LICENSE("GPL");
--
1.8.1.1.dirty
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 1/3] ARM: mediatek: Add Reset Controller for MediaTek SoC
@ 2014-11-03 9:02 ` Flora Fu
0 siblings, 0 replies; 18+ messages in thread
From: Flora Fu @ 2014-11-03 9:02 UTC (permalink / raw)
To: linux-arm-kernel
Add a driver in reset controller.
Signed-off-by: Flora Fu <flora.fu@mediatek.com>
---
drivers/reset/Makefile | 1 +
drivers/reset/reset-mtk.c | 131 ++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 132 insertions(+)
create mode 100644 drivers/reset/reset-mtk.c
diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
index 60fed3d..adcebdf 100644
--- a/drivers/reset/Makefile
+++ b/drivers/reset/Makefile
@@ -2,3 +2,4 @@ obj-$(CONFIG_RESET_CONTROLLER) += core.o
obj-$(CONFIG_ARCH_SOCFPGA) += reset-socfpga.o
obj-$(CONFIG_ARCH_SUNXI) += reset-sunxi.o
obj-$(CONFIG_ARCH_STI) += sti/
+obj-$(CONFIG_ARCH_MEDIATEK) += reset-mtk.o
diff --git a/drivers/reset/reset-mtk.c b/drivers/reset/reset-mtk.c
new file mode 100644
index 0000000..7d792ec
--- /dev/null
+++ b/drivers/reset/reset-mtk.c
@@ -0,0 +1,131 @@
+/*
+ * Copyright (c) 2014 MediaTek Inc.
+ * Author: Flora.Fu <flora.fu@mediatek.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include <linux/mfd/syscon.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
+#include <linux/regmap.h>
+#include <linux/reset-controller.h>
+
+struct mtk_reset_data {
+ struct regmap *regmap;
+ u32 resetbase;
+ u32 num_regs;
+ struct reset_controller_dev rcdev;
+};
+
+static int mtk_reset_assert(struct reset_controller_dev *rcdev,
+ unsigned long id)
+{
+ struct regmap *regmap;
+ u32 addr;
+ u32 mask;
+ struct mtk_reset_data *data = container_of(rcdev,
+ struct mtk_reset_data,
+ rcdev);
+ regmap = data->regmap;
+ addr = data->resetbase + ((id / 32) << 2);
+ mask = BIT(id % 32);
+
+ return regmap_update_bits(regmap, addr, mask, mask);
+}
+
+static int mtk_reset_deassert(struct reset_controller_dev *rcdev,
+ unsigned long id)
+{
+ struct regmap *regmap;
+ u32 addr;
+ u32 mask;
+ struct mtk_reset_data *data = container_of(rcdev,
+ struct mtk_reset_data,
+ rcdev);
+
+ regmap = data->regmap;
+ addr = data->resetbase + ((id / 32) << 2);
+ mask = BIT(id % 32);
+
+ return regmap_update_bits(regmap, addr, mask, ~mask);
+}
+
+static struct reset_control_ops mtk_reset_ops = {
+ .assert = mtk_reset_assert,
+ .deassert = mtk_reset_deassert,
+};
+
+static int mtk_reset_probe(struct platform_device *pdev)
+{
+ struct mtk_reset_data *data;
+ struct device_node *np = pdev->dev.of_node;
+ struct device_node *syscon_np;
+ u32 reg[2];
+ int ret;
+
+ data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
+ if (!data)
+ return -ENOMEM;
+
+ syscon_np = of_get_parent(np);
+ data->regmap = syscon_node_to_regmap(syscon_np);
+ of_node_put(syscon_np);
+ if (IS_ERR(data->regmap)) {
+ dev_err(&pdev->dev, "couldn't get syscon-reset regmap\n");
+ return PTR_ERR(data->regmap);
+ }
+ ret = of_property_read_u32_array(np, "reg", reg, 2);
+ if (ret) {
+ dev_err(&pdev->dev, "couldn't read reset base from syscon!\n");
+ return -EINVAL;
+ }
+
+ data->resetbase = reg[0];
+ data->num_regs = reg[1] >> 2;
+ data->rcdev.owner = THIS_MODULE;
+ data->rcdev.nr_resets = data->num_regs * 32;
+ data->rcdev.ops = &mtk_reset_ops;
+ data->rcdev.of_node = pdev->dev.of_node;
+
+ return reset_controller_register(&data->rcdev);
+}
+
+static int mtk_reset_remove(struct platform_device *pdev)
+{
+ struct mtk_reset_data *data = platform_get_drvdata(pdev);
+
+ reset_controller_unregister(&data->rcdev);
+
+ return 0;
+}
+
+static const struct of_device_id mtk_reset_dt_ids[] = {
+ { .compatible = "mediatek,reset", },
+ {},
+};
+MODULE_DEVICE_TABLE(of, mtk_reset_dt_ids);
+
+static struct platform_driver mtk_reset_driver = {
+ .probe = mtk_reset_probe,
+ .remove = mtk_reset_remove,
+ .driver = {
+ .name = "mtk-reset",
+ .owner = THIS_MODULE,
+ .of_match_table = mtk_reset_dt_ids,
+ },
+};
+
+module_platform_driver(mtk_reset_driver);
+
+MODULE_AUTHOR("Flora Fu <flora.fu@mediatek.com>");
+MODULE_DESCRIPTION("MediaTek SoC Generic Reset Controller");
+MODULE_LICENSE("GPL");
--
1.8.1.1.dirty
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 2/3] dt-bindings: Add Reset Controller for MediaTek SoC
2014-11-03 9:02 ` Flora Fu
(?)
@ 2014-11-03 9:02 ` Flora Fu
-1 siblings, 0 replies; 18+ messages in thread
From: Flora Fu @ 2014-11-03 9:02 UTC (permalink / raw)
To: Philipp Zabel, Rob Herring, Matthias Brugger, arm
Cc: Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
Grant Likely, devicetree, linux-kernel, linux-arm-kernel,
srv_heupstream, Sascha Hauer, Olof Johansson, Arnd Bergmann,
Flora Fu
Add device tree bindings.
Signed-off-by: Flora Fu <flora.fu@mediatek.com>
---
.../devicetree/bindings/reset/mediatek,reset.txt | 45 ++++++++++++++++++++++
1 file changed, 45 insertions(+)
create mode 100644 Documentation/devicetree/bindings/reset/mediatek,reset.txt
diff --git a/Documentation/devicetree/bindings/reset/mediatek,reset.txt b/Documentation/devicetree/bindings/reset/mediatek,reset.txt
new file mode 100644
index 0000000..3c5687b
--- /dev/null
+++ b/Documentation/devicetree/bindings/reset/mediatek,reset.txt
@@ -0,0 +1,45 @@
+MediaTek SoC Reset Controller
+======================================
+The reset controller driver accesses registers through the syscon regmap. It
+is a child node of syscon.
+
+Required properties:
+- compatible : "mediatek,reset"
+- #reset-cells: 1
+- reg: The register region can be accessed from syscon. The first parameter is
+ reset base address offset. The second parameter is byte width of reset registers.
+
+example:
+infracfg: syscon@10001000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "mediatek,mt8135-infracfg", "syscon";
+ reg = <0 0x10001000 0 0x1000>;
+
+ infrarst: reset-controller@30 {
+ #reset-cells = <1>;
+ compatible = "mediatek,mt8135-infracfg-reset", "mediatek,reset";
+ reg = <0x30 0x8>;
+ };
+};
+
+Specifying reset lines connected to IP modules
+==============================================
+
+The reset controller(mtk-reset) manages various reset sources. Those device nodes should
+specify the reset line on the rstc in their resets property, containing a phandle to the
+rstc device node and a RESET_INDEX specifying which module to reset, as described in
+reset.txt.
+
+For MediaTek SoC, RESET_INDEX is reset bit defined in INFRACFG or PERICFG registers.
+
+example:
+pwrap: pwrap@1000f000 {
+ compatible = "mediatek,mt8135-pwrap";
+ reg = <0 0x1000f000 0 0x1000>,
+ <0 0x11017000 0 0x1000>;
+ reg-names = "pwrap-base",
+ "pwrap-bridge-base";
+ resets = <&infrarst 7>, <&perirst 34>;
+ reset-names = "infrarst", "perirst";
+};
--
1.8.1.1.dirty
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 2/3] dt-bindings: Add Reset Controller for MediaTek SoC
@ 2014-11-03 9:02 ` Flora Fu
0 siblings, 0 replies; 18+ messages in thread
From: Flora Fu @ 2014-11-03 9:02 UTC (permalink / raw)
To: Philipp Zabel, Rob Herring, Matthias Brugger, arm
Cc: Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
Grant Likely, devicetree, linux-kernel, linux-arm-kernel,
srv_heupstream, Sascha Hauer, Olof Johansson, Arnd Bergmann,
Flora Fu
Add device tree bindings.
Signed-off-by: Flora Fu <flora.fu@mediatek.com>
---
.../devicetree/bindings/reset/mediatek,reset.txt | 45 ++++++++++++++++++++++
1 file changed, 45 insertions(+)
create mode 100644 Documentation/devicetree/bindings/reset/mediatek,reset.txt
diff --git a/Documentation/devicetree/bindings/reset/mediatek,reset.txt b/Documentation/devicetree/bindings/reset/mediatek,reset.txt
new file mode 100644
index 0000000..3c5687b
--- /dev/null
+++ b/Documentation/devicetree/bindings/reset/mediatek,reset.txt
@@ -0,0 +1,45 @@
+MediaTek SoC Reset Controller
+======================================
+The reset controller driver accesses registers through the syscon regmap. It
+is a child node of syscon.
+
+Required properties:
+- compatible : "mediatek,reset"
+- #reset-cells: 1
+- reg: The register region can be accessed from syscon. The first parameter is
+ reset base address offset. The second parameter is byte width of reset registers.
+
+example:
+infracfg: syscon@10001000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "mediatek,mt8135-infracfg", "syscon";
+ reg = <0 0x10001000 0 0x1000>;
+
+ infrarst: reset-controller@30 {
+ #reset-cells = <1>;
+ compatible = "mediatek,mt8135-infracfg-reset", "mediatek,reset";
+ reg = <0x30 0x8>;
+ };
+};
+
+Specifying reset lines connected to IP modules
+==============================================
+
+The reset controller(mtk-reset) manages various reset sources. Those device nodes should
+specify the reset line on the rstc in their resets property, containing a phandle to the
+rstc device node and a RESET_INDEX specifying which module to reset, as described in
+reset.txt.
+
+For MediaTek SoC, RESET_INDEX is reset bit defined in INFRACFG or PERICFG registers.
+
+example:
+pwrap: pwrap@1000f000 {
+ compatible = "mediatek,mt8135-pwrap";
+ reg = <0 0x1000f000 0 0x1000>,
+ <0 0x11017000 0 0x1000>;
+ reg-names = "pwrap-base",
+ "pwrap-bridge-base";
+ resets = <&infrarst 7>, <&perirst 34>;
+ reset-names = "infrarst", "perirst";
+};
--
1.8.1.1.dirty
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 2/3] dt-bindings: Add Reset Controller for MediaTek SoC
@ 2014-11-03 9:02 ` Flora Fu
0 siblings, 0 replies; 18+ messages in thread
From: Flora Fu @ 2014-11-03 9:02 UTC (permalink / raw)
To: linux-arm-kernel
Add device tree bindings.
Signed-off-by: Flora Fu <flora.fu@mediatek.com>
---
.../devicetree/bindings/reset/mediatek,reset.txt | 45 ++++++++++++++++++++++
1 file changed, 45 insertions(+)
create mode 100644 Documentation/devicetree/bindings/reset/mediatek,reset.txt
diff --git a/Documentation/devicetree/bindings/reset/mediatek,reset.txt b/Documentation/devicetree/bindings/reset/mediatek,reset.txt
new file mode 100644
index 0000000..3c5687b
--- /dev/null
+++ b/Documentation/devicetree/bindings/reset/mediatek,reset.txt
@@ -0,0 +1,45 @@
+MediaTek SoC Reset Controller
+======================================
+The reset controller driver accesses registers through the syscon regmap. It
+is a child node of syscon.
+
+Required properties:
+- compatible : "mediatek,reset"
+- #reset-cells: 1
+- reg: The register region can be accessed from syscon. The first parameter is
+ reset base address offset. The second parameter is byte width of reset registers.
+
+example:
+infracfg: syscon at 10001000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "mediatek,mt8135-infracfg", "syscon";
+ reg = <0 0x10001000 0 0x1000>;
+
+ infrarst: reset-controller at 30 {
+ #reset-cells = <1>;
+ compatible = "mediatek,mt8135-infracfg-reset", "mediatek,reset";
+ reg = <0x30 0x8>;
+ };
+};
+
+Specifying reset lines connected to IP modules
+==============================================
+
+The reset controller(mtk-reset) manages various reset sources. Those device nodes should
+specify the reset line on the rstc in their resets property, containing a phandle to the
+rstc device node and a RESET_INDEX specifying which module to reset, as described in
+reset.txt.
+
+For MediaTek SoC, RESET_INDEX is reset bit defined in INFRACFG or PERICFG registers.
+
+example:
+pwrap: pwrap at 1000f000 {
+ compatible = "mediatek,mt8135-pwrap";
+ reg = <0 0x1000f000 0 0x1000>,
+ <0 0x11017000 0 0x1000>;
+ reg-names = "pwrap-base",
+ "pwrap-bridge-base";
+ resets = <&infrarst 7>, <&perirst 34>;
+ reset-names = "infrarst", "perirst";
+};
--
1.8.1.1.dirty
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 3/3] ARM: dts: mt8135: Add Reset Controller for MediaTek SoC
2014-11-03 9:02 ` Flora Fu
(?)
@ 2014-11-03 9:02 ` Flora Fu
-1 siblings, 0 replies; 18+ messages in thread
From: Flora Fu @ 2014-11-03 9:02 UTC (permalink / raw)
To: Philipp Zabel, Rob Herring, Matthias Brugger, arm
Cc: Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
Grant Likely, devicetree, linux-kernel, linux-arm-kernel,
srv_heupstream, Sascha Hauer, Olof Johansson, Arnd Bergmann,
Flora Fu
Add reset controller to MT8135 board dts.
Signed-off-by: Flora Fu <flora.fu@mediatek.com>
---
arch/arm/boot/dts/mt8135.dtsi | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm/boot/dts/mt8135.dtsi b/arch/arm/boot/dts/mt8135.dtsi
index 90a56ad..259a2b5 100644
--- a/arch/arm/boot/dts/mt8135.dtsi
+++ b/arch/arm/boot/dts/mt8135.dtsi
@@ -102,6 +102,32 @@
clock-names = "system-clk", "rtc-clk";
};
+ infracfg: syscon@10001000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "mediatek,mt8135-infracfg", "syscon";
+ reg = <0 0x10001000 0 0x1000>;
+
+ infrarst: reset-controller@30 {
+ #reset-cells = <1>;
+ compatible = "mediatek,mt8135-infracfg-reset", "mediatek,reset";
+ reg = <0x30 0x8>;
+ };
+ };
+
+ pericfg: syscon@10003000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "mediatek,mt8135-pericfg", "syscon";
+ reg = <0 0x10003000 0 0x1000>;
+
+ perirst: reset-controller@00 {
+ #reset-cells = <1>;
+ compatible = "mediatek,mt8135-pericfg-reset", "mediatek,reset";
+ reg = <0x00 0x8>;
+ };
+ };
+
gic: interrupt-controller@10211000 {
compatible = "arm,cortex-a15-gic";
interrupt-controller;
--
1.8.1.1.dirty
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 3/3] ARM: dts: mt8135: Add Reset Controller for MediaTek SoC
@ 2014-11-03 9:02 ` Flora Fu
0 siblings, 0 replies; 18+ messages in thread
From: Flora Fu @ 2014-11-03 9:02 UTC (permalink / raw)
To: Philipp Zabel, Rob Herring, Matthias Brugger, arm
Cc: Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
Grant Likely, devicetree, linux-kernel, linux-arm-kernel,
srv_heupstream, Sascha Hauer, Olof Johansson, Arnd Bergmann,
Flora Fu
Add reset controller to MT8135 board dts.
Signed-off-by: Flora Fu <flora.fu@mediatek.com>
---
arch/arm/boot/dts/mt8135.dtsi | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm/boot/dts/mt8135.dtsi b/arch/arm/boot/dts/mt8135.dtsi
index 90a56ad..259a2b5 100644
--- a/arch/arm/boot/dts/mt8135.dtsi
+++ b/arch/arm/boot/dts/mt8135.dtsi
@@ -102,6 +102,32 @@
clock-names = "system-clk", "rtc-clk";
};
+ infracfg: syscon@10001000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "mediatek,mt8135-infracfg", "syscon";
+ reg = <0 0x10001000 0 0x1000>;
+
+ infrarst: reset-controller@30 {
+ #reset-cells = <1>;
+ compatible = "mediatek,mt8135-infracfg-reset", "mediatek,reset";
+ reg = <0x30 0x8>;
+ };
+ };
+
+ pericfg: syscon@10003000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "mediatek,mt8135-pericfg", "syscon";
+ reg = <0 0x10003000 0 0x1000>;
+
+ perirst: reset-controller@00 {
+ #reset-cells = <1>;
+ compatible = "mediatek,mt8135-pericfg-reset", "mediatek,reset";
+ reg = <0x00 0x8>;
+ };
+ };
+
gic: interrupt-controller@10211000 {
compatible = "arm,cortex-a15-gic";
interrupt-controller;
--
1.8.1.1.dirty
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 3/3] ARM: dts: mt8135: Add Reset Controller for MediaTek SoC
@ 2014-11-03 9:02 ` Flora Fu
0 siblings, 0 replies; 18+ messages in thread
From: Flora Fu @ 2014-11-03 9:02 UTC (permalink / raw)
To: linux-arm-kernel
Add reset controller to MT8135 board dts.
Signed-off-by: Flora Fu <flora.fu@mediatek.com>
---
arch/arm/boot/dts/mt8135.dtsi | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm/boot/dts/mt8135.dtsi b/arch/arm/boot/dts/mt8135.dtsi
index 90a56ad..259a2b5 100644
--- a/arch/arm/boot/dts/mt8135.dtsi
+++ b/arch/arm/boot/dts/mt8135.dtsi
@@ -102,6 +102,32 @@
clock-names = "system-clk", "rtc-clk";
};
+ infracfg: syscon at 10001000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "mediatek,mt8135-infracfg", "syscon";
+ reg = <0 0x10001000 0 0x1000>;
+
+ infrarst: reset-controller at 30 {
+ #reset-cells = <1>;
+ compatible = "mediatek,mt8135-infracfg-reset", "mediatek,reset";
+ reg = <0x30 0x8>;
+ };
+ };
+
+ pericfg: syscon at 10003000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "mediatek,mt8135-pericfg", "syscon";
+ reg = <0 0x10003000 0 0x1000>;
+
+ perirst: reset-controller at 00 {
+ #reset-cells = <1>;
+ compatible = "mediatek,mt8135-pericfg-reset", "mediatek,reset";
+ reg = <0x00 0x8>;
+ };
+ };
+
gic: interrupt-controller at 10211000 {
compatible = "arm,cortex-a15-gic";
interrupt-controller;
--
1.8.1.1.dirty
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: Add Reset Controller for MediaTek SoC
2014-11-03 9:02 ` Flora Fu
@ 2014-11-03 9:39 ` Philipp Zabel
-1 siblings, 0 replies; 18+ messages in thread
From: Philipp Zabel @ 2014-11-03 9:39 UTC (permalink / raw)
To: Flora Fu
Cc: Rob Herring, Matthias Brugger, arm, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala, Russell King, Grant Likely, devicetree,
linux-kernel, linux-arm-kernel, srv_heupstream, Sascha Hauer,
Olof Johansson, Arnd Bergmann
Hi Flora,
Am Montag, den 03.11.2014, 17:02 +0800 schrieb Flora Fu:
> Add device tree bindings.
>
> Signed-off-by: Flora Fu <flora.fu@mediatek.com>
> ---
> .../devicetree/bindings/reset/mediatek,reset.txt | 45 ++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/reset/mediatek,reset.txt
>
> diff --git a/Documentation/devicetree/bindings/reset/mediatek,reset.txt b/Documentation/devicetree/bindings/reset/mediatek,reset.txt
> new file mode 100644
> index 0000000..3c5687b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/mediatek,reset.txt
> @@ -0,0 +1,45 @@
> +MediaTek SoC Reset Controller
> +======================================
> +The reset controller driver accesses registers through the syscon regmap. It
> +is a child node of syscon.
> +
> +Required properties:
> +- compatible : "mediatek,reset"
> +- #reset-cells: 1
> +- reg: The register region can be accessed from syscon. The first parameter is
> + reset base address offset. The second parameter is byte width of reset registers.
> +
> +example:
> +infracfg: syscon@10001000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
Since we use reg = <0x30 0x8> below, #size-cells should be set to <1>.
I have updated the syscon child support patch and fixed the binding
documentation to allow this. Previously I had only thought about
children that use a single register or just a bitfield in a single
register.
With that change, feel free to consider this patch
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
> + compatible = "mediatek,mt8135-infracfg", "syscon";
> + reg = <0 0x10001000 0 0x1000>;
> +
> + infrarst: reset-controller@30 {
> + #reset-cells = <1>;
> + compatible = "mediatek,mt8135-infracfg-reset", "mediatek,reset";
> + reg = <0x30 0x8>;
> + };
> +};
> +
> +Specifying reset lines connected to IP modules
> +==============================================
> +
> +The reset controller(mtk-reset) manages various reset sources. Those device nodes should
> +specify the reset line on the rstc in their resets property, containing a phandle to the
> +rstc device node and a RESET_INDEX specifying which module to reset, as described in
> +reset.txt.
> +
> +For MediaTek SoC, RESET_INDEX is reset bit defined in INFRACFG or PERICFG registers.
> +
> +example:
> +pwrap: pwrap@1000f000 {
> + compatible = "mediatek,mt8135-pwrap";
> + reg = <0 0x1000f000 0 0x1000>,
> + <0 0x11017000 0 0x1000>;
> + reg-names = "pwrap-base",
> + "pwrap-bridge-base";
> + resets = <&infrarst 7>, <&perirst 34>;
Maybe it would be useful to add a header with #defines for these reset
bit indices?
> + reset-names = "infrarst", "perirst";
> +};
regards
Philipp
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2 2/3] dt-bindings: Add Reset Controller for MediaTek SoC
@ 2014-11-03 9:39 ` Philipp Zabel
0 siblings, 0 replies; 18+ messages in thread
From: Philipp Zabel @ 2014-11-03 9:39 UTC (permalink / raw)
To: linux-arm-kernel
Hi Flora,
Am Montag, den 03.11.2014, 17:02 +0800 schrieb Flora Fu:
> Add device tree bindings.
>
> Signed-off-by: Flora Fu <flora.fu@mediatek.com>
> ---
> .../devicetree/bindings/reset/mediatek,reset.txt | 45 ++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/reset/mediatek,reset.txt
>
> diff --git a/Documentation/devicetree/bindings/reset/mediatek,reset.txt b/Documentation/devicetree/bindings/reset/mediatek,reset.txt
> new file mode 100644
> index 0000000..3c5687b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/mediatek,reset.txt
> @@ -0,0 +1,45 @@
> +MediaTek SoC Reset Controller
> +======================================
> +The reset controller driver accesses registers through the syscon regmap. It
> +is a child node of syscon.
> +
> +Required properties:
> +- compatible : "mediatek,reset"
> +- #reset-cells: 1
> +- reg: The register region can be accessed from syscon. The first parameter is
> + reset base address offset. The second parameter is byte width of reset registers.
> +
> +example:
> +infracfg: syscon at 10001000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
Since we use reg = <0x30 0x8> below, #size-cells should be set to <1>.
I have updated the syscon child support patch and fixed the binding
documentation to allow this. Previously I had only thought about
children that use a single register or just a bitfield in a single
register.
With that change, feel free to consider this patch
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
> + compatible = "mediatek,mt8135-infracfg", "syscon";
> + reg = <0 0x10001000 0 0x1000>;
> +
> + infrarst: reset-controller at 30 {
> + #reset-cells = <1>;
> + compatible = "mediatek,mt8135-infracfg-reset", "mediatek,reset";
> + reg = <0x30 0x8>;
> + };
> +};
> +
> +Specifying reset lines connected to IP modules
> +==============================================
> +
> +The reset controller(mtk-reset) manages various reset sources. Those device nodes should
> +specify the reset line on the rstc in their resets property, containing a phandle to the
> +rstc device node and a RESET_INDEX specifying which module to reset, as described in
> +reset.txt.
> +
> +For MediaTek SoC, RESET_INDEX is reset bit defined in INFRACFG or PERICFG registers.
> +
> +example:
> +pwrap: pwrap at 1000f000 {
> + compatible = "mediatek,mt8135-pwrap";
> + reg = <0 0x1000f000 0 0x1000>,
> + <0 0x11017000 0 0x1000>;
> + reg-names = "pwrap-base",
> + "pwrap-bridge-base";
> + resets = <&infrarst 7>, <&perirst 34>;
Maybe it would be useful to add a header with #defines for these reset
bit indices?
> + reset-names = "infrarst", "perirst";
> +};
regards
Philipp
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 3/3] ARM: dts: mt8135: Add Reset Controller for MediaTek SoC
2014-11-03 9:02 ` Flora Fu
@ 2014-11-03 9:41 ` Philipp Zabel
-1 siblings, 0 replies; 18+ messages in thread
From: Philipp Zabel @ 2014-11-03 9:41 UTC (permalink / raw)
To: Flora Fu
Cc: Rob Herring, Matthias Brugger, arm, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala, Russell King, Grant Likely, devicetree,
linux-kernel, linux-arm-kernel, srv_heupstream, Sascha Hauer,
Olof Johansson, Arnd Bergmann
Am Montag, den 03.11.2014, 17:02 +0800 schrieb Flora Fu:
> Add reset controller to MT8135 board dts.
>
> Signed-off-by: Flora Fu <flora.fu@mediatek.com>
> ---
> arch/arm/boot/dts/mt8135.dtsi | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm/boot/dts/mt8135.dtsi b/arch/arm/boot/dts/mt8135.dtsi
> index 90a56ad..259a2b5 100644
> --- a/arch/arm/boot/dts/mt8135.dtsi
> +++ b/arch/arm/boot/dts/mt8135.dtsi
> @@ -102,6 +102,32 @@
> clock-names = "system-clk", "rtc-clk";
> };
>
> + infracfg: syscon@10001000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
Same as with patch 2, please use #size-cells = <1>.
> + compatible = "mediatek,mt8135-infracfg", "syscon";
> + reg = <0 0x10001000 0 0x1000>;
> +
> + infrarst: reset-controller@30 {
> + #reset-cells = <1>;
> + compatible = "mediatek,mt8135-infracfg-reset", "mediatek,reset";
> + reg = <0x30 0x8>;
> + };
> + };
> +
> + pericfg: syscon@10003000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
And here. Other than that,
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
> + compatible = "mediatek,mt8135-pericfg", "syscon";
> + reg = <0 0x10003000 0 0x1000>;
> +
> + perirst: reset-controller@00 {
> + #reset-cells = <1>;
> + compatible = "mediatek,mt8135-pericfg-reset", "mediatek,reset";
> + reg = <0x00 0x8>;
> + };
> + };
> +
> gic: interrupt-controller@10211000 {
> compatible = "arm,cortex-a15-gic";
> interrupt-controller;
regards
Philipp
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2 3/3] ARM: dts: mt8135: Add Reset Controller for MediaTek SoC
@ 2014-11-03 9:41 ` Philipp Zabel
0 siblings, 0 replies; 18+ messages in thread
From: Philipp Zabel @ 2014-11-03 9:41 UTC (permalink / raw)
To: linux-arm-kernel
Am Montag, den 03.11.2014, 17:02 +0800 schrieb Flora Fu:
> Add reset controller to MT8135 board dts.
>
> Signed-off-by: Flora Fu <flora.fu@mediatek.com>
> ---
> arch/arm/boot/dts/mt8135.dtsi | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm/boot/dts/mt8135.dtsi b/arch/arm/boot/dts/mt8135.dtsi
> index 90a56ad..259a2b5 100644
> --- a/arch/arm/boot/dts/mt8135.dtsi
> +++ b/arch/arm/boot/dts/mt8135.dtsi
> @@ -102,6 +102,32 @@
> clock-names = "system-clk", "rtc-clk";
> };
>
> + infracfg: syscon at 10001000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
Same as with patch 2, please use #size-cells = <1>.
> + compatible = "mediatek,mt8135-infracfg", "syscon";
> + reg = <0 0x10001000 0 0x1000>;
> +
> + infrarst: reset-controller at 30 {
> + #reset-cells = <1>;
> + compatible = "mediatek,mt8135-infracfg-reset", "mediatek,reset";
> + reg = <0x30 0x8>;
> + };
> + };
> +
> + pericfg: syscon at 10003000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
And here. Other than that,
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
> + compatible = "mediatek,mt8135-pericfg", "syscon";
> + reg = <0 0x10003000 0 0x1000>;
> +
> + perirst: reset-controller at 00 {
> + #reset-cells = <1>;
> + compatible = "mediatek,mt8135-pericfg-reset", "mediatek,reset";
> + reg = <0x00 0x8>;
> + };
> + };
> +
> gic: interrupt-controller at 10211000 {
> compatible = "arm,cortex-a15-gic";
> interrupt-controller;
regards
Philipp
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/3] ARM: mediatek: Add Reset Controller for MediaTek SoC
2014-11-03 9:02 ` Flora Fu
@ 2014-11-03 9:55 ` Philipp Zabel
-1 siblings, 0 replies; 18+ messages in thread
From: Philipp Zabel @ 2014-11-03 9:55 UTC (permalink / raw)
To: Flora Fu
Cc: Rob Herring, Matthias Brugger, arm, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala, Russell King, Grant Likely, devicetree,
linux-kernel, linux-arm-kernel, srv_heupstream, Sascha Hauer,
Olof Johansson, Arnd Bergmann
Am Montag, den 03.11.2014, 17:02 +0800 schrieb Flora Fu:
> Add a driver in reset controller.
>
> Signed-off-by: Flora Fu <flora.fu@mediatek.com>
[...]
This version looks good to me. I'm going to apply it as soon as there is
agreement on the syscon child device patch.
regards
Philipp
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2 1/3] ARM: mediatek: Add Reset Controller for MediaTek SoC
@ 2014-11-03 9:55 ` Philipp Zabel
0 siblings, 0 replies; 18+ messages in thread
From: Philipp Zabel @ 2014-11-03 9:55 UTC (permalink / raw)
To: linux-arm-kernel
Am Montag, den 03.11.2014, 17:02 +0800 schrieb Flora Fu:
> Add a driver in reset controller.
>
> Signed-off-by: Flora Fu <flora.fu@mediatek.com>
[...]
This version looks good to me. I'm going to apply it as soon as there is
agreement on the syscon child device patch.
regards
Philipp
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2014-11-03 9:56 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-03 9:02 [PATCH v2 0/3] Add Reset Controller for MediaTek SoC Flora Fu
2014-11-03 9:02 ` Flora Fu
2014-11-03 9:02 ` Flora Fu
2014-11-03 9:02 ` [PATCH v2 1/3] ARM: mediatek: " Flora Fu
2014-11-03 9:02 ` Flora Fu
2014-11-03 9:02 ` Flora Fu
2014-11-03 9:55 ` Philipp Zabel
2014-11-03 9:55 ` Philipp Zabel
2014-11-03 9:02 ` [PATCH v2 2/3] dt-bindings: " Flora Fu
2014-11-03 9:02 ` Flora Fu
2014-11-03 9:02 ` Flora Fu
2014-11-03 9:39 ` Philipp Zabel
2014-11-03 9:39 ` Philipp Zabel
2014-11-03 9:02 ` [PATCH v2 3/3] ARM: dts: mt8135: " Flora Fu
2014-11-03 9:02 ` Flora Fu
2014-11-03 9:02 ` Flora Fu
2014-11-03 9:41 ` Philipp Zabel
2014-11-03 9:41 ` Philipp Zabel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.