* [U-Boot] [PATCH] usb: ehci: fix Interrupt on Doorbell flag of USBCMD
@ 2014-11-05 14:11 Masahiro Yamada
2014-11-06 20:09 ` Marek Vasut
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2014-11-05 14:11 UTC (permalink / raw)
To: u-boot
CMD_IAAD (Interrupt on Async Advance Doorbell) is bit 6, not bit 5.
While we are here, sort the flags.
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---
drivers/usb/host/ehci.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
index 433e703..79aecd4 100644
--- a/drivers/usb/host/ehci.h
+++ b/drivers/usb/host/ehci.h
@@ -47,9 +47,9 @@ struct ehci_hcor {
uint32_t or_usbcmd;
#define CMD_PARK (1 << 11) /* enable "park" */
#define CMD_PARK_CNT(c) (((c) >> 8) & 3) /* how many transfers to park */
-#define CMD_ASE (1 << 5) /* async schedule enable */
#define CMD_LRESET (1 << 7) /* partial reset */
-#define CMD_IAAD (1 << 5) /* "doorbell" interrupt */
+#define CMD_IAAD (1 << 6) /* "doorbell" interrupt */
+#define CMD_ASE (1 << 5) /* async schedule enable */
#define CMD_PSE (1 << 4) /* periodic schedule enable */
#define CMD_RESET (1 << 1) /* reset HC not bus */
#define CMD_RUN (1 << 0) /* start/stop HC */
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] usb: ehci: fix Interrupt on Doorbell flag of USBCMD
2014-11-05 14:11 [U-Boot] [PATCH] usb: ehci: fix Interrupt on Doorbell flag of USBCMD Masahiro Yamada
@ 2014-11-06 20:09 ` Marek Vasut
0 siblings, 0 replies; 2+ messages in thread
From: Marek Vasut @ 2014-11-06 20:09 UTC (permalink / raw)
To: u-boot
On Wednesday, November 05, 2014 at 03:11:10 PM, Masahiro Yamada wrote:
> CMD_IAAD (Interrupt on Async Advance Doorbell) is bit 6, not bit 5.
> While we are here, sort the flags.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Nice catch, applied, thanks!
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-06 20:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-05 14:11 [U-Boot] [PATCH] usb: ehci: fix Interrupt on Doorbell flag of USBCMD Masahiro Yamada
2014-11-06 20:09 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.